From: Yu Zhao <yuzhao@google.com>
To: Saurabh Sengar <ssengar@linux.microsoft.com>
Cc: ssengar@microsoft.com, akpm@linux-foundation.org, jack@suse.cz,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
jostarks@microsoft.com, Matthew Wilcox <willy@infradead.org>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] mm/gup: fix gup_pud_range() for dax
Date: Thu, 20 Oct 2022 16:18:37 -0600 [thread overview]
Message-ID: <CAOUHufbkcdyg8RAEa08DvKE=+bsxjuReiP4iscTV99sZ1oBQ2g@mail.gmail.com> (raw)
In-Reply-To: <1666289686-22798-1-git-send-email-ssengar@linux.microsoft.com>
On Thu, Oct 20, 2022 at 12:14 PM Saurabh Sengar
<ssengar@linux.microsoft.com> wrote:
>
> From: John Starks <jostarks@microsoft.com>
>
> For dax pud, pud_huge() returns true on x86. So the function works as long
> as hugetlb is configured. However, dax doesn't depend on hugetlb.
> Commit 414fd080d125 ("mm/gup: fix gup_pmd_range() for dax") fixed
> devmap-backed huge PMDs, but missed devmap-backed huge PUDs. Fix this as
> well.
>
> Fixes: 414fd080d125 ("mm/gup: fix gup_pmd_range() for dax")
> Signed-off-by: John Starks <jostarks@microsoft.com>
> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
> ---
> mm/gup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index 05068d3d2557..9e07aa54a4cd 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -2687,7 +2687,7 @@ static int gup_pud_range(p4d_t *p4dp, p4d_t p4d, unsigned long addr, unsigned lo
> next = pud_addr_end(addr, end);
> if (unlikely(!pud_present(pud)))
> return 0;
> - if (unlikely(pud_huge(pud))) {
> + if (unlikely(pud_huge(pud) || pud_devmap(pud))) {
Perhaps s/pud_huge/pud_leaf/ ?
> if (!gup_huge_pud(pud, pudp, addr, next, flags,
> pages, nr))
> return 0;
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-10-20 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 18:14 Saurabh Sengar
2022-10-20 22:18 ` Yu Zhao [this message]
2022-12-07 5:40 ` Saurabh Singh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOUHufbkcdyg8RAEa08DvKE=+bsxjuReiP4iscTV99sZ1oBQ2g@mail.gmail.com' \
--to=yuzhao@google.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=jostarks@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ssengar@linux.microsoft.com \
--cc=ssengar@microsoft.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox