From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ABA3EB64D7 for ; Tue, 27 Jun 2023 03:05:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 973448D0003; Mon, 26 Jun 2023 23:05:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 923228D0001; Mon, 26 Jun 2023 23:05:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EA998D0003; Mon, 26 Jun 2023 23:05:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6FCAE8D0001 for ; Mon, 26 Jun 2023 23:05:04 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 32EBE1408B6 for ; Tue, 27 Jun 2023 03:05:04 +0000 (UTC) X-FDA: 80947036128.10.E9FBC0F Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf25.hostedemail.com (Postfix) with ESMTP id 7414AA0016 for ; Tue, 27 Jun 2023 03:05:02 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=7dXkce0t; spf=pass (imf25.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687835102; a=rsa-sha256; cv=none; b=S5OLmtHWZSEoqPipnoL2NYxQUU5erkmU9qZPZbbL7vnhGjjXaXhti1p0w16Qroo06F4Rpf aAyZFZ3kVupQKmhaFcJ26iOCW3JvMQje8TktYzpz6UeUhEwAoRLxY/2GM9R09g/szMOoFh qeAh+kmhh6fmJAWFeoTfvn4kRTWS6Wc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=7dXkce0t; spf=pass (imf25.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687835102; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Udfkb7SVUpoKn3jnskw7T04Cur4Mk4q30DewKVsVPBw=; b=PKgJ0x8uFuG1Fcq9fzZhwvAkjKuLpO9cwMRdwZdtfT1sBHy9Ej5T+uWmKg8dTFXnomgJtB CqyAFx8dawDQKOrD/hwKnfyJBY6x0AwGegSMs3O6it86Rb4KROzN9W5baAnkR8Mh4Wup15 yi2jbqAGScQU+vAL/j1DVd4WNTOW8wI= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-401d1d967beso138381cf.0 for ; Mon, 26 Jun 2023 20:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687835101; x=1690427101; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Udfkb7SVUpoKn3jnskw7T04Cur4Mk4q30DewKVsVPBw=; b=7dXkce0taLND+PJoW+Jbed5b0GMFVghZW9QTkNtQ/meQQ+G4/JcOxPI9Kz0HTIpUjJ DVPqS8EWIMWDNLQb9jkhcv0ZsAV/EK12K1no2eVRvJkp1/XJsLCtTp+lt5ximqKd3QcA O/4FOzC2WA2gGIIWEdtacwm2FXxfG0SQAhL3dtnCVqkZxjmSj6j+j9svH7NJ0A6Nj9Rb jKGMzazG69HvNtEOmK94lVQRbs31Ue4JFIlJhwIOy1XZl8cJtEk1tGxwOUPkGV61Icm6 b01rBLpfsO2BiVCGWGTplTaE03Ks9gzUEE9/yTs/Jw+v/FzXpBLgUpA5jsREDvfG7KVe F4+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687835101; x=1690427101; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Udfkb7SVUpoKn3jnskw7T04Cur4Mk4q30DewKVsVPBw=; b=SUPi0MVd0IROq64Sh2RGSU1YE2I7QItWnkVCVg9I+HIDgVDg6xdyVhKrdD2LOQEN+e bDMbkOw4F+VkibwdD9IABdJ3JwyclTAihRrOF5ChP2ZSCJC8MIIxzJY8xO6JFpi+CzZE emu1l1rQyCic05GL7VtSO5D9tOIndVwYO/eMa9RNIS72zR93BhGqQGbNN13OrNh8R6Fo 4qzQbBTUeC8//mtJom5wXYpOgGjeFrgSbh5idHKblJcZSmqg8rpizF4yCDfhQ1NO4R1i yER//cWPMxwKRRCzlT3JYFKOYYF+OS4tX0oIcnZ+fLDjiL4mqkooIeLqjd0MzJiEE6fr UFCw== X-Gm-Message-State: AC+VfDwmYi3nAWMSwBiwotTE/RPjFjp5fX604ruYR5zLqtHHGRv/k+Db O4ckOzLngYJupyIIBgJY7T4Vj4XeD/csCtfBNF8R+Q== X-Google-Smtp-Source: ACHHUZ6aOgvPbYHnS1BNpa8jCA1x3qA5T/74s8rMt4G/rjNue/yoRJoe9/AmYeGifNbUrQ7LDjo+Du5iRcRAq+DY/jI= X-Received: by 2002:a05:622a:1014:b0:3ed:210b:e698 with SMTP id d20-20020a05622a101400b003ed210be698mr71765qte.7.1687835101534; Mon, 26 Jun 2023 20:05:01 -0700 (PDT) MIME-Version: 1.0 References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-8-ryan.roberts@arm.com> In-Reply-To: <20230626171430.3167004-8-ryan.roberts@arm.com> From: Yu Zhao Date: Mon, 26 Jun 2023 21:04:25 -0600 Message-ID: Subject: Re: [PATCH v1 07/10] mm: Batch-zap large anonymous folio PTE mappings To: Ryan Roberts Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Yin Fengwei , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-s390@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7414AA0016 X-Stat-Signature: thpy5eoryzswodkbwnqgrafhyzaddgqh X-Rspam-User: X-HE-Tag: 1687835102-343566 X-HE-Meta: U2FsdGVkX1+KKgpgiGc+1eDTtNrPtlF5ESd8W5Zn+sEgzwFtvLW8xxhWGF26+UWRDuJ1EU3PEv2QGfrokeBfbWNh5IlSH1R7clcdWyoyZRY396ah1eCxv2DedyhlrklJBQ1Or3rA3602DH9l62CAB3OW+JhWWO25MyH7+aDWSkCr5BZ+L3mDXKZRZvQb8lsGNMbyXqYvssvQspcErrsJL3IOCkAtY8LANmqGR226QZFAv8NhtY39AA8kvyvG463DQfhyR/kwDYYLulayi5AhVEyPFJL5g5LLBW5LiUNfGdloSYI2JFnuAdrNdr2kb2A2DH/UJIbX6qYOLj74LML2a2DpxHlCFo0TMKEv2K2oj5KqeXnJzPM7pn4A7f+jck4O9wmJtET2GBIT89wcAkbuGOL5phfUMQWfKQ+DT71C8vSgQ2B9tCez47yK9krOFaltrbqtLn+7PbfasT0VYs8vpZXj3XNK6qwAMCUqMNBHYwtI89n+ZJ5HZXpKnrKvnnYCWeyTEDzbmWX8efhaQ5a+T6StgUULlOA+8ps2iBu+GDt7E8hziOAKPkke/TPiVLpwL0v720rXJqYaPpm1VF0MSbpZO0fjL37n2v2u7PRgY1ZRrQrCfHJNXrzyvxwl0nW/h6cccPWEkGyJtrNpcG9Xo0K5++0olGZmj83AFSMxoSGNH8R/YI14PQikR9Bx0vm9IKja4yqwcl9/ESkrtpkl+2hJV+Y43Lf0iXoxI1YGBYoVDv4ef3enw5MO66GNFlwLN4NcxxSLLmjr5gLcmsaV10AQLiQrnJHiNxhA6x4jPYRunG1B8bQrCw/G6jaPlhHqz64jilY1aBp/9IoTgxOxX3FqfNAQRWEPj3BQuMc16MjNEyJTIqlxbPZeUoCCw6dbov2RRjHhT+cIB4BkI2qsYl68TBRjC2x+QxAaWqGxCGPBN5MCaWmPRBzcfFCGkSoDbyMBPIz9tBJG8YbCyiz DDjGP0CU 9PqlWvwBzelkcaYtXFIZ8Uk3iD6ibIIjHQIBH+IM3Mgi/jdJ6J5i8obXRF7gZjE5PZBWADGS1qCAadCNYjhr1lpFDbOd2kF2vTJuZJcTbP0Vlxsba8c4Xj/F/mUoISFoucY4lYxvqLgTrfMegHF1U0xisI9TfOjFPfXDihCFCqLNMzbBPnQ0sDCClPmfJ32dsJAGwu0b/GgvGm3SMDVKWW9dyIbLMlrUPtdS4haiJebmL43GA47o1porkAe1MA8oMES0jKfVobJ+CzP202unNLfHZxTV3qvBWmifjg3cgh8slOYVHFPFtR3Oz2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 11:15=E2=80=AFAM Ryan Roberts wrote: > > This allows batching the rmap removal with folio_remove_rmap_range(), > which means we avoid spuriously adding a partially unmapped folio to the > deferrred split queue in the common case, which reduces split queue lock > contention. > > Previously each page was removed from the rmap individually with > page_remove_rmap(). If the first page belonged to a large folio, this > would cause page_remove_rmap() to conclude that the folio was now > partially mapped and add the folio to the deferred split queue. But > subsequent calls would cause the folio to become fully unmapped, meaning > there is no value to adding it to the split queue. > > Signed-off-by: Ryan Roberts > --- > mm/memory.c | 119 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 119 insertions(+) We don't really need this patch for the series to work. So again, I'd split it out.