From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22BCBCDB47E for ; Wed, 18 Oct 2023 16:29:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 831FD8D0163; Wed, 18 Oct 2023 12:29:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BA748D0016; Wed, 18 Oct 2023 12:29:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 681CC8D0163; Wed, 18 Oct 2023 12:29:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 54ADC8D0016 for ; Wed, 18 Oct 2023 12:29:04 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2BD9E1CB80C for ; Wed, 18 Oct 2023 16:29:04 +0000 (UTC) X-FDA: 81359116608.28.3A7CCBE Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf07.hostedemail.com (Postfix) with ESMTP id 5CC394000D for ; Wed, 18 Oct 2023 16:29:02 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VNAdeS+n; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697646542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NP8epScHrNgHZ84MxLEjBdBvtFkaSpGQFw1IMN4MPNo=; b=MCtc4UauZJVHYREKiiCDpKt1TLDalgbYQU3tH3bYTU3sw/WSRDvUkea+vpq/dFTjgB9imL uS1PE5JEPVKJT59ShMZR7V9hcQC3yIsD28w4H7+79CVj8L5mZGfrwvLidRUoXrgC+vEfek vJUez7Nww73D2RhZ9nC2mEjWm5mJsZ4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VNAdeS+n; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697646542; a=rsa-sha256; cv=none; b=NiS9JJ+CujJJfa0UGCjpQSBAZYBndJtHyF0HMvlQtY6Du5/OE4ivDDEYBUGo+n3Yp3r+Aw R0el03yzjK3bFNntVPcwfeR0q2oag1+vGkcnHiNXrfoULDwsB7Fhor2YTq5bDimWynDSSa P9KsvzsnYvvpKlpJtDNJ7cJiH4pb5WQ= Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-41cb7720579so295341cf.1 for ; Wed, 18 Oct 2023 09:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697646541; x=1698251341; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NP8epScHrNgHZ84MxLEjBdBvtFkaSpGQFw1IMN4MPNo=; b=VNAdeS+n4yfz172QQkR4oNPjGDeCViq/fZQJUEfUlpIL5ismRhhZKEIfvE+086/gIT 8Yz80jnqSObwe10w9NniaccEDe5JOM0lvP7LWf9qylYaIftFY6g3TVA0sOkIsCMzWrCc WNMT1dsocKlDuyigzuzI6WJV9UJNHSqny0W6QledbD0q7wWeZiIpfBRbGM4xjFe90u1Q cLxSJuKdJr4yJtATCr+MHffJhKx4JGO//ceXGeHW6/8bdARJHEcN6tDagH1o77Nm0oVe QIQe639jtwyWqRDoNhx6Xt6fgTtOMc6EwBb/R2M3l3/y91i8eQWrixhYssaNn1wlZQKF LXgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697646541; x=1698251341; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NP8epScHrNgHZ84MxLEjBdBvtFkaSpGQFw1IMN4MPNo=; b=rk5cxu/tF7tqX9Y62alysKeT3ww13c7/J4RvRwID9tShq/zlN68e7KE4O+a8mVD76K 6VkPQOVijrXFu3dK2NxQCSGyyfitcRhDhRmx+gazWQcGo7f1TmKsi+wy7zs7DB9PNwMH jHU/V1Ys4DGptaT+vM/h60g+7MWQBpzC8riHg3ywmH8WX3w5oqkyG5ifXhfiytwZefN8 RfOPJfzZmc2YZGR09TOt40il7OTuI+zXmVkLZ7U1Mc33IQ2VZQT6UFmEa7HCvNjMiZ66 mUHcwVYeID7aZ/rP+pBxVo9lttBRfkcjakOL4avzqJCcI4czG7bf/IqnppF+ALbYXUHL ue2A== X-Gm-Message-State: AOJu0Yz5XU8UHA7CPqQYiU1vSc7C98N7yFm2fA3SYRDb/GJQ155CFvS8 QWKwW6hDNO6FKFWJJb/VWi92rr/GQ/V4Ovo7b6lZXA== X-Google-Smtp-Source: AGHT+IEjZdE64AlO/kPu6yekVca1LeSJ4143bYX+rUPzxbvwQZgKxFi7LC3iGp1nmFLzzNVPtiFHfVLV7D6UhUO4iQY= X-Received: by 2002:a05:622a:4713:b0:404:8218:83da with SMTP id dn19-20020a05622a471300b00404821883damr251529qtb.1.1697646541251; Wed, 18 Oct 2023 09:29:01 -0700 (PDT) MIME-Version: 1.0 References: <20231018082104.3918770-1-link@vivo.com> <20231018082104.3918770-2-link@vivo.com> In-Reply-To: <20231018082104.3918770-2-link@vivo.com> From: Yu Zhao Date: Wed, 18 Oct 2023 10:28:25 -0600 Message-ID: Subject: Re: [PATCH 1/2] tracing: mm: multigen-lru: fix mglru trace To: Huan Yang , Jaewon Kim , Kalesh Singh Cc: Steven Rostedt , Masami Hiramatsu , Andrew Morton , Suren Baghdasaryan , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, opensource.kernel@vivo.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5CC394000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: zzwak1iprikqmfmgomo114o19secbndy X-HE-Tag: 1697646542-847853 X-HE-Meta: U2FsdGVkX1+yoe1zbGfVdh34K5Jb0aU071gElthIEJgOlygQb9M/USvA/Y3n1rPmzRM0qlYbozHBZeYtlynOPIkCksZgh9vktYlJx1Uvvc3AGDgzj3fxptm8wdhrjK6UNGJD63G0aXVlgyUqq0R3gzqs80vYzXa4J6EPgo2VojB4KCprWKkuWCIjkZuJoodE5QuqpXOgFjqlftn9RCZ5+fi62x0CV3nCMtQAkZYxxgNmEsd433Fc+Di86USMGtYIo56MJYWQCwRxw40PrB9syX103rwlZw8xxmxRVpxhurszXwU0Gz151e6wGq7PzHSd6U/TcDdzLo8QKORZZ2T5CoAOANb4hd3olIG8C/P60/8u6zURiJ8dUwNeULmO2xeXQzny0xDbYwTSXnPEspsO2I16frhzTTYBkqukqi7KVMK22b/csdRsl4cOY+RdoPO/VLgztwl6mCHGaYQlT9WflZxx6BJyeGJIWlDIGYrxM6OHbkZ1wU5WjzVQaTnQjoAcPvREffPaYF6hCfa+JuIyhgbAT0vaw+NVRyGayt/fKSZ+yb7XGeso6h5THcuUxZDFeWrVsVMQ8bqvYCwOgbbNgXx23fIsD84zzI6adYTVBPGRCFZVUgvy/0q00V4LqKyChJF1FN3ZYqCtK+T/ZQd03+YXHaUT5fxsTJcoQau/Z/hyZPNsEMzvQQgcHpfksslcIEre4bOL39IXl1h9RYZMG7yoRBmViQ88Xws5GSHaqLeCh1tgb7NfWRakVHuR4dqw0bArX2Niv62yKwR6ClOwwsAQu7OplztEXUiRJhg9JY1glf+rr0an71KVpjWeKVjtfmdJcYKISudNTdLvolteA1KEFErYrOe1GGmA5s5ZQOQiegHzuZTxuUKSzvYJ+ESxJ/GKbcKHLpVrJdKbDQWPS87D3FIOaAqLMHNCzKcPiAlmPmuLI+USbfwttcWMxwajpH2etivEGdkpcz3jBUO 77Ku+rhG i2TfqK3cgvXhXYHjxtfm3h4CqDleoHKGHvnLofmU5Pcc+yJz5wF1TUuV+VfyRjE4sMRITdmKs/Z9PPBlaPzt1Klb3A7fpQvz/YO/Vdth1EAgsKqplqRrENmcbfWAw9EEAEYcEdqiRg2NwQUwDdJpLiWAtE7FjuCdhr/ZvjoNX652pbPVcYM4nqKHQp+K3guGUU0H441sULn6TYPYp/xJxZuuH7Xt76uXM/GyRqfb/rRfEuBfIwyL2wkJypghToKBX/kMMaylt8fdpr2Lxf4BrOk174iOgJWmCTun3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.036676, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 18, 2023 at 2:22=E2=80=AFAM Huan Yang wrote: > > This patch add two reclaim stat: > nr_promote: nr_pages shrink before promote by folio_update_gen. > nr_demote: nr_pages NUMA demotion passed. The above isn't specific to MLGRU, so they should be in a separate patchset= . > And then, use correct nr_scanned which evict_folios passed into > trace_mm_vmscan_lru_shrink_inactive. > > Mistake info like this: > ``` > kswapd0-89 [000] 64.887613: mm_vmscan_lru_shrink_inactive: > nid=3D0 nr_scanned=3D64 nr_reclaimed=3D0 nr_dirty=3D0 nr_writeback=3D0 > nr_congested=3D0 nr_immediate=3D0 nr_activate_anon=3D0 nr_activate_file= =3D0 > nr_ref_keep=3D0 nr_unmap_fail=3D0 priority=3D4 > flags=3DRECLAIM_WB_FILE|RECLAIM_WB_ASYNC > ``` > Correct info like this: > ``` > <...>-9041 [006] 43.738481: mm_vmscan_lru_shrink_inactive: > nid=3D0 nr_scanned=3D13 nr_reclaimed=3D0 nr_dirty=3D0 nr_writeback=3D0 > nr_congested=3D0 nr_immediate=3D0 nr_activate_anon=3D9 nr_activate_file= =3D0 > nr_ref_keep=3D0 nr_unmap_fail=3D0 nr_promote=3D4 nr_demote=3D0 priority= =3D12 > flags=3DRECLAIM_WB_ANON|RECLAIM_WB_ASYNC > ``` Adding Jaewon & Kalesh to take a look.