From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D223EC001B0 for ; Thu, 10 Aug 2023 23:13:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02DEF6B0071; Thu, 10 Aug 2023 19:13:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F202E6B0072; Thu, 10 Aug 2023 19:13:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE89B6B0074; Thu, 10 Aug 2023 19:13:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CF13C6B0071 for ; Thu, 10 Aug 2023 19:13:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A380C12114E for ; Thu, 10 Aug 2023 23:13:46 +0000 (UTC) X-FDA: 81109749252.02.C8607CA Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf26.hostedemail.com (Postfix) with ESMTP id C9DE614001F for ; Thu, 10 Aug 2023 23:13:44 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=qNAQlVmZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691709224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rc//26/31Jd4cOSTD1J3aAtcl52PyUGftq/fbg3u2dg=; b=YSuETFyL9jF+pmDp+P1xddb3FTaQFCDvTDo7r/FstY337u6chpKj9G01fZ8sB/vdcMGox2 /MaKaB8YcdrTLag9pLQT02HNpfC3af7Z58I7nl6meTrVvLs7FnP3gfe1fOJRVgkbyb1Yt6 c3G8keKuImi5P/JX09Pp/M9RccYbnwM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=qNAQlVmZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691709224; a=rsa-sha256; cv=none; b=SngnFE2KQybVm3r920619vBnYpjEn+2wq8FzIpSFSqvfB/+cqSNtI2+O1tnjDAAJo98B4i IFNSRvfFi+40MjPi9zlOoYjwPhu1Z7xsqizAmBMPtpOpyyOPLllO5Saav/UnKjUH6fDItv jErem3Z2X2w/LvINhNbBHOkg2L5BSdk= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-40c72caec5cso63341cf.0 for ; Thu, 10 Aug 2023 16:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691709224; x=1692314024; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rc//26/31Jd4cOSTD1J3aAtcl52PyUGftq/fbg3u2dg=; b=qNAQlVmZWz5mr5w2Q7GzmKY2aI6s3BbZvEh57UBBSWdOfTWZPXO5WtTGweiU6mG9UN skfGNnHz+cG+rnVwOJlN39FLYsnkog79QGrV3dFowtWUTzaROH7gyPLjRwigBIGZ0joo iscFfD1gIMtZ1vI0zZ0fvH+tIvoydMQyQOeV9Sa+ao3OqOdn15n4wjBPt9tXo1vApczz MpVQR1gGsEIGsA4pyhE29II0UGlthBCPnwihQeq8kP5gIumUpNDlSs3vfd/+iIMlSCWl O1v6EFFYG6FqI0yA7NPvqHGKGJDwOe2MZxxPuegwgbiARfjZym0xqoMRjIN0Pkhazs/w tdmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691709224; x=1692314024; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rc//26/31Jd4cOSTD1J3aAtcl52PyUGftq/fbg3u2dg=; b=CtT16IlH60BOF0kZlmSKzGAOwuVkGsWFhnv3ZtpyESv0zoJFji7j+TGNaQBee46fP+ VRDKv9zUycLLSoTzgVQYf3Xu8SMObicqWL1cK3+A43ECjTBVt2kPbtWP7EXy7e53aDV6 mdmQ/gwOm+4M/ug4IJDzmYjIhR4H1SMb29yanYFtRjy/HdjecEGIRsJ+JNEostBoACgq NInQDeuqyqUPFcXFrA0FXtVMlo1wO0cWzdBlmZXwoYfHt4m/Pfds8g5VWyolt8Z0cxlG hMX4/yROyVHZ8oJ+nRsy+zYsrGp3dbDwbOpJetZRMyyst5UtJBa1dkjpq5goPqupNALB IAOw== X-Gm-Message-State: AOJu0Ywug57PSqsdrh17ylslcVxH4Im+Aw8MB/XWyCRSBQxt56Drf9qQ anqsGMouIRb1e0AMV2aiLpIWWqgFEma920uuSIlE4A== X-Google-Smtp-Source: AGHT+IHsgm0oPYGpzGZEFgT8eaG71qDwSt8R+5gOCfug4dNC0NFtIKVXLQ9Kv/sm4riEjaAgCT6srejVdoY10T4WsJw= X-Received: by 2002:a05:622a:1888:b0:3f5:2006:50f1 with SMTP id v8-20020a05622a188800b003f5200650f1mr114052qtc.12.1691709223839; Thu, 10 Aug 2023 16:13:43 -0700 (PDT) MIME-Version: 1.0 References: <20230810095652.3905184-1-fengwei.yin@intel.com> <26949c92-95a0-414f-918a-8b8cc11e3e9c@intel.com> In-Reply-To: <26949c92-95a0-414f-918a-8b8cc11e3e9c@intel.com> From: Yu Zhao Date: Thu, 10 Aug 2023 17:13:07 -0600 Message-ID: Subject: Re: [PATCH] zswap: don't warn if none swapcache folio is passed to zswap_load To: "Yin, Fengwei" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C9DE614001F X-Stat-Signature: znppwje41zdb6buku3kstyt1tsf91mwz X-Rspam-User: X-HE-Tag: 1691709224-273345 X-HE-Meta: U2FsdGVkX19Q6pLkyiYpSZVERYDO4za5mhCz7ThOO+20sldPhc1mhWComMeJZ9Ltu4siC8FkryLp7AK8kRMNg/ObEOnlH7MftXhscdphJWfNsHMI0r3a10NAdrMEA/KjYfxMaQj55AA5QAdgw+k44OKd3jn7OGPx6jVoOh8hDKlVOs9/DE4+cgFXguLNCEDafTp/mztST2W0WjA2yBeU9yKfsAj4AlXjsTsABu4r5CRn51y1sWz8id7D17tqEFqTqYhZGqI9PXHzU/20pYgIlV+aCGJTsQ8DfJV16AH6RDRH/AFSDbsjY1+fpFVsbOlfR2EMh7OIz99w9okiKyOnuaO66wXl7DGVNgL7CNTEiCTnus00Xm6h3R7rlNnVkOT5yqzJORavjaf/mG0KnJYZdkppmpPyHxjzas5LIpSd5Fki6ShDQTHt4Eu5QFNyE/RoVEh5SEG1CexEKc0lLkg2/0oPAWk/yldzuYo2ZZoSzPGFRPdqAiM+4Q3w1V2GLB0xlrQ3mGYxLX6h96qaCj1NWQnZEYp3ELMjzIo/kPAgubzzjeM5gclzsoulGSI5kmfPoMj0YaV37q4AFVRH0VPjHQyoE/8vukTerjsu5sXmSCbNQY1RvHdu09dEJaSj6ih5HsI2ov7dn43DkIKsj+osq3aPregeNduv4kize4MtwnCePfNu86+W48IdGobMrbgLbIRMxRdFynlo9JB4egcGOk+elSUh/0ZqFubrzE1ZRGh6/thWtNU/o0v80NkRHsUeeSdz7rXJZGj/jOgLzfTc+R8FzKYZNf3BhnSo/WW8dcqig9kHBDU80wz+296i75S3t0o9uq5UFyhObbqWcMxkD2bl8GeCiYNQ0GRNt7NU+VCyc4NMUoKz99/EBxemL5x3kCzG4eaVP3YozXFRPYwdP+DhAY/1rltCgHGGESCD+hjVNU10l4qMo0bTWih9/jVpVWfhXjn/YXFnsu07yJu tdAmpH26 sHRTl0o7ye/01BRgAF0GWkLTbcvqDQGB6gx93iamDqdecsOItJsQwFdCl7yohSrRhIA1fCpcHa+7UFp6GH1zPN1xSBUJltqbTnFBu48d4kxaJt2g5yyOjXU+DwF4Jt6YhGoANzoIjaKvvERv6AKZptWMuTIpzdnNHJ4SzKRou8xQ783PdaUzUiohqKUfAj+j06UdVSk/PC5gXs4AHMvkcJzR3TlZJkw4Y4Ft8NT/CuaaPl2pwElkkgDeA7pXp3c2q5zX0nbe4SP0CjBWwWYnAaJr3anm7Lq141xaQiCm3flF6njgul1DDd6U7qrqocmsghy6+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 10, 2023 at 5:09=E2=80=AFPM Yin, Fengwei wrote: > > > > On 8/11/2023 2:44 AM, Yu Zhao wrote: > > On Thu, Aug 10, 2023 at 3:58=E2=80=AFAM Yin Fengwei wrote: > >> > >> With mm-unstable branch, if trigger swap activity and it's possible > >> see following warning: > >> [ 178.093511][ T651] WARNING: CPU: 2 PID: 651 at mm/zswap.c:1387 zsw= ap_load+0x67/0x570 > >> [ 178.095155][ T651] Modules linked in: > >> [ 178.096103][ T651] CPU: 2 PID: 651 Comm: gmain Not tainted 6.5.0-r= c4-00492-gad3232df3e41 #148 > >> [ 178.098372][ T651] Hardware name: QEMU Standard PC (i440FX + PIIX,= 1996), BIOS 1.14.0-2 04/01/2014 > >> [ 178.101114][ T651] RIP: 0010:zswap_load+0x67/0x570 > >> [ 178.102359][ T651] Code: a0 78 4b 85 e8 ea db ff ff 48 8b 00 a8 01= 0f 84 84 04 00 00 48 89 df e8 d7 db ff ff 48 8b 00 a9 00 00 08 00 0f 85 c4 > >> [ 178.106376][ T651] RSP: 0018:ffffc900011b3760 EFLAGS: 00010246 > >> [ 178.107675][ T651] RAX: 0017ffffc0080001 RBX: ffffea0004a991c0 RCX= :ffffc900011b37dc > >> [ 178.109242][ T651] RDX: 0000000000000000 RSI: 0000000000000001 RDI= :ffffea0004a991c0 > >> [ 178.110916][ T651] RBP: ffffea0004a991c0 R08: 0000000000000243 R09= :00000000c9a1aafc > >> [ 178.112377][ T651] R10: 00000000c9657db3 R11: 000000003c9657db R12= :0000000000014b9c > >> [ 178.113698][ T651] R13: ffff88813501e710 R14: ffff88810d591000 R15= :0000000000000000 > >> [ 178.115008][ T651] FS: 00007fb21a9ff700(0000) GS:ffff88813bc80000= (0000) knlGS:0000000000000000 > >> [ 178.116423][ T651] CS: 0010 DS: 0000 ES: 0000 CR0: 00000000800500= 33 > >> [ 178.117421][ T651] CR2: 00005632cbfc81f6 CR3: 0000000131450002 CR4= :0000000000370ee0 > >> [ 178.118683][ T651] DR0: 0000000000000000 DR1: 0000000000000000 DR2= :0000000000000000 > >> [ 178.119894][ T651] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7= :0000000000000400 > >> [ 178.121087][ T651] Call Trace: > >> [ 178.121654][ T651] > >> [ 178.122109][ T651] ? zswap_load+0x67/0x570 > >> [ 178.122658][ T651] ? __warn+0x81/0x170 > >> [ 178.123119][ T651] ? zswap_load+0x67/0x570 > >> [ 178.123608][ T651] ? report_bug+0x167/0x190 > >> [ 178.124150][ T651] ? handle_bug+0x3c/0x70 > >> [ 178.124615][ T651] ? exc_invalid_op+0x13/0x60 > >> [ 178.125192][ T651] ? asm_exc_invalid_op+0x16/0x20 > >> [ 178.125753][ T651] ? zswap_load+0x67/0x570 > >> [ 178.126231][ T651] ? lock_acquire+0xbb/0x290 > >> [ 178.126745][ T651] ? folio_add_lru+0x40/0x1c0 > >> [ 178.127261][ T651] ? find_held_lock+0x2b/0x80 > >> [ 178.127776][ T651] swap_readpage+0xc7/0x5c0 > >> [ 178.128273][ T651] do_swap_page+0x86d/0xf50 > >> [ 178.128770][ T651] ? __pte_offset_map+0x3e/0x290 > >> [ 178.129321][ T651] ? __pte_offset_map+0x1c4/0x290 > >> [ 178.129883][ T651] __handle_mm_fault+0x6ad/0xca0 > >> [ 178.130419][ T651] handle_mm_fault+0x18b/0x410 > >> [ 178.130992][ T651] do_user_addr_fault+0x1f1/0x820 > >> [ 178.132076][ T651] exc_page_fault+0x63/0x1a0 > >> [ 178.132599][ T651] asm_exc_page_fault+0x22/0x30 > >> > >> It's possible that swap_readpage() is called with none swapcache folio > >> in do_swap_page() and trigger this warning. So we shouldn't assume > >> zswap_load() always takes swapcache folio. > > > > Did you use a bdev with QUEUE_FLAG_SYNCHRONOUS? Otherwise it sounds > > like a bug to me. > > I hit this warning with zram which has QUEUE_FLAG_SYNCHRONOUS set. Thanks= . Reviewed-by: Yu Zhao