From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5808C433EF for ; Fri, 24 Jun 2022 19:00:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AEDB8E026A; Fri, 24 Jun 2022 15:00:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35F838E0244; Fri, 24 Jun 2022 15:00:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2253B8E026A; Fri, 24 Jun 2022 15:00:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 105D88E0244 for ; Fri, 24 Jun 2022 15:00:06 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D476120977 for ; Fri, 24 Jun 2022 19:00:05 +0000 (UTC) X-FDA: 79614044370.24.ACB0377 Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) by imf31.hostedemail.com (Postfix) with ESMTP id 3BBFD20028 for ; Fri, 24 Jun 2022 19:00:05 +0000 (UTC) Received: by mail-vk1-f179.google.com with SMTP id j15so1627150vkp.5 for ; Fri, 24 Jun 2022 12:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SGluoKDvNhpoEckHDDWOrxS1tEeRkkrqbbiy7mtXDJo=; b=SeBK9OzzJLTSt+E2NcO4CyshZ5eHLG0+k5F08mXxwS2vxxQ9f/og5eFQvpKJ8uSSwI rHel2K+mUIoxl2Afl9nRzCRLf3eWH9X7pklzRV2sYVenMZQDJ9ViZZ3ozsOnypQl1toQ bAJ60csNSyGqcrE+qY1mCB468Vs/hKPnFMwiKFOdp9z6vJ4VZDIqzOYk4ZIs9G5/pKLZ eGXW2mR4f/2KWbDJrx4Gs/xh6DA0sVwkUyg1EZcCOY2cyjAX/mq8VqdOwQJN4jBYv5w1 Hw7gwdX71XnQGV0lxkEQdiUjeIfZtKjhEioV9HJPoMu1f/p2+QgVO/u4CpEyhkTabe5v Fk7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SGluoKDvNhpoEckHDDWOrxS1tEeRkkrqbbiy7mtXDJo=; b=EEVCTAwPvHg5j5G9J5cTu1YUzbZGyiUIbn67HKFoP0KaFFY89aZ++IG3Uf8gR4BWjp k1CbOnOSXBMu0eqaempHWRMDabQaxQ/VMzoVTsx48n4oE3aJF3Kze5FpYc5yqdZXh6m3 UG1r9abi1PztXKETOkW4qDTTBAuY3ofT1lb+k7ZwV8K8ydKBuFJCUODI+LLqQcDb8ouO Ov+zfYe4qtJmBT+0raOLySIiDrYRk60GZO/ccA8H2Dg1xmvgWcf5zaJ8ETGcIThj0Hzz Slit5x3JOUDnX3PW9Iy4QachYoY+Rq3WCjHyvrUCfjUerKfwYgFic6X0P3NxYzoUZq8c FzFg== X-Gm-Message-State: AJIora+X4egRwXFklVzifSfUbK5TvrdBee1FJlQoR5/baaqUCU5D4aR+ G36rK2cpJmg9b596PX3ZIFOuOiBUUEzU98VGCYVY4g== X-Google-Smtp-Source: AGRyM1ukY9oxnkNfmBtHx7HwwDrY4EIVheW23sU7aprr50cq3luECdsgoeFJYDVuTX/JqSzKyopFqE+pi+fD4wyo4bE= X-Received: by 2002:a1f:1886:0:b0:36c:c60b:a4ef with SMTP id 128-20020a1f1886000000b0036cc60ba4efmr125792vky.29.1656097204398; Fri, 24 Jun 2022 12:00:04 -0700 (PDT) MIME-Version: 1.0 References: <20220624125423.6126-1-mgorman@techsingularity.net> <20220624125423.6126-8-mgorman@techsingularity.net> In-Reply-To: <20220624125423.6126-8-mgorman@techsingularity.net> From: Yu Zhao Date: Fri, 24 Jun 2022 12:59:28 -0600 Message-ID: Subject: Re: [PATCH 7/7] mm/page_alloc: Replace local_lock with normal spinlock To: Mel Gorman Cc: Andrew Morton , Nicolas Saenz Julienne , Marcelo Tosatti , Vlastimil Babka , Michal Hocko , Hugh Dickins , Marek Szyprowski , LKML , Linux-MM Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656097205; a=rsa-sha256; cv=none; b=odJ2mRekXieBV9iUgepfGWpsLZJIaGzUY+AflXsyYXt4wgIE8RVVl/XPg7QZo6f0s9Lkn3 azS4URfnej713zrp6r17Ghqmqh6VKsxv8n4cP6QLeWVk76wG77o8X/FFfMa9RvOE/M7THu d8M5tAUuLpe4ZRve8heagcqEOJcQid8= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SeBK9Ozz; spf=pass (imf31.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656097205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SGluoKDvNhpoEckHDDWOrxS1tEeRkkrqbbiy7mtXDJo=; b=xXNIbWagvcHMtuAHF909y7aWphN+RDHtAiIwC7joT6eMMix6En43id5rR2QN7EAnEIzL4P KvzbGJpXp8APeQRITOzAx4ZeP1dL2zWqP5vClT7NnoX4/kDGSciQW2d0BBvJBMIj1nDppY ku3wZNo05u3lzvfxWOjXr1E5kh7BF/s= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3BBFD20028 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SeBK9Ozz; spf=pass (imf31.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Stat-Signature: x5mjg4f7ihe4dbxb9zi1ua58r1b41usu X-HE-Tag: 1656097205-350792 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 24, 2022 at 6:55 AM Mel Gorman wrote: ... > +#define pcp_spin_trylock_irqsave(ptr, flags) \ > + pcpu_spin_trylock_irqsave(struct per_cpu_pages, lock, ptr, flags) > + ... > + pcp = pcpu_spin_trylock_irqsave(struct per_cpu_pages, lock, zone->per_cpu_pageset, flags); Why pcp_spin_trylock_irqsave() was added earlier but not used later?