From: Yu Zhao <yuzhao@google.com>
To: Yin Fengwei <fengwei.yin@intel.com>, minchan@kernel.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, willy@infradead.org,
david@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com
Subject: Re: [RFC PATCH v2 4/4] madvise: avoid trying to split large folio always in cold_pageout
Date: Mon, 24 Jul 2023 23:26:27 -0600 [thread overview]
Message-ID: <CAOUHufbVZ_jxoKRuqqf3m6aNykEb5Z2M9Pi116dh2_F6CPO_zg@mail.gmail.com> (raw)
In-Reply-To: <20230721094043.2506691-5-fengwei.yin@intel.com>
On Fri, Jul 21, 2023 at 3:41 AM Yin Fengwei <fengwei.yin@intel.com> wrote:
>
> Current madvise_cold_or_pageout_pte_range() always tries to split
> large folio.
>
> Avoid trying to split large folio always by:
> - if large folio is in the request range, don't split it. Leave
> to page reclaim to decide whether the large folio needs be
> split.
> - if large folio crosses boundaries of request range, skip it if
> it's page cache. Try to split it if it's anonymous large folio.
> If failed to split it, just skip it.
>
> Invoke folio_referenced() to clear the A bit for large folio. As it
> will acquire pte lock, just do it after release pte lock.
>
> Signed-off-by: Yin Fengwei <fengwei.yin@intel.com>
I currently don't have the bandwidth to look at this one. Minchan, can
you please take a look? Thanks.
prev parent reply other threads:[~2023-07-25 5:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 9:40 [RFC PATCH v2 0/4] fix large folio for madvise_cold_or_pageout() Yin Fengwei
2023-07-21 9:40 ` [RFC PATCH v2 1/4] madvise: not use mapcount() against large folio for sharing check Yin Fengwei
2023-07-21 18:57 ` Yu Zhao
2023-07-23 12:26 ` Yin, Fengwei
2023-07-25 5:22 ` Yu Zhao
2023-07-21 9:40 ` [RFC PATCH v2 2/4] madvise: Use notify-able API to clear and flush page table entries Yin Fengwei
2023-07-25 5:55 ` Yu Zhao
2023-07-26 2:49 ` Yin Fengwei
2023-07-26 3:26 ` Yu Zhao
2023-07-26 4:44 ` Yin Fengwei
2023-07-26 5:40 ` Yu Zhao
2023-07-26 6:21 ` Yin Fengwei
2023-07-27 3:28 ` Yu Zhao
2023-07-28 16:14 ` Yin, Fengwei
2023-07-21 9:40 ` [RFC PATCH v2 3/4] mm: add functions folio_in_range() and folio_within_vma() Yin Fengwei
2023-07-25 5:42 ` Yu Zhao
2023-07-21 9:40 ` [RFC PATCH v2 4/4] madvise: avoid trying to split large folio always in cold_pageout Yin Fengwei
2023-07-25 5:26 ` Yu Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOUHufbVZ_jxoKRuqqf3m6aNykEb5Z2M9Pi116dh2_F6CPO_zg@mail.gmail.com \
--to=yuzhao@google.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox