From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E9CCDB47E for ; Wed, 18 Oct 2023 16:22:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0FF48D0161; Wed, 18 Oct 2023 12:22:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC0958D0016; Wed, 18 Oct 2023 12:22:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B00F8D0161; Wed, 18 Oct 2023 12:22:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 891798D0016 for ; Wed, 18 Oct 2023 12:22:28 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6290D802B1 for ; Wed, 18 Oct 2023 16:22:28 +0000 (UTC) X-FDA: 81359099976.03.7B70633 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf29.hostedemail.com (Postfix) with ESMTP id AA799120005 for ; Wed, 18 Oct 2023 16:22:25 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lIspOWRj; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697646145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1ESBoSu0Q2kOoNHH1TTBfnX4/YG198ciywvQbN8v9rE=; b=rI+CNzBUj/CGZj2wt1HXZfEv/InUG1Q9qf0me+OG0E2NvjlZAkaLx7KYOqgCP1xvdc+GeR YBrT2HSNo9Dj8Bvs6C1coB1hSMEEkIlRQMyJqaLy/riMDILVVmNn+gjnMekkSpeYPyNEgs 4t/HTsK7kB4na7KD2kduuFxnyNeVnrk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lIspOWRj; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697646145; a=rsa-sha256; cv=none; b=HHPUzsO+QcL710IzMHn0iAWGLJWy0Sw7QBxQA6GiVHO1fqxLOfCafPI7sZpIT+n0Yc/193 v5+PC2HavvZRKR3wXALHA3mPUMBm8b9xA+zli+9mBfjOAEhtqcGoklvHKqDWagqjanPYpC sCReXL+InVRg5KJOPnDTUw9doKiXtOk= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-41cb7720579so292591cf.1 for ; Wed, 18 Oct 2023 09:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697646145; x=1698250945; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1ESBoSu0Q2kOoNHH1TTBfnX4/YG198ciywvQbN8v9rE=; b=lIspOWRj78F9/669Nw7pvEkpdVxYkdyttEf4hL1crlYr0wKAgW8u3VCyDPb2eZhHma 9+jIEmZn3HpyvO2fGvPiaSfYFprt1WoZPE24WQWw4vnyqqd3ZggASN5pSKGyIPDaaEHW ACWliU/jOkYRZeV9EM/kbfSq49DQgQKdW0hjU39+AL9UNOWSEaYL36F7cw6hL2O/hKdt 4n31TlV70/dp7d0gwTMDuj4zGwk0qtLJjeiis4FJikxn3UTfWHWoXVVrMqMNxqUbqiUn NZp6EavjfInBD2SodnI7r6Vr0jH8AThlFwFwKHvBZsEFrvFv5FBMnEy9ddjSjA2gyXze moKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697646145; x=1698250945; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1ESBoSu0Q2kOoNHH1TTBfnX4/YG198ciywvQbN8v9rE=; b=esDfot0UdxvwL5WwGT3kcEq/c1zctKe2h8qPBjFnk7O1lL2EmkAd8l5Bhhva30IT6m K7fKCKONPaLtaHlijka+nC8EPbhPvQMVyQjFsMbYMQT5Io9kN+cZa30C+UWjvWvb1+ns xv5BDWnJcKPxNw/L/ko3kPSYzhU8N97ClFlCS6V8mo2lHUOzp1nOMnr8nx8rxLrFQgGb QxdfKOuUXl+ydz1jy+r8TbkEWYfzPDmbMipY4ASOWJW/2PVlM4xTlN4maQvq3fIKkg8t F1gafW3XupHQf5hxFBSBB8mYrqGR3qLRyp15nEJEw/EWsOkfLai5+ltmctw9JYg6vUxV Wq5A== X-Gm-Message-State: AOJu0YwyEOj5E2fcXeILBrdn5IJhGVIkLF6fckxOAXke1BWkJXFb7uJJ 3UY1x7BByCoQtFraTzsWI0oa1OhkPp0hOn7B9Npdqg== X-Google-Smtp-Source: AGHT+IF6mJk4QPRLAjJWI/o6MMUeKJaaas0JnbYE4DP1GoPpKt3v9snrBQH4kk0quh0gH9SuLieuXsPbaCYJn2+Gj98= X-Received: by 2002:a05:622a:7711:b0:41c:375b:81a3 with SMTP id ki17-20020a05622a771100b0041c375b81a3mr321200qtb.18.1697646144607; Wed, 18 Oct 2023 09:22:24 -0700 (PDT) MIME-Version: 1.0 References: <20231018082104.3918770-1-link@vivo.com> <20231018082104.3918770-3-link@vivo.com> In-Reply-To: <20231018082104.3918770-3-link@vivo.com> From: Yu Zhao Date: Wed, 18 Oct 2023 10:21:47 -0600 Message-ID: Subject: Re: [PATCH 2/2] mm: multi-gen lru: fix stat count To: Huan Yang Cc: Steven Rostedt , Masami Hiramatsu , Andrew Morton , Suren Baghdasaryan , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, opensource.kernel@vivo.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AA799120005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: uh7fdwsbmh4az6cchqgomxjxyzu3cngu X-HE-Tag: 1697646145-573045 X-HE-Meta: U2FsdGVkX1+vLcnf4Vzq9Il5O7kGiQ4x8LSNAhi3NutBWTQ5lQi98KPXloR5rJ4gIIwnYhdSmxz0KqJjf0S/30dvvDtsIf7hV3sVKzLRpde1jlqyyr3G5Zu482Rf9IMot4r3kqmYHGBux5FsjxPzKaX+NYlH732W0YBbf2SrM/wRKx8T3KtmqvA0er13UOK2I2prvUN1EeLYGoUjJgFxC8L2ODqzwcJbCXfJgCrM1ff3vBHhBFAhve3lLA49OBO+DdVAORUmbHfPOLSY+VxkLyMDgOvWVk/CCrgS8F6Yn8KL3RaetuRWSUcr8wUwhu0nHyIz0uxQ1DqQ5qtEPhc7VrWnHY2u+P7rXXPryTX4op1DtuVFVwBb/7VMO8NTgG9tnNu39t3BQisxxzfNjktEFN9hF6pUs3jgfG0CKMDbKt1G6rh5a2kL22WHmLmQGapLUMPQDfmw7ITXww/mk/WcC/PncvRvmzIKg0/uVDYtc4za2rndicQ08emohZutzOSc+ksjy6B+VGk3FwqEuHC57bM45rygpUGBFWH0Ck/edPJXuFl2QVOy44RxUQMvhHgOMu5SfGI/m+CqFFcZs6TUU45+yRe8i9kIg4K7w6mlxR8tVyYcS9jO2MBPvjg76Qme4w92bTxcYkChnOS0qK14SPCQFNlOAQSkygbeRUWsEgTRyHpqBT1/RNATtE9MAlIrv0wqZ99FcD2v9tDrWA+PMTDUIwXz+cUsFb5pUNjp59lU+4OhNfGbrVVXwUOec8jyyVieNhP0g0teFabHJvrZ0bUuc/ICOlNfW+GrU4q82EeicTCTQB1W1SPzGI20zkWB+vzpcnmlFTzzqblcO0erxH7yRm5omsEN8dzyjnvtWg6hG/D8rol1VVC1MiU7CTAWZEfsENhI9CTmX8kW+CfX9dWpqMUTVCW38AyAihSUDzx1yYkMP/v/weEXUabTBYm4iajQJEk83mKwHARkqG7 znI3aFWx pLvAzl4cBCDUrI8Jy+84tCFWYi1/Mdm3XWjM2irlPcrwsVDN+SrjNjDxwKjC4WSWb7408nmEvolFII/zG79F61XGrlEUFq6tU4S07lLe2u3xgTOnvXHFtiQCu6W24KUb7lKY57LSwGnGuZmYZfqZVi31hZoRChRY6GHII0sAICct5vSmx4gkI8n7eZ8AjqnyQjMqKLmtVBgCQVFDGJtQbjYHnMxJUPE7ACNbjLVCfEnAZWqsEi4pVGezMD2nGXccbUNbWBYbFEuipsYl2b+i6UD4v9xb1e8lVTW0H X-Bogosity: Ham, tests=bogofilter, spamicity=0.032080, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 18, 2023 at 2:22=E2=80=AFAM Huan Yang wrote: > > For multi-gen lru reclaim in evict_folios, like shrink_inactive_list, > gather folios which isolate to reclaim, and invoke shirnk_folio_list. > > But, when complete shrink, it not gather shrink reclaim stat into sc, > we can't get info like nr_dirty\congested in reclaim, and then > control writeback, dirty number and mark as LRUVEC_CONGESTED, or > just bpf trace shrink and get correct sc stat. > > This patch fix this by simple copy code from shrink_inactive_list when > end of shrink list. MGLRU doesn't try to write back dirt file pages in the reclaim path -- it filters them out in sort_folio() and leaves them to the page writeback. (The page writeback is a dedicated component for this purpose). So there is nothing to fix.