From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1C30C001E0 for ; Thu, 10 Aug 2023 19:31:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 330516B0072; Thu, 10 Aug 2023 15:31:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E05C6B0078; Thu, 10 Aug 2023 15:31:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A8C26B007B; Thu, 10 Aug 2023 15:31:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0BAC66B0072 for ; Thu, 10 Aug 2023 15:31:00 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D4DCDA01D9 for ; Thu, 10 Aug 2023 19:30:59 +0000 (UTC) X-FDA: 81109187838.15.7A46CCE Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf27.hostedemail.com (Postfix) with ESMTP id 1540740023 for ; Thu, 10 Aug 2023 19:30:57 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Jd0onYPo; spf=pass (imf27.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691695858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qTpLyvzgH53OBSjK9r16H8W2zoDKFMFaOweQykQ1i2Q=; b=b7Om9F4BrO85+F4w+q5xlxb+I2ZoIWgyTn2vT+SBoNVI+8JWbAdSWTTmn9AqX3lvIYbY5M MFds4zQoK3EBty6m+AIW58zu199gvolHBDv2PgJMS6ddoDFb1BDHliPyJqDN2GsEOw2Pgm pbJPiGaKcKSq37FAQAFZRA0BA2wTK7E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691695858; a=rsa-sha256; cv=none; b=NcjnIfIg6CfvxPNxx/PmfxnI2HH6FdN7i7msdgQL2cmu9q9DHrVmufXrgrLfUvMUf73POQ Ua1xIKB45N0gu+i7qzHj9AD9qi6jwY2ncyy1L2gXh2Myk0e+jlXwk3tUgQ5nkxmIs8zzVw 4OFfgRdS6PgaklGLMpCRCTaSne/GJBQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Jd0onYPo; spf=pass (imf27.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-40c72caec5cso401cf.0 for ; Thu, 10 Aug 2023 12:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691695857; x=1692300657; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qTpLyvzgH53OBSjK9r16H8W2zoDKFMFaOweQykQ1i2Q=; b=Jd0onYPoMWrLrJcrl+4baJAMA3fFU3mzHVw40Z6XLVS7IZN3kxUORnmw8qqBm3Nd+6 fZjg04ErCqQyY/qrv6N8ZaHCGRRayDj4p1fXFrMOC0dsVL/PwVKGYHUEggzqYiZT63Gl bPaWhSbLfLPDtXBCrr4MqOdwpdSzsNiIXHVtUTvJMFa7Rem12Q6+Sq7uBND2sLjrIW2Z kTn9xV4prZ8ZHTWB+Nk0T+X/VLNx37bD0ZqsuBEPSf3XIb/Tq2YR7+xc/EfBHilIzZ7M 6+RCZ6pK1klHm4jzz7k8oYwnF77tphhLyVD2HiT6GHVun7qkQdC9NXdEoU83SJauLCuy 3AEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691695857; x=1692300657; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qTpLyvzgH53OBSjK9r16H8W2zoDKFMFaOweQykQ1i2Q=; b=lgHXxatsHcH3e3pSYJykXIqkGCuoQqoj4uImrMKWsBkbEDCV+1BLT+6AoD3G8CpwVx PyX29R4OcaRzDj36iINHzintWvFXGsGi64eFmrCnKXu9px726v//Vu0Ttpzgfbo8/6Ii YR6qECbJimo/4cy2mI6SADYFui7FEgMD+zbpkYggMcWODKmtvY3A0ibDZzqEdMdM4a9R k+1IVwjzmW8QVM9WDwMlrOy9nQQJsr9gLH+ul2Zjh70rxquhJNPkL9wDAob22ONrK2TY s2RBBS1CUDKzFND6MNIhXGnX0+Z+T7BgxxDuGwlmmbQbzj7JfCme219vn3Ic3B/Tac7L PKlw== X-Gm-Message-State: AOJu0YxCI3wOPN3CsxtM0wW6xJNwkfSGs7y4GJ7elnRkGh+kN9DDD4V3 evsGn1LnG/GPT922t+hQLrNj/twKWJeLO6hoFKErQg== X-Google-Smtp-Source: AGHT+IFQwyV5vdBv3g4FI28KH2jTSacKQzB1wU2GpBf9QmLIuqeNpbksGrg9tW/xVtlmoiYoWmSC53nQVRaK/P4Z1Jg= X-Received: by 2002:a05:622a:282:b0:3f8:5b2:aef2 with SMTP id z2-20020a05622a028200b003f805b2aef2mr51442qtw.26.1691695856840; Thu, 10 Aug 2023 12:30:56 -0700 (PDT) MIME-Version: 1.0 References: <20230810192128.1855570-1-axelrasmussen@google.com> In-Reply-To: <20230810192128.1855570-1-axelrasmussen@google.com> From: Yu Zhao Date: Thu, 10 Aug 2023 13:30:20 -0600 Message-ID: Subject: Re: [PATCH mm-unstable fix] mm: userfaultfd: check for start + len overflow in validate_range: fix To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Brian Geffon , Christian Brauner , David Hildenbrand , Gaosheng Cui , Huang Ying , Hugh Dickins , James Houghton , Jiaqi Yan , Jonathan Corbet , Kefeng Wang , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Peter Xu , Ryan Roberts , Shuah Khan , Steven Barrett , Suleiman Souhlal , Suren Baghdasaryan , "T.J. Alumbaugh" , ZhangPeng , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1540740023 X-Rspam-User: X-Stat-Signature: 5c5q37uxjqi7i3ktp6c6paxff4m7yd9i X-Rspamd-Server: rspam03 X-HE-Tag: 1691695857-858347 X-HE-Meta: U2FsdGVkX1/xqCMzBvcr9SbOKlsZvE5FSfCUrqVs82AtGaGYB11nKTVSdykRU0yEA4ehOLI06NjqckJyxU1kCWPUrZrS1W+exG+LhSR4rY0ocb10SlZzaURTpeCo6WZhPxRr30IEip6HiUlbI0vwFluVEX9oeHgLhkEfKHKDmpGAbA2+z3bsPXBWoSTiyj1ESBAos3c7eElV+agMHE5Ya9/1J+mRKpZQsVbJyl+YuDe7Iuq3ET+hmzRG5w1GTa135GlIN0PPgQqM/6WgQcEXmcbR3DgCm4l3GoNK0kO2gEB0YW0kdZ0enp/o8OCQehFR0Lt3hTtFh8wziGe0EreEVs8GA2yjHgUW185jK2zSqg3a5PzVCW1GvbqB8eoALQwmz+tdvnPJNfS8QFK4IifbyLQ6RkLEPw5MVeqjGsaIKafx7PbUB3pGJMLVR+3BswkIJy1ZSYgcHJiCrUYPorxqw6JnVMpIa6AUd9OORoP19zv1peJVUZ3epPd6p6Vn3Kab7qA7+7mkD5f60lsaA6gxDhuB2pDcunkGlbxmqL8Nfm9LdmqTWlUniMJWOSlJd0iBHEHJgqObjd4nmoenwt5rzW8hnqR6R2+nhcVlfhrMcOSbNG1ZzCoQO1QuA3hdUciUP8k4fPwwxcwEzSq+gUSwOpgA5VHQuGlJN9Ggc3/b4POuExgrlPGEocsSmy4FkiH0uxu9BB/8/ZEVUhyptE498iJJnQv3RuAbPRCj4RI5QNN3ztn7N1SQjjGs5gBxY0x/1I7VeUI40vKuTgIfy/JrS2w1P3fQAfpxassLJtzHacLqCPMaJX39eX7OKNUn96mycurRP+qKMKEs6vqoPNAjyj2A8+7vhN0DhSFElRwvXOYNuD4bVDyj/bIpuDTPVdN1d87mBsH0x18gWcd27IoIb/t4wxLMyxtjhnwy+UE6talLo9gprCKz/GWhSD7d3RnuKxL9Bj+ug9AC9QFzFHY QwbI9p9l LUWSXLR2ClR7TyOXaEPXHXxzazsHJkfCu+JsUbkiAG3F9/Pz/K8uvhmcElOPEGDlLjhtfZ6W9ryNwHdoy6Z1Fk1ZEklEPfqQ+p8vtTqfy9DRO8d4DzRAoY78D9C+lusqz54/fnUa66PT2KylmXueEV4ACyWab6HAjIU7T3hRJjizawsH9HyRMyPtPJtMQQSkjFyzc0paV+14O4oNTVik421KYqZxzThzhUAvCNhYZsisqzJxk+X9lC0/gUTKemx6c57wkt7qf0h7nS0K8HJEQu0twi7Vd0YZNtJCjjAh3UdUrMED0jj52wWJokIo8SegZA5LZNTBXc7w61MXKdAQgFVQaFTw2u4S4WuQ4d8gh1wacBaSS5LBAMVI0CKt6ZG8cNOV2u1bTP4zXB7MCQgTJ68wAvNvyH+kqFOC6kBMgPlIBkplzLnzXcmzlIJ5fSGZaFhY39scmAj8tSdwoWw7A1E3pwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 10, 2023 at 1:21=E2=80=AFPM Axel Rasmussen wrote: > > A previous fixup to this commit fixed one issue, but introduced another: > we're now overly strict when validating the src address for UFFDIO_COPY. > > Most of the validation in validate_range is useful to apply to src as > well as dst, but page alignment is only a requirement for dst, not src. > So, split the function up so src can use an "unaligned" variant, while > still allowing us to share the majority of the code between the > different cases. > > Reported-by: Ryan Roberts > Closes: https://lore.kernel.org/linux-mm/8fbb5965-28f7-4e9a-ac04-1406ed8f= c2d4@arm.com/T/#t > Signed-off-by: Axel Rasmussen Reviewed-by: Yu Zhao