From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3713ACD1288 for ; Mon, 1 Apr 2024 14:32:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C58F6B0083; Mon, 1 Apr 2024 10:32:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84CCD6B0087; Mon, 1 Apr 2024 10:32:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7172A6B0089; Mon, 1 Apr 2024 10:32:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 51B126B0083 for ; Mon, 1 Apr 2024 10:32:03 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DB44B1C010A for ; Mon, 1 Apr 2024 14:32:02 +0000 (UTC) X-FDA: 81961202484.01.4F92275 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf07.hostedemail.com (Postfix) with ESMTP id 0675940005 for ; Mon, 1 Apr 2024 14:32:00 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VpiQ9v2j; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711981921; a=rsa-sha256; cv=none; b=G5aQ+Ys5nXJNFfPOR7vCCohbboGFXt94P4KEYU41spza33qjLeF/fmAatnUnOwheXKs1RM LAMzyaag8VUuYYl02l2IoqouRNWVkQ1cqPYXwLULGITopxz1QBsgzpdVGQarP/2bSnHVEE LJ+W2i+NC+JJUq5zUnY622n6L7ALmqo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VpiQ9v2j; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711981921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1KOTRfdlb96wg3JQvEVXeDDrjwIrXhXgqbZ+oZikD30=; b=pE4qQwxDxgMDk+eGmJa0L8yBwE+SELsK21r6do118gU7CxSL0hz2g66SP9LDt17KzCaRZY C/A2hPHb3S9aRJVdXSIYpcKsZSStXF+FCjyw1+oO5WF5xwoKkL1qSETWQIvPLgS0enT68f 2HIDpaFArWA7VkhbRXLE+sBwnCaHhlc= Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4156ae9db55so38625e9.1 for ; Mon, 01 Apr 2024 07:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711981919; x=1712586719; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1KOTRfdlb96wg3JQvEVXeDDrjwIrXhXgqbZ+oZikD30=; b=VpiQ9v2jlQXpq5iG5QHFIw/59palBth7lxeMxFc0nfy4bBmt3vGdkIA3y9pRcCotxV ZH5Doh3NETnLerC0RdyF4xfYAJmyec2XyapuzDGsgqGHLKhVegtIXqDn0uBXb/2xQH4P 02o+c7ohvgWEOSLBs1FScQlgEN+dGp1KYnQEGn2YEIsQ7GnvXKknG/8YX7jTiR5VR9t4 jXfjUx1UYMNAfIcZhWYX5Pq3veEloartXMh0pUi8vqCZxgQAXu2nRnX0U/EpQao3gPcS dFd85ipQ3WB3C3xwU6Vq10fg4ftxSN/++haUa3GzPAjgM/g8onl6LOBq1oAUkeuNBx9V ptjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711981919; x=1712586719; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1KOTRfdlb96wg3JQvEVXeDDrjwIrXhXgqbZ+oZikD30=; b=BRT4PMpLnzeI/ZKHuMbcT5nvNRS8mNKAT5ZXiQLbsCMXae1Hhk6CbQ11sakUL5Mx6q +e1QURNWvqUr88U76FaYV215bx9huOgyl4nlwbVlV0M6wW78R/3W/Z4D0xBeloYjDot1 3axrIgmfIg4l1r8py47nCtNOJuAj8WNl41WxIMI5Ln+NGW4JPbCLZ10t25uqG3MnidKt VhvrEhWudxMFl0aCr9q+krJtrPj77LD9Dad1PhvE5I0nPuq89LzsfMNYTJCvpXt3iQ1l fmPCfpg2HOh9DxeAF07bpVCEMQIyqUQLU+1BR+yziOR6QnaukwQ+GVWC8soCQvrF3Gdl kPAA== X-Forwarded-Encrypted: i=1; AJvYcCV0KJSGQv9LSoyCoIG+hkVz0A7KrTvF83UkwwQJHr1UHO47bTSy5r/ImKy0FOwsdCAtw/sk542O5N1VldwXQ0NGjOw= X-Gm-Message-State: AOJu0YwU5sSpVhFWeZt5pcRH87ACA3FY4HZ9C6RYfi35CIr57V5Q2MUr mJRm8+NxLL3MZsHfEbS+hYu2i+tWzXMzPtQZ0JI4aP3XX8apZT1/2tz02ol0XNFlOCnWWGk1SWa wJcBnWlt/6EyWv6pUWCw85I3iCZBknAicT9Lv X-Google-Smtp-Source: AGHT+IG+u23aU1rXzBPhKteiMq1T1djcdv7lhCX1QEg+e0SJ7XlBGeCeRCs/T8iztgcvI52c5nLJlVws6uRQkVJeEO8= X-Received: by 2002:a05:600c:4754:b0:414:7f73:6158 with SMTP id w20-20020a05600c475400b004147f736158mr566112wmo.4.1711981919221; Mon, 01 Apr 2024 07:31:59 -0700 (PDT) MIME-Version: 1.0 References: <20240329073750.20012-1-21cnbao@gmail.com> In-Reply-To: <20240329073750.20012-1-21cnbao@gmail.com> From: Yu Zhao Date: Mon, 1 Apr 2024 10:31:20 -0400 Message-ID: Subject: Re: [PATCH] mm: alloc_anon_folio: avoid doing vma_thp_gfp_mask in fallback cases To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Ryan Roberts , Kefeng Wang , John Hubbard , David Hildenbrand , Alistair Popple , Anshuman Khandual , Catalin Marinas , David Rientjes , "Huang, Ying" , Hugh Dickins , Itaru Kitayama , "Kirill A . Shutemov" , Luis Chamberlain , Matthew Wilcox , Vlastimil Babka , Yang Shi , Yin Fengwei , Zi Yan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0675940005 X-Stat-Signature: jezzkj84m5q7cur7w6ftcdb8mzsx46pa X-HE-Tag: 1711981920-484556 X-HE-Meta: U2FsdGVkX1+eJ9fpeCb81QAy9KIjuQeznS2zJU5caVYYbEkqD3LljdJadxHfrAyusz8Si5nJsDfiF++a3as9gVqvKLhRX2WpRzAKq84YORq1PoyTcnMB7RPEGC8HXi6FQzt1vqPCo/XgjqkawiW3RVdoC044zHMI2ni3odqElpcyktD/xUlm8hcotF6IhmOojNurrrzfPWTHZjcQr6L/VBLXT2zk8Q5t5mHCu0MaLMjlsmQN8XviAUcGehynhML0FP8rR6BVN6Q8FOse/YrWc6zh9dVQCwhkTSdkpXXhQoMfQ4F5ZdsX1dhuysz3uVYU1HvmTFvBOI4OHjqfwe14vMpbwLVmzBBtDYrXNWrVS7jDBPt9WFHKQfSyeMDRcJU1fel9i+MJsfvaPRmG1ayFNDWVVjlwB/T2gv0dr1O9cS6jLzECX9vNY9CH0lG2Ie2BKsVpr/d74ZVBdYIIqDn88fPyC3SRhzfAhU7QXBxXhA2jCLGe/8E7wJKtOdrjUZb8zK9dXLWdkPtS8DJH+36SRd8Lbw/J81Fskx47I0dIpb8DCe6NsVn6OSxh+s3ln4/E5EvyavdfgYlZPDJljBLc+e27TVx28qFkFimhMwD+TAmW/9x1aPbVHL/c01ShiutHfteAAAevR9G8BB9J9HVQPpAjXL2jh3P7pSXt2eaE3S2RrmzXidqFgcKQBVYbp5Ui8Lge5D6w94gu+1sY2TWu50raABhM93Ye6JbzycF5ZlU94AtLJg0UWYvDVKc1TCqYSS7DJIyaAhko1ms1tQTt1u0b5rCCTEK6ZNVNRbX7zrwoBK0KxXyWnMDTqTPhOFSJ4SDkKP0ZGx2RRorfocqFjksbJ3UNftqp0xWXhXL2EQJsTfg2dmQj0vDD6AQ53gLG/8CfHEKBWgR4q/6mkZix6gPUeznCLE1Oi4bvCBUOeSfX8CHBSjFvhLsdxT2zd7KBvJ6LhR3/QKRRU+XvnNY i+BPrCqw clZSAPriAlJtC0i476NqAaY2DBUuGE0WzTOeb+APhLN+xpZXQLiYhkrySLefpmnbqw6KklwbdtRJan/9YDl9BLSYBxU6S80ZJzZd7stq7+gKNYVI3bCIaM3QmlS56PEn9IvBTEnwXOgTvxJ3V40IQEh5jrJZq48NG+Sl2NCdaV3NRZoMYncBaazoMJ7ObgeVF47NSQBrI0FdcddfFybAE4LdfpM8CF9Lz4vaZzICEEEb0FAC5Bs02fzfUgL0XVpxqNNC+pP+TNuE3rGa3IOPXuJGiFFDCOZnnOuxhMk2ib5LRPllHU45rddK1hk6tk3NBacorfeK4406LKf7O2gqzfk9KXPvSI8VEAlTC4ir08v2IxPHsmx5DAH3YXTXEsJIoePtuY6V5e2vnY44cDP18EOtdjBwbSxugcc49N9UahpGHjboGdT41V3wVBXMTu2I7tjml X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 29, 2024 at 3:38=E2=80=AFAM Barry Song <21cnbao@gmail.com> wrot= e: > > From: Barry Song > > Fallback rates surpassing 90% have been observed on phones utilizing 64Ki= B > CONT-PTE mTHP. In these scenarios, when one out of every 16 PTEs fails > to allocate large folios, the remaining 15 PTEs fallback. Consequently, > invoking vma_thp_gfp_mask seems redundant in such cases. Furthermore, > abstaining from its use can also contribute to improved code readability. Acked-by: Yu Zhao