From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3187C19F2D for ; Tue, 9 Aug 2022 23:36:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC4FB8E0002; Tue, 9 Aug 2022 19:36:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C74FF8E0001; Tue, 9 Aug 2022 19:36:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B15238E0002; Tue, 9 Aug 2022 19:36:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9E9EF8E0001 for ; Tue, 9 Aug 2022 19:36:21 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 70A6316021C for ; Tue, 9 Aug 2022 23:36:21 +0000 (UTC) X-FDA: 79781665362.29.C735800 Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by imf23.hostedemail.com (Postfix) with ESMTP id 174E6140050 for ; Tue, 9 Aug 2022 23:36:20 +0000 (UTC) Received: by mail-ua1-f49.google.com with SMTP id 5so5223203uay.5 for ; Tue, 09 Aug 2022 16:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=o4wdgvd9lokOVkmz3///Dw5D/UVYUgUiBJagcPYB94M=; b=bXQyJL88COq3m8pU1jfr6QgcWtKMoygb+O7A5xhSAn6byuBoRKA7YPEgwkvc/hp98n Nmwf/o0VAi7udRT2BEDfLzS/IB0BBkY4f+GsAuesfVq84iHg2T/ylNEdHDoG1pe8h16v IMCwwJ+FqhbWtajm2L10HsNVfk3jlz/iDOVlKtt/Sp5PR2nT79/zCmAK7MEQ3tffWgGy /Jbo5swYJmZxcm1wuNJSH3k08BdXLfRSdOSnRsmZsgfTHNyufGmqCLS1RVo/nDVSfjmT QUw6MI4TF0D8f1Kit9Bf6pKAUzzFDCh2Echh+LztL/1L1ElxK9rzolfDTrxVZ0se/IPn SB+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=o4wdgvd9lokOVkmz3///Dw5D/UVYUgUiBJagcPYB94M=; b=1NxchTb7e91uSM7lNi72RmavBX3KEVA2DEtn/PqTwUC4W+0MRTrnzGjEC2+j1SeWuh EVGc6//TSIxEMOTUBehMIiDjX5rky2PQty4+Exu4zCLNdo1SRRgvQWimHuB4SVUag6q7 jbBu4raYhSGOZiQUXdGf3WtXDAnbQ8gBsY81+nTaTMCnogu/iKRwZUTClmr/fzRTcrYP ESXh5Yj/YBSRFONUJXjjS5hBX50MFxJQqEcwFkInz7QYPXExu9Vqic3/UTrLxkyaPhHW XSRTJAB587Q1C1mOwdXCwalyde3SXhDcK60/ctP7zdw61+mlnOEmZMGNprWi/4Pm0kKB ow5Q== X-Gm-Message-State: ACgBeo3YG9yBQv40olyCM7UtuR7tuCAnD5ZweeP7ozi2Rw1tI5xVh6AM nt/u7HTOuRKmcteZWf8kOLj7tCxUnWm4cuAlUvkmug== X-Google-Smtp-Source: AA6agR61c1M90WGtrFaP+Gh5AcPiEcbJHfs9ELby75M3kF5agX2qra8YCIPBx93xFQbktlykLKIWh8EoaYxHRtP78ZQ= X-Received: by 2002:ab0:2242:0:b0:38c:7f0d:623e with SMTP id z2-20020ab02242000000b0038c7f0d623emr6415328uan.59.1660088180210; Tue, 09 Aug 2022 16:36:20 -0700 (PDT) MIME-Version: 1.0 References: <20220805184016.2926168-1-alexlzhu@fb.com> <0b16dbac6444bfcdfbeb4df4280354839bfe1a8f.camel@fb.com> <1F8B9D85-A735-4832-AD58-CA4BD474248D@fb.com> In-Reply-To: <1F8B9D85-A735-4832-AD58-CA4BD474248D@fb.com> From: Yu Zhao Date: Tue, 9 Aug 2022 17:35:44 -0600 Message-ID: Subject: Re: [PATCH v3] mm: add thp_utilization metrics to /proc/thp_utilization To: "Alex Zhu (Kernel)" Cc: Yang Shi , Rik van Riel , Kernel Team , "linux-mm@kvack.org" , "willy@infradead.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , Ning Zhang Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660088181; a=rsa-sha256; cv=none; b=8WpEnOPJcQkYfN50IxUFiO10ISE2hVGq4Y1C/r3TfxyinK0ZZu3gdQhFAcDkMWrcabvdl2 Q0th52bNdFiPOvKZGolHZ+tEO5ImpzFIz5Fgn44oqlvJJIwuIcUUZr89NN627rAX0Vz9If VVOpA+1rsAaX1fPvtYp3eFZBXqPx6+Y= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bXQyJL88; spf=pass (imf23.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.49 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660088181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o4wdgvd9lokOVkmz3///Dw5D/UVYUgUiBJagcPYB94M=; b=E69pm0W/SvDHgo4c11zAnN94uvZe3kwSw+ahGNa/h0WzuOpbwhYTH/F5mbZI7amfRKOI0s yMS0lZfQklMwHH99FRP5TvObPixeYoeFX9ORqKCBGqrYFWAZT8T3ct6kZDD5vnv7FXDwfJ RaigaSchOSSIIBydznfOXyazXEA4ZGw= X-Rspamd-Queue-Id: 174E6140050 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bXQyJL88; spf=pass (imf23.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.49 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: gay1ikxnibz6dpiucd3zdcrcucd58s1q X-HE-Tag: 1660088180-147568 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 9, 2022 at 11:16 AM Alex Zhu (Kernel) wrote: > > > > OK, it is hard to tell what it looks like now. But the THPs on the > > deferred split list may be on the "low utilization split" list too? > > IIUC the major difference is to replace zero-filled subpage to special > > zero page, so you implemented another THP split function to handle it? > > > > Anyway the code should answer the most questions. > > They can indeed end up on both lists. This did have to be handled when > implementing the shrinker. > > We free the zero filled subpages, while modifying the existing split_huge_page() > function. Will follow up that change in another patch. FYI. This series does it: https://lore.kernel.org/r/20210731063938.1391602-1-yuzhao@google.com/ And this one: https://lore.kernel.org/r/1635422215-99394-1-git-send-email-ningzhang@linux.alibaba.com/