From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A047EE77173 for ; Fri, 6 Dec 2024 05:34:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E434B6B0198; Fri, 6 Dec 2024 00:34:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF2D86B0199; Fri, 6 Dec 2024 00:34:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB9EE6B019D; Fri, 6 Dec 2024 00:34:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AC9306B0198 for ; Fri, 6 Dec 2024 00:34:35 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 56B28161887 for ; Fri, 6 Dec 2024 05:34:35 +0000 (UTC) X-FDA: 82863418638.06.387EBE3 Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) by imf30.hostedemail.com (Postfix) with ESMTP id 18FEC80009 for ; Fri, 6 Dec 2024 05:34:01 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gPOSXAv+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733463266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=16KGT4gLtqp9hrwwvR1/YXm4X39dxUtnEO49CGuLwJc=; b=Lzv3gB8gaP2F2tCHDGg6ng/nW8poMvmw6FB5UB9vkBn+U9+yuZUKMYLZjoZ5bf7Kcei5ug pHR0yqz59HyMX/ewEO+EramKXVo5J5bGfqcpCw0tUC07WBXDi63+er7wrMg2ISN1oIIxTl vmYHWmzcE4fVFWmLvNmMwYm/60iztY4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733463266; a=rsa-sha256; cv=none; b=zWJLeBRaYlkk/wI6cc3EhYFT5EXLMILW8XV+JZCFpxdTHJxL/7ChPc2RwU864X7egFPxNO iXfmM3CJ2bIYGfbEO9g4sPTRqDIngiauRpQkkH6Ot5XI3iN9T6TTAblUtf5K4VzYOWTVLN i76fuKYwki7Tf+LRwk2OMlnrAuCffFI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gPOSXAv+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=yuzhao@google.com Received: by mail-ua1-f51.google.com with SMTP id a1e0cc1a2514c-85c436db302so195609241.0 for ; Thu, 05 Dec 2024 21:34:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1733463272; x=1734068072; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=16KGT4gLtqp9hrwwvR1/YXm4X39dxUtnEO49CGuLwJc=; b=gPOSXAv+z5V7M2NT9YGWMExG3CYJISZLlzf9kq6/V65+ZlwOe6kJQMAjCRvS2rOCd2 49U2hkQHcvP7o68AKAjLkqIg8RB3uKzLUfJ9xjlq5M8v+kNr0V8l5geGGaokpC8ed1P1 fsBaPXmR5vNfL7DPp6d5CQ7tKiPLeOxz5Ee1PjQFCbFEFtF1Yoi60+sqeE4i31ni7Dkm PShzj4rvEvaBJJkTbNQuSfKYQfGNCqbGfK8bicOlwytiVxqQuLw3coz8UcLVUUhSUc8q 2ekyEf+tra/BiknYw/oBKXHF+E7WRMjYzrWifnWFLePAwEjPHcykzlMklompSCskSbu0 ONXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733463272; x=1734068072; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=16KGT4gLtqp9hrwwvR1/YXm4X39dxUtnEO49CGuLwJc=; b=raGd4aGJ96JrqK4D5BcZD8Z29FH+OO5PYbYjMMMW4rJcmvyCiyKuimD1kG5c4bzFJm hTyKNFxeACd+XJFqoJKUlghVXr/gGh+5yGuaKtdbOU8VLfV8NNKRpS8dAaZmEuejBrBl 9gkDs+pysl+sLpLIXCQHF7Xh8X+gV1pooBGCMYApnXy1Kn+iMIlqAM9iSc1+ytUpKJ0B ekvJt5gODOgFesil7hJSQg8ObsTUbIAsg1E7ERdwflXqQ/GCUQ9G0gUt2L8B4fVAJT8W badhkG2yFAVUhcZ9Mttaz9wASitRc+f27SADBV4llacv47u5ZfsU7/APRHQg0i/Im/XN kRLA== X-Forwarded-Encrypted: i=1; AJvYcCVPIHaXB3tq0cNxOfIR9ai0Jp9siUoWplAN+5+BlY5GR2EGZaVrI34qoi6+/Z1QrNXzzrv2JpjB/w==@kvack.org X-Gm-Message-State: AOJu0YzR3CYT4B1apRN1yG+hpLiFcjlt6qlxeM4FyIh8rguw9wh2byGf wsMSqwZmS3XnuNo/U+KNsJReQ9jvLgvomzirvkA4Lxdq2C5xfnmHtkJRjp5HSb3krSbO0KC7waY 2PXn0WQvK3YZlSOrAqNJePEkLD92Ykc0owsYK X-Gm-Gg: ASbGncuLwZ0MqUeKpVoshw95sxCQCpM4nb8TLoYYRu7YiNqWbTCIxcPlU7X7LY2XTrQ W8QDlPyxH4fFe4oDQ4cKNZnTW2cbCrLG2p+aXAKZ/k5jVYXYoarJGTtFaQ3zdDPbb X-Google-Smtp-Source: AGHT+IEvLPcxcG6dZYsc3RKvBr2mvmoMEUY4/wcnwdmAjPDkJVyQm0dyThNYTYOoPk5dcYLaVciUxeWQ2PRBVfQ8Qbo= X-Received: by 2002:a05:6102:5493:b0:4af:586c:6197 with SMTP id ada2fe7eead31-4afb9345c75mr7082003137.0.1733463272304; Thu, 05 Dec 2024 21:34:32 -0800 (PST) MIME-Version: 1.0 References: <20241206013512.2883617-1-chenridong@huaweicloud.com> <20241206013512.2883617-4-chenridong@huaweicloud.com> In-Reply-To: <20241206013512.2883617-4-chenridong@huaweicloud.com> From: Yu Zhao Date: Thu, 5 Dec 2024 22:33:55 -0700 Message-ID: Subject: Re: [next -v1 3/5] memcg: simplify the mem_cgroup_update_lru_size function To: Chen Ridong , Hugh Dickins Cc: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: hp5zqjyxweuejg8bxtxde7hrsehig9em X-Rspamd-Queue-Id: 18FEC80009 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1733463241-730305 X-HE-Meta: U2FsdGVkX19APvknuUywDRVHSQnxawOSb8uHg6WBJ1waK2wNIhvxkH3VMpjiLkekwnOP0dW5F0svoom80yEUfESDwojRCxrVc3Wsp9YImOaR787kSW+UA4kHKRuYpghpMh2ANgnqVv58RebSikLtaJZc6MrUBoLdPw1oy8s2pd72NxLHYzfJa6KxSblQ70jZTCCNxfxh7S/6b9YXPj5kbfLrS9eCBEyF6ecsanpSlg8DYjKo4Vnrd1bq0EmlBHPQziquE7Q9wxrzJJ51X7hNK6XdDhZswb2pDCqlv1WPulVBSeHxC3tN8mdA1UJuf2VfjwtBZ4yjtLZWPeu3Wtv7J7JQENcoCDmEZw1lSaqJgnUyahFEo10Ti2qYYBL21/z47BXHTvrPm7+8h129TC+hQt0Wv65XgHPoAAWhotQgbx/4KD1cFQkfL7hdWFUev5opt3BCywsn4YqRtqX8YqeRvW2zFKUMq0pf5rSpCRzMhSwhBAvCzfimCMLq0WvMhhw1ccPMqMrhqD9XeLbbVaGUXjHefAr0/Z8vcZP/46Ak+b5hhBraLoyir9o2GJUoVbZOjC+Etrux5IftLHrQ9PBVI5L7YsBfO6QY0ABqsbS8TZM7/ey9rrilcIIJe/SmodPKZvWnT53U1hNt3Z8i0bjbXblfKMHv4mtYqA7c3xum4q+sRMHENbMmQDVp9zWY8S10aZ49G2ykCFJQa5czXyy+r0mqJPt67wCM8NopNNLfymsIJuGmBCXwmOdVOe63UoYjGx5INAZX7mEfmyBvX8x/f7U8i2/X8QY9tTMsCyPzhuIPFa7mElhhL+3nfwrEOhfRDEWjaT/xIsEaZTEoq/7Hgy6fHEL1BlP1fq6UIkATDNWVjAVa9J0QZENsNsQaooIN2UTvo6hXnxqc4igZT44T0481948gGR9KcQcnS2jMpT60ZmMYL/GVtrxWyy+XPLrrQBr7S9H7d8SUlymo4JC cdcgGOnn Zty8I39zIV175QACdg58yzKkFvohoQXqdxfJc9xL1+7bmtArmTBvM0vHoyrcf1RiJ00cWc4PJe9x0kn6IK+xSD28Dtlw2dBGrExCvXhNsLXr6CjyVNoMWds5Oo4XGU+g6q3zG81jNDsbfUwk26plo8jn+HVMkmy1K2NQnhbSftF+TT2y8mN9ARNLVaraiu+qR0M0/YC0RVfAZfmSV/zjHTwhvJ5b6BIT2HxMdWUI2jTzpbdTcI3f2m5zrgrr2FHBt5BKcZMbFLQeTK6yyOQjOx/t5qCsbfY+6PqGi X-Bogosity: Ham, tests=bogofilter, spamicity=0.006187, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 5, 2024 at 6:45=E2=80=AFPM Chen Ridong wrote: > > From: Chen Ridong > > In the `mem_cgroup_update_lru_size` function, the `lru_size` should be > updated by adding `nr_pages` regardless of whether `nr_pages` is greater > than 0 or less than 0. To simplify this function, add a check for > `nr_pages` =3D=3D 0. When `nr_pages` is not equal to 0, perform the same > actions. > > Signed-off-by: Chen Ridong NAK. The commit that added that clearly explains why it was done that way.