From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4436EB64D7 for ; Sun, 18 Jun 2023 20:58:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A9358D0002; Sun, 18 Jun 2023 16:58:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3596D8D0001; Sun, 18 Jun 2023 16:58:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FAA98D0002; Sun, 18 Jun 2023 16:58:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0F96F8D0001 for ; Sun, 18 Jun 2023 16:58:11 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D461E14032C for ; Sun, 18 Jun 2023 20:58:10 +0000 (UTC) X-FDA: 80917081140.03.16F6C84 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf03.hostedemail.com (Postfix) with ESMTP id 15C0420007 for ; Sun, 18 Jun 2023 20:58:08 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ZVT9TlvX; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687121889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FZtyfCTAVMiPGQWHjgwoE9XDDUe5Zitl3naYIJu5u8M=; b=qPaVkAS8I0WfSWp/Lk3diT+S6AzV3F9+/iTRTmUaDD2+XA6SiQVmwakVVRV7A4BScgZvBF zFDqLNzcLZxAllLoJZ4/VmXa4HKEsG4lDjM++8HACn8rWl2015WqHrKz/QlAtg6BW/kXYj VmDzcV8AD6Fh1Pb/SdxLhrphxFETBIM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ZVT9TlvX; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687121889; a=rsa-sha256; cv=none; b=l4HlYH8rWKxNA7BVOsTAtBBScGLhOutwj1BMZgFR9dnWqxMWzhTQaNGpi08UYJXT3rCBIj PKmJfuJGzmskWjj/ONt3RxrW6Z2zAZL8erC1MfnPdfo/fTsmEokVyUepXWFYV2dNx8cl0c bTHn6MstordlJWOf2SPEVFpVOjls/C4= Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-3f9a81da5d7so251801cf.0 for ; Sun, 18 Jun 2023 13:58:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687121888; x=1689713888; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FZtyfCTAVMiPGQWHjgwoE9XDDUe5Zitl3naYIJu5u8M=; b=ZVT9TlvXekbzjsIk4FVN6w5b3V3bL2g07xM58CsOQEKlBliMaOMo4yZji4Q+4M2pTX PwOyYLy6AVqkAYYG8oZQzsoJ5wXO3fYU4dvuBveWcoPn/DBqA76dOm2wErETk5RMX4DF Pdjj7y7tVBfSg3bUPlVpNbbP9RKpJTFpWfMqG6NS8ogCoI9SFLLQjHjuiJCl9wmx/QMI sfudbAhw5Fv3ydEbSaSvd7K7sWgk9eaIp4KEVRbqeVVI+v27ojzRWzN3DHLLYoRPb3Uw 6IMcAn+rqIjZUCyYlDlj0BpHHcpwknOPBIBYMxSFkst2yjNHbhKR20MPChNpYuTjpIYD wwUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687121888; x=1689713888; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FZtyfCTAVMiPGQWHjgwoE9XDDUe5Zitl3naYIJu5u8M=; b=C3eVKdcjh7x+ngU9qaP4rnjC1EPoDyPqx1eU6PBCljP9B3xho8mto4RrT0wnUiIhJc tvih/05HLi0U3FBfRdLkLKGNdXCOKyU2YU3lqEYwXaWQQZiirUc1HZv8o5GwmoyQpqG0 Dfr6VEr7tdlV04ltgGm9jrvNNCS3339QTyNZ/Dk/2/PnD5Byb47HnivAq5fXVPGOhmiz l5Q3SRr4IZTO/QcB1olKMmoMI68CS8WKcYJeLrLeVsOBrNudBQkIg2aVHbn9K9FHzWGg WgU/ScLWCeKwKtDAw4Nn4wcSYrdpalgx7jJq7Ha98WD5saVeSr/+IPqU7zuesar1cKvL PLtA== X-Gm-Message-State: AC+VfDy1Qf4nZu6abO2GojSNigjl3vSvAMkVHTCvDi5zERtElnti8VR2 nLpVSgHn+tONeN0GWslHvVuF4W1dG/QIqAfiztmACw== X-Google-Smtp-Source: ACHHUZ6ZDWbPtAWRuLjADFFa6FEUQ3GypTx245KPaUVC0BHZGX9Wd0LOXtVKSGnZtQDaYiPHdDlVEaUz0sYg2vTadSQ= X-Received: by 2002:a05:622a:20a:b0:3f9:a78f:c527 with SMTP id b10-20020a05622a020a00b003f9a78fc527mr291449qtx.21.1687121888063; Sun, 18 Jun 2023 13:58:08 -0700 (PDT) MIME-Version: 1.0 References: <178970b0-1539-8aac-76fd-972c6c46ec17@google.com> <20230614231758.GA1503611@dev-arch.thelio-3990X> <344a4da-3890-45fd-607e-b5f85ca6ad48@google.com> <20230615155059.GB3665766@dev-arch.thelio-3990X> <76b41825-30fa-b9e8-d043-2affcba24317@google.com> In-Reply-To: From: Yu Zhao Date: Sun, 18 Jun 2023 14:57:31 -0600 Message-ID: Subject: Re: [PATCH v2 07/23 replacement] mips: add pte_unmap() to balance pte_offset_map() To: Hugh Dickins , Nathan Chancellor , Thomas Bogendoerfer Cc: Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Peter Zijlstra , Russell King , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Greg Ungerer , Michal Simek , Helge Deller , John David Anglin , "Aneesh Kumar K.V" , Michael Ellerman , Alexandre Ghiti , Palmer Dabbelt , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , Alexander Gordeev , John Paul Adrian Glaubitz , "David S. Miller" , Chris Zankel , Max Filippov , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-mips@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 15C0420007 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 3httuki9f65pbisosxz851ac965mg3sf X-HE-Tag: 1687121888-223022 X-HE-Meta: U2FsdGVkX1+1HF0iSN0+SKvkB+X2Yem61zywiaiW7rK+cOeJBo6RMkvEYJDhvfM2C5GvapMxNocTuf2AjJ0PcIvk5QbsYk0W+RmAfnKJbj0qF4O8hpVVxuoW3cFQky086gqU7iQzqk9UhCfmN4p8Nj7mD7z1WoDSgy70dZ7OD1Oyjuk1JdaGDvoozI0sJWvWeYNb91/NFE/3UM+0G1kTHphk3EMgHcaKzmfjVBtkDSRb0Pw7JG+ihUJOA8fT7EmkUefpa3kb2QuYJXSNHdE5dKBAoYQd7Jpmxsv3ZG1vVoMm9iUqqdd6ooLJi+XWzB0V0BXzGnHCGtKo93+CxJmTMo18hfBptfgciFcR+XzX5d8pyhZSJjqd7NNx8GdueQ8LGmf2W0X43HI/JS5T1pSiJmTyIa7pN50pDP+7VTO/2SnlVD1dA2OkXVhM6l/zrHzE8fmKb/GF0SKjEtMeVvkwywcuQBxEs/iu2SyjwPbLK393DAjlVnG4xa4CQAy71iL2wrngtxH/0ldOcUtSDjJzOKQmNNq9rEsRZqbIGUFg+PPVeu39TWP9ilUiG42yF6aoQTSZ35H0VrECH5wXPnO2vWCOQuivpQFP9VAzqn3KwOy+04L8Y82X3yFHq7EjG2+UPYu7Bo54mt7Sy4E/NTo0jtzDmvcL7Sne0AMuv+i6wes6nH3fJ76kPWSjn0JIExzwBISfXOlUP2JOVPxBdQavzQC9lzV5ZDIYFvHz0yjJHwonJ0B9NWNJKD+a5bE6/PVs4UXDk8u9exIodvhxTsP6c/zj2D7aHsizzOAXMM2aWq2sfIRh6h72hQAoYN7c0j+XOuyU3GbRxsmCe55oWS2/SBGKHfiglyHBneRhaWopustSfB6I4W6qCcpxFN8hQ/lCVfDTaZCw+jnDS9oDgGBqKiH225cZtwmlkCXYdbhIDnueas3JNgTCeD5hSgnIu+2067GJWT4uXNTnB0G1ekI QKXLmiQ5 RgLm3QMZgTgGXoakA8dVKgdApOFCnH4QoyCDpMaIA4U0lcIKvuma13C7V2lchD0am3aIxTUv8oW5aHa3nLYRKN9kx8B7T8j3HGKXpCUDJSNe8fqbrQIOoj5gZwnjdd4t7SUqfHoP12GMS5vFk40xroRkfGi8sAeuv5stCvDUC1MpesuP9MS9YAdfpcRCH/yQ6i+ZVbPszsbM3DxT8vrQSK0X8PoaVVxgihunKKnd2y8Di9pYi6UbvQxK+9rDizxwXgcLQmtdkktACrpAo7gf/BUI0BsdbftIh4o+4n5Y1SvUaFYXQtOtywJ1Q0IwzO+GTYYZ/8NCodpvrGaLnB33yTAK3qJlPB9i6OzCrcbmF5ekKAaw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 16, 2023 at 9:54=E2=80=AFPM Yu Zhao wrote: > > On Thu, Jun 15, 2023 at 04:02:43PM -0700, Hugh Dickins wrote: > > To keep balance in future, __update_tlb() remember to pte_unmap() after > > pte_offset_map(). This is an odd case, since the caller has already do= ne > > pte_offset_map_lock(), then mips forgets the address and recalculates i= t; > > but my two naive attempts to clean that up did more harm than good. > > > > Tested-by: Nathan Chancellor > > Signed-off-by: Hugh Dickins > > FWIW: Tested-by: Yu Zhao > > There is another problem, likely caused by khugepaged, happened multiple = times. But I don't think it's related to your series, just FYI. > > Got mcheck at ffffffff81134ef0 > CPU: 3 PID: 36 Comm: khugepaged Not tainted 6.4.0-rc6-00049-g62d8779610= bb-dirty #1 ... > Kernel panic - not syncing: Caught Machine Check exception - caused by = multiple matching entries in the TLB. In case anyone plans to try to fix this - the problem goes back to at least 5.15 stable. My (educated) guess is that nobody complained about it because all the testing is done in QEMU, which does NOT detect conflicting TLBs. This means the verification of the fix would need to be on a real piece of h/w or an updated QEMU. In target/mips/tcg/sysemu/tlb_helper.c: static void r4k_fill_tlb(CPUMIPSState *env, int idx) { r4k_tlb_t *tlb; uint64_t mask =3D env->CP0_PageMask >> (TARGET_PAGE_BITS + 1); /* XXX: detect conflicting TLBs and raise a MCHECK exception when neede= d */ ...