From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7230CC7EE26 for ; Tue, 23 May 2023 22:05:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDACA6B0074; Tue, 23 May 2023 18:05:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8AD06B0075; Tue, 23 May 2023 18:05:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7C21900003; Tue, 23 May 2023 18:05:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B86EA6B0074 for ; Tue, 23 May 2023 18:05:33 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8623EC0821 for ; Tue, 23 May 2023 22:05:33 +0000 (UTC) X-FDA: 80822902146.19.008CAC9 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf17.hostedemail.com (Postfix) with ESMTP id ADBAA40017 for ; Tue, 23 May 2023 22:05:31 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=WgGqTH+f; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684879531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2WG7cm3SOeE/AEmJ5imPtVDm8ujtcFrQwX6MexQOiXA=; b=RyVu9pQITvWsm9Z18tP4UxrvjCJnT2/KYMluNV1NHFb/DcpnTZUw9L3BB5A/lKzzsuTZk/ 1DgFtelHJmPvtmKRGsxHnicSk2MBWAp/+bHMJBNHmSvRc+k90P8lNxF2nQfV5toy2t3oZX LsYvspkTLyuiIFEToYAXJVBkjasq61c= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=WgGqTH+f; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684879531; a=rsa-sha256; cv=none; b=NROMw5q8AX+k3pzBjn25lhjgYDug/pVMLYtM4gYqMTh32tH675L59oqsGqws0LkM/bwkua YoAQABUCQMxik9B0lABMVHI8Zrav9JsjPOoSyNm3+yEYnQfNo5Bw9sxkipAHvQtheuN6tY qBLShaifcfprMt2ly7ix1vX6fMTV2Mk= Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-3f600a6a890so25605e9.0 for ; Tue, 23 May 2023 15:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684879530; x=1687471530; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2WG7cm3SOeE/AEmJ5imPtVDm8ujtcFrQwX6MexQOiXA=; b=WgGqTH+fr7xzJ54Wv5q5B/fbZQtGZzIeF7zH10dyE2lfIyMWMk9Sa1co17wzGUEoO1 zridCyqqqIDgZ/GPkIsmtLW73lTXaUibio0Nj0nTIPixvhE8xbHOX9EcN57b677hCZyV BL2LQrOmLTap/9v0APYz6LB1h+gj3FfLtp6VJ9v/0dG++AL5BDCC3e+4lmx4aZfPjLG/ LVCOC+DO4OfGUk4GgGOFUlcnRMSrErNHsVvuOrUyXnjVuiX6BIuFOMdnyy8bSRtniSgy n1FSM9n3hxf/BsepoPBWGTx8515rjMph8knbc5T5yyM5tzMq+P+Rv0xIxWo2VHTkccHd U66w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684879530; x=1687471530; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2WG7cm3SOeE/AEmJ5imPtVDm8ujtcFrQwX6MexQOiXA=; b=Swk02Vfou4qUGE64lPPQkgBukeeNnFAi3fSHhJLScRsND+39/AC39kKoK50JibxbgQ NSrFpyAUUPdtrUz+4Ptq6MThdtPAzxlRzOkIaugzNPggFVQtgm6TiBlpO5/PMIYcqrSR 5fsYiy0BV1orziaH2/wg5j3ku7x5gmVB5dUzTu68RFTGfmiRYX5mzasPL2DW91Xbbkpj sx6Cz52JwbQddNfbcv3JozolioESmuAzX2/gD1BWatYqD1hy8m0vcG51D7pJ+WotkpnE 3LQyqIb6tElqkdCPTEVSSnpwBJcQCKEi+LIB/pjFxOEDGPs6LzJ5ghV73ji+rH1uPgsm uPwg== X-Gm-Message-State: AC+VfDzjRYhaJWds7vyHL3I0ozxE8oiTQofxpeKKMNeo6KwcoXL9l7hd LtI7ckwmKthn5rAdl+IJnQyZCZ6q+qb+a3B/7djKBA== X-Google-Smtp-Source: ACHHUZ6uGkm2EnvzV8wfnKBvB7qTrDSxdqvEltJbQAidg1jAdH//992ples+uIUAin3vmMaLJSN5IADG76zb82LC34Q= X-Received: by 2002:a05:600c:1c87:b0:3f4:2594:118a with SMTP id k7-20020a05600c1c8700b003f42594118amr64682wms.2.1684879530132; Tue, 23 May 2023 15:05:30 -0700 (PDT) MIME-Version: 1.0 References: <20230523205922.3852731-1-kaleshsingh@google.com> In-Reply-To: <20230523205922.3852731-1-kaleshsingh@google.com> From: Yu Zhao Date: Tue, 23 May 2023 16:04:51 -0600 Message-ID: Subject: Re: [PATCH] mm-unstable: Multi-gen LRU: Fix workingset accounting To: Kalesh Singh , akpm@linux-foundation.org Cc: surenb@google.com, android-mm@google.com, kernel-team@android.com, Charan Teja Kalla , Oleksandr Natalenko , "Jan Alexander Steffens (heftig)" , Brian Geffon , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ADBAA40017 X-Stat-Signature: zacu1z4tpmjczjet4gd57ie39j3q73xt X-HE-Tag: 1684879531-321900 X-HE-Meta: U2FsdGVkX197mDHpxrN5NT2FCM2OEylBB01PsOfFrTBWsWuTuvo8gYfvIjkyUUgVagcG/CyEnMdJuQjPrJKMauoiPW88wPVEMudn3YZdSHQsG7rICGePUb7BfSICKyolJo5OTwNQsdFkrEgGo7diN70783BwiddGVV0ii/ERIp4rMpUDbjvHGBIxELaMJ0bTnUcNJ5FxzT7zt/bQymcA3SFHundFV19jZaXLpmOSp/bf0SZmhpilELqwbMdYUL0AO4QCK3+W/vo5CrniclE4dkptCPlDIJN/t6oEQlhB7xGAKmtu5jbJd/WDZnIo5XvFKtK7bf+eaR98yWxjQsUARSeMvY3jRs8P3KSvDjMidjtHyekkzmTGz8rpCdfkW3+ZYFVynFIjFSdp+HV3DJ8bzWHzp9Q+vmNRl0GYZXXtqx2ArVQ9NXLtmIMhviTFrKCnAlutfNMcDRjAqLxkibNkEYCQLcrvVYi5p8A7RzwrkVfg3/HW4+vWdoa2t2U07a/7GzClT46t0+lOpoy3wjgEJemfmg69/2oGuVrZo9rNWAlCBDm78ffOtPWaK0CB2nckoNmQWouZDH80VBakAq514sZAz0BozdYZTEsi4BQSXdROAa3v5GbNi8pc1i+PClgbE5CuWHPxO+2Ynid41HIy50oWiLEIvo93rihAIWOrvkKOTb7Kctm3BVmRyEc68HednSnYdRwxnKcxCrYoLYaG7GguWQWLnCNPGG/vDKxzYif5cnxr33q3eBCIsFXIr4HijtSebpHqFZVw5hYOJZ+W9N3dDj6lW6WheEm4hegQihkdwpRrC1JKqrqNIEupo6md58dMnrPnhLfJjflmP6AtFey7LyITo3nvQrveQ2YdQivZR7YqdHc5jrNNdvMWZxZIZ1AcK36uPUrhtqW3eAHmH3X5UbSFRo1oFG5dOuUiNBUvjCd6S2CZgCM9r4dyfeHJmF4FsTXYTyF/noQRLN1 6mLo5wIB 8TLXgGOWDSd9BX1+xlYrIzjSuKrLuBSnyxo+tZyOf/XDT8A4RBtf9rbhwzUwEH7wE3UUokW8d+V7jCDnxVKmHN7lKJsim+N6I1tvd9bhBR070jJDvGKjxLrAhnZZwv/BdbbWQlYuwEcTCTRZxrZl83ij3zp0ToOLpJU2Sn/g2xlZNcj/EsD8derMEsJV1TB3xRDtJydeEfjZZdFVWx1a4d0FOcrCjniggBirCskuSzp8GdQX3gRKxw7GGeI0a23muQmPPcPKKSADEkM1VleEN3gJnGNEWkrDflZ33SzUjAKJyBZW9P43dRBkw3mvxeN2zUgXEqlNh8jsXU7k/rGMPnTXTjs4iZ+e5HOeBC0dEyq29Kbc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 23, 2023 at 2:59=E2=80=AFPM Kalesh Singh wrote: > > On Android app cycle workloads, MGLRU showed a significant reduction > in workingset refaults although pgpgin/pswpin remained relatively > unchanged. This indicated MGLRU may be undercounting workingset > refaults. > > This has impact on userspace programs, like Android's LMKD, that > monitor workingset refault statistics to detect thrashing. > > It was found that refaults were only accounted if the MGLRU shadow > entry was for a recently evicted folio. However, recently evicted > folios should be accounted as workingset activation, and refaults > should be accounted regardless of recency. > > Fix MGLRU's workingset refault and activation accounting to more > closely match that of the conventional active/inactive LRU. > > Fixes: ac35a4902374 ("mm: multi-gen LRU: minimal implementation") > Cc: Yu Zhao > Cc: Andrew Morton > Reported-by: Charan Teja Kalla > Signed-off-by: Kalesh Singh Acked-by: Yu Zhao