From: Yu Zhao <yuzhao@google.com>
To: Kalesh Singh <kaleshsingh@google.com>, akpm@linux-foundation.org
Cc: surenb@google.com, android-mm@google.com,
kernel-team@android.com,
Charan Teja Kalla <quic_charante@quicinc.com>,
Oleksandr Natalenko <oleksandr@natalenko.name>,
"Jan Alexander Steffens (heftig)" <heftig@archlinux.org>,
Brian Geffon <bgeffon@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm-unstable: Multi-gen LRU: Fix workingset accounting
Date: Tue, 23 May 2023 16:04:51 -0600 [thread overview]
Message-ID: <CAOUHufb88CBQibAx=jr7xX7y4Witw4HhCSAd-P4q2qoCKBLZSw@mail.gmail.com> (raw)
In-Reply-To: <20230523205922.3852731-1-kaleshsingh@google.com>
On Tue, May 23, 2023 at 2:59 PM Kalesh Singh <kaleshsingh@google.com> wrote:
>
> On Android app cycle workloads, MGLRU showed a significant reduction
> in workingset refaults although pgpgin/pswpin remained relatively
> unchanged. This indicated MGLRU may be undercounting workingset
> refaults.
>
> This has impact on userspace programs, like Android's LMKD, that
> monitor workingset refault statistics to detect thrashing.
>
> It was found that refaults were only accounted if the MGLRU shadow
> entry was for a recently evicted folio. However, recently evicted
> folios should be accounted as workingset activation, and refaults
> should be accounted regardless of recency.
>
> Fix MGLRU's workingset refault and activation accounting to more
> closely match that of the conventional active/inactive LRU.
>
> Fixes: ac35a4902374 ("mm: multi-gen LRU: minimal implementation")
> Cc: Yu Zhao <yuzhao@google.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Reported-by: Charan Teja Kalla <quic_charante@quicinc.com>
> Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
Acked-by: Yu Zhao <yuzhao@google.com>
prev parent reply other threads:[~2023-05-23 22:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 20:59 Kalesh Singh
2023-05-23 22:04 ` Yu Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOUHufb88CBQibAx=jr7xX7y4Witw4HhCSAd-P4q2qoCKBLZSw@mail.gmail.com' \
--to=yuzhao@google.com \
--cc=akpm@linux-foundation.org \
--cc=android-mm@google.com \
--cc=bgeffon@google.com \
--cc=heftig@archlinux.org \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleksandr@natalenko.name \
--cc=quic_charante@quicinc.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox