From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10F17C433EF for ; Wed, 20 Apr 2022 00:51:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 395A56B0071; Tue, 19 Apr 2022 20:51:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31DD16B0072; Tue, 19 Apr 2022 20:51:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 196406B0074; Tue, 19 Apr 2022 20:51:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 071AF6B0071 for ; Tue, 19 Apr 2022 20:51:06 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BCFE9249F3 for ; Wed, 20 Apr 2022 00:51:05 +0000 (UTC) X-FDA: 79375428090.08.B91E067 Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by imf12.hostedemail.com (Postfix) with ESMTP id 7B22740012 for ; Wed, 20 Apr 2022 00:51:03 +0000 (UTC) Received: by mail-vs1-f43.google.com with SMTP id d9so146172vsh.10 for ; Tue, 19 Apr 2022 17:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h7H+ruNwzO0FOIHU2htbNl3Kgc9iK+Bls9V1N1i8rMc=; b=OnOMTCYq6051btEbQdA/SW6lBMQiN41PdkjZlZG9x+F5Z2Fp5ZPf9z3O5FGQD5I3Bt Aqu7Ir9V4PuJOLUX9+z0nt4ZBEu7ggItdDaVZUwN89XoqjYFb6VBywYIUchsvFvvv1rI bzHI8BCjqL8SdtnES04F7vRBggnpY9MAgIO8xVKkizf12bGKssGMk4bSgP8B4IH1yS/E zfYNJ3dwvbrKbqzRglxjYZA35Q1DlfsX8LSRzy0XMy7bChgH6VA+85s9R9/TGye6bm4a jnN+Ldnj+yMwk7NhkcyubqFwa4NQNmZS+LtzcgI5ImpG+dVAsJIIVacqu1rkoYOv3lfv mT6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h7H+ruNwzO0FOIHU2htbNl3Kgc9iK+Bls9V1N1i8rMc=; b=n8mUMeVg+LQhbU42DRmzgoYLDXXszdKu3d2tq0Kc1kVL+gx2rDczrGs8jVH5OEtHNi 14ejGcAxvv4RbjZ8d97BEFAhg0z6R7uaTNoMGQTq5nhdRUwHZvrqT9dzQJX3g4wmoFE5 aPOYYjC4GPP1ukZMsr8ov0JJ9n8jfSGGkWoHV7UCN30lfEpLDk6tU711zApoq+qj3frI 1cXPGGLZyi+2rRO05gzQU0KCVgW3irOnQ5hq2pahlBcjP84zaKy8n9MwNjd6K6QjmbbD 1ducXXRXUlujbJm3Na2wlm2y5Pkuyk6J5ngoqbQZ8no8SOCZuKex2JfNYhuxqA5oOsV3 wmoA== X-Gm-Message-State: AOAM5333EmloZM3p49fGwtMZ7cs17mRYalT5muukroo9D9Xshw/v8hv8 abF2rvL53c8eLzRfVpL/4sMPGAmzVRA16kRBQIGtQVnc7fyl7DqF X-Google-Smtp-Source: ABdhPJwuEo0eOW39/zOg7eYcPPJSP/xsmVyuFfGg9nS0PhO8HBJcxJV/zMegVDXjYoxfbeDFOkSb45wsppx48DRHipM= X-Received: by 2002:a05:6102:5cc:b0:320:9bd2:3823 with SMTP id v12-20020a05610205cc00b003209bd23823mr5664333vsf.81.1650415864537; Tue, 19 Apr 2022 17:51:04 -0700 (PDT) MIME-Version: 1.0 References: <20220407031525.2368067-1-yuzhao@google.com> <20220413220636.dd33898d36156bc7339f04e9@linux-foundation.org> In-Reply-To: <20220413220636.dd33898d36156bc7339f04e9@linux-foundation.org> From: Yu Zhao Date: Tue, 19 Apr 2022 18:50:28 -0600 Message-ID: Subject: Re: [PATCH v10 00/14] Multi-Gen LRU Framework To: Andrew Morton Cc: Stephen Rothwell , Linux-MM , Andi Kleen , Aneesh Kumar , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , Linux ARM , "open list:DOCUMENTATION" , linux-kernel , Kernel Page Reclaim v2 , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7B22740012 X-Stat-Signature: i3yr8bur4yeqduarbzd1pba5go7r7o4s Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=OnOMTCYq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.43 as permitted sender) smtp.mailfrom=yuzhao@google.com X-HE-Tag: 1650415863-367793 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 13, 2022 at 11:06 PM Andrew Morton wrote: > > The code uses > > struct lru_gen_mm_walk *walk > > in some places and > > struct mm_walk *walk > > in others. This is already driving me nuts. Can we please use > different identifiers for different types? Sorry. Going with "struct lru_gen_mm_walk *args", unless there are objections. ("struct mm_walk *walk" is an existing convention so I don't think I should change that.)