From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F91E7717D for ; Fri, 13 Dec 2024 09:37:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54AA56B007B; Fri, 13 Dec 2024 04:37:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FB496B0082; Fri, 13 Dec 2024 04:37:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C3DE6B0083; Fri, 13 Dec 2024 04:37:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1FF696B007B for ; Fri, 13 Dec 2024 04:37:00 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C366FC0ADB for ; Fri, 13 Dec 2024 09:36:59 +0000 (UTC) X-FDA: 82889431464.02.4AAE782 Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) by imf19.hostedemail.com (Postfix) with ESMTP id 0A2331A0015 for ; Fri, 13 Dec 2024 09:36:30 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LWlxKAFs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.44 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734082594; a=rsa-sha256; cv=none; b=YyUVnT56+/4n7Wu0VVm0FEIFam93ryhGUJ8WY6DPFFY7beCUmOrwOVwHf4R8fPlawErAzj sVaAeAAKatzXaC1LUqlCYL44AYeUGNVqMPHvVi+kLX7KGPdfyX/6yTBFrSLelDJZxi9rV2 6K+38+6EpI6uZs3pe7pkSm35frqrnPU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LWlxKAFs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.44 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734082594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i3XXJHW5LnEyEta6X/firnxrZkn91cljZSj6HOtEdXU=; b=R+UxxIlOQ6YZhfo5H44iyNNJhOwT1g4a3cS+DFHTqraYJUpPCA6IvGpkMF/x9CirpU/j3M ojvOI3a/Z+HZVP3i7rb6hp+qtMHznxnB5G+svxApvrseK+Bx4xBVcgmYL7kmPeSzVkx0BF HcvbZRSvKXIzGHLRa7pV0gUHYlsFY0A= Received: by mail-ua1-f44.google.com with SMTP id a1e0cc1a2514c-85c4b4cf73aso292379241.2 for ; Fri, 13 Dec 2024 01:36:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734082617; x=1734687417; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i3XXJHW5LnEyEta6X/firnxrZkn91cljZSj6HOtEdXU=; b=LWlxKAFsKr4/ggd8HCqxxYWhCPiVqEVR5AXpHETSdtKlTjrcKcsgDqgHepbzn6+8WI Vq8PYz6DjkZV++rkUnhP6FbOOWcv0hqbwtPh4GH4ca/kyPIive2yra7ScvRkV/mO7QMW qdgQPEWqJF2K+44LIGd/p3E7MW63p4ciSAQd2F/81F84NcXeUvP05zb+Bm1uBCzmRZgm bGHFjN4ZZJ1pFPHrbBLPLdlYJu4mMtFBtBiUd6KGgmh+nce2Y5AtLYQMAspUxUbNlRKR x+va6eXoJ/M7wuSDqLQjOh7+hJSKOnKy8MRcVeIRG137+Ay8mqUrEAs1LXMxjye6J/Cw 3LRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734082617; x=1734687417; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i3XXJHW5LnEyEta6X/firnxrZkn91cljZSj6HOtEdXU=; b=fA7NNQYwSaA2ueqAf7JYPsFiTBvnxmDC9ZZZXJAE18cjbroVEy/9eAi3h//gBt74Bn gg1hza6lUGzQpoaIZieNIMs2tXLtKABLCVvAlYtIcDghEJl0SkYFUe4M9+uFlT2S2eZF lDDOFC2Q65cyAXuw9WZvBiPHpncYfZvMoe5KJuJq+x/6uHERDz5wBYlFIyuxitKtTVZo +wNpIj3dS3dMtU2L61CrDUPXMMKwJxUsERrxwcXR2w4ppsUfOawWZwri+5p2QfJYabwv GFcYngSIl6lvz+dNzlGnFKUJNiFwjESEBkTUFX8ZEy3nyQbPCVjbc4JGhnKVRXZ7ugJn ppSA== X-Forwarded-Encrypted: i=1; AJvYcCVVOfIT0UxZ2+l+3oy3PTrA3TPA2nfUnxLTuHwBWEYdjjQtHYjmJhXdkZj13CRGwOLqbAE659jTmQ==@kvack.org X-Gm-Message-State: AOJu0Yzj/VKGsSBuYiv2rw4FZH582HKipU81cgSjmsDv9NSpor3HD04H KeF4niVKNJouZThnHVa7VnuA+Vqf4nv20IHoVKhiUIjiq32nqA0BQ919UAm8Qrc6P1q7FnBFcg2 N3JoJQcrvkC0QHtT6c3TJd+f0FimIifBjl1ad X-Gm-Gg: ASbGncsDs1yISX1CcnIA3Emx4kh2OCOHj0ph+vtGbz42ycRS7Xw7JTP7A9Bzwp5r/0i C4vFegg6ZyWch/HE8mBUyhAZHbJqT+5JjdQNv9hU5FzVmHEkSxj4v/HTMjW47zcJ9nfZ3Hhw= X-Google-Smtp-Source: AGHT+IE3r8tCj94yDViV8T0hug96B5mFZ4NL+7fdwhKNHFFk8OfSbcKbHILSNoIgVb2TRCHYLfw95G8EYPD4MIShBHU= X-Received: by 2002:a05:6102:1044:b0:4b2:5ecf:d128 with SMTP id ada2fe7eead31-4b25ecff079mr1116441137.23.1734082616712; Fri, 13 Dec 2024 01:36:56 -0800 (PST) MIME-Version: 1.0 References: <20241211105315.21756-1-lorenzo.stoakes@oracle.com> In-Reply-To: From: Yu Zhao Date: Fri, 13 Dec 2024 02:36:19 -0700 Message-ID: Subject: Re: [PATCH] MAINTAINERS: update MEMORY MAPPING section To: Lorenzo Stoakes Cc: Andrew Morton , Jeff Xu , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0A2331A0015 X-Stat-Signature: ke7curg4czdjkjytde3ce57kqacmrju3 X-Rspam-User: X-HE-Tag: 1734082590-988645 X-HE-Meta: U2FsdGVkX18ATencn9zHL1jUF6Esq5wTnkwwQxIqFBd6YnHs4lthjQ2sZZXEm2R2AUlvlAS2quov0PFQh3LV+wiIvhno95D0Rrlr30sH1/Ho7RPVRtfqiGvKwrrql1w8oX8EV3V4hwjwt66zOf9Anx4Pg49a6734HpKmlBvfgp4FSz9ie5hCTG+gQKUrGqR+PBY/0yg0oBLt8arihY3gRgeQzOk95aJ/0G8CNcqj+kxdXZ/dBjiOUuKA8TklFyQfsogDk/C5N9eKOV9EEBdBnHV4gx9UpaxEO870eys817ISil81PdgqRnWCXSB0qUUx3c35xAF9/KYUCsfGzjX4Q7+2DeydBXlO+clu8nAVE0aS0hFb5t+iUzJPHUSE7f2Ycy9srmWryJJYaqNYSasPxaVyZ3/lB5FjQUHJcJ5WPru+ag0KPb46cwmTmK74zbydm8m/Se3wcnt96bgHFYKglgynbYbW48tonVBcAdRUsuisS0TF5AxfDoRWitprP4MvplqtE4iRYpJA4K2x24iesIRcYY+t7+zGU+0p9qDwgtBCU7RGH1BbUgkPIJeMI3PNUF0Td9pbx7S42dPywIEbYUNmoKXrTAOkfVHnzNejy/vaHJFfguMNX2Q8Dq67nMG71TXeJKjiwJBeijDAdQkGl8R87IV5EGKXWjQ0G/MFDFlqTSXPmMmZE5wFerVzi1xXhcqGe3G//eRumJynEg9wQZ8eXMAnqhirvoeMbbFLAeXo8LUyx+bSoxArrT8vBKKdTdaYH1TIi/hCrXQWJhYebmFAmgA3xWQFC+hfcYT1g9WhwX49Wgj0YwjXy1D87nybC4kCJTmXWt86fKxF753mwgdkCXJOpHW7+CWCojx01wg3IyUpmorhCqKvQcisqvS2UofX9Vd7nHi0nJMTUDAcQbmDF7ET8qwYpHCUYqbhiVpcQisomyQoHdvU400bJAeCLARekgjPGPjnpwo9TA/ xo6VL2BY DqodOBUmX37GatLnscCyk08OEqSBv7QX3HTBSiBXCsunxiVWLOP4cypAApkWokg0wEyR8R2T7QojW+MzPVOT3baYnioYePwWvjGSEQnHX3aZnEBunyJpTeZjKnwk6f3iACnef07+3WXSWAWDXQi4ATVrrPuG0mPp3YDxeHzeht6FMyb5j1iLvxTvtYoc9HTo24XhGwtv3+VHua9XwtiOnLRbfCRp7oUeyLNLTQnxqyRWw3kHwdzBe9XT+lRAHRU9twehdRjtKSajnDEtQ9GDmCZy6vjLD3Unw2ywQk3BNpUxPKZI+l8YD5AW2yQmGs0C0dfdbKjkJiviWgul+CgBxqBZre9aYBFPPGM7i/LDxUO944xQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.048140, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 13, 2024 at 2:18=E2=80=AFAM Lorenzo Stoakes wrote: > > On Thu, Dec 12, 2024 at 10:50:19PM -0700, Yu Zhao wrote: > > On Wed, Dec 11, 2024 at 11:57=E2=80=AFAM Lorenzo Stoakes > > wrote: > > > > > > On Wed, Dec 11, 2024 at 10:36:42AM -0800, Jeff Xu wrote: > > > > On Wed, Dec 11, 2024 at 2:53=E2=80=AFAM Lorenzo Stoakes > > > > wrote: > > > > > > > > > > Update the MEMORY MAPPING section to contain VMA logic as it make= s no > > > > > sense to have these two sections separate. > > > > > > > > > > Additionally, add files which permit changes to the attributes an= d/or > > > > > ranges spanned by memory mappings, in essence anything which migh= t alter > > > > > the output of /proc/$pid/[s]maps. > > > > > > > > > > This is necessarily fuzzy, as there is not quite as good separati= on of > > > > > concerns as we would ideally like in the kernel. However each of = these > > > > > files interacts with the VMA and memory mapping logic in such a w= ay as to > > > > > be inseparatable from it, and it is important that they are maint= ained in > > > > > conjunction with it. > > > > > > > > > > Signed-off-by: Lorenzo Stoakes > > > > > --- > > > > > MAINTAINERS | 23 ++++++++--------------- > > > > > 1 file changed, 8 insertions(+), 15 deletions(-) > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > index 68d825a4c69c..fb91389addd7 100644 > > > > > --- a/MAINTAINERS > > > > > +++ b/MAINTAINERS > > > > > @@ -15071,7 +15071,15 @@ L: linux-mm@kvack.org > > > > > S: Maintained > > > > > W: http://www.linux-mm.org > > > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > > > > > +F: mm/mlock.c > > > > > F: mm/mmap.c > > > > > +F: mm/mprotect.c > > > > > +F: mm/mremap.c > > > > > +F: mm/mseal.c > > > > > +F: mm/vma.c > > > > > +F: mm/vma.h > > > > > +F: mm/vma_internal.h > > > > > +F: tools/testing/vma/ > > > > > > > > > Will madvise be here too ? > > > > > > No. We had a long discussion about this on another version of this pa= tch :) > > > it's blurry lines but it, in the end, is too much related to things o= ther > > > than VMA logic. > > > > > > We probably need better separation of stuff, but that's another thing= ... > > > > > > > I'd like to be added as a reviewer on mm/mseal.c. Is there any way= to > > > > indicate this from this file ? > > > > > > This is something we can consider in the future, sure. > > > > What'd be the downsides of having an additional reviewer? Especially > > the one who wrote the code... > > > > > However at this time you have had really significant issues in engagi= ng > > > with the community on a regular basis > > > > I'm not aware that this can disqualify anyone from being a reviewer of > > a specific file. > > > > > so I think the community is unlikely > > > to be open to this until you have improved in this area. > > > > I do not know Jeff personally, but I think the community should make > > anyone who wants to contribute feel welcome. > > This is very unfair. > > I have personally spent several hours doing my best to try to provide > advice and review strictly to help Jeff get series into the kernel, perha= ps > more than anybody else. > > My intent throughout has strictly been to HELP Jeff, to both ensure that > mseal is as good as it can be, and that he can be a productive and > successful member of the community. > > This is, and has always been, my only intent and desire here - so things > are actually quite entirely the opposite of what you seem to think they > are. > > My point here is solely that this is just an area that he needs to work o= n > and I'm not enitrely sure it'd be helpful until he has done so, this is > all. Thanks for clarifying. It was just miscommunication.