From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F6C0C43334 for ; Thu, 16 Jun 2022 03:03:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 145176B0072; Wed, 15 Jun 2022 23:03:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F4B26B0073; Wed, 15 Jun 2022 23:03:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED6EA6B0074; Wed, 15 Jun 2022 23:03:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DE26D6B0072 for ; Wed, 15 Jun 2022 23:03:33 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id B790180FFA for ; Thu, 16 Jun 2022 03:03:33 +0000 (UTC) X-FDA: 79582603506.28.F0EAC3C Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by imf29.hostedemail.com (Postfix) with ESMTP id 3AEB712008D for ; Thu, 16 Jun 2022 03:03:33 +0000 (UTC) Received: by mail-vs1-f44.google.com with SMTP id x9so37023vsg.13 for ; Wed, 15 Jun 2022 20:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eK4aJf4dNKPPG+yrUWwtkRmADyYs8/1P16jxzY6zkAo=; b=hJOf7+nGrqydnUcuaV8uAn8kgR5hGvqhYHn2L2vBeA+YlPLCGHdHmqHfMv2uc4MobD xMgdlBHLPI8q58KyiRhiuYprVFQAx/DZ4/r4OUbwP8T39aqJLVz74ZUhUA3T4fZao2rz kQZfrx1WYOtj7+vqPerH1bPla7mnuFs2VnIlFXG1WRkwryNOsLfmKYFrhBk/FRa3a793 cfIkV6fFzV9+UWXiFE3g8JZR4x4eQHgJOL0dzl3yWON0B8muxtauDfOh7dMJtLSZYPlU E4fLmPrtbDDSeNwmn2tP3ZyYBTAEfgsjnDN5+SiC4+RHrSPzzXSBCgc+0JuOsGUJQIX8 RLUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eK4aJf4dNKPPG+yrUWwtkRmADyYs8/1P16jxzY6zkAo=; b=d/+hvLkhhawEQTeXeBirUWITcboMq7qVtjpUFjq7G6oBtnFSA1elfEr2XwrJrE0wpJ io9tYk5gUVolFdvqWeP0+IY/VJAIyfqHyGOjS76pm5QVFS7XrzNDYhpH0EYljV8SWkTm JDDEQ7pHYjjGlE0GhZ6kNbDeWkf1UYcgZ6PVlm4XgpKFsqh2QKVIBGWg3vj35gIzPrgd d4vBmklscpPB25K00wvE2io3qOVjgeds/b1b7h7CVdX3m77ybiDocZ0Ah6AHFhqhsICH kzlPckfjMkOQ9XTZbg7pmXVmgIF8NCgMljMAlmbRLrqN0HZ3XdBW6+kL7hxBUyhuo+ea NSDw== X-Gm-Message-State: AJIora9ZWg32IoUgh/Z398FM8axZfUlwmBI3DxTMCBrOYVzVdB9KedhJ gxC7oGgH0/+zfk/uhb6wTtWiLW8g0apC0GL3jSgrOg== X-Google-Smtp-Source: AGRyM1v1X3hcxC/hdemLGne774q7m11lOSax/ov6+bStIC/IJdsxP1W987QqVdf/p2/NMGVsGMmOhJWqr1J+zO6Urk0= X-Received: by 2002:a05:6102:214c:b0:34b:b31d:1a50 with SMTP id h12-20020a056102214c00b0034bb31d1a50mr1268700vsg.41.1655348612359; Wed, 15 Jun 2022 20:03:32 -0700 (PDT) MIME-Version: 1.0 References: <20220615142508.mtp65w6tdiurtvcn@revolver> <20220615185500.i5bzt7srzm6q72na@revolver> <20220616014956.6jgxvbzh4ld3c32q@revolver> <20220616025557.euz6z5rlh7fqewy2@revolver> In-Reply-To: <20220616025557.euz6z5rlh7fqewy2@revolver> From: Yu Zhao Date: Wed, 15 Jun 2022 21:02:56 -0600 Message-ID: Subject: Re: [PATCH v9 28/69] mm/mmap: reorganize munmap to use maple states To: Liam Howlett Cc: Qian Cai , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655348613; a=rsa-sha256; cv=none; b=VyyH8cfenbJEM9M828bqjWsK4t12xqpoCZ1RY/JjkmaSjJfo9H6gwyNNtlT/SkM+hZVnOy jUkcgJANNmu9TMhW9vNObJFEEqw8L1lGSs2trX3DDvkG4ckEuw4gtLsCPDrcUqScdGgpI/ M/TWnGJOTeokP2f5ErDyuG9Hcieajfs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hJOf7+nG; spf=pass (imf29.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655348613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eK4aJf4dNKPPG+yrUWwtkRmADyYs8/1P16jxzY6zkAo=; b=D0Psp6AUFc8XfQOaLoaiRjAfNv3UAP/DvHBJtY818371I8C9Ewa/Yxi/tYneYzInKBlwB+ Wl8ZewdyjXZ5gmZVO9wsX/Th6bpbQZPwX+rkRfPUq3sSj674V5+pAFuTbSigl2GSKRzxp/ 8ADMnKVQXkYWniqdDoVckkv5ZPFIFIY= X-Stat-Signature: cw31zdfpgio81xrm488yxe7e99yka9f3 X-Rspamd-Queue-Id: 3AEB712008D Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hJOf7+nG; spf=pass (imf29.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1655348613-93235 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 15, 2022 at 8:56 PM Liam Howlett wrote: > > * Yu Zhao [220615 21:59]: > > On Wed, Jun 15, 2022 at 7:50 PM Liam Howlett wrote: > > > > > > * Yu Zhao [220615 17:17]: > > > > > > ... > > > > > > > > Yes, I used the same parameters with 512GB of RAM, and the kernel with > > > > > KASAN and other debug options. > > > > > > > > Sorry, Liam. I got the same crash :( > > > > > > Thanks for running this promptly. I am trying to get my own server > > > setup now. > > > > > > > > > > > 9d27f2f1487a (tag: mm-everything-2022-06-14-19-05, akpm/mm-everything) > > > > 00d4d7b519d6 fs/userfaultfd: Fix vma iteration in mas_for_each() loop > > > > 55140693394d maple_tree: Make mas_prealloc() error checking more generic > > > > 2d7e7c2fcf16 maple_tree: Fix mt_destroy_walk() on full non-leaf non-alloc nodes > > > > 4d4472148ccd maple_tree: Change spanning store to work on larger trees > > > > ea36bcc14c00 test_maple_tree: Add tests for preallocations and large > > > > spanning writes > > > > 0d2aa86ead4f mm/mlock: Drop dead code in count_mm_mlocked_page_nr() > > > > > > > > ================================================================== > > > > BUG: KASAN: slab-out-of-bounds in mab_mas_cp+0x2d9/0x6c0 > > > > Write of size 136 at addr ffff88c35a3b9e80 by task stress-ng/19303 > > > > > > > > CPU: 66 PID: 19303 Comm: stress-ng Tainted: G S I 5.19.0-smp-DEV #1 > > > > Call Trace: > > > > > > > > dump_stack_lvl+0xc5/0xf4 > > > > print_address_description+0x7f/0x460 > > > > print_report+0x10b/0x240 > > > > ? mab_mas_cp+0x2d9/0x6c0 > > > > kasan_report+0xe6/0x110 > > > > ? mast_spanning_rebalance+0x2634/0x29b0 > > > > ? mab_mas_cp+0x2d9/0x6c0 > > > > kasan_check_range+0x2ef/0x310 > > > > ? mab_mas_cp+0x2d9/0x6c0 > > > > ? mab_mas_cp+0x2d9/0x6c0 > > > > memcpy+0x44/0x70 > > > > mab_mas_cp+0x2d9/0x6c0 > > > > mas_spanning_rebalance+0x1a3e/0x4f90 > > > > > > Does this translate to an inline around line 2997? > > > And then probably around 2808? > > > > $ ./scripts/faddr2line vmlinux mab_mas_cp+0x2d9 > > mab_mas_cp+0x2d9/0x6c0: > > mab_mas_cp at lib/maple_tree.c:1988 > > $ ./scripts/faddr2line vmlinux mas_spanning_rebalance+0x1a3e > > mas_spanning_rebalance+0x1a3e/0x4f90: > > mast_cp_to_nodes at lib/maple_tree.c:? > > (inlined by) mas_spanning_rebalance at lib/maple_tree.c:2997 > > $ ./scripts/faddr2line vmlinux mas_wr_spanning_store+0x16c5 > > mas_wr_spanning_store+0x16c5/0x1b80: > > mas_wr_spanning_store at lib/maple_tree.c:? > > > > No idea why faddr2line didn't work for the last two addresses. GDB > > seems more reliable. > > > > (gdb) li *(mab_mas_cp+0x2d9) > > 0xffffffff8226b049 is in mab_mas_cp (lib/maple_tree.c:1988). > > (gdb) li *(mas_spanning_rebalance+0x1a3e) > > 0xffffffff822633ce is in mas_spanning_rebalance (lib/maple_tree.c:2801). > > quit) > > (gdb) li *(mas_wr_spanning_store+0x16c5) > > 0xffffffff8225cfb5 is in mas_wr_spanning_store (lib/maple_tree.c:4030). > > > Thanks. I am not having luck recreating it. I am hitting what looks > like an unrelated issue in the unstable mm, "scheduling while atomic". > I will try the git commit you indicate above. Fix here: https://lore.kernel.org/linux-mm/20220615160446.be1f75fd256d67e57b27a9fc@linux-foundation.org/