From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2BC2C001E0 for ; Wed, 9 Aug 2023 17:09:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 392FD6B0071; Wed, 9 Aug 2023 13:09:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 343078E0001; Wed, 9 Aug 2023 13:09:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 231DF6B0075; Wed, 9 Aug 2023 13:09:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 14EED6B0071 for ; Wed, 9 Aug 2023 13:09:55 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CA6AE120F8A for ; Wed, 9 Aug 2023 17:09:54 +0000 (UTC) X-FDA: 81105203508.29.86B5C19 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf10.hostedemail.com (Postfix) with ESMTP id 10E51C0005 for ; Wed, 9 Aug 2023 17:09:52 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=aNJkmQnJ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691600993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jtpCk/kHhj2S6pipOJUYP67g+bYAwvz2JrywuvS8YOQ=; b=eXp/fkZRBuBWZBPibOulBKAPgBz7b6uqva3UxhjjfrICZM9XW9ft3/aqE7nE2+Tr0KERM1 DR/U7gu0ITksFHazgDKixwKEVkUU48c+UwVY3V4ssVCa/6YJRJGOFwZ39GUfqFagZyE8ob 1+NYtUxRLYbvyYJafLX3IguTp3D1hRo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=aNJkmQnJ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691600993; a=rsa-sha256; cv=none; b=ggMIq5NIiURnQdBs8WVvjlWQW06WZ3IMf2uQswsXlipV4MwZ3HlvLSOCUKUoz21r7A/Qfp 8wC1uVdZrY0dHCtc7tRiLqik9S1zNqwYxXWWsN5yfvqNh9hBwITBnAN2pCMwCnl1mWnHD8 qe52JsgblrEwoDTVZvi/UYva9dITxjI= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-407db3e9669so10401cf.1 for ; Wed, 09 Aug 2023 10:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691600992; x=1692205792; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jtpCk/kHhj2S6pipOJUYP67g+bYAwvz2JrywuvS8YOQ=; b=aNJkmQnJc9BMhQElymADNWR0bea0CfKbnPyRAbMOIsyX1O5SvhbT5XEBcr59UUQSY2 rtJQgNlr+3XX2e4IBleDAAsMgPaIXQLK9gJ5mrqP++BsLxTne0JBtTrM377YGNJHVtw7 7qwCfGdC3VxbMvpXVqINkG344YjRDZFrs/KJ/YqBVX4HgG5XxwGaOoUhY6XDYwyGObiw F/lUkD3HnAfwPC57vNU1aLBeQrXBUjcbkMutG0I4FqWkHe3AqSnQ8c0gI5hInh5HFupd QQyrDkRKWUZ4m30p/E+rbmWW+IkR6TI4unkqu41EeO3D9auij5NTGZXbtQuDdlLO5pLo nc5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691600992; x=1692205792; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jtpCk/kHhj2S6pipOJUYP67g+bYAwvz2JrywuvS8YOQ=; b=RJXlZo46tRHpTcNry/I2enhDViJirdYnywj8nY+IMVhqa8EoeRwzImMItM28uXULq9 FSu7TlydnNQ0PSXpf4tw99sO0ILI0Ezz2vNxinEyz1OHZlCkX61wkcUcpYpzHthXDPnG F8mwWj0c4hRy9bZjgy2t7VVaofuQ2YQsaYYKP2m/lBNEeF6e8o16jpLkH2k3mTAkEDRq IeziF04KMpGdTCcaD78F9qeNRmpzA8qSbqILfL5orU/7avJHkmoyVZ9HgmSD0vIs8FDy K6dSp8hcDO50Cjm+MrNEnWDM0yYRb1uNNnw91NiR/dqD+mSjFsi9ZJB0KyD8hSJ/3Fqe EP/Q== X-Gm-Message-State: AOJu0Yzc+/o13IIYqOJgt4rew/olcn7JcrCXEWFCUp3xb/fuEdxjcVmF rvtRYgpBvv06JFhzgoTr2vqSNYcf2vNg4/0VOYcUbw== X-Google-Smtp-Source: AGHT+IG3KpWlEgRZKeJSH8IgCAin4Njba7/XEsLpalnm0FAG6d4NjQB5bA/B5TubP0zyNjJ1pjjco2FQoZ4A8eX95sk= X-Received: by 2002:ac8:5790:0:b0:3f2:1441:3c11 with SMTP id v16-20020ac85790000000b003f214413c11mr201381qta.2.1691600992091; Wed, 09 Aug 2023 10:09:52 -0700 (PDT) MIME-Version: 1.0 References: <1691568344-13475-1-git-send-email-quic_charante@quicinc.com> <9d109a43-78a3-dee4-5aaa-385bdfe4bcb3@redhat.com> In-Reply-To: From: Yu Zhao Date: Wed, 9 Aug 2023 11:09:16 -0600 Message-ID: Subject: Re: [PATCH] Multi-gen LRU: skip CMA pages when they are not eligible To: Charan Teja Kalla Cc: David Hildenbrand , akpm@linux-foundation.org, zhaoyang.huang@unisoc.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kalesh Singh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 10E51C0005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: bouwokigun3sagwkboaz6rjhi4m4w7sk X-HE-Tag: 1691600992-140359 X-HE-Meta: U2FsdGVkX1+aF0aEBmAsNnrzTE/maWr2Q16bP5fmpu0OP4ct9blJ1evmC2UqGTd8Jx/jBTWRUXbwIv3lwq+uSfhc/Kuag/YrTJTZkK9vGttjVC/VGQScHEOBgnJfLvlX/K0nQaNkLlAacRwg7ea++ZWVtWHEToF7Wjy6QCzZrkYnT3DyiYpVi8jI6DTvSNraU9kI5uYMPAyPun1Vqva5DaxNvCfi+t1i7ECjSlshIsO2SZJ4CjiFwrBdFJM7CmlubScsiQgh86aMmY7wuIPZDpRfV/lnJQhq9WT/92CGAAp2nIRzT4Ofg/tcIQE7QBrmt5frAFxMSBvVCFPuiXL+URRfcjigkPIJHCIotuMBJ9CjwcRozGpHCTHRsydZTmvL259ZmG+uLyWns7+VxlKViDE5npjw6846ipnecXDf9wcOOKtbHZKYp062TqA0N5b9YwAI6FFCPW7qo1cZepYSD1G8qCD70ndqH6KKhMv5wJJxKxxq771vIq5sQ4Gg7l4nXlGCFkNyHRnnKafHO5OaStai/cj0LTilnoP/ecCmRo8sEwm8HWQHExrqQ8H3WqXDzwuc6/OadXOe2IwUFciXrmvnYBwWZ66E4sBnNtOYew214U9W5zoy5SmJJcU9H8UHCdlYfCtFMXvPnFjLM+Nx8N+/2+NQB7zdxcdULdN1DpEstiL0vZeeKgn141s9xcclf8PDlUZ/Fl1F354eTwpo4tYZtETZHqunUb0oLebJZTv2gfsAWbUUVU9byM41D9z4OYNR/CPLXbN12aeAAO5XAnUcdTL+zuMSFx0dtZ6VUDsciPWhk04WEQL1gOSlDKwtvmGCLAe2ztHc3qhb/f9jfoEgRmERIm9wk+GrEieTJbzDja73XKg6ktyG33m4DH8o8YBY+fiIvnrSdSWztnNc9I4/rxTm4/VEBmk9PrkZLC1ZNvs7O/kFO6QqkAsOZJEXcN+ubFDnvMh6L1E/5Mq fVmVFRsg MUXuucSznK7Le8Sda1TepAzlMlIYK3MGgOx/VwBo4CHlyTNSIulJGUXdYGqVumdSQcgSwHzhOMO680HC1lgMd/iKqKkzvLWt0RohTRCSSJhWLqNbPJa+SB0gjEP/0VVXTy/5kECbvBvmsYLYpQ5QyiYNf4+PVb+R+H9jqi2KO2k6RO+4wv2d4nM2eyA1Uu/+2OrZX/7MDNtjUaiFrziw45s6t5HCFyk/g20QjOU4rUaD7rYdqoOQ3KQBMUmIrfPklNwIE7Nt8bulxUA6vjDtD/xbKRAOA74hxea3ssjnzSIs7BdszFM/Pp6WgKutSWkcxJqQYm8hTik5prjo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000053, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 9, 2023 at 9:54=E2=80=AFAM Kalesh Singh wrote: > > On Wed, Aug 9, 2023 at 7:00=E2=80=AFAM David Hildenbrand wrote: > > > > On 09.08.23 10:05, Charan Teja Kalla wrote: > > > This patch is based on the commit 5da226dbfce3("mm: skip CMA pages wh= en > > > they are not available") which skips cma pages reclaim when they are = not > > > eligible for the current allocation context. In mglru, such pages are > > > added to the tail of the immediate generation to maintain better LRU > > > order, which is unlike the case of conventional LRU where such pages = are > > > directly added to the head of the LRU list(akin to adding to head of = the > > > youngest generation in mglru). > > > > > > No observable issue without this patch on MGLRU, but logically it mak= e > > > sense to skip the CMA page reclaim when those pages can't be satisfie= d > > > for the current allocation context. > > > > > > Signed-off-by: Charan Teja Kalla > > Reviewed-by: Kalesh Singh Thanks, Charan! Do we need a "Fixes" tag? > > > --- > > > mm/vmscan.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > > index b4329f9..6cbe921 100644 > > > --- a/mm/vmscan.c > > > +++ b/mm/vmscan.c > > > @@ -4943,7 +4943,7 @@ static bool sort_folio(struct lruvec *lruvec, s= truct folio *folio, struct scan_c > > > } > > > > > > /* ineligible */ > > > - if (zone > sc->reclaim_idx) { > > > + if (zone > sc->reclaim_idx || skip_cma(folio, sc)) { > > > gen =3D folio_inc_gen(lruvec, folio, false); > > > list_move_tail(&folio->lru, &lrugen->folios[gen][type][= zone]); > > > return true; > > > > Makes sense to me.