From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8E4FC43334 for ; Wed, 15 Jun 2022 18:08:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38A7F6B0071; Wed, 15 Jun 2022 14:08:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33AB96B0072; Wed, 15 Jun 2022 14:08:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 202656B0074; Wed, 15 Jun 2022 14:08:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1186D6B0071 for ; Wed, 15 Jun 2022 14:08:31 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E7635351AC for ; Wed, 15 Jun 2022 18:08:30 +0000 (UTC) X-FDA: 79581255180.11.27FC65F Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by imf31.hostedemail.com (Postfix) with ESMTP id 93E1A20014 for ; Wed, 15 Jun 2022 18:08:30 +0000 (UTC) Received: by mail-vs1-f47.google.com with SMTP id r12so12508806vsg.8 for ; Wed, 15 Jun 2022 11:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bifXozJGbo2KT995FRrx29MncDAj30k/nMYRikNI7Us=; b=k67Cqug/KGcfDfJvUGzGpDoRMkM0wQGv3NOMJFcL85FnMSa/n+LmSaJrbs8kgHdf/+ 0AhX+ZANP6ffNUhunuMIwTOc0dHv9naqexOTZFgK7Gmbgjvo1Oe7KoaiPAqPoZdfwAIM SdKZNTFvMfU9hqOlDyKaCAUaawN2yJjBYfQowfwnsZ30l6I6IzRyUB5QJGx1qCb/w7yx kUaSet8RG8bneb51mfOK8eEUq7HDBM5l4TwNBU2IWwkPs80mgMwQZPx26uKoHWQVUfqV ka9aYYCNP5aqGB1zHAdqhuetl5szBdwsuiwefa/98RZ/uoq43Mm1VzzXpfi3zSc4Mut5 /+8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bifXozJGbo2KT995FRrx29MncDAj30k/nMYRikNI7Us=; b=m6v/J/4ZSUfh33SL0cjztkPXwKj2g38fWgQ4TV92lR/otXAI5UBoSjBcU5DqfhLEpp Yj/wW2yttHaCRBN85nywzMOa9IbwYKLmBsaFb0Xgkyu1xFsYwATu9Lu15cY8fpcszgoe 7g2r/BGAFXwfJZc22nihuGtAYLivJK8sc7iXGGioOTSRYuslaVUkLHEiBL7/FaRkPsUp bp2+pvL8Flq2kw8sOCoxUXvgfNAfbrjWvWtaE4YkqqjOzIVcJQRXlJkJSByOX64rGpUS +hbycCaoLBOmngpXCtgSUpHbLhnsHs1oiUhuUGdWi5+aakgVim7CQGLvqPkLr9+4PmIq AVjQ== X-Gm-Message-State: AJIora/h7t2/POcAfxsJsHfDxSyKvkPfaImGvJtjQnFyYJCajVZLOvjH pVLsCVK56NharBJsdUB79RCCGuR2iGa4mvSF6cGKFw== X-Google-Smtp-Source: AGRyM1vm4MUmXMdIsm7m17iINrr4Dp60T17s5/so7x4+sgCh08nPSiYN7VN7nJSpqFOJcZkWGdPRZwQ/W1Hg5KzJEWA= X-Received: by 2002:a67:f3d0:0:b0:34b:b52d:d676 with SMTP id j16-20020a67f3d0000000b0034bb52dd676mr520254vsn.6.1655316509460; Wed, 15 Jun 2022 11:08:29 -0700 (PDT) MIME-Version: 1.0 References: <20220504002554.654642-1-Liam.Howlett@oracle.com> <20220504011345.662299-1-Liam.Howlett@oracle.com> <20220504011345.662299-13-Liam.Howlett@oracle.com> <20220606161940.fh5edq5nyz4jru2u@revolver> <20220615142508.mtp65w6tdiurtvcn@revolver> In-Reply-To: <20220615142508.mtp65w6tdiurtvcn@revolver> From: Yu Zhao Date: Wed, 15 Jun 2022 12:07:53 -0600 Message-ID: Subject: Re: [PATCH v9 28/69] mm/mmap: reorganize munmap to use maple states To: Liam Howlett Cc: Qian Cai , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655316510; a=rsa-sha256; cv=none; b=KV9xAWskhYuIlo/38S6lARO+2Kl1mW0RO4zOGy+h2bQ80Ed0orcSW2Tu+nKgB7nFqgeB3k MIxHWFih8D7xo3t/oM3WtoCWRlTkkDkuBfU9cKILLlGnDazhw56twBCxmMdz6bW+F7lowz dlT3WfW4Vo0nxH/CbC5wdYat2KVk8qo= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="k67Cqug/"; spf=pass (imf31.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.47 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655316510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bifXozJGbo2KT995FRrx29MncDAj30k/nMYRikNI7Us=; b=3aF4ue90kfXqwoUoZ/+YK1qrzG2rxLzx1X2xhThJCk2zri36Kk5HXjXEjJDx4D299egOex bA5HGlEzmvCnHo4iY6oajxiINg/eU6RQdhtSv+6KhHwTzuFqSI2jH9G/RTnX2LBNwqzFk1 VlBxQs3jgbnJu164s+t8Puym79nPRTw= X-Stat-Signature: we1duft8s3esd5rhcsx8ytygnq8p3kzr X-Rspamd-Queue-Id: 93E1A20014 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="k67Cqug/"; spf=pass (imf31.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.47 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1655316510-350116 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 15, 2022 at 8:25 AM Liam Howlett wrote: > > * Yu Zhao [220611 17:50]: > > On Sat, Jun 11, 2022 at 2:11 PM Yu Zhao wrote: > > > > > > On Mon, Jun 6, 2022 at 10:40 AM Qian Cai wrote: > > > > > > > > On Mon, Jun 06, 2022 at 04:19:52PM +0000, Liam Howlett wrote: > > > > > Does your syscall fuzzer create a reproducer? This looks like arm64 > > > > > and says 5.18.0-next-20220603 again. Was this bisected to the patch > > > > > above? > > > > > > > > This was triggered by running the fuzzer over the weekend. > > > > > > > > $ trinity -C 160 > > > > > > > > No bisection was done. It was only brought up here because the trace > > > > pointed to do_mas_munmap() which was introduced here. > > > > > > Liam, > > > > > > I'm getting a similar crash on arm64 -- the allocator is madvise(), > > > not mprotect(). Please take a look. > > > > Another crash on x86_64, which seems different: > > Thanks for this. I was able to reproduce the other crashes that you and > Qian reported. I've sent out a patch set to Andrew to apply to the > branch which includes the fix for them and an unrelated issue discovered > when I wrote the testcases to cover what was going on here. Thanks. I'm restarting the test and will report the results in a few hours. > > BUG: KASAN: slab-out-of-bounds in mab_mas_cp+0x2d9/0x6c0 > > Write of size 136 at addr ffff88c5a2319c80 by task stress-ng/18461 ^^^^^^^^^ > As for this crash, I was unable to reproduce and the code I just sent > out changes this code a lot. Was this running with "trinity -c madvise" > or another use case/fuzzer? This is also stress-ng (same as the one on arm64). The test stopped before it could try syzkaller (fuzzer).