From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4705DC433EF for ; Mon, 18 Oct 2021 22:29:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E0FA1610FB for ; Mon, 18 Oct 2021 22:29:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E0FA1610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7C27B900002; Mon, 18 Oct 2021 18:29:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 770CE6B0071; Mon, 18 Oct 2021 18:29:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 660A8900002; Mon, 18 Oct 2021 18:29:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id 570F26B006C for ; Mon, 18 Oct 2021 18:29:08 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 244E331E67 for ; Mon, 18 Oct 2021 22:29:08 +0000 (UTC) X-FDA: 78710999976.36.FE0FFA0 Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by imf26.hostedemail.com (Postfix) with ESMTP id DB70420019C8 for ; Mon, 18 Oct 2021 22:29:08 +0000 (UTC) Received: by mail-ua1-f54.google.com with SMTP id r17so4394932uaf.8 for ; Mon, 18 Oct 2021 15:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XMD63kGqlNMIm2FKXXcH/6opQFRwCGdWT3zmw0bkJrA=; b=aKYJXtCHjg2UnpSBovbegHvrjQiiX3aR+c/HFkMZBU2WdysI4FgFgIb+VhXYJYJ/Fk iK2oY2LGnIt902esFd+ID+e7zq5LkydVbKsiV4NsYawJaxuGHILadEQxbrVslmZAQjAK E2cMzdN7w4+72V9KvpnzfS4jOQdQZLDL/EtYaMUX94zllgePPaTFyNfUCcbFw82PS8tL OD/1GlZNj69MvquEwQKhJCmDayJDO0iAiNvrTUvFtdIP71EaESI0iqsw2SLpdb2UUqTW oeulcO37ldGjq5//rxfNwSv8k4TZV8QovvZM7JioV9JGWuk9f4unkLNtw/36UY/R3CQQ 5cPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XMD63kGqlNMIm2FKXXcH/6opQFRwCGdWT3zmw0bkJrA=; b=xf0fKPZOudHx0VzoTpBAJ8v7Vwml0LjuSuMHedUlbhocvkv6jph7VVmlUzvwB4RH1z 0p+bZLVuDdX3tvnfG5o5zD4zVkvI7uEZDtwUDRBhSVV1Jv1zO+C0Wm4pk5SJB3kZ3skx qxrJV3SoIkvJV/io+XBkNGDo/87hJtY+4N+dve0TRrysHhwwfLUsmuP1wWaIa9JdI/nG Y7qqiJk9EIHpChSw6+zrKG/xO0w2iyJb/K+LfgDVPGJ7jltdmImZ+w27vV+JFwss7FRU Qj+rGrALx/UAG47VmlPEPnQQv5oN1PKuarHRAMA0OcxRfUf4LzZGWvhQc1OVPEk5zERY oYKw== X-Gm-Message-State: AOAM532D70gmH2z1oxK9WzbEBSKcl5n9WcfFPe32efmtnyCTHhiGBVMn pUWeHQ48yHbdRZYNCvokwzFjeOeHvAQptzIameWozA== X-Google-Smtp-Source: ABdhPJzo0CfetTCPrXkMaZh15zQ32H+Uc/w23A3wWlFLZgyQ214JKsoGDlpvpzAuhdk/f2lsqyFwk935WRE9e4LzKoc= X-Received: by 2002:a9f:23d0:: with SMTP id 74mr28388250uao.131.1634596147043; Mon, 18 Oct 2021 15:29:07 -0700 (PDT) MIME-Version: 1.0 References: <1M9_d6wrcu6rdPe1ON0_k0lOxJMyyot3KAb1gdyuwzDPC777XVUWPHoTCEVmcK3fYfgu7sIo3PSaLe9KulUdm4TWVuqlbKyYGxRAjsf_Cpk=@protonmail.ch> <87ee9pa6xw.fsf@disp2133> <878rzw77i3.fsf@disp2133> <20210929173611.fo5traia77o63gpw@example.org> <20210930130640.wudkpmn3cmah2cjz@example.org> <878rz8wwb6.fsf@disp2133> <87v92cvhbf.fsf@disp2133> <87mtnavszx.fsf_-_@disp2133> <87fssytizw.fsf_-_@disp2133> <871r4itfjw.fsf_-_@disp2133> In-Reply-To: <871r4itfjw.fsf_-_@disp2133> From: Yu Zhao Date: Mon, 18 Oct 2021 16:28:56 -0600 Message-ID: Subject: Re: [PATCH 0/3] ucounts: misc fixes To: "Eric W. Biederman" Cc: Alexey Gladkov , Rune Kleveland , Jordan Glover , LKML , Linux-MM , "containers\\@lists.linux-foundation.org" , Hillf Danton , David Howells , Jarkko Sakkinen Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: DB70420019C8 X-Stat-Signature: 97weyk4un4db1njn8ih95zi614ydgjmr Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=aKYJXtCH; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=yuzhao@google.com X-Rspamd-Server: rspam02 X-HE-Tag: 1634596148-154837 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 18, 2021 at 11:21 AM Eric W. Biederman wrote: > > > While digging into the previous ucount kernel crashes I found some minor > bugs in the ucount code. When hit these bugs all result in a ucount > either being counted in the wrong location or leak of a struct ucounts. > > Nothing particularly serious but certainly things that should be fixed. > > Eric W. Biederman (3): > ucounts: Pair inc_rlimit_ucounts with dec_rlimit_ucoutns in commit_creds > ucounts: Proper error handling in set_cred_ucounts > ucounts: Move get_ucounts from cred_alloc_blank to key_change_session_keyring > > kernel/cred.c | 9 ++++----- > security/keys/process_keys.c | 8 ++++++++ > 2 files changed, 12 insertions(+), 5 deletions(-) Thanks for the fixes. Tested the whole series on the latest 5.15-rc6. Tested-by: Yu Zhao