From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FDF2CD4F59 for ; Thu, 5 Sep 2024 06:42:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F18806B00A3; Thu, 5 Sep 2024 02:42:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC7F96B00A8; Thu, 5 Sep 2024 02:42:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8FCE6B00B2; Thu, 5 Sep 2024 02:42:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B81786B00A3 for ; Thu, 5 Sep 2024 02:42:51 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 56497141A8D for ; Thu, 5 Sep 2024 06:42:51 +0000 (UTC) X-FDA: 82529741742.26.FA3A58C Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by imf22.hostedemail.com (Postfix) with ESMTP id 9486AC0007 for ; Thu, 5 Sep 2024 06:42:48 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Tst3dc54; spf=pass (imf22.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.51 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725518544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9V4VCmPg6eMZasmKiWPriv+IwgAInkpodNw0GExUhCM=; b=1xy1yaqgo7arPUPCLRaaHK/F7YRkwtdQWU2rhgtuBwm3NEq11y+NdRO3Aq4/HSvA3bgBm6 aAxyCCVwcAaECVenpQkTYd4v4C/u5TZdmtJPDgSVWb/TCGqdqd98+bubfOke8LN51zAKRC xH6FvyG1+neUYXmQSCz57mEfc3ub+BQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Tst3dc54; spf=pass (imf22.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.51 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725518544; a=rsa-sha256; cv=none; b=cFKjojK5Jjc/6gSUX3pfQYfFzr7T7UPB78aKpddCe+IEQhNAZQmpZmwtvpEV9zKhA9JaOS V/sNZ+TWklYQWQid/knzqhrUuvUYUdPttAIZollQr0voixTZiGR7Gb6hpwlI5AnihHN38Y rUlATkOZv1b99qGntzVEESFLvNx45fA= Received: by mail-vs1-f51.google.com with SMTP id ada2fe7eead31-49bcbf7bdb9so133297137.2 for ; Wed, 04 Sep 2024 23:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725518567; x=1726123367; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9V4VCmPg6eMZasmKiWPriv+IwgAInkpodNw0GExUhCM=; b=Tst3dc54qhtNnn77Z5YZuCgfO+ABmY2wiz6nBADGF4van9MYCC7geUcexWDdGLldnD 4uqh0Qcpm0vR0k5sYNSvjU7mx2u2SHd4hvgWcUHCc16KZ0GHGOgJC0MDd8D3rDhXRYhT DLQ91/x+Yry7bChBue1vwNzfFN3078b7vglwAyNYhbz/OG9VBtupG1wE8tDwK+eFZSnZ NY1KLlZzT+g1F6afLEYNrqfTF6HvSdl8/iU2suU+7DKWDXwTPkwHhwMfGT03+5N12HYZ 5+eT0BFbkLSlFx2bGpcwWhmj63YSjrge2juM6cW+RyAOvBiRxiRn8wN465xrrgTCX95V ZenA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725518567; x=1726123367; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9V4VCmPg6eMZasmKiWPriv+IwgAInkpodNw0GExUhCM=; b=XaL9Xo6i8gjS8vkqgwxiHRcx+je8xn67M4AI3eui8vXTWZS0+yuc5gFAmXRcymmlRB 87IqUhBQ6tYVg6ULo7sJgpW9GtMSrWT80MLdRNg0lKzaSv8UCZsPWJ4m+C+PVmJd/iZT X6/4QQmdBmMTdHCvqm1uXe3hrG9KDqmR9qXlqvQQqOqkdLupx1BZ1lHD5iCa15LabrkS tiFzqNARN+FPbcuu0X6sjC2KtTzouuG8uy4AkDdfGlXa0H2r5FmuTgeUtMUsMwacrbR7 Q8ACRSvuMSQ2Khhy7XG+9VnFMwVaBY2h7WfyMuyUlZzndamxCipX6BQ6v61BWP58WhnN NarA== X-Forwarded-Encrypted: i=1; AJvYcCXU78NK8QpdfM9jFAGtW4spoMrdGcEagVT4kfFakbKQ2tOpj79TPZTZsp7bcIbL0DIoeGBi0sob3w==@kvack.org X-Gm-Message-State: AOJu0YwRiYOPGFlIUtSia3UTw2ZgKVhINH3oqR0aHeit0BAA7oZF+CDx BrREafcWl+4MSU9qz1He/pYhiC/8lRNi3jtQ7Zs6XkIz5/yIjx6NdefATOS4ThF6AwzAjYT+otX ZcdmATaJI8f4q3moOANKzfuyoiQRHtMnrbJO8 X-Google-Smtp-Source: AGHT+IEh5tjCAD20+/NXlcvkgFmY9ljkBmWFLbXVoYAhxosbLoYnJ60puOzPhErf+40yYr0ygC1DD+2ouGTExQGvGfs= X-Received: by 2002:a05:6102:3706:b0:48f:3f9a:7609 with SMTP id ada2fe7eead31-49ba89b5318mr11158020137.5.1725518567275; Wed, 04 Sep 2024 23:42:47 -0700 (PDT) MIME-Version: 1.0 References: <20240904-lru-flag-v1-1-36638d6a524c@kernel.org> In-Reply-To: <20240904-lru-flag-v1-1-36638d6a524c@kernel.org> From: Yu Zhao Date: Thu, 5 Sep 2024 00:42:08 -0600 Message-ID: Subject: Re: [PATCH] mm: vmscan.c: fix OOM on swap stress test To: Chris Li Cc: Andrew Morton , yangge , David Hildenbrand , Hugh Dickins , baolin.wang@linux.alibaba.com, Kairui Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Linux regression tracking (Thorsten Leemhuis)" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: af3t8caez6fuxruaymb9r9ep1ygz11mb X-Rspamd-Queue-Id: 9486AC0007 X-Rspamd-Server: rspam11 X-HE-Tag: 1725518568-921424 X-HE-Meta: U2FsdGVkX18UwUw2fk8E3I3QVSa8o0HNLNk/FoGLJj0kw7LxWhu3JA4fY5D0vTagXFwEqg+7vL921pr7rhmrDlWcj68wWVpenF4ZbMyKwG00x8cRTE4DIkqllF90zovWj8C/B2j+A3f4Mqj5/oGi3dcr4Q9IHuqxqn2wa3HFdPP9PYgbDSw2f1gM68xO1m3idHlTQ4YnTQUXKf37ovjIaaXSKb6uMCHSP/LgxBIe4rwudSFyHgNAZq7ulh6mUOXM/LkFO99leQTvjGLQ6JSCfN7dHunZx5RcjhDwBB8NZsJ5d+sR4fPq/9dat5T3YaDHcgH85m4WJENNopCqyKPnKBV+Z71BlBDsSST4ezaoWGLuDRENjLR11mD2Dx9s9KDY8ezQ3O+24DD5UYlFewM0xoMH7BGxCqaXjHOCR6m6YvOBLkL0/1C8q8I5t5V8T26RE+gkN//6eyDfHHkB3x2r3DqLUwCQQQSTN5Xb0T8qKVh3pq9XbxrPyGStWQ34bIhZdCWp7VFonkMIiY7UQj7MwePSngmO8UjHTw+OfJHwSOjg1XdCKOzSAgAsjWk7hylQzwACrYB92ufOHp+Kzlsqyvr6cZeQzymjai88KRRrwtZY2zXiE7BvQYeFiZqfV1fZwHB8FFQ8OeYv1k9SuR6jo+N1/jxjfixpE+e0w3AnAWpPoqdVMBxOmxerFSP6gUeAqVtp6XQrfAFHuEe1vLoz+p4/r6zIdkA62hO4yeLZ8v8ph5dtldmzsstGOM9pjWdrzxOOo7srQ3QAhGLyX+v1rCJ5ZBZY6L9jwZKN1TyiYaN08pyHu8G4y5/W6P0GfeiCScBzJXgGpHPVCq+4HJSYNn7NoUFST6dGWgvV036qIXNTEPGJYmSFdNP7qKsgX0zb5j8O82dJZE1l3rT+Y0Wo1ej37TcAxMZCGxwg7nBDQWf3l1sRGPDZtffyZ8vgBT9Ka8N+RsXcSzDpkh1gpAV RGzf8NI8 9tCC//KWs8oAScp6Q0hf94A+fAOLpOFRpPibenWmS5GU4trC2mEGcOdNH1j44ZH2PXE38dsD3q5rD7XUdR1KxmPm7PtCN93aLn4iLs+4yPkJW8hnaFakFdjelFJ1wdBJfUHhwry5GOVcEoNNKxRuDBa33XagMM+Sj0CyWMthzhuNuQF9ZfCuaV+efIU63SdxN7Zv5nsXM4xv4es11MZVnp9WbN9Kv5uV0W1MG/Yl1IswYofXN2fRBYkuD7zKS0BFOfKHj84M/8fKq++s5DCUE26p9ccDwPmE7QQwxcX//3U81TOpCU7n22Urf9W9OjZ9amrLR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 5, 2024 at 12:21=E2=80=AFAM Chris Li wrote: > > I found a regression on mm-unstable during my swap stress test, > using tmpfs to compile linux. The test OOM very soon after > the make spawns many cc processes. > > It bisects down to this change: 33dfe9204f29b415bbc0abb1a50642d1ba94f5e9 > (mm/gup: clear the LRU flag of a page before adding to LRU batch) > > Yu Zhao propose the fix: "I think this is one of the potential side > effects -- Huge mentioned earlier about isolate_lru_folios():" > > I test that with it the swap stress test no longer OOM. > > Link: https://lore.kernel.org/r/CAOUHufYi9h0kz5uW3LHHS3ZrVwEq-kKp8S6N-MZU= mErNAXoXmw@mail.gmail.com/ > Fixes: 33dfe9204f29 ("mm/gup: clear the LRU flag of a page before adding = to LRU batch") > Suggested-by: Yu Zhao > Suggested-by: Hugh Dickins > Tested-by: Chris Li > Signed-off-by: Chris Li Closes: https://lore.kernel.org/56651be8-1466-475f-b1c5-4087995cc5ae@leemhu= is.info/