From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73C20C4167D for ; Mon, 11 Dec 2023 22:01:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F84A6B020F; Mon, 11 Dec 2023 17:01:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A85B6B0213; Mon, 11 Dec 2023 17:01:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86FE36B0246; Mon, 11 Dec 2023 17:01:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7857C6B020F for ; Mon, 11 Dec 2023 17:01:53 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 46EBB16086B for ; Mon, 11 Dec 2023 22:01:53 +0000 (UTC) X-FDA: 81555910506.04.D3F08CC Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf12.hostedemail.com (Postfix) with ESMTP id D0F754001D for ; Mon, 11 Dec 2023 22:01:49 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XnMintgi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702332109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AYuCFWZ1VmS4Lp7mhYmBi3WLT2kfEMP1dhisfQvZFgw=; b=3YwbtVmP5AdS5evkqAFHu0y9ER50a45dMZ8nxJ3Z/l2qsb5YPssjOIBVjt8kKTRDwi/UyO a/1Nux2JIdNjcTIAlk8+l+Td9bhXS4V86ySPN4chmz9fZE5OEVS4UKgyo2b6CYIr+9elUk VY5pOwGnPBKq2omDNqtVjiGA4jtRDAA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XnMintgi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702332109; a=rsa-sha256; cv=none; b=M7xyupQ/BecXgv8WQZYEhOF4mS9/IYFtYccf6P9jIFIRT7mu5dAu6LXZ3GNovAyqWJHntB Zo1dmP4M+YFKGaHiP6JKu6C6vHcBV5gsc5xR575a9/ORgAg4jeNae7/YX/gW/N23zIuQP4 1NnPRUHPxSBAG8q3tOruVLrCLdvWda0= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4258b6df295so124831cf.0 for ; Mon, 11 Dec 2023 14:01:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702332109; x=1702936909; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AYuCFWZ1VmS4Lp7mhYmBi3WLT2kfEMP1dhisfQvZFgw=; b=XnMintgiTNw7R0cS+4o7o4AnLHoQw4ZQLhJkLePlQSK76knj64POoY48dM2KJtNYUy U/RFwSLpgDJambSZ4vm2wu7XqLDAu2xGkoAtI35mbaBBXmutBAMv1+UCNyhZH+I6gVm6 y5snBaBGM6WsHpMVWjGioS2BRyrYNrpg6BEm1atDhPshHiHZd8nphffUAoPPq2we+PwR VK2YGQWPeWi9TNmQqIa2iZrKYPL90AfifL8WVGIud/srFKenrezAHdtKlk9KIW5YCaX2 OAqtRS4mAVwhjmrP1MuIqI8sZlsIRrjkK/t0Bjwxn5Mh1rHexem8gAD039dVZqHDAIYc jnLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702332109; x=1702936909; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AYuCFWZ1VmS4Lp7mhYmBi3WLT2kfEMP1dhisfQvZFgw=; b=aU8/8BTkfKNmti/aaHTQp+5uD0lYLwEvUVmogdtXpT6pX1sm47Wb1cwzKiLT2FuOkS slKO/Da+KNb97Mq9x3sdWR3RVDKBv1XOtEW3RkwZ0iwJAjgm5ua+uJx0GcayA/t5OFe3 hIh0YgkqsPLxdnUwUXyuwYcEWu9IJ1SlgaAW+gNTqynQw05JQ/Wi3O/2WHL7ulk1SWcC 8uBZN4rlib/EV68Dyg9hmdrH6aMnCDBd3MO+T/T0cS7YM1FvqS0WgkOFC+Z/SxetDGZR bMGb/IX+Mj5bVBWlb91Yz5YDUY/QOUUmMOM9FYh8lL1F/DS9cFaz+/P1EjgSghIlVFKy 9Q/g== X-Gm-Message-State: AOJu0Yz5jwvDZb2L/w/Aq4jAHirtXsuBMmhWWs/15pVd1jSMcO6LoQMt YUAtwJxcyULKGI7vckf11P/iTsP/vRqg/EtBRGKGpWiu7YKJ6OBf0TU= X-Google-Smtp-Source: AGHT+IH2IiHUqiS+hDMAihXMhQybFlm8Q+pUYtSDNA+K//Qg9HawPEM7ueM0PxZfERfjiArm+ASOh3BFax4JtNQiks4= X-Received: by 2002:a05:622a:1b91:b0:41e:2bad:f3c5 with SMTP id bp17-20020a05622a1b9100b0041e2badf3c5mr823643qtb.9.1702332108841; Mon, 11 Dec 2023 14:01:48 -0800 (PST) MIME-Version: 1.0 References: <20231208061407.2125867-1-yuzhao@google.com> <20231208061407.2125867-2-yuzhao@google.com> <20231208110011.102-1-hdanton@sina.com> In-Reply-To: <20231208110011.102-1-hdanton@sina.com> From: Yu Zhao Date: Mon, 11 Dec 2023 15:01:11 -0700 Message-ID: Subject: Re: [PATCH mm-unstable v1 2/4] mm/mglru: try to stop at high watermarks To: Hillf Danton Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Charan Teja Kalla , Jaroslav Pulchart , Kalesh Singh , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D0F754001D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 3k63n4i3qce9ki6fsawi3pz3q3f8sa8y X-HE-Tag: 1702332109-706253 X-HE-Meta: U2FsdGVkX18o0oKr6+7GpaymJL0w33ehMkfviVuWD+3YQTSdkOb9IhZwcP32ch7pZsDdTbBuNRMkKVaHffUOalxodMuYC6gRlN78BMSvjOYgzqPpB2yzBQhJkb4QsZcUwcm64l5C06y0d9EXfZwWCqWu3TMPr+TjuOeIPPSpp2jCI2z+bDHhwhqdU7Ujy+dRG7PetlzZ+gp/4luGe+ny8syeooPCoGXz0NN2X6C+gi3lBxO/ZqI9S+u+Xd1Vt03Rhy5lfTefgj2D3NJ5dc/Sj09t976yT71nL6FGuvvwcqjeDE9gef6FsFmFfuN5NXwQh2spMssqLaCQEWPCOcZiQjYIJtjKCY4Z6n1xOs7GjMSrKRc0KPKWDSVi0WgjDVM4GwC1Ltkh5ClmwIAm64p+zHYYPAYUKTpSg2/rG75aSl3bZwUznPZVq7A/jGSNaxnbVrYCNlUH3v0kxGfPYFUbENrE09FrglkhvLUIkVm/zdW1AKFPBBFZSxnEN037jBpZDDEIZFo1aKIi3Ukmjv8EjvEv+HNloA3GMUHt5Wdz7XQgg64w3PZle9hcqBRpj6GTnT6dMf9kYi29kdf2cGCiYpEF2gT3+g3wOJGRLys1A4KE3hpxHQh5vjv0x9MOzRuRgXsBCd0leaxNtm0IlfZGHuDjy/rPCYaDF2KZ+Pk3eMnnrK9/Du7qNwD9QM77DQ3BGzPhpkczoV6cH5FPLUzzwokut3PaygZYbuhZCIrG+bb1vLxn9HsNxMwqtC+rN552kdLeA3Rq061wd6ZA57LKX0oYRgUwjDdusb0sBjQAbAPlpE+5Q2RXx+gV1BXu0saL+07rBk1R+OlaarZQ/ibKPY0Y89kRtJlen6fTzQ3FLM6S8WF4Eaar1+x8fXAD26w++8Nqd954ivywvq1s9+6qVLO2ZtoCG0gYe+SKhJOcczJfH8R/Uhcj3F7adRDv5Kf9i6Fyfp0kQImIE8Gp8zF N6DW06LZ uPRX6XeUCl5wR5m8ksygy3kACbDemSaQzaQ8N6sKfYlCMySaMFquh+3HY+00azB/ZwaIuTyrXuyAwAZFMny23QhiWqdlChqlsN3qeE7G0+rGGCJ63AFq9R5EiRHF+1rkARFMaBRO+g6oKiNNyBsGD0u5aEDJhsHWAIO7xWTExUSjdLL72tww6r0/zq3r1Zj6B1s5qu92miiT20QGAuUjaxkdg8tXdDedSUH3PuhAnZBZJOiu8ZZoRUR8x4WdQBkc0DXQ1nxvzLf7Iw/op9ReSN+T+ub3Gf19Byv3yTKazI+3oSYLwBK3ofllLlQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.006187, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 8, 2023 at 4:00=E2=80=AFAM Hillf Danton wrot= e: > > On Thu, 7 Dec 2023 23:14:05 -0700 Yu Zhao > > -static unsigned long get_nr_to_reclaim(struct scan_control *sc) > > +static bool should_abort_scan(struct lruvec *lruvec, struct scan_contr= ol *sc) > > { > > + int i; > > + enum zone_watermarks mark; > > + > > /* don't abort memcg reclaim to ensure fairness */ > > if (!root_reclaim(sc)) > > - return -1; > > + return false; > > > > - return max(sc->nr_to_reclaim, compact_gap(sc->order)); > > + if (sc->nr_reclaimed >=3D max(sc->nr_to_reclaim, compact_gap(sc->= order))) > > + return true; > > + > > + /* check the order to exclude compaction-induced reclaim */ > > + if (!current_is_kswapd() || sc->order) > > + return false; > > + > > + mark =3D sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERI= NG ? > > + WMARK_PROMO : WMARK_HIGH; > > + > > + for (i =3D 0; i <=3D sc->reclaim_idx; i++) { > > + struct zone *zone =3D lruvec_pgdat(lruvec)->node_zones + = i; > > + unsigned long size =3D wmark_pages(zone, mark) + MIN_LRU_= BATCH; > > + > > + if (managed_zone(zone) && !zone_watermark_ok(zone, 0, siz= e, sc->reclaim_idx, 0)) > > + return false; > > + } > > + > > + /* kswapd should abort if all eligible zones are safe */ > > This comment does not align with 86c79f6b5426 > ("mm: vmscan: do not reclaim from kswapd if there is any eligible zone"). > Any thing special here? I don't see how they are not: they essentially say the same thing ("no more than needed") but with different units: zones or pages. IOW, don't reclaim from more zones or pages than needed.