From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1869DEEAA42 for ; Fri, 15 Sep 2023 03:35:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A836F8D001F; Thu, 14 Sep 2023 23:35:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0C408D0001; Thu, 14 Sep 2023 23:35:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AD148D001F; Thu, 14 Sep 2023 23:35:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 74EDC8D0001 for ; Thu, 14 Sep 2023 23:35:08 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4BBBF1CA0BD for ; Fri, 15 Sep 2023 03:35:08 +0000 (UTC) X-FDA: 81237415896.16.24C5755 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf26.hostedemail.com (Postfix) with ESMTP id 9109214000A for ; Fri, 15 Sep 2023 03:35:06 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=bfggC8WL; spf=pass (imf26.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694748906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h+PNwmN/bmJL1I9mkj8ynEN5iRLRKttuy6RTWtwzLdI=; b=y1aV+ckuoRLeA5iyD96mArsnrUYBSpRprYrZ3HKaB+RfLMmC5Vj6P/fyNEpe6xXs5oZuiX E8wLbfPfPFc90Zl+Y7XDYxG/qQAUyI9+WIx8p5LV0YAP6NzvQd7YbuIrGXijsF/nsAOokO tWjeJiJhkxTgY6GJwN958C5FlHRL7jo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694748906; a=rsa-sha256; cv=none; b=2NkeW7IET4HNipDyk6WOXv0wMkDXtKdTF11vczl8KsCx0nKhUs/UYHWiIVTf5qebD/sH2V GJmNdR09d+My3rGy33cAtBwVfYBO3AOQC+LfP/IuqTZ/YYWIvq+3qH3m2QyG9sWbxw6Ze2 zvFk+n8YCAl7CLfI10IMwR7/3WnKJFQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=bfggC8WL; spf=pass (imf26.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-41761e9181eso116911cf.1 for ; Thu, 14 Sep 2023 20:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694748906; x=1695353706; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h+PNwmN/bmJL1I9mkj8ynEN5iRLRKttuy6RTWtwzLdI=; b=bfggC8WLxkQWr41GIvJxDrh3F/KU3tIkrIWNbatdv+vHSkfEqE0ML7QHsfdI7sLhwW m40L4/GJ++/vm7noFX40p6a2sfRg2IQiisI9r91IjP32DJ0JmKXN+vGhvLYlYvQLsA+0 OoiGWE97Pt/RkhQz3P4+UXs+S9tKyvs84aLbxLA3yEAup7TrZwLeA27rCs7b6MGGw1vK 9lkKD0fhpuGURl9m+hAWvBtyUS7uOCsKcXwMbo07IX+ELNWqOXQaI6akFGKtj5x6/q6y ROMxXoJmDqS+WXoIYCJuuFaSwlS8yIK0ikdIqxclZCBbujwj0bch1/labf+hKaWrGMM4 6P/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694748906; x=1695353706; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h+PNwmN/bmJL1I9mkj8ynEN5iRLRKttuy6RTWtwzLdI=; b=tr/M2jcSVhedXefnyyjcXXqRivM/rw3F0RlRNldELoPLjVTamwbsSQ3/NCn0g0JR+s 3SEAy7LAExAs0XgWScIgmSYDZsauWtJbQF09DN/uWzbujxNUbe4v7oKtywPeFi+X8FEy JByvyrHLDid4RqJQrEzyuP/uglKypyKdufyDmAyPaY9S8dcIO2NUfh1hrxe2DyUwYj6R wfGBH6ckr0qCVV8uwYNla3zZ3jD+sF8BBlZYfWpwU31E/ObOYWUfzN5usYmJszYrO2ay hBGjR0nx7Tgv5XFwjh1TywSBr6VIjUADY9F53ZHcKfMH+Zh1WfeO0fpEY/OOGv3wL4ID u7GA== X-Gm-Message-State: AOJu0Yzd7Cdd0iV0F9MNm/a7RldzFa7VzprW23oQ9lpjs6ZN5YK6uHTz fkVyW73U3/QXBIrObwfz2XKy6bauzRiXbwO2mfWTN/2McKKta9IhW+cDZA== X-Google-Smtp-Source: AGHT+IEnS0u+vEl2AIzO6qpWtLjUY+Kb25imxoo0RaRfnzAF/oMKZrh73kXLe8DSGdC2WylAKA3cWGcYP1PHrhacuNQ= X-Received: by 2002:a05:622a:102:b0:417:5a8c:a104 with SMTP id u2-20020a05622a010200b004175a8ca104mr140525qtw.26.1694748905646; Thu, 14 Sep 2023 20:35:05 -0700 (PDT) MIME-Version: 1.0 References: <20230914140823.1732-1-justinjiang@vivo.com> In-Reply-To: From: Yu Zhao Date: Thu, 14 Sep 2023 21:34:29 -0600 Message-ID: Subject: Re: [PATCH] mm: mglru: fix add unevictable folio to lruvec->lists To: =?UTF-8?B?5rGf5b+X5Zu9?= Cc: Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "opensource.kernel" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9109214000A X-Rspam-User: X-Stat-Signature: syayequoge1qfyyier8mp3r9pxonzzjo X-Rspamd-Server: rspam03 X-HE-Tag: 1694748906-337953 X-HE-Meta: U2FsdGVkX18fKx4MuWJNNiFbTBMmFjzhwff4kGosWMfqcnAz0r4hyJqhG+/+Wh1F0QuW72UgyTImc7xIBv6zsEo3sUjsInTf2bAWT4Lm6Sy/9x4JlkQyUSOdwQ5bUxy30T/Bs6TO0vmVBDhnVwuGQDoF+cC8P57AIuHfwPdCIw1tOKZBq8l7FW//Z/Ujsf/DhOc2FKa9WPpDkdFRF7U+L/vcXoRF/Qq/CiTNxz3cXkg3Llu1tGMb0+JJQEqKuAWRkZeGIOg/Q89zHd23kQ7omFxV0MoZxGQcJYEX3V1uye+M/eEIev2OkKba1wycI96RIWfy4T06b1GiY22HjCI5m/OvWFhd5LcAchGpo9v37M6XMlcIu+x0GKZmRgXh1VDZilqkiYch3natFGxMAlnpJGbt9icQ9fjzhGLS6mzkhxvpYcuRFc52wpcviycJpCNMoGvtr4wNEh4jdEBGRl5Ul6XCNXxYVK+M4EXe3X935yJIHJPmnVb+3xmbhyrXKZDadCQB8U9ErX9Ekby6CxA888a5YnCUuI051+9L686WMQtYdo7cpFYaCw531C+g9NPfXAQPx7HMn4wcpirBlj9S3P9CNJlQ49ODxEC2cGpf7vptNNoELFsSq2HXPBdDJIGb9YF67mHdB9q2ZkAi3Y4bps5EKG97AAA1Z3lbwFJF0x2vjsBck161+xcEeuKGlo/ZnSKvde763EqGBjk0o1AtaQS5zS3CDYHpElILHbseu4H4g6SMpXCcKCGyhBH6nk8ESVs+GxbFC2SRX3dqnLRpq2djUniYU2JrcENr2Bll87sIDorqpESWxNQTF7BH6sViwJ7kYF8h3J4NcgzsL7Pc/DnZqUXtM8jYstKQlItzHDcT2+s7Gaar9aFCJTqcwJeYG44DONUPdFU51W9Z4wT0KHMq/0PVAA+W3PfvLY7U/E0MbkO0lV8TAV8ShRFNBzqlrFa72qyoBect6VcgEsq vD6hQP7I 3s/M+5+ZEshbSW1Bz8ZMqmSn07m6mlow1cyyV3P4NpKK3iUlH4tF7IBGisTeOyBmr+gotU532dAWBUAPXec3pclQMWOzSA21OruxTr7UylZms0fo1/gGQ2uILTF+x3BNb0+tKeZlCdE0AW+u4ZIrYZlWkWD0M2Urx3P9fRoVWlxZxsaMMsEV6sRlxsfFzY6dQQ+nUGSPf6eBrJWVt7Eht2PsxDgYO31jy+KEko8MJnmXsLjJ9OMbJJytW7QRoro0vooG3xwCgLEm2WNLNIhCr1lC1qRI8+V2U4DZHyearn0Xn9Zz8/aXQZ2nnBqUpVwZxoD44emYmdEoyMEDxFpfuhwlWXAniwSj2hrKVGKz6WpWFeOVqcP02GWVCzMXt69ze9yCBtfZwTm2h6JNV25n5k9YMikjbzfM1EIv7tZ9G4fN5sLwLtORssfiboA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 14, 2023 at 9:33=E2=80=AFPM =E6=B1=9F=E5=BF=97=E5=9B=BD wrote: > > Hi Yu Zhao: > > Thank you for your reply and sharing. Sorry, wrong link. This is the right one: https://www.kernel.org/doc/html/latest/mm/unevictable-lru.html#the-unevicta= ble-lru-folio-list > On Thu, Sep 14, 2023 at 9:19=E2=80=AFPM =E6=B1=9F=E5=BF=97=E5=9B=BD wrote: > > > > Hi Yu Zhao: > > > > How is the unevictable folio managed in kernel? > > https://www.kernel.org/doc/Documentation/vm/unevictable-lru.txt > > > On Thu, Sep 14, 2023 at 8:08=E2=80=AFAM Zhiguo Jiang wrote: > > > > > > The unevictable folio is not supported to add to lruvec->lists in > > > lruvec_add_folio(). > > > > > > So use lruvec_add_folio_tail() instead of lruvec_add_folio() to add > > > unevictable folio to lruvec->lists in sort_folio(). > > > > > > Signed-off-by: Zhiguo Jiang > > > --- > > > mm/vmscan.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 > > > =3D> > > > 100755 mm/vmscan.c > > > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c index > > > 661615fa709b..a15e45632034 > > > --- a/mm/vmscan.c > > > +++ b/mm/vmscan.c > > > @@ -4237,7 +4237,7 @@ static bool sort_folio(struct lruvec *lruvec, s= truct folio *folio, struct scan_c > > > success =3D lru_gen_del_folio(lruvec, folio, true); > > > VM_WARN_ON_ONCE_FOLIO(!success, folio); > > > folio_set_unevictable(folio); > > > - lruvec_add_folio(lruvec, folio); > > > + lruvec_add_folio_tail(lruvec, folio); > > > __count_vm_events(UNEVICTABLE_PGCULLED, delta); > > > return true; > > > } > > > > NAK. > > > > lruvec_add_folio() > > { > > ... > > > > if (lru !=3D LRU_UNEVICTABLE) > > list_add(&folio->lru, &lruvec->lists[lru]); } > > > > lruvec_add_folio_tail() > > { > > ... > > > > /* This is not expected to be used on LRU_UNEVICTABLE */ > > list_add_tail(&folio->lru, &lruvec->lists[lru]); } > > > > struct page { > > ... > > union { > > struct list_head lru; > > > > /* Or, for the Unevictable "LRU list" s= lot */ > > struct { > > ... > > }