From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FDA4E7719A for ; Thu, 9 Jan 2025 06:47:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C5616B0085; Thu, 9 Jan 2025 01:47:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D9166B0088; Thu, 9 Jan 2025 01:47:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62AC76B0089; Thu, 9 Jan 2025 01:47:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 47B2D6B0085 for ; Thu, 9 Jan 2025 01:47:16 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E25E1161345 for ; Thu, 9 Jan 2025 06:47:15 +0000 (UTC) X-FDA: 82986981630.04.A82BA01 Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) by imf25.hostedemail.com (Postfix) with ESMTP id 16E6EA0003 for ; Thu, 9 Jan 2025 06:47:13 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KZHduLut; spf=pass (imf25.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.48 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736405234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WA0BAOpvGBtdfuAMS7ehVuk4xBXZ0sIKaMx+6J8Mok4=; b=RSaM27QlGHULegf7Y4A47fL9XXzf6zY/zkDMhYUtIwAdqQGG9nnB/rSDbsQF/mME7NkVrT xQ6tOTqMzLo4ksYYVIDibjrnt9PBjwOki6YyEI3z+gjGrgWGBl3Uu9PEsESa5DJ3YaZaVm QgLBILERh3uCtBWAfz2nje+aGk0+Rlw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736405234; a=rsa-sha256; cv=none; b=1En4lbv7919b6hS7SE1WcFwo/4xORwhPubtcIxzNSP58Md2kLd0lqpmrZldB9L3qTFd0cc 6P9oTnm8v5KywK45+RrzVRueK1YX6QrZIYMZF1yzENHZt/y5xktSvmC229gKsefOmDl9Qd 1aapfN5vsTi1MHs+7YHRj+qSQuDuU1A= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KZHduLut; spf=pass (imf25.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.48 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-vs1-f48.google.com with SMTP id ada2fe7eead31-4b10dd44c8bso201589137.3 for ; Wed, 08 Jan 2025 22:47:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736405233; x=1737010033; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WA0BAOpvGBtdfuAMS7ehVuk4xBXZ0sIKaMx+6J8Mok4=; b=KZHduLutZ+EfV5gof+pJNoT1Rao2KSeE6yCwCagrN+MLyj8/zDL4acOZaUz1BNYmRd m+D/HRMYL5gZcGS/BHPe1BajK3c8+A3A+OOYGuwZzhVTCddUVEGxw1FBa2GeDFnJ69pj pTVA+G/yuQ8/ZbIkKyh3TlwtWDbDYoUGN4SYsrAIAESDWBTF8PDJlJajrBCiQ6X66xue PBtMgBotzpzb5YbjdCdI5BRVMx6hRv71cn07CZq6pwqOTTjz/KnW/GiVH8JFDqUJY4ON CjHmH4kQlB1sAc3wobsYml5wj7N7+F2BeD91rPrIhaJPux4SlvWeZL7f2/1JQuJIooG3 oW/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736405233; x=1737010033; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WA0BAOpvGBtdfuAMS7ehVuk4xBXZ0sIKaMx+6J8Mok4=; b=k7xvYYqX7+qTxx0tLLzcPxTlGfJ/Yf1qp8GfSzUS6MuKb6CKX7AOTHrSrhY0640Bs+ BWTp1i/cNYQE9/BQyYmJhfCklJmmSZRvKD8G6h8lemdNt1JraYxn8VKwck7OOLQm8zct 1ie1NhrjQhNHhPKffTPPD9sGUF7jjDhOGIMV0SKJsS/dzTCnUpWXXnymN7gZJPwmDvj1 3wPkZjq/DVynhgz3hD9MSRuOzfMaCHRqkXnOgP6BaWGOS56h7WJlydAP42iY8E3SDZGY qUdLl4mi7oSqr7RWXV1g3jprsM3Tz3MAz92u+AOP9DJmHv7vq7lLERoLJp/Fd1rUtxCs wddw== X-Forwarded-Encrypted: i=1; AJvYcCUb6Jp1asCSOuktlmwuDTpN/RSYC0YVA4CVUHQCCPrGRGtXrTnhMzZD+W19nmGTjxSbDq833WJyfQ==@kvack.org X-Gm-Message-State: AOJu0Yw1YSB3LFyO1PB//7liKVoKSXfNK5wswxOBUy9dl26KzQyXum6f iyxZZTeCF/ZFFm6qUmejzIRH5yITFTLHFrcrGyf7BwXCzYjmeeH1zfr/TfBBgHszKvuyOhPE8lq 68uohj2omOIDzs8w/mIs65RHvoVnghdQ+26nk X-Gm-Gg: ASbGncuAJUKcPmD0Cn2ApvG99XnTnZjmRMzgVBZ0YzQ8I0H5Tp61sFIRbNoH3XeKbip ullyW1eFH7fCYQgvte5u4UZ4ni6+7XzvgclyL1KzbhEsq/7FF3nXa+iRkkHWlJ30IX323NgI= X-Google-Smtp-Source: AGHT+IEne5JtKx7DCWIWMlvVrmFZttIB0w7WEXtZjUmrrsUhsgHE1+PsrTVHoRZ3jE2qXOhML5SznplYQIePXgnP74A= X-Received: by 2002:a05:6102:1497:b0:4b2:4a38:7b8f with SMTP id ada2fe7eead31-4b3d10485c0mr5022214137.17.1736405233043; Wed, 08 Jan 2025 22:47:13 -0800 (PST) MIME-Version: 1.0 References: <20250109060540.451261-1-donettom@linux.ibm.com> In-Reply-To: <20250109060540.451261-1-donettom@linux.ibm.com> From: Yu Zhao Date: Wed, 8 Jan 2025 23:46:36 -0700 X-Gm-Features: AbW1kvaDPX4dfgWGMtvJdZVAQILTvm4SbgtB1j9Q_ig95foUKRvLIP-l8MUb7RI Message-ID: Subject: Re: [PATCH] mm: vmscan : pgdemote vmstat is not getting updated when MGLRU is enabled. To: Donet Tom Cc: Andrew Morton , Kaiyang Zhao , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ritesh Harjani , "Aneesh Kumar K . V" , David Rientjes , Johannes Weiner , Michal Hocko , Muchun Song , Roman Gushchin , Shakeel Butt , Wei Xu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 16E6EA0003 X-Stat-Signature: 4ya1trxn3psxwcqby9igh71z69xdkyo4 X-Rspam-User: X-HE-Tag: 1736405233-584083 X-HE-Meta: U2FsdGVkX19miYuV5rZnXs5kOUQbzJDw/vhoEj+aF6TiHF185symS+tyK/YDQPBr74YQ3OkcXu0JoXp/XnPNlDvhED/6ZZ3OGP/LV/2TRxusBfyTSgA+mfyATpN7nRd97B/1SssBPGM8vGdipovKbphhQ1F6HBnrCUcH34B/QXhNs7mobMoiSE+FxPdqH5ylY5s4KFPqXrFWjVq2M5f8T9RuFYfjHdelohoPneT6S6LvKTwWj9wm+dyzSOq8OEkYnU6eoQ1obgX87Ty7YD7tuCq6txF2OGr/GO/ajNQoJTTWVt7kSG4cV/v75MFfheMgnwgpkO9xnuhdEnehKsfJgXBqmkZlaz5ZwQt1DePuAQ3MAM7NGQK2+uD7PKBdsmZRuXcvn4AUNoXM1LBrK8YjEh2GzSmRsFJ+wokree9gF430Tc5O9Ytg3HJhoMlvRpf2K5PrSHP4YZpi0LcOo3bE06nUx0VZcfQsoPwLC1mzwM5y1PhaypXPPTdKu6/tZqggfglFjl/ZJD7vDQZc1Ex2Yez3nGM4HT0vtAMSa3vxFzIgPRoQuOCSPNc0aonzl/Ae3/KaGB+dFkq26rHdIVP+VVsyMoNpvRDmOCt4hW3U0h/VTEOaM11TfwApHoncyjZwcvBtsAC+hOyM2rBJkTY2rlkCpaGOYSLqxIyiXMhxBff60GLXPU3662F/Jbp5IVzx3UcD24F8BrG+/5AVVQ1G65ezLx2LA8913kTQXGodS97Gh+fTaWLnwkErn6RSWi2fJZ1yH37M1RxJrJSKpjnahwwUfZ8AHI0dP4jBbgyejEpxujMIq8YCAqqTstschzhhnPaNF9SeJnsraHsolQrHlRHi3OE5BiWMhT3B+Opr3+7vR5vI4pWGiL9flAVZUL6cSuSkdTd6Q11oQg/uKySX8+c0cxhfq6MyB4IWWeCRO2hHKcvZjpzU+8g02mJR3c2sutl/ughvm77M3YsdfxJ rM77rQAI +LSrCETW6y6qMfsm7LWnf+RqJFpxJxSKFzUKGhokBdhhXRJLaG6BoQtXg4PhbLyna7EYS718RIswCXFtA9S0cAO/eR7TjbbDVr10v52q4DBPKTAdQpiVV0cumvpZQWKovN2A4RXGrmnWo9oW8t7m01xY8Sj7SnMXZdvATuBSXfziAx/M2WS4XE/oXFq7d4xyfc2jJ7YaWowq3co1hHX4sjVoqRMJa86gGej4zm+mME1y9ZLGqboFKMuOlClMOHWMFL305zySTY0qkgdr3uPVzyMCSjSXez/dwZoPtFqfSuNU2qL5LIEmslUAIoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 8, 2025 at 11:05=E2=80=AFPM Donet Tom = wrote: > > When MGLRU is enabled, the pgdemote_kswapd, pgdemote_direct, and > pgdemote_khugepaged stats in vmstat are not being updated. > > 'Commit f77f0c751478 ("mm,memcg: provide per-cgroup counters for > NUMA balancing operations")' moved the pgdemote vmstat update > from demote_folio_list() to shrink_inactive_list(), which is in > the normal LRU path. As a result, the pgdemote stats are updated > correctly for the normal LRU but not for MGLRU. > > To address this, we have added the pgdemote stat update in the > evict_folios() function, which is in the MGLRU path. With this > patch, the pgdemote stats will now be updated correctly when MGLRU > is enabled. > > Without this patch vmstat output when MGLRU is enabled > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > pgdemote_kswapd 0 > pgdemote_direct 0 > pgdemote_khugepaged 0 > > With this patch vmstat output when MGLRU is enabled > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D > pgdemote_kswapd 43234 > pgdemote_direct 4691 > pgdemote_khugepaged 0 > > Fixes: f77f0c751478 ("mm,memcg: provide per-cgroup counters for NUMA bala= ncing operations") > Signed-off-by: Donet Tom Acked-by: Yu Zhao