From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA3D1C38A2D for ; Wed, 26 Oct 2022 18:09:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E968F8E0002; Wed, 26 Oct 2022 14:09:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E472E8E0001; Wed, 26 Oct 2022 14:09:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D35778E0002; Wed, 26 Oct 2022 14:09:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C6F268E0001 for ; Wed, 26 Oct 2022 14:09:20 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8DE44AB607 for ; Wed, 26 Oct 2022 18:09:20 +0000 (UTC) X-FDA: 80063887680.03.351F961 Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com [209.85.221.176]) by imf03.hostedemail.com (Postfix) with ESMTP id 17F6B20021 for ; Wed, 26 Oct 2022 18:09:19 +0000 (UTC) Received: by mail-vk1-f176.google.com with SMTP id v81so8360983vkv.5 for ; Wed, 26 Oct 2022 11:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mojyIGWRIgJTNX8C5UMuUHcoan5R5wVfttH40XiofO8=; b=qOvclwxcs2pCPf3b7fyIiVIyTEfjD1jTs4ZGaLYpA5KI7frj16xL3ixl18REeohVMO RycGt88O7USFm3kVlZka907NIzYH6o5UESbznHPgzedZPsx6KddGIRjX2x5nOv8Ov7Pa hSfmK+MFeBi5Jt1YyBm2Pcr3lIAzqHrPb15lINQPlLCqhBYnHJgpJwoilQmR+8FBI4SC fgCgW34HDHMlXqA6YxjiAQbAE+suaCrla42Qa0usY+V5Doz33N5yB/wVEiBB/HikkTRn bt4nKDdmAScWH0VF9ZknHXkapHMjS5/FEOK45/F+aSfJacyhWC835uNHquESC/f4JA3K is2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mojyIGWRIgJTNX8C5UMuUHcoan5R5wVfttH40XiofO8=; b=noIJgXEKdHHr1IomWNYjdlHvNQnI+jwFGCqQGAR0a3lK0Gl+GKqo73bqywI5ir0Gq5 9aWqJIHGCS0Vim0ryGJGL4qb2WkiuADhaIVHRSXd0SYLSFoXLynbY2mxdOkl1HJeStRv mrAy9YBjkWCbiwky5N+e5aNsP+HJVbheK6shgI0AHY2aQOqyDVlI4EORCvdfSv9vV1+O eKxU7zVH3yDCzWj79zUWcoRd7NMin2gzjTbHTNwQqazCvau9lQwTlnEo5QzdSmL8qrO1 wXw0N1zl029BQtTJr7mkMEOROZDEwW8q6MPln1mjj24k/l3/esvGv2nJdOLH9N3XqVEQ 3GDg== X-Gm-Message-State: ACrzQf0R1jR8tMCas1CFctSovYlmdxWVnDJd2C1nJCGPkopFpwnfF18w xkvbY1JjojE+3mmqiB2Yythn5L5/63g83R0jk+p3gA== X-Google-Smtp-Source: AMsMyM4pCaEAiXvP/ByR3WUnlBcWfEJLVa/ungHbHC9hE2BeZn2QP75gYsEHDzq6RE7w4GuU14Qx6tRy9a2VehLLiq8= X-Received: by 2002:ac5:c969:0:b0:3b6:2a34:a26b with SMTP id t9-20020ac5c969000000b003b62a34a26bmr10091328vkm.30.1666807759152; Wed, 26 Oct 2022 11:09:19 -0700 (PDT) MIME-Version: 1.0 References: <20221026134830.711887-1-bigeasy@linutronix.de> In-Reply-To: <20221026134830.711887-1-bigeasy@linutronix.de> From: Yu Zhao Date: Wed, 26 Oct 2022 12:08:42 -0600 Message-ID: Subject: Re: [PATCH] mm: multi-gen LRU: Move lru_gen_add_mm() out of IRQ-off region. To: Sebastian Andrzej Siewior Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Eric Biederman , Kees Cook , Andrew Morton , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666807760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mojyIGWRIgJTNX8C5UMuUHcoan5R5wVfttH40XiofO8=; b=2h+kJc8Q/Yd2OCrILV0CCF1BmHBu8470OuZdYhY5vSpe0g3BCyNGdanJsvgHhGXP3hZl6d 2qeB1tlMMlTUIXlqtEj9zWjBL8GS+lGY3keJ7g7CiHq2CJ7GTc4qSFh8xJzkym7GmZ+XLC 00Wys7gU/Q4PtOOZ6/gBtxJD+NBKcKs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=qOvclwxc; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.176 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666807760; a=rsa-sha256; cv=none; b=mBTgwGp4SoFK1JcaSODD+4Jj5s2YwqVMwbqMI++R5fTAdKOKqs6es/2PN4SBWDK3N+qyat yJsm3CS6EcV6qzD140PYjilyPWAKD/tie4KfTAEdm8bNknXtXhxDVUN9LkSphomTcw7mah bafEc1kvLNVoVqse7O2BCkwfAI2zt2Q= X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 17F6B20021 X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=qOvclwxc; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.176 as permitted sender) smtp.mailfrom=yuzhao@google.com X-Stat-Signature: i6gqwamy3yx3yii8p6fu4dy67s41aeqk X-HE-Tag: 1666807759-367560 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 26, 2022 at 7:49 AM Sebastian Andrzej Siewior wrote: > > lru_gen_add_mm() has been added within an IRQ-off region in the commit > mentioned below. The other invocations of lru_gen_add_mm() are not within > an IRQ-off region. > The invocation within IRQ-off region is problematic on PREEMPT_RT > because the function is using a spin_lock_t which must not be used > within IRQ-disabled regions. > > The other invocations of lru_gen_add_mm() occur while task_struct::alloc_lock > is acquired. > Move lru_gen_add_mm() after interrupts are enabled and before > task_unlock(). > > Fixes: bd74fdaea1460 ("mm: multi-gen LRU: support page table walks") > Signed-off-by: Sebastian Andrzej Siewior Thanks. Acked-by: Yu Zhao