From: Yu Zhao <yuzhao@google.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Eric Biederman <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] mm: multi-gen LRU: Move lru_gen_add_mm() out of IRQ-off region.
Date: Wed, 26 Oct 2022 12:08:42 -0600 [thread overview]
Message-ID: <CAOUHufaW94QseZJqaDuyFTwvX7TyZwuFwYULgno25Vb5HduByQ@mail.gmail.com> (raw)
In-Reply-To: <20221026134830.711887-1-bigeasy@linutronix.de>
On Wed, Oct 26, 2022 at 7:49 AM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
>
> lru_gen_add_mm() has been added within an IRQ-off region in the commit
> mentioned below. The other invocations of lru_gen_add_mm() are not within
> an IRQ-off region.
> The invocation within IRQ-off region is problematic on PREEMPT_RT
> because the function is using a spin_lock_t which must not be used
> within IRQ-disabled regions.
>
> The other invocations of lru_gen_add_mm() occur while task_struct::alloc_lock
> is acquired.
> Move lru_gen_add_mm() after interrupts are enabled and before
> task_unlock().
>
> Fixes: bd74fdaea1460 ("mm: multi-gen LRU: support page table walks")
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Thanks.
Acked-by: Yu Zhao <yuzhao@google.com>
prev parent reply other threads:[~2022-10-26 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 13:48 Sebastian Andrzej Siewior
2022-10-26 18:08 ` Yu Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOUHufaW94QseZJqaDuyFTwvX7TyZwuFwYULgno25Vb5HduByQ@mail.gmail.com \
--to=yuzhao@google.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox