From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 952DDEB64D7 for ; Tue, 27 Jun 2023 02:53:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C35A8D0002; Mon, 26 Jun 2023 22:53:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0740B8D0001; Mon, 26 Jun 2023 22:53:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7E598D0002; Mon, 26 Jun 2023 22:53:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D523E8D0001 for ; Mon, 26 Jun 2023 22:53:48 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B0D641408AE for ; Tue, 27 Jun 2023 02:53:48 +0000 (UTC) X-FDA: 80947007736.14.267E76B Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf21.hostedemail.com (Postfix) with ESMTP id F33431C0006 for ; Tue, 27 Jun 2023 02:53:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=xBIB9H6D; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687834426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jXL2A5XwGkQBMKHvJmT9XBgr9QrqO5b2xYT/yObtZVs=; b=O/pc61P7/uk3iMhYT2z15+z0Cxp4Fu8Lu5x3yx3441ufC7kx78KVEoDa45925UywniZLOd /nyekXFifMFYZIXWM0M5o6DWPeiVZ603vq2PvRmZuoLvLQWGgDtuv8v7I8awHO3/iGYIn/ o1gxEyn5Joq7R8HpjFqTCA4zfmRKEv4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=xBIB9H6D; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687834426; a=rsa-sha256; cv=none; b=3irhGq8Y2t2ovTwbmezLt/UdoUp4bCUOSx2DHp9HC694UTvsh1VW1lH2GGdEoQc6WeHIlH MuIevE7dnMXsbULAMXjkm8wji57e03ZuFz0pjueelXOjlK3znLPA9tDX3IQ7vcEFGdKAK6 +nM7hhDD5Ttwg1ED1d5BGNRrg97UGUk= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-401f4408955so89761cf.1 for ; Mon, 26 Jun 2023 19:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687834425; x=1690426425; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jXL2A5XwGkQBMKHvJmT9XBgr9QrqO5b2xYT/yObtZVs=; b=xBIB9H6D26duO7D5p9m4SYXnyo8r6ka9obuVuhUc1nSeyBJJHDhGhS//0CYhrq0cEo C3ZegRAqeuF/nHp1Hz01nsb8c9MfJMrAHGvaaVYgKY+EepRGYl1OeaJM6w1KW+G0F5aY Ja7Ufnd8fXGxS7FeHYaRjSPLXtMSgzv5A2UfRDFV+8V3+yG9iAYrGactEFGmsUrKFpMO lx6ka2RYtqwA6/JcD2tJ0Voq7K6g6sgAIIREvF1zoR/jNw4UZJnFjM6K6j2Ysp9yjdfl md6pDBt8J1TZcYvdzAlWxXHjudvUk4mbHTfK96zyrtLCi00HysOXC1SH5YQBPjkeB6Rt +7Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687834425; x=1690426425; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jXL2A5XwGkQBMKHvJmT9XBgr9QrqO5b2xYT/yObtZVs=; b=R2YgIimYDGxTGlx52l5iWH8R6atnWSstN0X1qvd8fcedeWLIYywm/PG0ChA0Ff7Pv9 q3FIdCDv5GhKKicl4j9TEdiu7Y0cd7XlNO2joSso/zQdC/Q5kv5XT6lrsHnPV0/csL55 p9s81tvYMeqxsyd2B+E/kPjoRROSFJIPEVBGCT7sNbI/XNaf4fv6l0Ak6WUPvOWhhTK6 Bja8mar/+yIP+fosO7Q+SJPW4xekmKKYdTz++N5j+UJrUDLI5bbK+XQQf9X3K+yNP+3M ApmZ51hSkgshCmsoeq5GmxTG0ElsSjlJ1EP2l+GhbPvSoXrehKTao9u5Xjki87Ttwhzo 9X3Q== X-Gm-Message-State: AC+VfDwSw+ll6tP4JVQrJ4x1qJnleZS/0982HxnKT2CJWi/lB8M+1Bcw xd4ZvxKA9wYqbwygDBUGoMSUi7mZh38PzW+ucxlPIg== X-Google-Smtp-Source: ACHHUZ6zI76K2CG0sVaEiLZmWTUL3AMky+bfMr9SxVJfeyKmojoMzl9FYlquTsH7N5mo4L8oNK3cBNdwJ5mTx/oVrN8= X-Received: by 2002:ac8:5a4d:0:b0:3ed:86f6:6eab with SMTP id o13-20020ac85a4d000000b003ed86f66eabmr658445qta.14.1687834425082; Mon, 26 Jun 2023 19:53:45 -0700 (PDT) MIME-Version: 1.0 References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-10-ryan.roberts@arm.com> In-Reply-To: <20230626171430.3167004-10-ryan.roberts@arm.com> From: Yu Zhao Date: Mon, 26 Jun 2023 20:53:09 -0600 Message-ID: Subject: Re: [PATCH v1 09/10] arm64: mm: Declare support for large anonymous folios To: Ryan Roberts Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Yin Fengwei , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-s390@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: F33431C0006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: wgh4eeouzxt1c1gi11dxkpe5gxnp1hfy X-HE-Tag: 1687834425-831203 X-HE-Meta: U2FsdGVkX18dBcubIvHOEc5cIZB29dep6+GKW30WZMtqbEvcVP3p7L/n6h6BxZPxQAnARABSfIsf9xtKQH3kRMGInPvK/LOI4bU8lYuYkJmrDJaXI5+eVZ3C/ZHaTXV2S5hxJpwora8jgg3qgL5pZZLJEPjKTjDJJce3LtFCWTtxLwL5ruY1mqztXmGKnch64CTDIAhfzmVSDjWtqlM1tIyAz4mSaSfgpxaAzVUK58lkQqQaKSBYpQWnjUjTb53uuX/DvMaXKoIGE2WMB7ffE09NpwZNhngrRrfmTUwX/4DzIZvSkoekgic+2ZZlv9xtJpynGOajoYKv+jJ3jmsauA90d57CzZDH3B2uVldtcIJvTR/H24t8oX3F9dwTAi3k7ZVMij+2OdPDvLRV27cJqfHf219kkWR2upSIvREu8m8Xy6dBLgEY4eqtV3pBPG2+blosCfiRM+A77DaazRolCvA6Ug43Hwn15j/zRYN5ySnhQrgGuC6viNRQC/upp5fp4BnSiT7Yp2UrJTV/3Lj1F5LHYDTzmPVLPgIEl01f4cFxjg6Hx3r6Q2L/d7a4AJsWLMXMQwGma77KLAEkaMpdSUNSgVOu4AVzh4oX4XSfpbJdddT6p+F91JcH5d6TaJpq5ceXmGPmntEl2QKRz3CBBgDuV8zaohz5yHhLlVAlT7hlyuZ0ZtEBrqba0kQWKl3pby20mIEWIklQNuZjTKwZnPqmuev5DHCXxqPkuyNOrHugYGxgimSaYarlK4dKHuB8xsbipsb7KW5yjhS7xfbGyZp0EdJvZvNF9Z/ObtKiCa6vOm7lvj7D+5pmv5H/BvOR9gIxdcUMxe3Btrb6POBB41xUBcmlI5uEoIcNFC/+EVQkkxP/HK0axkknQHFkVx1IE+hBMBWcbiXUrxMTx2kzS84NH0/w3BJtteitHHdT0jpfGK6Nrt4//mInWDIcc0winqzPSEXhmrQxn4gEsKm jwaWFwbf e/4fzuKS5pIaaiOIVv8834rT56a1h0BE9wa7bc4ZqahDdUW1Z2iWTJxx9oJfLljEkGO4/Tr55zGmCgkD318O3ykgHZxMQwRbuQGQR9V0uxAnQvWquPZLDvyj2EDtXNxZt2SeNc4faomFhrhl+YWgg5W0kr/6nIFJMLOuiAVxJpZTjE2CUwTmTmvn34xQGcvUyE0Vu0i4uNMa9lpHwk6Y8TsZ0s66heoe+AQRzw1Pvn67V7HNozDLQRjlf/0A1yCehKBVS7FQyZRMmjlpyQ7TEOTzAm9FsoJAlCkX9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 11:15=E2=80=AFAM Ryan Roberts wrote: > > For the unhinted case, when THP is not permitted for the vma, don't > allow anything bigger than 64K. This means we don't waste too much > memory. Additionally, for 4K pages this is the contpte size, and for > 16K, this is (usually) the HPA size when the uarch feature is > implemented. For the hinted case, when THP is permitted for the vma, > allow the contpte size for all page size configurations; 64K for 4K, 2M > for 16K and 2M for 64K. > > Signed-off-by: Ryan Roberts > --- > arch/arm64/Kconfig | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 343e1e1cae10..0e91b5bc8cd9 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -243,6 +243,7 @@ config ARM64 > select TRACE_IRQFLAGS_SUPPORT > select TRACE_IRQFLAGS_NMI_SUPPORT > select HAVE_SOFTIRQ_ON_OWN_STACK > + select ARCH_SUPPORTS_LARGE_ANON_FOLIO > help > ARM 64-bit (AArch64) Linux support. > > @@ -281,6 +282,18 @@ config ARM64_CONT_PMD_SHIFT > default 5 if ARM64_16K_PAGES > default 4 > > +config ARCH_LARGE_ANON_FOLIO_NOTHP_ORDER_MAX > + int > + default 0 if ARM64_64K_PAGES # 64K (1 page) > + default 2 if ARM64_16K_PAGES # 64K (4 pages; benefits from HPA= where HW supports it) > + default 4 if ARM64_4K_PAGES # 64K (16 pages; eligible for con= tpte-mapping) > + > +config ARCH_LARGE_ANON_FOLIO_THP_ORDER_MAX > + int > + default 5 if ARM64_64K_PAGES # 2M (32 page; eligible for cont= pte-mapping) > + default 7 if ARM64_16K_PAGES # 2M (128 pages; eligible for co= ntpte-mapping) > + default 4 if ARM64_4K_PAGES # 64K (16 pages; eligible for con= tpte-mapping) > + > config ARCH_MMAP_RND_BITS_MIN > default 14 if ARM64_64K_PAGES > default 16 if ARM64_16K_PAGES Can we please just add one Kconfig for the large anon folio feature, i.e., ARCH_WANTS_PTE_ORDER, for now? Feel free to add as many as you wish for arm specific features like HPA and contpte.