From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A966CC433F5 for ; Fri, 7 Oct 2022 00:47:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32CDE8E0001; Thu, 6 Oct 2022 20:47:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B4CA6B0074; Thu, 6 Oct 2022 20:47:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12F038E0001; Thu, 6 Oct 2022 20:47:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EE7396B0073 for ; Thu, 6 Oct 2022 20:47:54 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C4594160396 for ; Fri, 7 Oct 2022 00:47:54 +0000 (UTC) X-FDA: 79992316068.08.33A830E Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf17.hostedemail.com (Postfix) with ESMTP id 707604001D for ; Fri, 7 Oct 2022 00:47:54 +0000 (UTC) Received: by mail-yb1-f175.google.com with SMTP id 207so4155251ybn.1 for ; Thu, 06 Oct 2022 17:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=M+IcUxG/8bdfwhbp6VP9RN21xHZcHPUGPwHgSYZ2tDc=; b=IvPDLUYVYcv7i6xEYqj2pK/ic9i0+t9wXkTDZ40VIQ8yZM5bxmlNFQ1MQPTJ0+6iRa JRjldH6NhNtHwSOnETQiEOf+KOfhYkd4x+xjq5CIu9/PXJuoZjc1erErakZasuALUlep ZS6JG7dCdxKDLtws6lLrJERMwlqKWmCinX5aRevWgRESoS/2ZPV2WJ3hLa+bt6KfMdYP 2e8N9grppoDD5bJ0HHCCLrIs5lUeBHU1kRDiW3qxOSOTcJ/mqey5tvFdML5N3L7yW029 2+g9Sg730IZQOmi+2cIGThTikDQ26j8NQgks3rgH9DpZ9iblo+F6fr8BcKJyroTPvYO5 R4VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M+IcUxG/8bdfwhbp6VP9RN21xHZcHPUGPwHgSYZ2tDc=; b=5acxT7kBYgkAwLABqtQJxrmS8BdXP+HTWYZvoQXu7ZCM+oaE2PGcidFCQuk88SAewq kfobpXTXoWQSHT8ravZ3tnf5GGS5w8sKW7Qd6pIcq9XyK+Y2rvyio/iX9fpHCe6+qk9a YsXszASBCIGX8PnY/ndm7c2O/eYMSc2uCL5oroWD3Xm+LYUGFr8mVTFbRIwU3mVJR0FN WzxaTPxsweyMiSBN/JvJi58Dajgdk5tmU1hiGkpMupgVfnuxUVMFrdaz8KlELL5Ko8bj pUPy8Oa26siySMH5EopMpLcTSjrQXGcmallr5yxXjbxHPHmTwDM++WZaap1l+3ZngOR/ dcOA== X-Gm-Message-State: ACrzQf2Iab6dBAJTxZqOxuLUkLn7Uofj6JFBU/+11IKy1482EaFv76rB 5++cbfG4L6Eqb8YSmxJ4/BCUrcnZwkmemHMojgpjTw== X-Google-Smtp-Source: AMsMyM7slrDWoJGHsan+6S5It1PTLpfTN5q1pL+3r1aMElMlYee8QZmqBbua3VWq6he2/l/9IuqhwOkAMwzrKM/DBtk= X-Received: by 2002:a25:d292:0:b0:6bf:87:21e9 with SMTP id j140-20020a25d292000000b006bf008721e9mr1670311ybg.242.1665103673555; Thu, 06 Oct 2022 17:47:53 -0700 (PDT) MIME-Version: 1.0 References: <202210052318.5ad10912-oliver.sang@intel.com> In-Reply-To: <202210052318.5ad10912-oliver.sang@intel.com> From: Yu Zhao Date: Thu, 6 Oct 2022 18:47:17 -0600 Message-ID: Subject: Re: [mm] 763ecb0350: kernel_BUG_at_mm/mmap.c To: "Liam R. Howlett" Cc: lkp@lists.01.org, lkp@intel.com, Andrew Morton , David Hildenbrand , Davidlohr Bueso , "Matthew Wilcox (Oracle)" , Linux Memory Management List , linux-kernel@vger.kernel.org, kernel test robot , Hugh Dickins Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665103674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M+IcUxG/8bdfwhbp6VP9RN21xHZcHPUGPwHgSYZ2tDc=; b=dkfvF5A+QrPL9EMtxZoCdPbNg6+fHM3JyZD6X/Txuc7kl/65oCstF2Nt8VEA04dSwu8CMS 8avA1Z/lr4soxUWV8uroqZS7RAPdfrCrCfaoU08SiyBkI3w46MhOi/6eEyHduWy2t98hni 38RaHqzcELYWNr3WibD4ycml1O/For8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=IvPDLUYV; spf=pass (imf17.hostedemail.com: domain of yuzhao@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665103674; a=rsa-sha256; cv=none; b=QDOo+UxNYo1C9Awz/yB9KphQ3qWkJkK5CW8wE0ATWWoTpJjNA/ff6swLtYA9KuAC0mNqIx A5cl3B59aCt/9/iPQdYMGjXasXIuIAHo80/V7aPcse0ecBmVWOf8U1NLYDC1/vHpOMsB2Y OoCI8yj0bLcvr/NNTzR7h4ZM1H1/0mg= X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=IvPDLUYV; spf=pass (imf17.hostedemail.com: domain of yuzhao@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 9y9rau6ychjtutrfgmpeiu7zgwtk7ssa X-Rspamd-Queue-Id: 707604001D X-Rspamd-Server: rspam02 X-HE-Tag: 1665103674-229578 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 5, 2022 at 9:30 AM kernel test robot wrote: > > > Greeting, > > FYI, we noticed the following commit (built with gcc-11): > > commit: 763ecb035029f500d7e6dc99acd1ad299b7726a1 ("mm: remove the vma linked list") > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > in testcase: trinity > version: trinity-static-i386-x86_64-1c734c75-1_2020-01-06 > with following parameters: > > runtime: 300s > group: group-03 > > test-description: Trinity is a linux system call fuzz tester. > test-url: http://codemonkey.org.uk/projects/trinity/ > > > on test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G > > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): > > > > If you fix the issue, kindly add following tag > | Reported-by: kernel test robot > | Link: https://lore.kernel.org/r/202210052318.5ad10912-oliver.sang@intel.com > > > [ 63.390267][ T5018] ------------[ cut here ]------------ > [ 63.391875][ T5018] kernel BUG at mm/mmap.c:3167! > [ 63.393264][ T5018] invalid opcode: 0000 [#1] SMP PTI > [ 63.394501][ T5018] CPU: 1 PID: 5018 Comm: trinity-c1 Not tainted 6.0.0-rc3-00284-g763ecb035029 #1 > [ 63.396050][ T5018] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-debian-1.16.0-4 04/01/2014 > [ 63.397726][ T5018] RIP: 0010:exit_mmap (mm/mmap.c:3167 (discriminator 1)) Thanks, Oliver. The attached dmesg doesn't say much. My guess is the oom reaper jumped in between mmap_read_unlock(mm); /* * Set MMF_OOM_SKIP to hide this task from the oom killer/reaper * because the memory has been already freed. */ set_bit(MMF_OOM_SKIP, &mm->flags); mmap_write_lock(mm); It seems to me we need to hold the lock for write all the time. But there is probably a reason we didn't do it in the first place.