From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AD0BECAAD6 for ; Fri, 26 Aug 2022 17:28:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38CC6940007; Fri, 26 Aug 2022 13:28:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 312286B0074; Fri, 26 Aug 2022 13:28:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B33E940007; Fri, 26 Aug 2022 13:28:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 044436B0073 for ; Fri, 26 Aug 2022 13:28:31 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CD3261206A9 for ; Fri, 26 Aug 2022 17:28:30 +0000 (UTC) X-FDA: 79842427980.14.C7368C3 Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by imf26.hostedemail.com (Postfix) with ESMTP id 53F3314002E for ; Fri, 26 Aug 2022 17:28:30 +0000 (UTC) Received: by mail-ua1-f53.google.com with SMTP id e3so792685uax.4 for ; Fri, 26 Aug 2022 10:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=eovn363mZL025IZg0sVsfbPl1ZxCNrATH27pBIPe1s8=; b=lGM/xCV0GxHuZxm3LYK6PbtDUaMsJvLGuo4cnTOulAR9HXGVQyxPmwtE5vhzb+LRJA Q3kY3KYV1EAsyfRLKG/GJ40+YPZn4WusKvsQq/Z4TtWBwOaV+yZyBPF1lqiKe9xmUN6k r5AKoz2xsKztWbH2V1cZd9zdo4tzGTkaU/hclpRAzmZNf2xjxrUtziD8knXgfVCm0/Bg Egu3zJ9Xuedxkp8eywKSuzXp0o49pB8RyhhCNqgdQLXzXKkxl/EtuRTdihxrMYfZ71Xx jszCJZm71XbwUI3j0uYSjOXKfsfWpolhNKj6pFxZVRHLgd7BohXlJBK2HWzfLU7w/NKm 1qMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=eovn363mZL025IZg0sVsfbPl1ZxCNrATH27pBIPe1s8=; b=wdHOXkJJ8nw8cB68CJwJUv3SNTXwANU0Wmi450VYIkO9GRdcJboMNJ5SpUzwwlRozW 57SA9LRCIZqrnij8L9iY5l8SwKYA8+1wBiyJYCNrNdCRgKFquhfFmVMZkzzrClrK4Sm7 rHv3J0bk1+FePr8SpINl/5Dmb4evQMpMnHf5whggEDt/PCxKFq3AvL0DM4C/PRSFoUjE jgrG8UDkHKRkrpcXg2Ht3WcQvqp5O8fpDBaqAPpDz6ziJwW9+U0jdTk64fcPOuqd+WqV qo5DtRdiCsGLmTJD8bntbESrfpjoPeG1eWGdN56TVP/wRHdX30UWctMou5A9K/pBnkUk N/EQ== X-Gm-Message-State: ACgBeo23g927BxzPJToshzkC2bJpNQDQZGC7m3uBvD7KQSnZ1SFA7/fY C5FLcVdcFJ9yzxmqC8J5tBcvx4IPwMvFZR0e7vhwUg== X-Google-Smtp-Source: AA6agR5f9YsNSYUT7kg5AobOejexSwaLOgFDsrEn/1HzJuEJaM7P73mVjYj+/5y8zuscYrlTtVBCmgYXGcS+1BVZu8U= X-Received: by 2002:a05:6130:97:b0:39f:48e0:5cf3 with SMTP id x23-20020a056130009700b0039f48e05cf3mr311091uaf.70.1661534909476; Fri, 26 Aug 2022 10:28:29 -0700 (PDT) MIME-Version: 1.0 References: <485f8c33.2471b.182d5726afb.Coremail.hantianshuo@iie.ac.cn> In-Reply-To: From: Yu Zhao Date: Fri, 26 Aug 2022 11:27:53 -0600 Message-ID: Subject: Re: (resend)WARNING: trying to isolate tail page in isolate_lru_page To: Matthew Wilcox Cc: "Yin, Fengwei" , Yang Shi , Minchan Kim , Andrew Morton , Linux-MM , =?UTF-8?B?6Z+p5aSp56GV?= , mawupeng Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661534910; a=rsa-sha256; cv=none; b=r0wd1TqlTdH3R6njc9ZCzlPv77/F4WRYCt5YH33QCrlpxIW8gZechb8Re/UM6o4XPzTwNX R9XX8Hutu9VhysrxXoOVP9yvZT5wCMA8Cw0MNYQHm5KV3a/RXd9zQ546v4A2SganFoQPgP 6eaG69J2ox2pGRHdLPJYaEpXc1msX+k= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="lGM/xCV0"; spf=pass (imf26.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661534910; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eovn363mZL025IZg0sVsfbPl1ZxCNrATH27pBIPe1s8=; b=PvfoLOkcQiIwKTzry1yzOoOS4htt1AmnTYneAagRBhHtYjoF2WYzLOa1Kt1VQdNvs+gpsV jEHlSJ4k9DwqZd2ULYHEvFadaLZMF7rErN447sYzLX5QITbCesMWr3V/oAWpmGbKTAF/zO l+eOEpNc5mJUcCgQ/1ccif34FakwmHE= X-Stat-Signature: 4jobswifppx5xu9bftik7uhwjtasa79b X-Rspamd-Queue-Id: 53F3314002E Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="lGM/xCV0"; spf=pass (imf26.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1661534910-75212 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 26, 2022 at 11:15 AM Matthew Wilcox wrote: > > On Fri, Aug 26, 2022 at 11:20:58AM +0800, Yin, Fengwei wrote: > > On 8/26/2022 2:46 AM, Matthew Wilcox wrote: > > > There's a number of ways of solving this. I'm interested in seeing > > > which one Minchan thinks is best. > > > > My understanding is: > > PageTransCompound() return false for compound page if THP is disabled > > in kernel config. Replacing PageTransCompound() with PageCompound() > > could work here. But for the long term, folio should be the answer. :). > > Yes, ultimately, isolate_lru_page() is going away as an interface > and one will have to call folio_isolate_lru(). But should > madvise_cold_or_pageout_pte_range() even be getting called for VMAs > which are mmaps of af_packet? can_madv_lru_vma() rules out a number > of different types of VMA; should it also be ruling out af_packet VMAs? Agreed. > If so, how? We should add a reliable helper to tell whether a file VMA is reclaimable or not. I don't think we have one. Currently MGLRU checks mapping->a_ops->read_folio for file VMAs to determine whether they are reclaimable.