From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D6A5E7716A for ; Sat, 14 Dec 2024 18:30:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 279476B007B; Sat, 14 Dec 2024 13:30:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 229896B0083; Sat, 14 Dec 2024 13:30:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CA4B6B0085; Sat, 14 Dec 2024 13:30:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E21E46B007B for ; Sat, 14 Dec 2024 13:30:21 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 98B731C6B07 for ; Sat, 14 Dec 2024 18:30:16 +0000 (UTC) X-FDA: 82894403592.10.708D12C Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by imf12.hostedemail.com (Postfix) with ESMTP id F156B40017 for ; Sat, 14 Dec 2024 18:30:02 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Pr3MenOm; spf=pass (imf12.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734200986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cfqxcq4wpnphymnU6ypxtGC8QErPdjcXWjyPVc+zgoc=; b=apQbfspa8/sR+/TCqVFfcbIMCnbhXs+a86EYYvNb4mFw7KNjT1wDXKxWaiZ/KRzCVcVD8E HuGDhkIyC2sclvotxx+GWcKPmzESE/LTTkaj7+lvi2aea7+wbK8Avf9X7o9L503Fzg1c4Q 7W8rgxVOCnKLHgcSd4oB002UyjPfNfs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Pr3MenOm; spf=pass (imf12.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734200986; a=rsa-sha256; cv=none; b=D3RMk/QagJ3jlrM99wGGojmYRnNbAQI35OVOzHThQSQRXwXt+2xO8IzcJMUoVXE20T5whz CSxp7qyRiOmdbvSx3vYGYoElx98Sbh6m6MroGbn9ZLWUv/LNnzANFWnK3PSQBSpkNnMc3i SMDOsoLnwcfL4X1dtD12Z7d8Su1tvMA= Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-4affd0fb6adso718221137.1 for ; Sat, 14 Dec 2024 10:30:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734201014; x=1734805814; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cfqxcq4wpnphymnU6ypxtGC8QErPdjcXWjyPVc+zgoc=; b=Pr3MenOmkspkJH0Wtq19AsBunM3Rd+yIdbJUGr+JslgykShKeGYTkQ7R1TKkRB4JPC QNs8XemZYLQZuTbSnMHEHmCho0uyWhadJK/nYJmEkdeMiQyqc70J1ZBHqeopWMLTmQ6Z NqQXw6hcZjgdWcv3QG+DhywoRplp9YkyBAjJCEGrSX8BCwH4i3aOaadJtB4D2ty0qCyz As2Jh1bteC51mo5goxcmqRfwYZ8zBkYcgg/kmcVWSEA6xZWPJAO/3SsPlQwTbHM6Z6lq CrjvOrko/nlBT5hOyDjfYKf9vpAFjhh0+WXiyC+/vJmdD+5DBlCz/J6IKY4Uu0EDjaSd E35g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734201014; x=1734805814; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cfqxcq4wpnphymnU6ypxtGC8QErPdjcXWjyPVc+zgoc=; b=UEYG4Bm/Ggw4rQc+5KlET8CInwI2KN/wOll4PiRcPrUcV86G9iw97nUASaoFfDJzK0 U5MUjYy6lHmjVyIAVcCp6JskcwVsV4702tVebOFbeb4CT0+CBwSjsXZgU4ddDYT3cNp9 yVbyDE5rj65ik65iwOubD1rWz589DjfGdruZNn9TaC74qqgpWQImjlgQ7oulvimLSj53 9hc9/4EqCgL/jvgu+REqFM/zl6l8ym0Z8/4i/gqH4PZJT9zHVuP4usKJ4SKIUgGHZVZ/ igLhNyZTOtHsqllu8Sm71ZvBtt8G+wHIh6B8HfLOJUsZHW/++ycY1irmM9bIAolgC5VA dHsQ== X-Forwarded-Encrypted: i=1; AJvYcCUx9tHaZUpiqRWj8dzCz8Z6fdwvmxWaoO1JqJPNsuq3PkifPo+VAOvz7FWqQmmtWD/GGkm7OnBD+g==@kvack.org X-Gm-Message-State: AOJu0YyegaNDRVmmPEL9gxqTqpd7uOHCs/MyguyT6WjysN7DNoDHpodr +ghlKes6SowEthi6w6L4OXpUWiZEKxmXLde03nZuJdNaL5l+wPn9es04q2L98mcqdItm95Pm2iM 8KMtnBiCMB15piWazjdpegca9MXcbhGBPrxUq X-Gm-Gg: ASbGncvZMPXGWnaNR4Gz97nlFjx9rFu8dZzraH1IGFuJlFkHWaEyuhNoL0xakhQE9Qo yED6XGcfNH1gduMaozV4qP4m8oyy3Pzmgk8HKe7oliiW8U2D2z3j9Odpbpa+ttD1B1zDxJ4E= X-Google-Smtp-Source: AGHT+IERxcx+NGxGXAki+JjzuiZT8JRqTo75tQfQ8B0V4mn4vI3F5BUmfMlrnmFYVn/5gYY3jQjt28miU+4deXcTdtM= X-Received: by 2002:a05:6102:c90:b0:4af:c58f:4550 with SMTP id ada2fe7eead31-4b25d986cafmr8543738137.7.1734201012332; Sat, 14 Dec 2024 10:30:12 -0800 (PST) MIME-Version: 1.0 References: <1fdb3ee32e6958ad82229941b2213ef76b7c4705.1734164094.git.zhengqi.arch@bytedance.com> In-Reply-To: <1fdb3ee32e6958ad82229941b2213ef76b7c4705.1734164094.git.zhengqi.arch@bytedance.com> From: Yu Zhao Date: Sat, 14 Dec 2024 11:29:35 -0700 Message-ID: Subject: Re: [PATCH 01/12] Revert "mm: pgtable: make ptlock be freed by RCU" To: Qi Zheng Cc: peterz@infradead.org, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F156B40017 X-Rspam-User: X-Stat-Signature: fkqxu6wmk4ekc8qrncm3m5186io35zud X-HE-Tag: 1734201002-281600 X-HE-Meta: U2FsdGVkX19cYRp7WRko/3aorbURdRAQ2mEKYllZyCcKq2bw7Ab3yeAnYf+F+izEN6hF26Hds8NpFIGg19hXfhJscDE4tJhyuR/3+mWyx+pCRHdngvqrp3F4QEMXHU13hwCo5QnDnXoetByqpUO5DCeZK+Eigo+GnHf0Cd7G9eNiPmsQI0oJ8K53/fV/Tdm1N13q7CuZGnlbrWeEcZCBOGoLHHSC4V+Qh7kDAuzs2q9N2n+6D60RW1H/a/Q/2feCkAHvAoFg6fD4cilgJex5MU8YLQRWy7xkzbDBtQhz3S0wjBk0r/tckUTM6pkKxyv74ub/u+rSA0gkei6r8amOAoWvezo6JaexMKQIHEKwQtIyBEYAihQGYA2IEA9SS43qbAIqnAQLb9EkmvvLD7tntg0BzcJwHx8kQdH43ZGgzIRSCRKoRfezadN9VRLSHfdxTAVWdf9Hj/Ud1QKljJNsU8YscfcOQiW+qCaYHWFwfsIgJ/TBtL7l46oV2gz7+z575HgGlwhUxjXYx12zjfgz7FIar4MHYx0QySzhnz+4sz4QG3adqJawZqbfOz/vnlUvXWv9+ijz+51x2beYcTL3OFxFy7aQ2jOdYDcYZE3+Y9jdAhsO8LZ4WafUNuIodEuV+/owqtWCMROVfRIvFurXGdO6cB2W1TvxdnkyfOPFr6ivmDzYyL9tX5FzhinvuRJfjMKrmV2MYUPvMceTz7Fad7GDW66IjAG14XPfeT26qccqHqv4toNc4wqM89QExfeBIModT7f1vZ0LdonvtGwcyS8aTizBMSDUPuhOYAQXHwCmCHqb6BewdKYxdAlYAEvPKFl3DNFbak/O8ZFcejscdspc8bfPXl87GWnJWvbP4Z/ReDiviGevq81uBJ5qQyAutbZC0oLpdLGPD8jKyxDBDl8XK/T5FLAJBRHhLJKgV2lF9NdO83L8iFkZrp+mjp00vP/CAOEgveQZkvc+tZz G5Tmz/m+ EBQ+1V0mRR9fYtrWyGVcZi7+jNpRFKriYTymhJhQrjeqfiCy4z3MHSrHRsw8rIxb6PvlSXA/d4dhf8V2UMlSbEPmxkGbt3jOdja1u4HKWCAYkGQ8FCiWCOKibZMXGdHjTDhjhh/SW7Vzk49k3O7rUBhyrwca32ZGaqdAGn/OAh0hN/F497cMQbf+ioDjYCZe9WA/LBaRFpjNxujxTN5sKU/q4nzKx+sQ4B2RfVplcjHrHh9FMPiA6wy0aug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.054847, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 14, 2024 at 2:03=E2=80=AFAM Qi Zheng wrote: > > This reverts commit 2f3443770437e49abc39af26962d293851cbab6d. > > Signed-off-by: Qi Zheng Bloating struct pt_lock is unnecessary. Glad to see it's reverted. Acked-by: Yu Zhao > --- > include/linux/mm.h | 2 +- > include/linux/mm_types.h | 9 +-------- > mm/memory.c | 22 ++++++---------------- > 3 files changed, 8 insertions(+), 25 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index e7902980439cc..5e73e53c34e9e 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2988,7 +2988,7 @@ void ptlock_free(struct ptdesc *ptdesc); > > static inline spinlock_t *ptlock_ptr(struct ptdesc *ptdesc) > { > - return &(ptdesc->ptl->ptl); > + return ptdesc->ptl; > } > #else /* ALLOC_SPLIT_PTLOCKS */ > static inline void ptlock_cache_init(void) > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index df8f5152644ec..5d8779997266e 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -434,13 +434,6 @@ FOLIO_MATCH(flags, _flags_2a); > FOLIO_MATCH(compound_head, _head_2a); > #undef FOLIO_MATCH > > -#if ALLOC_SPLIT_PTLOCKS > -struct pt_lock { > - spinlock_t ptl; > - struct rcu_head rcu; > -}; > -#endif > - > /** > * struct ptdesc - Memory descriptor for page tables. > * @__page_flags: Same as page flags. Powerpc only. > @@ -485,7 +478,7 @@ struct ptdesc { > union { > unsigned long _pt_pad_2; > #if ALLOC_SPLIT_PTLOCKS > - struct pt_lock *ptl; > + spinlock_t *ptl; > #else > spinlock_t ptl; > #endif > diff --git a/mm/memory.c b/mm/memory.c > index d9af83dd86bbf..83765632e20b0 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -7041,34 +7041,24 @@ static struct kmem_cache *page_ptl_cachep; > > void __init ptlock_cache_init(void) > { > - page_ptl_cachep =3D kmem_cache_create("page->ptl", sizeof(struct = pt_lock), 0, > + page_ptl_cachep =3D kmem_cache_create("page->ptl", sizeof(spinloc= k_t), 0, > SLAB_PANIC, NULL); > } > > bool ptlock_alloc(struct ptdesc *ptdesc) > { > - struct pt_lock *pt_lock; > + spinlock_t *ptl; > > - pt_lock =3D kmem_cache_alloc(page_ptl_cachep, GFP_KERNEL); > - if (!pt_lock) > + ptl =3D kmem_cache_alloc(page_ptl_cachep, GFP_KERNEL); > + if (!ptl) > return false; > - ptdesc->ptl =3D pt_lock; > + ptdesc->ptl =3D ptl; > return true; > } > > -static void ptlock_free_rcu(struct rcu_head *head) > -{ > - struct pt_lock *pt_lock; > - > - pt_lock =3D container_of(head, struct pt_lock, rcu); > - kmem_cache_free(page_ptl_cachep, pt_lock); > -} > - > void ptlock_free(struct ptdesc *ptdesc) > { > - struct pt_lock *pt_lock =3D ptdesc->ptl; > - > - call_rcu(&pt_lock->rcu, ptlock_free_rcu); > + kmem_cache_free(page_ptl_cachep, ptdesc->ptl); > } > #endif > > -- > 2.20.1 >