From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9821AC46CD3 for ; Wed, 20 Dec 2023 04:16:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A9408D0003; Tue, 19 Dec 2023 23:16:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3591E8D0001; Tue, 19 Dec 2023 23:16:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 247BB8D0003; Tue, 19 Dec 2023 23:16:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 150A88D0001 for ; Tue, 19 Dec 2023 23:16:49 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CF05FC03EE for ; Wed, 20 Dec 2023 04:16:48 +0000 (UTC) X-FDA: 81585885696.08.EEDCF99 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf30.hostedemail.com (Postfix) with ESMTP id 08BE08001A for ; Wed, 20 Dec 2023 04:16:46 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="OAGGLx/8"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703045807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MmFRQc3E/ET5jgrtsAbnSkKJCHzabblomSdD+OjeUsA=; b=lPWHkodckU+gW8yXz7Fn9MywFkFmWObq/WY7Pnt4tT9Y7Yd5a7di2g26/gSs/ftIy9xFIw S9MdwVPztuGZDBr4bWOOBNpkKUEUNW8RDjt9YilZe69B23KUYdN4CDubLSnoRNX18HUt8F L7138f+EaRfXLmwV+PYorNflXjBOM/k= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="OAGGLx/8"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703045807; a=rsa-sha256; cv=none; b=zdd+umRAzkQJrz8a9+H1WDl/qAlmDVwwH0HEBZIxQ5kaXVV/5dqYRc6djq9ucW9GDR5ZiK I+cdgtqXwaBYX+epCfmZna0A6BJwaLvW0HIo4waWl0aL0LgSgeAvCj7t6o9bn4XZDtObvh +3xObJamlj4sxjqInNGsfXfOVekN5YA= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-40c32bea30dso28945e9.0 for ; Tue, 19 Dec 2023 20:16:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703045805; x=1703650605; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MmFRQc3E/ET5jgrtsAbnSkKJCHzabblomSdD+OjeUsA=; b=OAGGLx/8cEYiVYPLYyXVmGhkVeVECi5l0NC+QiAX5vcuCb0mICQ2acOtWvj5dx+DJN vT92xquTc2+k/GtOhdj7dMPyWOp4pcCSrGh3cHP/jZ+F+rUtdKLB+e8BzyLnve54D+Uo OFaL8fwpjCptbI70QH2pU3SbnSskDaxSfZbWqiqxNmEEJmFHzMdLQG3/jvA1kLzeWBFW 4iLCr22jv4OC4Aby6nGao6pyDz6CHle6woOy0EbG2x8YKvTdnpdz/ELo804v9ix9aLbz riSjw2oEFMPZR+09jbR9zPtoelsgWX4I3VJeKz4wmKbVabvRw92FQXbDcKQ8F92XZ8XU YkYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703045805; x=1703650605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MmFRQc3E/ET5jgrtsAbnSkKJCHzabblomSdD+OjeUsA=; b=e0LAM8IMdmqPxgizFsHyRA5SZs50KG1V3zVQr0ww0kwbec6yS0A6Zq5AgclEGAXCIs Jx2Q2tC+iRjACY20H3vSx9tSMeqDNR/Jq2BVw9jyghsC6Lg4nRiFc7vbbK06QOMU82zg 1WHw3yUK3ZkJgFfGi7LIFPNfPIjZ3wEx0YaQgqyO/EE5WfAXJ+/VYaNC45nH0/fKHbim J8s373smIGphsIPH98U7BbiqkvqdVdgv+XraIRIZnKUgxfed6LCGkWrAiXod8E5i8qNc HYQpB0zzXJv/3hZyrf8+eEfdJggSG05+3SVAU28H6VzKbNAacEFjT4MawNqNaEffjyHt PG+g== X-Gm-Message-State: AOJu0YweKmgbWVjOASgZv+/4nugkQyDEHM6zWIbdL9uCt2CnDFJlPjZE 0L8HPrwZt5eAadoqAtQZuyCEndT3Fg/dcppQ0V3Z4RPwmn1G X-Google-Smtp-Source: AGHT+IGQhTJJNWiY6fC30Ah4lqY817BxZMdpoi/AqZs6g+A6xMaTvYnmKr2LGf7gdQiYuL0SNjka8oaTlYu/MjAMkwo= X-Received: by 2002:a05:600c:1c9a:b0:40d:2bc7:e9b with SMTP id k26-20020a05600c1c9a00b0040d2bc70e9bmr91376wms.4.1703045805256; Tue, 19 Dec 2023 20:16:45 -0800 (PST) MIME-Version: 1.0 References: <20231220040037.883811-1-kinseyho@google.com> In-Reply-To: <20231220040037.883811-1-kinseyho@google.com> From: Yu Zhao Date: Tue, 19 Dec 2023 21:16:06 -0700 Message-ID: Subject: Re: [PATCH mm-unstable v3 0/4] mm/mglru: Kconfig cleanup To: Kinsey Ho , Donet Tom Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 08BE08001A X-Stat-Signature: y3xei1qk8tieiofshsjhzwz5ti4diux9 X-HE-Tag: 1703045806-300047 X-HE-Meta: U2FsdGVkX19LOkO0s4FIDDWSYnEEYLuGydUqdMvP+NP1U5fvkSeAu/eAdHqbRt8+hhJHW5u2VLAQBH6qxkrrnP3/XbRKcYTLS2rBzA91neOgzgKN9XUrs8QBWsErELq2DKWSbSA8qSRErH1nVPivRHH9N8EybZ/yO8FScB84X8VKFe+UA2OOQe/p7sDE953NGJ3k7I937WAg5GMx9WAFsTja0aWRgU/pVkf4U/hBmDoow4Fp9nS7r0SoJTFCOM7HyfeUEjIZkEnl6TNVYd/nY5EP88zn9F0sXI2wL306e9dTsC6fx0Ok6yo47j1Ys3GHJpZXP4dnq9w8nmFziU3kyDkpJj0h8iyrKZxCVIOSvMnwV03xSWH8CaUgnbIWNxIgGLDUeSAdWKhyE3+jxNBov+Jdkco7A6UZfh8WAWNrcatdKDJHo2Lr4+4NF3TwmihhzmsXq4kglGBWLacbAp2sRQd0G37SAOzfLWGJl5EoTfmjjBZKY1SUEU76o/f93RKWorJhIrvnV89RjQl8br3YB7ulqrBJsRVBTKGrTISD2eDqAeQnZTD7WZg/qEKy4M5Plg0tLWwp6udve1XOlY/D5PmM5KSujMZuIV8xclJ5BFrBp1HxwiJcSJeW3kKRnsasJvfbAeSYGOh81Sp1iFPuYR9nvT49/N8aLQmkERhmAvy0Um3s91KkNvI1G8rvH3qWkbVrdGEozdnYAduiwmNUNLDChvMm7cumhr7xhXO5j90r9kOoDc7D+a334NzhD/3yvUGJhtTkLOZ/uL5Dx4g8QRkllIbfzalPvC0a34+0Dt7yoUIOxQKCOsTpRD6xmaf9PBrRJYCbMSD2vesUbe2CdsyI4wp+463lBKcz0NbKG2lf8uLUYismnVXvCTcgM6W3rjofPPoL/9fmnRHQ1sq4dP14c2RZRPHP30lvm+cM+VMos6tD1Ku6APsWrruk7okJyBLGvbGfHd2RzXwZWb8 i3D3xMAh C25GepgUuroEbIcP7nSu0EiH+fiLvD8IPTF9wD4NUcttQ0vUdRml+9kM+AnbOmx9+FMAgC9ITwptsi7iU4rVMN6VhmyEAxvzfeMm/LVW/jjW9DuFBBvz+ThENhlfuJtc2ewc1lAzD+pkIqICECZatXkUKWUEGBniNcIT51JoeCxtbliALLu1DVjVuRyeLlNnkxBCGvaut4O2+DkQ3q2MGXPGki+iDJiUL45QBrFCCm9gPp1woG16TSQqhnylRh/ht6HqZd7Eleq8c8ru9NpvxGAtyrxF72mQ6+10AudrF7rCxIS8Mubx+m7Q1vWFBTl5az+y64lef45HBWUU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 19, 2023 at 9:01=E2=80=AFPM Kinsey Ho wro= te: > > This series is the result of the following discussion: > https://lore.kernel.org/47066176-bd93-55dd-c2fa-002299d9e034@linux.ibm.co= m/ > > It mainly avoids building the code that walks page tables on CPUs that > use it, i.e., those don't support hardware accessed bit. Specifically, > it introduces a new Kconfig to guard some of functions added by > commit bd74fdaea146 ("mm: multi-gen LRU: support page table walks") > on CPUs like POWER9, on which the series was tested. > > > Kinsey Ho (4): > mm/mglru: add CONFIG_ARCH_HAS_HW_PTE_YOUNG > mm/mglru: add CONFIG_LRU_GEN_WALKS_MMU > mm/mglru: remove CONFIG_MEMCG > mm/mglru: remove CONFIG_TRANSPARENT_HUGEPAGE > > arch/Kconfig | 8 + > arch/arm64/Kconfig | 1 + > arch/x86/Kconfig | 1 + > arch/x86/include/asm/pgtable.h | 6 - > include/linux/memcontrol.h | 2 +- > include/linux/mm_types.h | 16 +- > include/linux/mmzone.h | 28 +--- > include/linux/pgtable.h | 2 +- > kernel/fork.c | 2 +- > mm/Kconfig | 4 + > mm/vmscan.c | 271 ++++++++++++++++++--------------- > 11 files changed, 174 insertions(+), 167 deletions(-) +Donet Tom who is also working on this. Donet, could try this latest version instead? If it works well as the old one you've been using, can you please provide your Tested-by tag? Thanks.