From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BFA1C3600D for ; Tue, 25 Mar 2025 20:36:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2004280012; Tue, 25 Mar 2025 16:36:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED093280005; Tue, 25 Mar 2025 16:36:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D982E280012; Tue, 25 Mar 2025 16:36:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B90D9280005 for ; Tue, 25 Mar 2025 16:36:33 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 31E0CABEC0 for ; Tue, 25 Mar 2025 20:36:34 +0000 (UTC) X-FDA: 83261231508.11.61AE2D1 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf06.hostedemail.com (Postfix) with ESMTP id 2823B180003 for ; Tue, 25 Mar 2025 20:36:31 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Wot24R6C; spf=pass (imf06.hostedemail.com: domain of yuzhao@google.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742934992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I6fba/3YoYFkl+HOqtrwLDY2LW1/t6JXRquo5TnWLac=; b=gqf0KDgNuLR8yI2TT8wRxo4YnBaNAfoI7bYNUHeDL1zlWwuSrD5+pynTKLvmHxtZjrpe1t HtOvmPuBZVAzYEVn+ydH3sw3AXA/YJVOZFsTzh5XsqdhcfNMWY119+8Ihp8g1XTdfAArmk n8zE6u4MYJ3lUh/Eg4syA9W6ElXJhNs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Wot24R6C; spf=pass (imf06.hostedemail.com: domain of yuzhao@google.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742934992; a=rsa-sha256; cv=none; b=JQfqkJlYLKInepRdmFVtHusOXAGuQhKDalkS8Har4uL6SHEq1n4e2e8k0r1az836WhGnJC HPzbDbhKel1ZHPbSjJNHDuqYrhp4ORg4AqlEqUBz9m0b8RGA0Ge3QLgf+4H06ILu62XTUU sZhoEw8C+TFWQvIGTmCQ1po0H1yNdyE= Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-ac29fd22163so1024599966b.3 for ; Tue, 25 Mar 2025 13:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1742934990; x=1743539790; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I6fba/3YoYFkl+HOqtrwLDY2LW1/t6JXRquo5TnWLac=; b=Wot24R6C+zp4SjT1mmULcupoWk31SABXFhx+6i7n58AA3fnH2QCJWThgI6z2EqS6K3 axIj93Jq6pgbjwQTfFeo5TRmIyIQHa1zD7PKU5dtlPGaR5medsvDNgjWbPUuDjqqXccf oocaSXACezWPFBN4Fc9U0INRMNT6GxCz23jxizYbT9m98JNz+Nnp4KtRzDD1neqdJgNQ tAbxMj43K3K7S54/fqYk1GHkQKvcYVlv+B7pio+w5dRkYIilUDnc4rfLmU4obxE8BQHY CSCdnEiK2I+OJd3E8MQTMXCg/VkenzdFt+OUxxZQKxV07hzM0FH8y9KUWHaTrd/y3C/o uryA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742934990; x=1743539790; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I6fba/3YoYFkl+HOqtrwLDY2LW1/t6JXRquo5TnWLac=; b=Ak71t1HsiGWz5+eFICAVTx2vj1nVVWtqf8NrkT4YM6svDJTOzcuDGXMskhuoPURbb3 YUnHphv3+T8wk9jG4tdxsOtmj74Y6NEGTyDMTH1lR9eu/1CLA4uqqq0qfSQFC0XB3PSu 3WLnOCaNlkz2SvrLVBdc+JMRvUKe/moLF3EnOQs+uhExUGW61ukgps+K8F74vWy3ZwMw JXyYoq4h18dhqY80ftUZcIAqFQuDqoLeveh5NE+y/cCU+1YvLOouaKMQ5NGTBb4Lz1A+ F1/L0PYd1c3e+P+9DD8dGBvqji5p1QTiq0kJeQyGeVJb8fxI1ocORBzo6qoAhfaOdisy te1g== X-Forwarded-Encrypted: i=1; AJvYcCXtkV8YaZc4KBafn6L0ak881qoDi1c3Y3t49L+jqEOBfz9ws74b8/i0hoHcSFyfyg9L5YCwwTjgsg==@kvack.org X-Gm-Message-State: AOJu0YxoI9BYIdQ0cJwMwieRofSweKq8P+EDHMugyOnBXArDJLucEKCI HaIa83HH9yfkf5ijw48QBvFO2fNadxIpgbJ/rAbDYS61pJP7e4lxBtOSlWrs3ZKbFwV6RAk7l5s mARR97cHsi206OXbTxgNSze3bCVjv2RZdAE7E X-Gm-Gg: ASbGncvWFgOxLo+tgy/Wha0JS3QFWvyzXZBwKaZaYMSIjMYfj8v1KbRE6RmEei0QRUq uVEowwwg6BCmStkgmd96nTxv8oeP08hyVwajAJimzWyFlsBM+P7QRJD91QjyUbR4VF+cnng6pR8 hjFP8v6gdwjN8yAAcAwg6DfNvzih4atj27zOjuvdgu4prw5tQIr04JxXCOkzK4tkwFSGI9fQ== X-Google-Smtp-Source: AGHT+IGFvRQOs5e6tUN234mIXeawiwHxPK6Z4AdAsFuigZXP8TTEwbaXQLCOEb1Qg9E6FEO2+4xwzhkAdrmPe+ywrrk= X-Received: by 2002:a17:907:c810:b0:abf:4bde:51b1 with SMTP id a640c23a62f3a-ac3f210b1cbmr1701123566b.21.1742934990366; Tue, 25 Mar 2025 13:36:30 -0700 (PDT) MIME-Version: 1.0 References: <20250325194920.53307-1-purvayeshi550@gmail.com> In-Reply-To: <20250325194920.53307-1-purvayeshi550@gmail.com> From: Yu Zhao Date: Tue, 25 Mar 2025 14:35:53 -0600 X-Gm-Features: AQ5f1JrLRO0dClwYTbtpc5rcUSGdAUBn4FLBcxtBoy2i32laiGK3-8lpa7tKxP8 Message-ID: Subject: Re: [PATCH] mm/vmscan: Initialize dirty to prevent uninitialized use To: Purva Yeshi Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2823B180003 X-Stat-Signature: 36rwio8pa57rngkzfmz1qy5gpq1bwnec X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1742934991-108792 X-HE-Meta: U2FsdGVkX19yybWV8PMtkFMzOJEmxceJsRXqtuj74KVAqFIsav1g600ijmetvJOmFR7ML9oeHHSlyEwXk/NjehFQwz7LsW0ik+FbjNRvahdb7VAeqaXDuQ8toXzBcP7vgw72XpvOCG1bZR3cdwAv+YTWj5o8SR8KNzN/L3E4i8Wvl9BdmA7EkDLtYLAalYdTIDfV8uh81XEnLiZiaj20YGsCZjYiKWh7PmmS7Nf5k2h74+XL8hBo3qO+OEGFIzCWjEpfN6SHingoKE/68BqX1le7fj/VY5GLO+WEWQ7Mx1+GmXokB/5lpeUMe8/eMovY9CUr0qB6N8NNKpI0Ggbn5ht2DmpQlLouFt4XryT2Bap8WoQyUxnwHbw3mxJFNkhJqpF4H2quPntGwEWc6Yowb8UfUwv53wbRI04/xx/DOje04QA13s3sFVtJRcbGPr5gcexqdPLvAvO83b9qikMks8XYMffEGiDJ0fft+O8voJMpOPBJfYd3LEOXAYH5qb+MbyQA51MnjmbOmBb/Qhc8x6KtL9FELRq0ak1A9FVOgscYNNkutbfbfXTRbO9rcdzXhWLKaCLyQLbskFpBQjxU+DX7HUimhUvvzrl8TrN+FsgIbm28Q1redzLw5giyaUJ3SYoXCC2VyqE/CdGkUMrb4oRMvQmnOvVEU7cFxEQzF86si53BqpdWAjNZbjoK1jD0qnovWKmc+xBVBymsbkLN7/x75O0ikmChbSgL4Qv2VG1W0bLI7WdVbZ7NV1Ks6FAbAt+s2ohGhC9kUKn7IBl5Vgvv+H6tdcBsJJIzvauaYUhbMTDgkeNLO0B0cvqNzXvtOjmvQ8TeGHYHZVu+SfKJgqvEdwxxZ/TaXkCBt60mIf8xGC1ndizQHqcyxWtGJeVfQHivZymfGrR54Wc/UN6YvkhmKbPJkhU22Fhhk5cC99j4nwtKpmZjEH8PohutSvLFU2UKKhGoOphFAXCLAt9 tZ0xRFuR KlAcep5YAtC+wWLMHvNXuyySdmnJQasYRQS74mV2XMWzWQPNv2c2Eu7/PVxe0xeVZ628h1sfRIy6VRv/URCQuOfi9F0OA0NrIHaG5K9tfw3l29F3gcLmbLRWGhTI/8dU+JKuvknrSjX7Q74QDghm4qbLzcuDvrt86xVlGxgVVLm/fJovzUBE/+PEYvQhN+KdKgViDjw+vByPoBGYf+/XjdyAcNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 25, 2025 at 1:49=E2=80=AFPM Purva Yeshi wrote: > > Fix Smatch-detected error: > mm/vmscan.c:3509 walk_pte_range() error: uninitialized symbol 'dirty'. > mm/vmscan.c:3522 walk_pte_range() error: uninitialized symbol 'dirty'. > mm/vmscan.c:3600 walk_pmd_range_locked() error: uninitialized symbol 'dir= ty'. > mm/vmscan.c:3614 walk_pmd_range_locked() error: uninitialized symbol 'dir= ty'. > mm/vmscan.c:4220 lru_gen_look_around() error: uninitialized symbol 'dirty= '. > mm/vmscan.c:4232 lru_gen_look_around() error: uninitialized symbol 'dirty= '. > > Smatch reports 'dirty' as uninitialized, leading to potential > undefined behavior. Thanks -- this seems like false positives from Smatch, where the problem should be fixed. > Explicitly initialize dirty to 0 in walk_pte_range(), > walk_pmd_range_locked(), and lru_gen_look_around() in mm/vmscan.c > to fix Smatch error. > > Signed-off-by: Purva Yeshi