From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85448C433FE for ; Thu, 20 Oct 2022 17:30:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7E068E0002; Thu, 20 Oct 2022 13:30:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D057B8E0001; Thu, 20 Oct 2022 13:30:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCD5D8E0002; Thu, 20 Oct 2022 13:30:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A99C58E0001 for ; Thu, 20 Oct 2022 13:30:06 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3E71C1C6C34 for ; Thu, 20 Oct 2022 17:30:06 +0000 (UTC) X-FDA: 80042016012.12.AF841F3 Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com [209.85.222.45]) by imf13.hostedemail.com (Postfix) with ESMTP id C24952003F for ; Thu, 20 Oct 2022 17:30:05 +0000 (UTC) Received: by mail-ua1-f45.google.com with SMTP id t26so10537uaj.9 for ; Thu, 20 Oct 2022 10:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/3I182d8OS7x64S+BRqz8kKKkjGoMeVc6W9/b71l3sw=; b=bhSI7PYNE96zmlTK54HcXVXMKa4MpE9a0d4dT9ZRpfu7bAo4nZ0dY8odSDsuC0n4qb A0NFcoTa7mQMvE/GIp2fGxlNaTyc1xC+mJpWpkZHWApIZlZJ3laViyURgnGhUU5MCAVQ R3aA1LAKm6EK2SR5YSOJpLv5cUBKXKHSdX9JwmOWekAiv9N1om5ege3SRcktdGKMdNHh yQxvjQIOk/8YjZxrQSoJxslmTSutFc7m1L57zkygsaoPAhvYWKzOjOUDMOzSKj1eBDTZ 3L9UfmjsSMrcHEGhKK7d6tV0FEY6U+aSuevH+4xHLmsKF38KDErViXZa+bXzVBaq/OfH BBaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/3I182d8OS7x64S+BRqz8kKKkjGoMeVc6W9/b71l3sw=; b=dS/GGZHEZF31vxzwnANT27zOFuWZloUyJIxbrN01fHbBaxc0BvI4sbDE3PcpqsSLrq zGavbm8o487zOvkTk10iFupt+klRhPRnO8FGesNlQF2Z3DuAmZV349MDkgtziTFOe3Fk U7/R7n5WtjAAoQNqHJNUaorVRjfaDtNgKg5yXb4MB7u5Lh1omugcH8Rlh9N4u4ku9qGT OB2Sj+asC5yJoEgpUbQ4cBb7YaM+9R3JfPCkJs30iTEBucfvFfEGaSx35D7q8g8MGLfh X15CgpI5WQHAeaqCameeWqHnuEjPf5pJInV+8l9gxxQydwJPuo6SFtsq2fC+uY8HlYaL cNAg== X-Gm-Message-State: ACrzQf3KO8UIrRv4W8xGL/+5xAqehYM2BTUejTyT5o5xDwLsGeNIUAxh VyFRAgVVukk//rf0wabCXc8BfounXperHkGrygpNiQ== X-Google-Smtp-Source: AMsMyM7ZtK1yZD880885vt34ACfB0CnhggaIUmZIRNZa/OsjpdJn+CuCLZLquEgbn0ZGbfEfVGjcWZp2RLOvSEDhDfQ= X-Received: by 2002:ab0:6f94:0:b0:3d1:d6e5:5de6 with SMTP id f20-20020ab06f94000000b003d1d6e55de6mr7915486uav.51.1666287004714; Thu, 20 Oct 2022 10:30:04 -0700 (PDT) MIME-Version: 1.0 References: <20220815071332.627393-1-yuzhao@google.com> <20220815071332.627393-9-yuzhao@google.com> In-Reply-To: From: Yu Zhao Date: Thu, 20 Oct 2022 11:29:28 -0600 Message-ID: Subject: Re: [PATCH v14 08/14] mm: multi-gen LRU: support page table walks To: Peter Zijlstra Cc: Linus Torvalds , Andrew Morton , Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Tejun Heo , Vlastimil Babka , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, page-reclaim@google.com, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , =?UTF-8?Q?Holger_Hoffst=C3=A4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666287005; a=rsa-sha256; cv=none; b=zO08Z879/FQlxOVzoVa1uNe3Rg0kPvi1Lijad2F7++zy+WW2cVycqqnyPY9M7qrXy+EJw6 5QqippSeQ6sO3+wIDL6z6elhI0eDubuClsaHtzxm9OReGDYL1x0bCs6Kqt/0yDEZRySvCz Cp/EoH/o17sBpvFCOadmIwVG8cKoZKE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bhSI7PYN; spf=pass (imf13.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.45 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666287005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/3I182d8OS7x64S+BRqz8kKKkjGoMeVc6W9/b71l3sw=; b=pBsyU4gjjHplFcjC1PTB/bx5R07lhuvVLGDAp0sdeTqfWIJxg2XbkyaYIw5V1WVaRRdsdY 4ip/MxzuQOWMR8mKboNiWSYCO+WOTLbjDFY85JMGNKfp/nREVgfkgAG2M+6g9F5CkNZQEq D2ZZDQYQ5eb6cmjGGqTyD8EMtobSzSs= X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bhSI7PYN; spf=pass (imf13.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.45 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: tdai97m4cxxk6p1y9bzc6pkmn6bc5jwu X-Rspamd-Queue-Id: C24952003F X-Rspamd-Server: rspam10 X-HE-Tag: 1666287005-243969 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 20, 2022 at 8:14 AM Peter Zijlstra wrote: > > On Wed, Oct 19, 2022 at 10:40:40AM -0700, Linus Torvalds wrote: > > > Because as you say, the function is already called "read_atomic", and > > it should damn well *act* that way then. > > So I've been sitting on these here patches (and never having time to > repost them), which is how I noticed in the first place: > > https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=x86/mm.pae This looks good to me. It'll help get rid of all those open-coded barrier()s and fix a couple of missing barrier()s.