From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB361C52D7D for ; Fri, 16 Aug 2024 02:51:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 633166B00C8; Thu, 15 Aug 2024 22:51:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E3536B0131; Thu, 15 Aug 2024 22:51:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AB9C6B00D4; Thu, 15 Aug 2024 22:51:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2D8DB8D002B for ; Thu, 15 Aug 2024 22:51:09 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C1F3380B8E for ; Fri, 16 Aug 2024 02:51:08 +0000 (UTC) X-FDA: 82456581816.12.895C64E Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by imf22.hostedemail.com (Postfix) with ESMTP id 1021EC000B for ; Fri, 16 Aug 2024 02:51:06 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tJUT95ZV; spf=pass (imf22.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.43 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723776594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UZ4wKjX5UNtk1yVhJjQe2lnH4gaYcg79CHV/ANC3+VI=; b=40wTO7QKjEdBZ6iYxnK5OTxL6jPVNvwQ+So6HbZYPcJXIX2XVg2EPrdfAX7e5WUYxtxu9W a/UeXGuzSG7irLyji5ZX70MCZDaNb8hOD5K/0j1s/UIoKNMArc0XnsLIakJ5DOwNNFP7wZ xffeQszy+AvrDzHJxwx2kp/H2f4VBJQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723776594; a=rsa-sha256; cv=none; b=bkWXnkEf3c6vXQdJvTSHNZdmyxNK+LXmt4Pf3cCoEAsRmQDzr7kkN5+82tuoMyZPYpX1xX i/MzQYfvfys7LACNsTVZTMgZgJYZV27TiuQUxJzQTvx4tDn5nkDzNluELu0rk0m3As8D/M uKX4px6hRVA0w8N2nxCMhWixCSj7nkM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tJUT95ZV; spf=pass (imf22.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.43 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-4929540f38dso519770137.2 for ; Thu, 15 Aug 2024 19:51:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723776666; x=1724381466; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UZ4wKjX5UNtk1yVhJjQe2lnH4gaYcg79CHV/ANC3+VI=; b=tJUT95ZVNrw6Y4d+xXQF+LwOthEjLZ5eg5WjUB6QHUWdiNNTtQuzT5sbP2IR5Fpyrn NYBb7le7XhLYbmG9Ck/g6SOr0lrDHHhgLoqDW4aNpB4ZaZf/Cd5KDXFcVtiNMe8xfKVi E9C5FLOKxkhw2fj+fJ+f+B7bTaBSHceRFzXl0q+JyZtxqcloVtFo5DYdUhl342L5bsYk 6YjZIzSer85CpUGC28nJif3W9tZS9/9/yScdQdeVJrKXchSBsvjvCJ5vS8equo/RQgY1 VRwzTQ6wZ4LmeuLWHZswQj8ZDp887AFjXLSV9phXrLRv1A9ItGE/SwIv/YFEmX7cFDiu BuFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723776666; x=1724381466; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UZ4wKjX5UNtk1yVhJjQe2lnH4gaYcg79CHV/ANC3+VI=; b=GCjDgmFef76sgDygQhzpVNadlc/qH9WbC3I2VA9wZ5g/6jr2IOkWmPQUEXa83ACFB5 Ddcm37NHEb9HrkXBY6BoLHrTuYbkeCZimO3+XYMrvu+q/7FWS0E+M5RMU/lTrtorW+Ce VC8jyw138mmV3DFGTuumX2EHRqzyy9F1r7pONh3f58bq4mrlvv8ZxCbD6dkeU+/UxRS6 MnWYbMuay/uNVVivCPZfTyWL/UD7U6mWcXqGQfrHbY10q6+9e20/iB5iwG2SNQjZfLk+ sznwKP69JudWutLKKPCtnqNiFwdP4Ljm8GNhzYErLpmVAN3hu+jqTjhfoL/xK21Ie0Jx Gxlg== X-Forwarded-Encrypted: i=1; AJvYcCVQpLz/nXUQK7DHOKhLyZdpL/oCmAulR7Iv60cubWPb3wMbjBuY+ntyY/Z/8Yssfv6/7xl31kTx4xiu4ctHRWYmOmU= X-Gm-Message-State: AOJu0Ywmv+fDLOegvHSSOygLQMqhijxdNCd7ileZ7/HrcXCRq3QItxBX wbDzHBJ8j6dlNqk8v+vuu69qStfnMIW4GzqVw0YE6Rm4tDX1uBObjkAV7UanbJ9MFBb/MCrxBdb /jlKrv3083jyQKk4+uKHedTrdzbA0xU0V6ahPGw4Wcovh3x2fjw== X-Google-Smtp-Source: AGHT+IHqwyaAFVLD4FMxP5y+Y6lD7lVZjOIcgrTDKtU/avRO6AmG9E1BX0dgvzWK/lpcEFyoXStfLJZE6Lu7OJRibMk= X-Received: by 2002:a05:6102:c04:b0:492:9c55:aec5 with SMTP id ada2fe7eead31-4977993fe3cmr2271168137.15.1723776665944; Thu, 15 Aug 2024 19:51:05 -0700 (PDT) MIME-Version: 1.0 References: <88d411c5-6d66-4d41-ae86-e0f943e5fb91@gmail.com> <20240814230533.54938-1-21cnbao@gmail.com> <4acdf2b7-ed65-4087-9806-8f4a187b4eb5@gmail.com> <20240815163013.2522e3dd83acffe70af9cba6@linux-foundation.org> In-Reply-To: <20240815163013.2522e3dd83acffe70af9cba6@linux-foundation.org> From: Yu Zhao Date: Thu, 15 Aug 2024 20:50:28 -0600 Message-ID: Subject: Re: [PATCH v3 4/6] mm: Introduce a pageflag for partially mapped folios To: Andrew Morton Cc: Usama Arif , Barry Song <21cnbao@gmail.com>, baohua@kernel.org, cerasuolodomenico@gmail.com, corbet@lwn.net, david@redhat.com, hannes@cmpxchg.org, kernel-team@meta.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, riel@surriel.com, roman.gushchin@linux.dev, rppt@kernel.org, ryan.roberts@arm.com, shakeel.butt@linux.dev, willy@infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1021EC000B X-Stat-Signature: szud9jpu5mrgafyzs85118ckredmtd8u X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723776666-781986 X-HE-Meta: U2FsdGVkX1/cyz+FUwsb4X74rYpLnbnGaDVKBgxKKQeNgU2NLbHsTyAdSm+CaTQ2O94OFUpYBMaT59U1Sis86G651u+0syT1urk5XKj2RG9a1vk02ldYVP8o9GKWOIxKjHg3lhF+uL59wK3y2PmtoheDCtqg9pId7NRTPQEohRKvpWyOcZUwhET//jJnUj433PGGZkQUfWN9JBCFdMYKu6aq/iWNRdQN1GsAAwKMus8c7gGmRyTrGQJLIoYOCz1lpe/Xc73OdWZ05wso9ycqjtKj3opUTHkbIcBak5b5fNRcj40gTo1JD0/K9SGS2pM7XbmrSXfqIWUhykVXPL533aw//lN5j1sTqqB0e1uDgP6jpN6pzc84Dc1yKHvNZNpwka2vuc1u7+/RAXSMVMQsxRnXr5v2EKRpIStF4ztFG64bnMQ2vK9Y01FeUpZ42ST6y0XfwFk/NoCr3rd6dQ/NlBs00eADBAGPGhWBOc3prCQjPQ/mJR9SwS4WwEWS7yVYeNgAAuz3qVoTQGXnFbe5zIYRc3XI81/5vkpOW9QGYtAoElbBDmjZHQgOhva6P2Q9RUpSkKxQLu+80upOGWWgibzOtVh+Ee3zFoRdakLKKB8YWT4/UDvEa06yp393xhUtuKQ3+GVWNEa5cWSkjjSkKHTd/vm1luM9BR5YvvrdyAc2LxlazAQaHQMk6rQK29Kxd8P3mRsYfwTEwpoX4OIl1+tfko0qMRLHsqekJO6/0Fc2zjrqczNqTcCOCc6Lkjwe4CqmgfdUIHh8EpOnupdKbQJ+4u004xHgwreRKe4kkAGIzzl2cJSB5lInDzAUyCJ5YlVvlbA7BxizkEXOBDF3B7zGMsUugE+N0Fvpg7AkT5FR9SaiHKuaydtZvAvfaolV4kFjnKBeRis43HHDnvCSl5GTPT05a5L6XQMkJg2Px0pjJ6aX4r11fCyYon6fjnbwA82djo/lrZ8k97l8G/p AwiLBVFg 6HmwRktbYIe4xW3nPj5RelOuL33o4r82Quo1yxCA+sdjN0U8v2XCIERFCeyYnNaa3rQOdDIOlfOJ2rfe+y5YgcmjZ4nZg+OLgw0STz6hpojBImrVjGaZJLSCcoVwRaaE7oiCbqa0bP26fkji8LJoRXQQoPUPWoDTl88e1//tJUS05TLF9hmbAKoAEd/wmKTjoW1ifQBtU3SO6KSRwd5WrLs/a0OWsTOcQIeCt0AttkSnvAbVUOebJi65GYh5h2iH+TamM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 15, 2024 at 5:30=E2=80=AFPM Andrew Morton wrote: > > On Thu, 15 Aug 2024 16:25:09 +0100 Usama Arif wr= ote: > > > > > > > commit c627655548fa09b59849e942da4decc84fa0b0f2 > > Author: Usama Arif > > Date: Thu Aug 15 16:07:20 2024 +0100 > > > > mm: Introduce a pageflag for partially mapped folios fix > > > > Fixes the original commit by not clearing partially mapped bit > > in hugeTLB folios and fixing deferred split THP stats. > > > > ... > > > > Life is getting complicated. > > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -1758,7 +1758,6 @@ static void __update_and_free_hugetlb_folio(struc= t hstate *h, > > free_gigantic_folio(folio, huge_page_order(h)); > > } else { > > INIT_LIST_HEAD(&folio->_deferred_list); > > - folio_clear_partially_mapped(folio); > > folio_put(folio); > > } > > } > > Yu Zhao's "mm/hugetlb: use __GFP_COMP for gigantic folios" was > expecting that folio_clear_partially_mapped() to be there. > > I resolved this within > mm-hugetlb-use-__gfp_comp-for-gigantic-folios.patch thusly: > > @@ -1748,18 +1704,8 @@ static void __update_and_free_hugetlb_fo > > folio_ref_unfreeze(folio, 1); > > - /* > - * Non-gigantic pages demoted from CMA allocated gigantic pages > - * need to be given back to CMA in free_gigantic_folio. > - */ > - if (hstate_is_gigantic(h) || > - hugetlb_cma_folio(folio, huge_page_order(h))) { > - destroy_compound_gigantic_folio(folio, huge_page_order(h)= ); > - free_gigantic_folio(folio, huge_page_order(h)); > - } else { > - INIT_LIST_HEAD(&folio->_deferred_list); > - folio_put(folio); > - } > + INIT_LIST_HEAD(&folio->_deferred_list); > + hugetlb_free_folio(folio); > } > > /* > > Please check. Confirmed, thanks.