From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24918C3DA7F for ; Thu, 15 Aug 2024 18:11:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DECF6B019A; Thu, 15 Aug 2024 14:11:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 967B76B019B; Thu, 15 Aug 2024 14:11:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 808EE6B019C; Thu, 15 Aug 2024 14:11:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5DC926B019A for ; Thu, 15 Aug 2024 14:11:06 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D97CF81560 for ; Thu, 15 Aug 2024 18:11:05 +0000 (UTC) X-FDA: 82455271290.28.B6CBAD8 Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by imf28.hostedemail.com (Postfix) with ESMTP id 1A0F3C0030 for ; Thu, 15 Aug 2024 18:11:03 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WE7xcRE3; spf=pass (imf28.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723745391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ebf7Wi4TLq/FXpQ1/84J5moUBXUUd5tKcCYOOme7CHM=; b=6ROLMWttt5LBDUinHgP0QZxanXxRXa8ECvY/N3U2Z9X4gUlZuwBhInTqLPUTTyp+BDR6s3 lXit4976/ih3aZneVMhabXsOuBAZyEkfprxuT2R03myJlva2V38/fT5WKygJkMaKXiN2Rh 63EBZmZKSyUnw/wdzoG4VLEzGOeT0sY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723745391; a=rsa-sha256; cv=none; b=Qj7LLkzHZ9IZ4tN3nOk0Fpxdg5lEjSMQ48rj7pPss/kTBane+oyaVGbVMFhGU/yphWLYH9 0sR8YabsvQA/rt7kjFPZ5XFuk8qD34cRrhgbui1Kw3WXa8CYK6Z91sJfK70wxW7ggSglQq x4hh+hcsvBdZh5OyynM/UNYHml9Zplo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WE7xcRE3; spf=pass (imf28.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-4f51551695cso403648e0c.3 for ; Thu, 15 Aug 2024 11:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723745463; x=1724350263; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ebf7Wi4TLq/FXpQ1/84J5moUBXUUd5tKcCYOOme7CHM=; b=WE7xcRE3i7poZHoTaAtXSj/NZ78oXQWOiuSVFDGgtnzIt92HqBYZJNlZWEpDy2eXoA nw0Df7BWamkkNTr8lBLEbfV6HF1O/JSj1kz1NxhOhWI3UsCqZ6rSCTbJkzKS3ljx5e1R cMqI7PLwrlxGPj2DMVeeqm6Lno5/xnNgqkhIwPkctLg4ac11MyKX10OUMq2zayTi5MhN nzPGiAPyqNIQOVECHSeyq+hkqYTsbs0k4xVDES07O+H1l4EVMgnZyD0sQ4MOkNvtPul9 7G4mjQMFu2M5zQJ9D9N1tHcWDMKCiaMZB7Mftk+w795elU0ePSkRPjMpVM4pBHXOGuMG OIZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723745463; x=1724350263; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ebf7Wi4TLq/FXpQ1/84J5moUBXUUd5tKcCYOOme7CHM=; b=fgC6iphGL94yQHEgIqYc8NJx1K0OTAzOrpW/YN2UcRnMXpOfd4du7QzsMHSzauxsil H/oIgY45mFOpmqVH3d/R0r5FyhwtLpYwaxq0hX/J01KIWSzOFmvHNQPa2lcuAi1SUTNC BU14jAztaq0CZNNsFzzZb9UHgLCAvQXqjaBLXWbLiUI+uZq2TOyxeKqzBO6w6mbscRdR EQ0otPXZhUCer4nriYyxi1i95n9Hhhav6GKMC2EsEsk4y3VQ1QxVasB7EzZllQbBwGub 8gnolQrdkrBEg3BWmgJ58jYYxtDo2ij/hysXXCsSLga/Q6FSXODttqy4lOxe+2da7ivD 7jFA== X-Forwarded-Encrypted: i=1; AJvYcCWUXwPYYQB/DtjQEbdiXl7UM5VQ+rptEYBZZJSsnjHyk5+J16JnAAXPmGnRaTyqrRmeTGz1K6SMEaUx0F6ESd0qPJs= X-Gm-Message-State: AOJu0YySxYW1GkLd7DlHuoxj982q1OZE5enUljCIKE+7zD/UUMWus4th vCjLG+mEO9CQbcB/5ExyuiZFKGPSXUDJze6W9IH9QjGrc3/A7g/HygBWm/OorIVOTdJQAfLE//W IAzmsENptqQCLq2RHh1fHlgiOudHnio/TbkoN X-Google-Smtp-Source: AGHT+IHpN9FAXt4QTpC30hZU1ytH96AYrsgYeD/ZGBIq5DTLPRCONedLwVMZExKVBty/ko5WXeqLqsYVoWsfNVYe6rU= X-Received: by 2002:a05:6122:a19:b0:4f2:e9eb:951e with SMTP id 71dfb90a1353d-4fc6c9ed8b3mr711408e0c.10.1723745462903; Thu, 15 Aug 2024 11:11:02 -0700 (PDT) MIME-Version: 1.0 References: <37bbf461e81342a7b5798923b783e349@honor.com> In-Reply-To: <37bbf461e81342a7b5798923b783e349@honor.com> From: Yu Zhao Date: Thu, 15 Aug 2024 12:10:26 -0600 Message-ID: Subject: Re: [PATCH] mm: add lazyfree folio to lru tail To: gaoxu , Kalesh Singh Cc: Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Suren Baghdasaryan , Shaohua Li , yipengxiang , fengbaopeng Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1A0F3C0030 X-Stat-Signature: yhkqj3uqfcihse3aw97wi5aitxbewaxf X-HE-Tag: 1723745463-581875 X-HE-Meta: U2FsdGVkX1/G+NRszoRasI4Pc6cNqMptMnZbIdcj7klLyHO09H7qL270ef0b2/aNPAKiVb8II9Sf3Td1gGm9V4bVoRBnEFWwclm1YiROO+FqYmMIbH0CiaEsoYI3c04phKrhF4xsYcbG8pKVpGJQwBm/8lD7FdbmjgnOjEU0o3gM4SgiiMOYfFBb0tuvkNnJtmhzE+aWAcsGcWLSCspFyZ7r89qIfH6GBfU/FkTMNKqhUm+/Tt4ImyHgGCfz+ee3xBkVyJvvmfC9rQ1hgIekOLz5yDOT7DmNloPcA+HQax0NfPWS4qZ+HwpsFPKHs+Q1eCiR8gwyh53kkvSEdR9iNAQnA13iWST6fy0FXXBkNyjJHXvKsjsniIPHbhYzfCUg1mcsDqcMdvQ2PX8Qfk4+qrB6ME5m/hb4M8ZGMTa5H5WnFyDyKMRF3/I4G5mQ6SOg52zs5OeL/s1QJeSQA3jjnAWKIkjrJubp5xyOGPC42e6sfshbmaKWHlyMs1Nc8FYv1D+Qc+bMfFH7VTVcaRY+ywvuY5oCktC+Rwk/2xXzIh6OyhKYxmy8NFXLk40Faj8Vq3Cin3P4nQvoXLyU08DV8dTDXnhb3CxD0ZKVUCe4FgsQtekh9PMsMIPqip7bffhzmFMWWCkPhWPjEG6r1zgwoIOMAa3tLwzTRfYOxj4ufoctRueoEXeTJDKkTNBCLIlND5SjkyIxeoZO2t9cR1N47MyYIAZbYVS1nPS4SolMl0zaKxGFY20nhtYBErQIcWxfymchVu4ISFhYBdZlOWxteK/UEVKRwoMq6G7teSIp9LMdY45piumTBABgTwyP5nt92268O1C+C4tnznNllp4H+fHTs+dyJGn0UXuETkP+rIOihvMcvsgDpwYMIRRy2F5WqcL9v/7zWxyy/xYn5iDAHEVUeuDRWkXTgpt5gGcWK7i8kD8Xj+bEi2z94hvaZgMkJ6OOXsDd80Ty1hRUyFj E0SgjCXj 6Q9hrLAwOUzTEY4KaCeZWf/qunHYP1dPNqwBJWEHzzeD73hxj6s4BSZDWWms79niqoaLxaJ/X/gunxvxnFAu1CwrinfWpuYPnZpMeGzE7RH5Hottqbe+n+M3HKiCgYGSTFI7QYWrutV3WGHDWBTVSR6mxLFKhA3dEYYkLBFCSyw3ITCPeXk/lJHwAG2F3DbmtP7LyKHH2wwSx5PJNcgOMFbuxBZIkLx6C2aefTANKBdILFVHY87v30kDm6lZmogJmETcFeJKP4iqJ1xdtoM+xzGfrUlx8n56GUWnSJOZRDiFY3G/3sb+r46p4Ry0LgRq5mHp4ejw1QjGO7EE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000120, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 15, 2024 at 6:33=E2=80=AFAM gaoxu wrote: > > Replace lruvec_add_folio with lruvec_add_folio_tail in the lru_lazyfree_f= n: > 1. The lazy-free folio is added to the LRU_INACTIVE_FILE list. If it's > moved to the LRU tail, it allows for faster release lazy-free folio an= d > reduces the impact on file refault. > 2. When mglru is enabled, the lazy-free folio is reclaimabled and should = be > added using lru_gen_add_folio(lruvec, folio, true) instead of > lru_gen_add_folio(lruvec, folio, false) for adding to gen. > > With the change in place, workingset_refault_file is reduced by 33% in th= e > continuous startup testing of the applications in the Android system. > > Signed-off-by: gao xu > --- > mm/swap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/swap.c b/mm/swap.c > index 67786cb77..ed49643ec 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -635,7 +635,7 @@ static void lru_lazyfree_fn(struct lruvec *lruvec, st= ruct folio *folio) Please work against the latest mm-unstable. > * anonymous folios > */ > folio_clear_swapbacked(folio); > - lruvec_add_folio(lruvec, folio); > + lruvec_add_folio_tail(lruvec, folio); > > __count_vm_events(PGLAZYFREE, nr_pages); > __count_memcg_events(lruvec_memcg(lruvec), PGLAZYFREE, Kalesh has been working on something similar for lru_deactivate(), and he can help test and review this patch.