From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A07EC46CD2 for ; Fri, 22 Dec 2023 04:35:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A73D46B0075; Thu, 21 Dec 2023 23:35:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A23C26B0078; Thu, 21 Dec 2023 23:35:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9123E6B007B; Thu, 21 Dec 2023 23:35:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 837866B0075 for ; Thu, 21 Dec 2023 23:35:51 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 435A11201ED for ; Fri, 22 Dec 2023 04:35:51 +0000 (UTC) X-FDA: 81593191302.02.9F8CB33 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf09.hostedemail.com (Postfix) with ESMTP id 672F6140011 for ; Fri, 22 Dec 2023 04:35:48 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XRBFrw5+; spf=pass (imf09.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703219748; a=rsa-sha256; cv=none; b=ZbOy3uLfXgoM6gfQpN/W5+2THYcJg9Nt6laEceZA7Bi2j6fqpTAF9oLIXmPGCjVhIKBtA6 Bvc3eyc0a2jaUs8OH3ESxPGBfYpQrvzjneGbeAbHPyrYq0zXcddISpeGAz/a2klYmQ0lym zdB+dB7ivW+tw3baD0nypiCNFLxR2sU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XRBFrw5+; spf=pass (imf09.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703219748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cq4h5QboZhQMj+vS/GDQCzDFv690LhM1wOxTfWStork=; b=pPhjHeBgWmAUmBjjNd1l8e9r9bI+cjRsYlMICapAEzDGQSjeqpwnVwHjsR9V01k0h90qxD XbjydokTA8WTV1Wan1+m5icNPF2j2DmuL8sm/vhlpXpAIWlSsUvOvwmD6us79sO3vV4wtP 76AmVy7T6w8SMqRgZbZsZ7urd/PVb/o= Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-40d3102d5d6so33365e9.0 for ; Thu, 21 Dec 2023 20:35:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703219747; x=1703824547; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cq4h5QboZhQMj+vS/GDQCzDFv690LhM1wOxTfWStork=; b=XRBFrw5+RsDqiyZHi3ZHbtmqOmBAmxLqAUkhUXdkH8fxGabWcgDycT8ChdIb5dBlB1 rtNwGMns1xIyE2z8aJUzfsmV86T2+HJ81yQwXA9NEPsi8z4lI5PJx5pMulEN3gRH/Wgx 9uq+AePnu2RgIbS2sNv/nld+HbYTdq6fbmDwZTthHpSerlzvLMs6wJDZyspqgW8ffp2G zJAvjqfPXwpwzuSk07h5M2UC/zx/39ePItEUwccTU/M9OLp72wsCxSHqZckskznYCA1g RaYBlz+YiHWQ8SqcgZYYnsQDaTQi5vdQnIH1lT15VJHnFPS7uU1PNfhEQP9uLdUHLpc7 cZnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703219747; x=1703824547; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cq4h5QboZhQMj+vS/GDQCzDFv690LhM1wOxTfWStork=; b=W0xMAI+bN+kWtupNN5RUXWiIvUTF51mZTEyG0DHYHjHcGt6d72DYY33dEqnQyKcWTj SLkvunBAHtAOd7dR0In89WE6wBtIeog2G0PHUSv1w0eX5jhuW5F2W4t/P6fuGURa7x5T eHBQeosfRoDI6ODzuvp1oNTJv4bUpQba+okhm5i02CXxDAURlFbk+E5DFO+KbvxH9Wti VE0ZwXoHNLlw8nianOg5fbqcKmXhbcZPmgpjx6clkaPJW4tElDvZ2yNnyW3fx6BCypsh ttuo96JL3SP2i4v2FsOjoXpqsYMfI7D9CXtc4Wqx2BpbuY3UyuqM2ocmjCf0l1JPSEV0 bQKA== X-Gm-Message-State: AOJu0YwV1DpaosJc5vZaYLFxjUpKXTrPzWtzEwLATrKGwnJquAh0pQm0 RqJb5WqNLhXq2pt018/mdmgPHI1O0b+3cWtfOnmt2RA5yoYm X-Google-Smtp-Source: AGHT+IH3A6tFn5oze2k72i8bTIzJgmGOBYyk1ho+xIQoseIyv5aMevL4rl58JQRQLxjH0DWWp9+vQqCfI3ccWSJwSko= X-Received: by 2002:a05:600c:210d:b0:40d:3ab7:86e0 with SMTP id u13-20020a05600c210d00b0040d3ab786e0mr39640wml.3.1703219746675; Thu, 21 Dec 2023 20:35:46 -0800 (PST) MIME-Version: 1.0 References: <20231222024458.12441-1-henry.hj@antgroup.com> In-Reply-To: <20231222024458.12441-1-henry.hj@antgroup.com> From: Yu Zhao Date: Thu, 21 Dec 2023 21:35:08 -0700 Message-ID: Subject: Re: [RFC v2] mm: Multi-Gen LRU: fix use mm/page_idle/bitmap To: Henry Huang Cc: yuanchu@google.com, akpm@linux-foundation.org, =?UTF-8?B?6LCI6Ym06ZSL?= , linux-kernel@vger.kernel.org, linux-mm@kvack.org, =?UTF-8?B?5pyx6L6JKOiMtuawtCk=?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 672F6140011 X-Stat-Signature: dxqxmakduyt3gz4ncfymjpi9oxhbj3aa X-Rspam-User: X-HE-Tag: 1703219748-542570 X-HE-Meta: U2FsdGVkX18eiQ4jF0gbo6UcZNdxu/HITNbKHCUOs7lV7sotqh65WdYSLCcOsmiVe26os31ocivl/OPoWBGs62NLZyuoAHSAG3fKgRHR90EDfaiSNCc+dc5aq8HZuTsXqDKp3uSP7OM/sSMYlTyv58mn5wsjzZPR3juJTz3B105x51q63R0Mg+waFuX2gtCgTJa27hgFDqnTdMgNJ8WdIC+NQMETV1ZEHY42UD1wlymtYPYSxfSITztGd8q3mx/NPBH+Ac+pBKHOHJ/8aD/NNUeRf62hGG3bPcRxpZz1ilnArx2Q8mn9Z7xZ/9OqsAGbczrZTBtxAsfrW6DNzdVV3eAT6oLrsdb+2jQchQA7wfwYF5i2LvmInPx43YyBJo/FkAGdp7eIpqB4/BLR5fOseKA98NWb24RM2bIBFspJr93n9SPzFmqdl6vTJl9SVSXsqLdL7aKoq3U5pPkKNyQlPKJAipRk1/789uVPZDXxX2NPYFkno3bpaXlB7dpGo1/Fp/fsABG4x+VbLRhJdXX+6vBgkSeYbqmjMWILHLT5DkKK5bUQ12/qzqmKqv3LAMDde/bEgj4vwgtwH5GP0ppgaRQ/WHVj8SHw6iN5BduFpbz9yhytsNmwj0clufCJEva0ZVOWWWCdt7uLTvgfyCqz+SDh1xa64icvhSyFjwb4nt9NA+K38wp7NrIkA9XdcY/0vrGYnn1K7MhJaLsxdqlzYeUcyru+yDdMX8HMtivDYEM7AAoP6cjhXhK4UIzGeWxPWlElIIhc6OYhcX9mmopLcD7STKdqS9Q8P8J6T8oxBs3fsZKvq/J63kgZPzxwKMD/F7hjELC3pZuKhyj6fTQKow06pABiddq9Oqip47P6HNvaEq0beH9amwJxQY7Nz/o6UeJyYnVTS3dN38DkH43Lf2gH/Q4Zz5JS9YZkmmYUmqf0Ufr1zwIkKMMhYE2xlKC3M8ysi4rqaSqVUTkkzue Jy8Px5dn zQgVS08/Rohp8I4xIB8SgSI/wVIxXUPxqJfYiCCEux05a8rIlU6ulaFpSWUhLgfgFCMQjNiRTxoaxIxMMh/NoGf7Lwxb9GG3y/sfMD4PV32o/ZlRJiAE8JzBt7sg4v0C6mjzCyxraR1iIIJYf8cLtBbZzp6b4KIKjYmgdvkoQjjyuyGnch6ksgvfktR9LZCpbRHrJqQDBfoHw48c3s1KyGiY6yNb4NmVL8/USutORvBkiatO2xIlDRD8OcNNW1ooOrEQkAJo8HmN6HahDFaCPrcm+mW/wwZOgRcjHdVnnBPVIoMZSQXTE8Osye93mVybo5zg+KTgvZVz59T4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.009316, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 7:45=E2=80=AFPM Henry Huang = wrote: > > Thanks for replyting. > > On Fri, Dec 22, 2023 at 07:16=E2=80=AFAM Yuanchu Xie wrote: > > How does the shared memory get charged to the cgroups? > > Does it all go to cgroup A or B exclusively, or do some pages get > > charged to each one? > > Some pages get charged to cgroup A, and the other get charged to cgroup B= . Just a side note: We can potentially "fix" this, but it doesn't mean this is a good practice. In fact, I think this is an anti-pattern to memcgs: resources should be preferably isolated between memcgs, or if a resource has to be shared between memcgs, it should be charged in a predetermined way, not randomly to one of the memcgs sharing it.