From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C72C43334 for ; Wed, 15 Jun 2022 22:43:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A358A6B0071; Wed, 15 Jun 2022 18:43:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E5A66B0072; Wed, 15 Jun 2022 18:43:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AC4D6B0074; Wed, 15 Jun 2022 18:43:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 787B86B0071 for ; Wed, 15 Jun 2022 18:43:40 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 44BEF11C4 for ; Wed, 15 Jun 2022 22:43:40 +0000 (UTC) X-FDA: 79581948600.09.6635A9F Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) by imf30.hostedemail.com (Postfix) with ESMTP id E04E680052 for ; Wed, 15 Jun 2022 22:43:39 +0000 (UTC) Received: by mail-ua1-f48.google.com with SMTP id u13so739918uaq.10 for ; Wed, 15 Jun 2022 15:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2XObwvEIRFeSUPWlsccqJL2V2/Mvgt3nETnC1b9HKa8=; b=S2S/srd6++j7u7iD7ddlh75/PimyvVkw3xD/iReZx2VdakC+JjCSDBCASxeIHuv3V1 v+/dVFIS1Utv6mw9teyrxzcYyDxI7VofJ4oyO6GAUplv10+0M5XXrevWfmgSicsnWWFP 6a6FoXCgRLMDABe7hpmFkTJhwRj0JvpEG3N2C8lQkn9FQRrl6IdGuOIT6e7rjyomtpAc NfI6pE8pnIpMEJpgG0lC/bDDw9h0VMc9QWZG8Gs4Iz0i4IEe1pH4oSzcPrQJRgNBrKnm dkeBB4ax2K9f6UGVaK/PjM8jJyuxd2rJVuAu+hDcAdGOqwH/JM8t7kJbxnI80FPQaK3E UlxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2XObwvEIRFeSUPWlsccqJL2V2/Mvgt3nETnC1b9HKa8=; b=DCOhhpgq0j8ZZiq2I4klQMc4HFZOFdBhrojqdeHvOIXfGUXKsApFlDDDMpDM563yxw bFPEAZD1YOqVqmabzyVVnam7sk4h+NnoU+Awm9ogQeLFj8tzSd9zKpRGFBDsFGQDyOW3 E0ATJ8OkwJYW2BV8g6Xklh+PMJv2B01pn2Ou7e7V//Bc0Rx0jBtIYjAbiNR/K9eAyPap xOtIMVK8FIuD1NIDNPV+0zdLKvxJEmsH6ttK5YZSelHm7y8Do/OYYgq8ZwoZYo59/eIv JRa9yZf5zsoSfSYSN+DsDu8wPrlU1MIzSpSMfwmw4bpAs2jkvaRYpvBANp9xLmJcsTT/ mVEQ== X-Gm-Message-State: AJIora/+L3K+/jLabptI/jeIoIMv0ERBYGnpglpzhu1WX3HAsBBLSyLK s0CAb5Gv41difUlZ12lQ+8vE1dIZ+t77zRWv1vRMyA== X-Google-Smtp-Source: AGRyM1sJtiK4/NKr4JQEU3uA4VG/CjXI1G2Sh5Ajk9EO+Ng8ddNV3vNXEvLWkGBvxbnZlQvEuR4WKiIkRwH7f2u+jdc= X-Received: by 2002:ab0:5781:0:b0:37b:de3d:5d4e with SMTP id x1-20020ab05781000000b0037bde3d5d4emr1042184uaa.1.1655333019050; Wed, 15 Jun 2022 15:43:39 -0700 (PDT) MIME-Version: 1.0 References: <20220613125622.18628-1-mgorman@techsingularity.net> <20220613125622.18628-8-mgorman@techsingularity.net> In-Reply-To: <20220613125622.18628-8-mgorman@techsingularity.net> From: Yu Zhao Date: Wed, 15 Jun 2022 16:43:03 -0600 Message-ID: Subject: Re: [PATCH 7/7] mm/page_alloc: Replace local_lock with normal spinlock To: Mel Gorman , Andrew Morton Cc: Nicolas Saenz Julienne , Marcelo Tosatti , Vlastimil Babka , Michal Hocko , Hugh Dickins , LKML , Linux-MM Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655333020; a=rsa-sha256; cv=none; b=4AYngcDgC9IhflypsT4Fmu3/D8X7dUqj4/5lWOCXvWFcUkhA35Tr//RzmB4tGua4GlFycS Azw/WDLpYVHqIx1AtG/eABxfShXk7+75ENL7u4Eby7mxaq2hNWoEG+tUDneBp6jSOsvQDE woqIeaFFZdrtPeZOqAa1GVYwGflrWDo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="S2S/srd6"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.48 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655333020; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2XObwvEIRFeSUPWlsccqJL2V2/Mvgt3nETnC1b9HKa8=; b=yPbxBN4ip89NpsimjDKNhlGlnc/ND2I9WecUw/emEWTBb7NoCWyaGdT2Xp++sOEnYtYx5K Aw1HWiuqWQ5R6qQwVFZRU3iEL4O9QvNLaeesPiFKTgwhgPeguJT6A3CYNpTXj0JiS8n+xe 51/k8zx1DcZ/6aBjKR30/e03ghNPWAg= X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E04E680052 X-Stat-Signature: 8p3gb75bsa9p8bju16s361r3u7uc9m3b Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="S2S/srd6"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.48 as permitted sender) smtp.mailfrom=yuzhao@google.com X-Rspam-User: X-HE-Tag: 1655333019-169286 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 13, 2022 at 8:54 AM Mel Gorman wrote: ... > +#define pcpu_spin_trylock_irqsave(type, member, ptr, flags) \ > +({ \ > + type *_ret; \ > + pcpu_task_pin(); \ > + _ret = this_cpu_ptr(ptr); \ > + if (!spin_trylock_irqsave(&_ret->member, flags)) \ > + _ret = NULL; \ I'm getting "BUG: sleeping function called from invalid context" with mm-everything-2022-06-14-19-05. Perhaps missing a pcpu_task_unpin() here? > + _ret; \ > +})