From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E526C433EF for ; Thu, 16 Jun 2022 01:59:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8821C6B0072; Wed, 15 Jun 2022 21:59:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 809DC6B0073; Wed, 15 Jun 2022 21:59:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D1318D0001; Wed, 15 Jun 2022 21:59:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5813D6B0072 for ; Wed, 15 Jun 2022 21:59:12 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3078035491 for ; Thu, 16 Jun 2022 01:59:12 +0000 (UTC) X-FDA: 79582441344.27.12AA661 Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) by imf13.hostedemail.com (Postfix) with ESMTP id 78C8B20084 for ; Thu, 16 Jun 2022 01:59:11 +0000 (UTC) Received: by mail-vk1-f181.google.com with SMTP id z17so46889vkb.13 for ; Wed, 15 Jun 2022 18:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2wf+GQo1lkMGfk2sOlGy5EOrnw/TgqIePJAT4UiFG+A=; b=sbzqhCSBgGcqBDteaf4vfkNKOjSVtDqKJunMUhsu7AjKY+THtxWSShfj/LVlwkcU06 AD7AIT2YOeyLnPOdksCcl+hEAItYDTaDPsTjrPnjv43pzZ2YSt+hXHJk/Z91QBp8ECmI kEWpNBJZaupNmk4U9AAtJXZDW8Yjw/GGyEDFSHP9CLD0aA8m8L/6YC5QigppT2MK3/Lh fzHhAWQXw6reqAdTbEBPuyCRBLRWg4CDwoCKk3d8szKBKoI/mVe3nECHnCbYFXM6++OU YImQZkmBkjlR/8/QMnMjsd3yGh/VlouahhwETg8F1Zo0uLDG0JnyLwqGEQXI02Hdl3F6 TO3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2wf+GQo1lkMGfk2sOlGy5EOrnw/TgqIePJAT4UiFG+A=; b=POzfiIhvYjyzvgFzkHorvWIhSL+UHOWOo1tqHk1Brb51x8NGwDbpyTnZRAvpCG+IlH 3j2LBnm1KBnib+ffOc7NpA/KoReggVDVhX/xc32j9IUWFFYK7V8JCpYIoqVB+aAFgqbi k9xvA2ejew8mczdV4HyqgNlVZK5LvEP5GoO1gc/EKZSrjaq3/6F8Stj6TLyiR69T2uN1 KTBf4+uEha7VgZV/Zvb/YrYM6zm6FenxUcjbOExgApi/QR3JTNPxHwvoy7+I5GmL625T i1cUjinCUFdk3UIB9wI7PWCLmsrEo+B4ivVf2FOeFsbU3u9BwxMAc1BrcN3gyrRZy0Lc UlOw== X-Gm-Message-State: AJIora9tcFaR8WvEsXTGwhs3dmU4Fslha2nluZrYo9vE05y61zlXkKsN oFvZwZnl3Bp8MuNCRqG5CRUPESYO4ie8GtVKdODKCw== X-Google-Smtp-Source: AGRyM1sNY+7WXA3okVxr3z7AA0J5f4nsKVrJ4mHhbuK+pvtbX899hS8W+cB6pnXMa67E5Cg+2AxbKMK/NPXYOqr8arU= X-Received: by 2002:a1f:a504:0:b0:35e:4fd4:d3bf with SMTP id o4-20020a1fa504000000b0035e4fd4d3bfmr1196702vke.7.1655344750439; Wed, 15 Jun 2022 18:59:10 -0700 (PDT) MIME-Version: 1.0 References: <20220606161940.fh5edq5nyz4jru2u@revolver> <20220615142508.mtp65w6tdiurtvcn@revolver> <20220615185500.i5bzt7srzm6q72na@revolver> <20220616014956.6jgxvbzh4ld3c32q@revolver> In-Reply-To: <20220616014956.6jgxvbzh4ld3c32q@revolver> From: Yu Zhao Date: Wed, 15 Jun 2022 19:58:34 -0600 Message-ID: Subject: Re: [PATCH v9 28/69] mm/mmap: reorganize munmap to use maple states To: Liam Howlett Cc: Qian Cai , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655344751; a=rsa-sha256; cv=none; b=yzeZQPhCwBtg+pKGH67POYxzVk6q7WBZM0IpJSIkXmEHFgZAlfzThZ94DAo3h6/xQW5qj/ d8z2lSt4BycuRFNiobyChl0A7nIGt3Kcv1PvKsGwPSY3qzfxPEo0nJsa/SCiEDAya0GsXP LeSGSIeKN35G1zS6qdQNTw5D2dRbtTQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=sbzqhCSB; spf=pass (imf13.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.181 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655344751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2wf+GQo1lkMGfk2sOlGy5EOrnw/TgqIePJAT4UiFG+A=; b=Zmlfx73Wo2BJ4b5iG5gOPD46dafCq2DxWp+wCB5KtHpYC5483ifR9V2fYocpavDwcOg9pn ugoouphTI/Aw9Ke0YCbG2eBJz1nO/JD2rAd5RkeZOzTPQLmxMjeiOynDMlJe1TX9FhX1aM VXoYETP0UhxGYy3uqsENsEQRy3/icO4= X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 78C8B20084 X-Stat-Signature: ucpnwruskaiu1joaxs9g7i4wexk8y3af Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=sbzqhCSB; spf=pass (imf13.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.181 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1655344751-810914 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 15, 2022 at 7:50 PM Liam Howlett wrote: > > * Yu Zhao [220615 17:17]: > > ... > > > > Yes, I used the same parameters with 512GB of RAM, and the kernel with > > > KASAN and other debug options. > > > > Sorry, Liam. I got the same crash :( > > Thanks for running this promptly. I am trying to get my own server > setup now. > > > > > 9d27f2f1487a (tag: mm-everything-2022-06-14-19-05, akpm/mm-everything) > > 00d4d7b519d6 fs/userfaultfd: Fix vma iteration in mas_for_each() loop > > 55140693394d maple_tree: Make mas_prealloc() error checking more generic > > 2d7e7c2fcf16 maple_tree: Fix mt_destroy_walk() on full non-leaf non-alloc nodes > > 4d4472148ccd maple_tree: Change spanning store to work on larger trees > > ea36bcc14c00 test_maple_tree: Add tests for preallocations and large > > spanning writes > > 0d2aa86ead4f mm/mlock: Drop dead code in count_mm_mlocked_page_nr() > > > > ================================================================== > > BUG: KASAN: slab-out-of-bounds in mab_mas_cp+0x2d9/0x6c0 > > Write of size 136 at addr ffff88c35a3b9e80 by task stress-ng/19303 > > > > CPU: 66 PID: 19303 Comm: stress-ng Tainted: G S I 5.19.0-smp-DEV #1 > > Call Trace: > > > > dump_stack_lvl+0xc5/0xf4 > > print_address_description+0x7f/0x460 > > print_report+0x10b/0x240 > > ? mab_mas_cp+0x2d9/0x6c0 > > kasan_report+0xe6/0x110 > > ? mast_spanning_rebalance+0x2634/0x29b0 > > ? mab_mas_cp+0x2d9/0x6c0 > > kasan_check_range+0x2ef/0x310 > > ? mab_mas_cp+0x2d9/0x6c0 > > ? mab_mas_cp+0x2d9/0x6c0 > > memcpy+0x44/0x70 > > mab_mas_cp+0x2d9/0x6c0 > > mas_spanning_rebalance+0x1a3e/0x4f90 > > Does this translate to an inline around line 2997? > And then probably around 2808? $ ./scripts/faddr2line vmlinux mab_mas_cp+0x2d9 mab_mas_cp+0x2d9/0x6c0: mab_mas_cp at lib/maple_tree.c:1988 $ ./scripts/faddr2line vmlinux mas_spanning_rebalance+0x1a3e mas_spanning_rebalance+0x1a3e/0x4f90: mast_cp_to_nodes at lib/maple_tree.c:? (inlined by) mas_spanning_rebalance at lib/maple_tree.c:2997 $ ./scripts/faddr2line vmlinux mas_wr_spanning_store+0x16c5 mas_wr_spanning_store+0x16c5/0x1b80: mas_wr_spanning_store at lib/maple_tree.c:? No idea why faddr2line didn't work for the last two addresses. GDB seems more reliable. (gdb) li *(mab_mas_cp+0x2d9) 0xffffffff8226b049 is in mab_mas_cp (lib/maple_tree.c:1988). (gdb) li *(mas_spanning_rebalance+0x1a3e) 0xffffffff822633ce is in mas_spanning_rebalance (lib/maple_tree.c:2801). quit) (gdb) li *(mas_wr_spanning_store+0x16c5) 0xffffffff8225cfb5 is in mas_wr_spanning_store (lib/maple_tree.c:4030).