From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 576F2C0015E for ; Wed, 19 Jul 2023 18:24:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D41AE280080; Wed, 19 Jul 2023 14:24:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF1F928004C; Wed, 19 Jul 2023 14:24:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB9AF280080; Wed, 19 Jul 2023 14:24:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AAFC428004C for ; Wed, 19 Jul 2023 14:24:14 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7068FB10A6 for ; Wed, 19 Jul 2023 18:24:14 +0000 (UTC) X-FDA: 81029186028.07.03B5201 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf05.hostedemail.com (Postfix) with ESMTP id A170B100005 for ; Wed, 19 Jul 2023 18:24:11 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=cCcb6eQT; spf=pass (imf05.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689791051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jbxDP50CZlJWnajO6VajqSUKLZ5IRlVqyfdIEvg3GPU=; b=PQO4Df1LQgIpp2VjxSOjbDJFHFN6MmC/5MQLnIXcia8AU/e29aSP4t6Wnegg9+AQnPZtHH uvWBgAii6wgRfWS10EzFIWPkqpUST0VgR8aAofnjVmJy2/wn8I0x3IpVxrXwbJdP5+KZxq zqDsGeDSLTq9LUmrq7hqSqQnNPrvAzo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689791051; a=rsa-sha256; cv=none; b=uBiriUZBzvSdPgzQsPzs6ZlQP9uJZyMgS/UJkjdjtw6/XGHESKFzZz7AL/4aTdeKLxzXVN qaEZ78BcRdkFALZsgAWIqDvSeV9ZTg9En0fZFvnR7zug43/6ZUlezYBKPdBmBuWBFLlU5y WMVOw22/ViLQMpVu1wcDb2Ts8Vevtaw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=cCcb6eQT; spf=pass (imf05.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4036bd4fff1so34351cf.0 for ; Wed, 19 Jul 2023 11:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689791051; x=1692383051; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jbxDP50CZlJWnajO6VajqSUKLZ5IRlVqyfdIEvg3GPU=; b=cCcb6eQT6QeSg08XCK+G6+pNCXlEYQXfJlxkZW06c6q512LcRhBaKXOTDLPQXcMyhn wzRnmtEcp0EqhEqA4f4R4c+VJkr8COsUa0pFjRwFQHEvBzEz5XyI6gfWgu9MZ+3KjoR9 2xO+WUC6c88rDPj3E5lc4Jrwj+0YwQ6mTDEcvan34MhuALxpL+r3Z1iyxBeFo7nyuoPw MeZrCJNyRKls2MpWKVsUHq9DDxxbBcAtRxpeLc/Vr9vjJcfgcBFmIxKUDVTi+PLD9iO7 xwoKimjrilChWMMPSDBUBtiJsu4zHEtP8lBds/ls6u8cxZGOcltjdUMdZW90anUWU7Iq izsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689791051; x=1692383051; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jbxDP50CZlJWnajO6VajqSUKLZ5IRlVqyfdIEvg3GPU=; b=W2FWxzVDrJeQihHbQz337L0gC21gbCsZk4fVrPYut97hI60KIzRMETIbniHFksnW3h 1KbEq6o9ps+bn1FeSuJCSvaK8AiHzLc+Maj1zaARTfDOzcnzRqJlpPWKQDvfD4Fqeudg +VgewEvN4AD1ioYoVfMHJmnIuTmtLK3h8Omj0vshemSB8GdfB1sQj4ElSVcbX96b/8eM 9cco2AmC4nQSZsxniG/hTfnA/J8tXFOHIzaqM+k5vcGHZah+lKWu4p5vvdxVzA3gxpSc LC+51L3mfcVOvysK4Tce+AVrgkU1rRXHKfHyY6sENzH4ZSWMvk4u2MF01weWeeHXlQJz 6sEQ== X-Gm-Message-State: ABy/qLZ0H3DGtSEPi+BFL2cuE6mO7TQYorUvBLscghl2dvRT3eOCrmDg ewbaErLlxta6pTqFhSuOpEXa4tBL6rLQzXUAjo/4OA== X-Google-Smtp-Source: APBJJlGFr+FaLX5OMVBu61IXG3nYjTcxCvhEkVh0rHeOkEHasFwwQLcd87tTeXtQRNkG8Cz3VO8HPknFYMPiZlGyMJg= X-Received: by 2002:a05:622a:1756:b0:403:eb3c:37af with SMTP id l22-20020a05622a175600b00403eb3c37afmr27539qtk.26.1689791050679; Wed, 19 Jul 2023 11:24:10 -0700 (PDT) MIME-Version: 1.0 References: <20230719135450.545227-1-ryan.roberts@arm.com> <20230719135450.545227-3-ryan.roberts@arm.com> In-Reply-To: <20230719135450.545227-3-ryan.roberts@arm.com> From: Yu Zhao Date: Wed, 19 Jul 2023 12:23:34 -0600 Message-ID: Subject: Re: [PATCH v2 2/3] mm: Implement folio_remove_rmap_range() To: Ryan Roberts Cc: Andrew Morton , Matthew Wilcox , Yin Fengwei , David Hildenbrand , Yang Shi , "Huang, Ying" , Zi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A170B100005 X-Rspam-User: X-Stat-Signature: oaeif3jzjibauppfghoe6thxsrwz7mpb X-Rspamd-Server: rspam03 X-HE-Tag: 1689791051-325888 X-HE-Meta: U2FsdGVkX1//8mwBvJrx3J3MEeN8DdbSjGMikve4H4Gc7R+cPqqL16MG7rw7LHjpkouPmY4AHxLcqYRVh777DfGV2tIae3I5ZHXydCiLlu9CLcELNnnkKs+k0nHatbvBqlNNyt/r2LslRNXwoRS4O4rgIGz7j+DDyzeyHLm3KT/9sRQ4DnNh6WEbjf1SzJonXL4WDj91s0WIGMLfd12pg8EdKYeZt8s1WFick0zzvlmGobstJqf4vyHM0IzUzNwo4To6HwL0fQynxEfvgQMMn9sgeXhIUT/T7zX0GpMyRwBWlzp8nxg2NMDpdcbs2yZEx8CqA9932NakxmrSVhxrdZrzPR/KgJcv4da2Mb7XIxzsaATevdt3vpxFk3sjY+dRyoblzxo3cKeBsGTXOgn0Bbnlv6bt+xrR4wZ4cRTZ4SkDUDpPo4a9WlpO6eHvflNakqwFpiJCgKGS2ieY0qU8Z0sjTQpsAc9IQx6H4nfehelbQagqgrqVOisvwdrKFVY6e6jAhgOHzx4GqugHrFNn1unVMSqbJRvcj3ZY4qRHFTh7JYzoEzHqfxdvdRN0MYHoUjn2EvVJcxjJvnBVb80H+oPh1pd0aRlw4O/GwLDIubU7ltQ8zWGexhAQgxUWohuLlMdtexyMB824uyn/FTJAkEq0fPU0eIS9mfDTgTJDQV6INDLJc2bFDD2sZc40QMm7jzNSvPhLWzXVDtZMTox8IvMoq8Y++NCY8+4VRwhDaPsqIpOI9/yxJ/oXT/efcXfW7yO24JG6nGTs/HekpEHjYpI92dzR4OPuNX55aTwVt71Xs6Mo+GMSciRirpbsJp2HIpQzoBLG/NqYILBTpu1eSxjh8QnvInQRx7CwOJBaBgXEQO3+OQzZG1jpHi5Vn3+DuL/QTpG/s2w4jQfTy5dC6dH+SxZJo0e4B+lY78tsyuofjZG7CVhUUBf3FUs5hHOiydazMEbc+bd9ZSIsihJ J3sQVaXB 55D3M84ilZ2OWqBAg4LmH5iStqzCGgQYA+bjpq5I61WaNshrxmwOfBs9YtiF1+7U89at0eGmZAqutMQKBHUNsgNPZZd/ik9PtUmb3IxOlqJ86YThaWYJwzHODE0ro2XQqMRCHb9BQaEUXEdWNNZ/5065eCBAQ/y1JM9dTBBABztkgbeS0BavzK6+YF2elo8pkr8eqWRQaiZBiW+2IvuKDC4pa7ZFVoSFVkF+Olj8pTNRfSbnJsfIRWoEHsV5EacvlGkg3yATxX3kSao29CoAGTs1MVwqD0dzfneLiTcgdN5zvgKbu1o6+E8Xz2vwnC7REdkHFMXIiJYZB//GL4zBq9wNoAFgusL3CIRWoGZnMjHuLYgnJrVp9B13cL35VAO5lhn7y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 19, 2023 at 7:55=E2=80=AFAM Ryan Roberts = wrote: > > Like page_remove_rmap() but batch-removes the rmap for a range of pages > belonging to a folio. This can provide a small speedup due to less > manipuation of the various counters. But more crucially, if removing the > rmap for all pages of a folio in a batch, there is no need to > (spuriously) add it to the deferred split list, which saves significant > cost when there is contention for the split queue lock. > > All contained pages are accounted using the order-0 folio (or base page) > scheme. > > Reviewed-by: Yin Fengwei > Reviewed-by: Zi Yan > Signed-off-by: Ryan Roberts I have asked for this before but let me be very clear this time: we need to generalize the existing functions rather than add more specialized functions. Otherwise it'd get even harder to maintain down the road. folio_remove_rmap_range() needs to replace page_remove_rmap(). IOW, page_remove_rmap() is just a wrapper around folio_remove_rmap_range().