From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AED76D10388 for ; Thu, 24 Oct 2024 21:35:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 241466B0082; Thu, 24 Oct 2024 17:35:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F17E6B0083; Thu, 24 Oct 2024 17:35:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B9266B0085; Thu, 24 Oct 2024 17:35:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DEF4D6B0082 for ; Thu, 24 Oct 2024 17:35:01 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0DC2F1C736A for ; Thu, 24 Oct 2024 21:34:40 +0000 (UTC) X-FDA: 82709801034.14.D580BD7 Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by imf18.hostedemail.com (Postfix) with ESMTP id 85D011C0008 for ; Thu, 24 Oct 2024 21:34:51 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kArL06F3; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729805574; a=rsa-sha256; cv=none; b=4uwPU2+cRQy/kq/Kz6KI/JPfLKpzfZVEZTen4VNaM/OiO8CEQrTWEYB/BpWIMdMT4ciWc6 whlEglIrdf1CAwQe96AGOFeEJGGcb1kE05RVPgLxK1LjaWeQ3iNCyXJ95kP49wUlRBfXMo o/WFayr4mOGfD21vdtfP+McCKNpG60M= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kArL06F3; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729805574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8HJhFxyE1niqaPSLshWSHKw8RQSQcWCeF9FiIEMH9BU=; b=n7d3hDLpo15j0qDj8ClZTHkvVmK3Wp5HqNA+cNM+b7dA0tJ8lawZosmGtamb+fGranjLIv sK2uduPAm1CBM7OKIOFDVAzJZncsStWGkqn0bwJ3i4DflD54B5WpSJXTCI7sbWfdf9GjgO mCFPjV7t7+MG9ZuC+Scs5Bf1975N1yw= Received: by mail-vs1-f53.google.com with SMTP id ada2fe7eead31-4a470d330a5so505929137.3 for ; Thu, 24 Oct 2024 14:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729805699; x=1730410499; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8HJhFxyE1niqaPSLshWSHKw8RQSQcWCeF9FiIEMH9BU=; b=kArL06F3zfr1QCSP3z3/0V+ozVg43QHHdffVcwj4aLet18l91Eo4lQRMhTzPKlkNYP IvUhNZudThydktafbUye5OIUk5oZ7pTtVnSZQuJTZKBNmspwt0O9P6r+FdEOuvfj4Onn NaCu1ESU4TbfEg23Ct0f6A8LhrK544Ixp/NEVlDAcda3H0g+W6x/71Dn5Y/EydbYx7mg ZTqMUGg/1WZG4DrUdPODWARvLbWJBLOdhu3ZZE7Qy8E9ucg+dVdcMBPlGu9/0xYbnGCK TmWBHWvkqjOm4cUM+SaGzURhm1wOsa4rNk4g523rw0IBndyCaJ4zL9Xxiahi/F/9/jkb jEIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729805699; x=1730410499; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8HJhFxyE1niqaPSLshWSHKw8RQSQcWCeF9FiIEMH9BU=; b=FtbaQc7azTIoK9N4zG79gQ687VY4jE82GVwWacFwbfqw83wRF1MCe5NKMYUAmvpkHJ dw4g0hC1vH6Up1A2DruKjVZgTrmwRwoE5VaipwXagXHA+N+xP/yXmOJ1+eQ7G9MX5AY3 kTFHwZ6ichOaP4lokG9Xl3rv3e7vNt9ASw8Lv5/eMhKHbQ2Sq268mQIBeeNC3Qh1RnuI LYpfnE+O8eDz95AidgDLi7+me+sjuNth7Rktft4uDOUkZdddV1hLlO3xcLscYDOoyPKp P+bh8lPvzfCdOcl8+bUn3I56yL8GM1Z99QQygecTxDFZ6vOTFXiTBEGskpLOtf05HATh AAow== X-Forwarded-Encrypted: i=1; AJvYcCUo9pXOnI3LxsuCQs6AyQRe2tZoQQ6mcE6sH5wTRZjLEbYXy+VmvnXyWBUTx3OAkEhMFzvDau1kBA==@kvack.org X-Gm-Message-State: AOJu0YwQUxRrwSrBRINFzl9d79WYAlfdJn+r+p7PI5s6z3RQBUHmzl3/ f2J/Xhmhzp/rRYvbh8RPEfW5z/3rnZw5OMGMLYKENErfHROFwjQiFu4FaHuhgUr0+hH72mim4Co BRHtFBx2ouUINz4WGwsVJ7eILqIFIkXkkp9Vn X-Google-Smtp-Source: AGHT+IEgImX8myCywWp7XoCWKbGNI5c1o2R5BzcNDzWN5iUCiaDxo1vXGytaPpvTdh57eH+7o8lcsaK48tV8vseJcw4= X-Received: by 2002:a05:6102:374b:b0:4a4:8b30:53e with SMTP id ada2fe7eead31-4a751bc7185mr10100478137.7.1729805698731; Thu, 24 Oct 2024 14:34:58 -0700 (PDT) MIME-Version: 1.0 References: <20241024162318.1640781-1-surenb@google.com> In-Reply-To: <20241024162318.1640781-1-surenb@google.com> From: Yu Zhao Date: Thu, 24 Oct 2024 15:34:21 -0600 Message-ID: Subject: Re: [PATCH 1/1] mm/codetag: uninline and move pgalloc_tag_copy and pgalloc_tag_split To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 85D011C0008 X-Stat-Signature: anm36uyg9ze8y4b14xkc1h749abs4srh X-Rspam-User: X-HE-Tag: 1729805691-639771 X-HE-Meta: U2FsdGVkX1+Wzp+rW+/4Yw3SXm9CZR//Ld3QmEcX/PJ2WnsdKgU103Lx/lrTICTQpfMOx9EBQfvw1laK0NldT9kSIjHps3pQhd4lJ5n6GJIyUbWRX+piy6sYAaVeqc7qlJST04mvVwNsT6S64q5zBP9ivUEOdDAqk6WQT8lRj6MnN81+f7FcfyLWE3mFhvPey8rjhmqR4amLxoPx3AZ4CYB/OUyswlG/MkPws+wtlb/SyYyo45kocFJ+n2F0Mxe9SKxMXarlEGnwn3Om1RloL/f9jvXjzG7XEyefv1m1tWS9aIjCEZf/8vjzpWno6rSuo+DHAnBFpUeEt0fxPssYt/87W3VNg8QcgatopXXwmK+/1zLPGg87GEHno4vGs37g32VDuKYZi74S2OXPRPQOud5cJviyqrR1d+Kn+olMZFLgsfSQzNFk9WRYZarrBx0Kk6q2pKX3PhWfM+bS27tjAFEKGak0HG0Fe5hfps6MaCh3WPF0ru8KRuWGnQVoaA0lMublxDmQztduYVXc9bnKJ+TP129iYIogkaiwzo9l67NAg+f0nfajEul+9oXREh0mcwR60RTSBslqIciZfpneciRIhXY/2k6w8KIKY/8WccjeVuey5tQ64V1GGdpHg/8l718piWU04GTuTCge/jnMNd4W9HB+w/qTXNxFOziRNXAfGp6a9RhXG4rOrTSPJSdo8KvEFLRlv6R5LQQ+7Fp8qerpaSzo19f5oUUMdp0EPuduh+sPe3MQVMM1jnwa4VzlWBrEF/j4mwiVmFs/kJdTybgNzMbBGGJvfHHOlocXidcu9zWkmtZcM1D9+iCZR7jWLI0RS2ABNaQTP3qWf5gQmHD1Q/xpRI5G+5chjyLo2AuZnYD3HRY/aOj1mOpE9KKbZig7LYiJ9lvOE6LzlOi/8PpNWyJ0xqquyvkXK/tmrDh10FuCQoiFEzniaPFyQwwia6VKm8Wn56yxYttri0b inHznVlb KHH3SfFPrp2UuCsbDNcMlJLT8GhkF0aTXICa6WHI1jNdc1t/6tzTI8GADlruWeAWrMB7g1r7UaJa/HrG4Tw+d5aXkiIOSFW2XsoWYDg40KExJ0VbT30RznlUULknZKT3JfANB0RVZy70dTCyMFAph7BmheEiTep9zUKNtO3rxVsNgSQRwlbixHTtcchgODIqSGZP8GPQouM9ACGH0gzDb5seBfSbvAHn3KiNGSOwN8QyY+gxb293/krh1vjy+dQcABiPfuqVR3voHMhTPKW3i8c6hd2OnMWhKl+AqgTpNKxinVlKebulKS7BmTjo/kaqaWHt2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.337872, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 24, 2024 at 10:23=E2=80=AFAM Suren Baghdasaryan wrote: > > pgalloc_tag_copy() and pgalloc_tag_split() are sizable and outside of > any performance-critical paths, so it should be fine to uninline them. > Also move their declarations into pgalloc_tag.h which seems like a more > appropriate place for them. > No functional changes other than uninlining. > > Signed-off-by: Suren Baghdasaryan > Suggested-by: Andrew Morton Acked-by: Yu Zhao