From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3CD7E69E9A for ; Mon, 2 Dec 2024 22:20:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 031386B0085; Mon, 2 Dec 2024 17:20:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EFC876B0088; Mon, 2 Dec 2024 17:20:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9D816B0089; Mon, 2 Dec 2024 17:20:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BC2C46B0085 for ; Mon, 2 Dec 2024 17:20:09 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 81FDC40149 for ; Mon, 2 Dec 2024 22:20:09 +0000 (UTC) X-FDA: 82851437550.03.BC09D7C Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) by imf08.hostedemail.com (Postfix) with ESMTP id 656C9160013 for ; Mon, 2 Dec 2024 22:19:59 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ia5ikaQ0; spf=pass (imf08.hostedemail.com: domain of yuzhao@google.com designates 209.85.161.46 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733177999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KxDp5MnGW60aqBFJqD4JyRMmY5bR01t13DbUTGA+aMI=; b=xcgHOnxxY0b0Ib9H8N+KMFrtA7uGtVsWbH6n4PZmfG6r9O2jhEa9zJoVzO9pGrg0ZB7+Y+ /hwVV5rvOWDxquiMuhnNLqiKCV+FCSDFmPNkcZDBuAE0JjFS6NUmsWn/efnJCMLjLCAynA YR4ldwr3WupdztM253UwyXBmD+8m8GA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733177999; a=rsa-sha256; cv=none; b=Rr9gyCmcD6QCGE/IMzwzZr0lhh0HI8e8775IiFZeHmVSgTHcLP0UOJ803o2AlrjgYeX4Uu 3/m2SKSlHeqnrH4xBOsurTmQFZrLrRU1YOB7nq/YkEWviv32FOTSiVMQRdHlA98936BIAp adg/sVKhwXtfffst/j1P/acuRJC/C9Y= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ia5ikaQ0; spf=pass (imf08.hostedemail.com: domain of yuzhao@google.com designates 209.85.161.46 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-5f1d2487b95so1843905eaf.0 for ; Mon, 02 Dec 2024 14:20:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1733178006; x=1733782806; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KxDp5MnGW60aqBFJqD4JyRMmY5bR01t13DbUTGA+aMI=; b=ia5ikaQ0AWrYfzcAZoXq5xANEmEL91874OiercNvyKn2O5A+fIBGnPbUD4m3GGKnz3 nK3fQJ/MeWONqJCgyp6T7SK5xafTblcmVN3a55QdGby+lGqRLWlni2iuSz1LsIBw2PyQ 5v6fkCGrSRAGj34OBQfPCb8aHD1dCTn4UbJl75FO8U+dJJJA02bMst/WOG/9+Fodm2W6 0OsRFB66w5q0qv4UDR8sAcywfPpa/TK6mUwvwVmlvR7dZu3lVb2Pv3ilYeoXlUngc3tc f7BLoH8l1GG1H/D/DTrEwG8zNX5kroFbz4vicmXx1WYT0IflXfIYeQeMi+K0JqiOZdPc QJbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733178007; x=1733782807; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KxDp5MnGW60aqBFJqD4JyRMmY5bR01t13DbUTGA+aMI=; b=jx/ItTegCrB6xB6aiXJ4NN3ja9kbDh9n5pVkG8kRIcGNnngA3zpi0sW/11jWQ2uvsr 8JWQcL4e5/F57MxFuX8svBNvD0ZWYuHiQ8w6wnBBELawvNJaFwoMJzSRunjzjvpAQ3uX 5G6gxHa2rDzBWYQtToGTCyB1TyEIvfUaiybI6YOKBuwqw0rC7JR5jxtqy0sXCAr4dg8s h1m4C+jOysXFncyKzhBtmFRNkvombBRdo5gt6WdBbf45veLxSVAQvfaxsISrulakdjNC G98ux7KWRyRwFyHhAn62dE4M0ugvcPxukJro0AuhZ9t6QXoD85X8dQBqIQ70xbOR5AdY TY/Q== X-Forwarded-Encrypted: i=1; AJvYcCVWVHOEuL3avkn1O4XIzkm8WMWT6I2GKmPJyhxnDRLHtCTQiLrWPipAJ/atqtqEM3QlxFd6gLEpgQ==@kvack.org X-Gm-Message-State: AOJu0Yxa0K2VWUDzun0/7hAL48Q4lU5x0v48EB0oqZmXEW5oR08SlB3H /iWAPgOng+Im7kgDncG23R4eDEfrShS0KcR5AcptWz8H5h3zNL5XiT4xKaq5LJL6fbjw2LWZ43u x5R8O4MLmBsKLgCHgAJGOgEr7mqRESY9/i4jW X-Gm-Gg: ASbGncseUUBJKK8l+OjKfk1a40FyrWsCsn8UTrPGj86c55VTy9cKoSghS/+Zhi5E87a tCtc9+sKzsokaNvToE00gDmzykrf5kuMjwjFmHVXAFTMr7SDM+heIkXaB4niC6eg= X-Google-Smtp-Source: AGHT+IGatTpJwiKxbnO6DaUR3NzXa4m4OZ5gudCk71K5HQZbi0bxzC9mddfkQtkd9cEzkEL7rxYDSUpeQaMn7OuLA04= X-Received: by 2002:a05:6358:d383:b0:1c3:84de:4d5c with SMTP id e5c5f4694b2df-1caeac4ea20mr45668655d.23.1733178006499; Mon, 02 Dec 2024 14:20:06 -0800 (PST) MIME-Version: 1.0 References: <20241128102619.707071-1-00107082@163.com> <20241129025213.34836-1-00107082@163.com> In-Reply-To: <20241129025213.34836-1-00107082@163.com> From: Yu Zhao Date: Mon, 2 Dec 2024 15:19:29 -0700 Message-ID: Subject: Re: [PATCH v2] mm/codetag: swap tags when migrate pages To: David Wang <00107082@163.com> Cc: surenb@google.com, kent.overstreet@linux.dev, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 656C9160013 X-Stat-Signature: mjeo9ouxs6poaj7chizhxi9qyos967i8 X-Rspam-User: X-HE-Tag: 1733177999-634561 X-HE-Meta: U2FsdGVkX1+WXTix9dAPqNc8S95EPf9O7X44WDeCgnoyIZdbeRQmOzLnmXNhmgqBhC4DDHE3g9JK0OhVzvh9GQ79KNTKUPH/b7f/mYUIbuVN4m2LwJfAP4weAnVwWYpJrWMI3erjoWLvI3pVKFMW4AtZYTrLxHdrnPKAt1EA55Fp81taSODULoFRyQz8knHuIBQ5R6Utnt0eaZQ2FV+aFusGEKYVoqD+ivS4hmHogQZPfmPdJZoQEf4OCjSzad3O6kg4ZJh397PYwC4ZYgv6vo0q8yceTn6KURod1QuvmjwWAXLFZgG7IhmpM+wr171HiH51/b8EWsMZdr0YlmKuUKuv/10xn7sBMqgLRugfZIALH85X6DOVnls2aPUPS84w2KNhYm9nEHU4RugI2R1fmgHE8dwfgUU0DlUvrIS/ej/bVPpW1TJpi4dPHVXPdw5CdtOyz7WYRZ6IirU5pgGaj+S0AZyQCz/e7T7++xeTRfdZEqVirqmnaTkZRinj/go4HDb5VP8JapG09tbG6vu+K2EzdWgnuWHjGEYWZzXjOJBnyk8ysoGPi4S27/nDJvNejhnGLX7lPIxwO+40+NYbI+1t0rwdmCSuMM2PPgyLUdZ95pkhORFZRexGxoXZ/DTjsm0rVBDVFB5UxqAzp7ZQleF3ecO8QeEEMHMlh51pIWfmP1I0ugWtf0KMkxNiGyE/YWEGCvRbK7qttV199TvXVzwqHNQOUwiLDQoGaskoLhioq60egaJr5kGwCkz/Cz8KZ2Q8XgHGkSij/SWaqXun6DDy/+8yy3TfuPvdpFaL2V9RdbDVB77Y1AaEt4yq5wMPgAXorgi5+POhIdARPynw/uHEdl2ZzvBAQXYQ/LaD9pZQUiefozQyxRDFdoh90f3HMDfLQ8MxKGoOUjP6lhXA69bPZoYODjCDJ3ZvuoEni153DTc38KbtUdzDYV4C130FCJsY1cz/bz2VcHpJd7o T0dopG1y rgZn7xmV9s8xzseBEthuwHRw+Gzv4ii+H3jdHHISfM6yTCwoL1n1ZI5GOFoBXN+fyJpHeDTpmVyizIJv+mzjw9pxI1tF9YUcMCFYB+J/L6eGmv6uXYaRp2/W7IunGmLNpOrvoo4hh2eUlDHcqITq5GdEeGwVhTY8NZlEosVgdxhcuwHtY7Bee9BezwfbkBPk8lNOnNGC+aSKPQnc1oxTrkWpLBlG/1zgB8QayXNSVmq+WzQ8C8q4WgcOrKYsTX7sa+CXmmMGGO50k2oJYdKrygQTiY/SWHn6LDiThw+LbIQMxxLXqduPzHPuH7c/dgx6C7/GqIsA9EzmlYOS//y2nUg4HtyUOPfrFrbp1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.083484, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 28, 2024 at 7:52=E2=80=AFPM David Wang <00107082@163.com> wrote= : > > Current solution to adjust codetag references during page migration is > done in 3 steps: > 1. sets the codetag reference of the old page as empty (not pointing > to any codetag); > 2. subtracts counters of the new page to compensate for its own allocatio= n; > 3. sets codetag reference of the new page to point to the codetag of > the old page. > This does not work if CONFIG_MEM_ALLOC_PROFILING_DEBUG=3Dn because > set_codetag_empty() becomes NOOP. Instead, let's simply swap codetag > references so that the new page is referencing the old codetag and the > old page is referencing the new codetag. This way accounting stays > valid and the logic makes more sense. > > Fixes: e0a955bf7f61 ("mm/codetag: add pgalloc_tag_copy()") > Signed-off-by: David Wang <00107082@163.com> > Closes: https://lore.kernel.org/lkml/20241124074318.399027-1-00107082@163= .com/ > Acked-by: Suren Baghdasaryan > Suggested-by: Suren Baghdasaryan Acked-by: Yu Zhao