From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD55C433FE for ; Sat, 22 Oct 2022 20:00:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 162328E0002; Sat, 22 Oct 2022 16:00:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 112C68E0001; Sat, 22 Oct 2022 16:00:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 002FF8E0002; Sat, 22 Oct 2022 16:00:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E405D8E0001 for ; Sat, 22 Oct 2022 16:00:09 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BABD8A0576 for ; Sat, 22 Oct 2022 20:00:09 +0000 (UTC) X-FDA: 80049651738.22.D4478A1 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by imf23.hostedemail.com (Postfix) with ESMTP id 5422F140010 for ; Sat, 22 Oct 2022 20:00:09 +0000 (UTC) Received: by mail-vk1-f173.google.com with SMTP id t85so2238927vkb.7 for ; Sat, 22 Oct 2022 13:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oCc6fCDBvainHyxcsWfWzc9zC2rNiGmKs3GME/+sOgY=; b=fVR2/grxqt7bRXxWMaVwi4cf8jCYMukFdRGbhVkhbFp6kKPkdpz1xAYE+eanuh8YiM R/rrLqcT+TC8p7uNhLeBpzpiOfb4tW+XhAkOmka1foCM3Qwh3CDRa6RdI+jJWYEZbm5P s44MaOZuqbKAJby4Xafout/ZTPZ562ngXpn0hR+TXsgkRdryqYpOU8qMCuW0TlCkaih3 QE6pgOCxpzTqlj1SyokVNgoB3XPwPtc6M5y6nWzpyybtGx9g1N7Gwj1ERqmkNvvgMTAQ ebG4Cw7O7LfcCBQ8fnA+8LkO5V2WeDjFIRSrXE7tpBd2NyZufjcWnIkJxpAdnLdnQn7u 15hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oCc6fCDBvainHyxcsWfWzc9zC2rNiGmKs3GME/+sOgY=; b=dY19aPdw8/Ayc11mfcgzQIFyr8yIlfQJdiNuqZHW/27PRE1WtcL1g7jS89JcD8c7mx nTIBbl/2oE6fxrI2144qC/ApxuZLYUyy1qdybs3QOqxscxHvXZC2XLNH8oTRpBkVmzTe t338ci7kYXVXzJ/R7PBYcPDrPe/roxgxZ2IXv2PWDCGL26gB0pODm9OXVzYN2Ixrbp8e /LpqfZDVHfDR8Cow4TD8pbOpEONzlkj2zCcBgRoIyny78bO2Of7p2phJs+NIZsqXnf3J XzpC1zJGnuFxiSuzggNoM+m/dFhJJfzqtdKLjixngk+n0yOkGtAcI+fE3t/v1Uf2bNRf np3Q== X-Gm-Message-State: ACrzQf3TuoeHKLuIVPWPib3eak8Q6WbwcXYjJWdQ0oQLUOv4EJmf1A0B u/Exdacl3U4YTDNH3y242v2/PfG9lS2XU435g+jfNg== X-Google-Smtp-Source: AMsMyM5R7wJkJY47oWSGLG3+XPHJI1satIgi1THu/sUcJKJfxUksdiKmnecYsRKQNWcKFFIOjh6zYJAxmp6NkkNc0m4= X-Received: by 2002:ac5:c969:0:b0:3b6:2a34:a26b with SMTP id t9-20020ac5c969000000b003b62a34a26bmr765722vkm.30.1666468808375; Sat, 22 Oct 2022 13:00:08 -0700 (PDT) MIME-Version: 1.0 References: <20221022111403.531902164@infradead.org> <20221022114425.298833095@infradead.org> In-Reply-To: <20221022114425.298833095@infradead.org> From: Yu Zhao Date: Sat, 22 Oct 2022 13:59:32 -0600 Message-ID: Subject: Re: [PATCH 13/13] mm: Remove pointless barrier() after pmdp_get_lockless() To: Peter Zijlstra Cc: x86@kernel.org, willy@infradead.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, aarcange@redhat.com, kirill.shutemov@linux.intel.com, jroedel@suse.de, ubizjak@gmail.com Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666468809; a=rsa-sha256; cv=none; b=4CAXf4tAu4YZ6amfYy/ctGZh736aj8OOkssmcBk3MO2OGu1s+nJSRUvbmAm9h3rICC9pSe HdKOx18lZjlzzyVKScB6p/8MjomA/lF+5gul+R7CaKCDO34qxdEAiOQD3qYOAHozTH8aEQ rZW4Knhah9FZSoHsTGz9FN7RKc3B5Tc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="fVR2/grx"; spf=pass (imf23.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666468809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oCc6fCDBvainHyxcsWfWzc9zC2rNiGmKs3GME/+sOgY=; b=dgPGyKlJJQuKrCExRPDq3fah71ZRAOlj4wf0IjcesrAdxIgs69Oo1UncdK2K8wA5Qvt11L 0lFZE/fcX5C2lJQius8yZfuW9dnapsZE1tLICAqb4DephcDQU1fq+skEulOl7zjOLiiVZa fQdRnOBGL9yqGbBPQpnbrp8K84B5ddI= X-Stat-Signature: nnofpqwj843ybhsbti1wwkzckzxdtz15 X-Rspamd-Queue-Id: 5422F140010 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="fVR2/grx"; spf=pass (imf23.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1666468809-181777 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 22, 2022 at 5:48 AM Peter Zijlstra wrote: > > pmdp_get_lockless() should itself imply any ordering required. There are three remaining barriers that should be removed as well.