From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC65FC3DA6E for ; Mon, 25 Dec 2023 06:55:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EA1D8E0002; Mon, 25 Dec 2023 01:55:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29A488E0001; Mon, 25 Dec 2023 01:55:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 161978E0002; Mon, 25 Dec 2023 01:55:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 070E78E0001 for ; Mon, 25 Dec 2023 01:55:17 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CBA45140129 for ; Mon, 25 Dec 2023 06:55:16 +0000 (UTC) X-FDA: 81604429032.10.7D59A43 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf12.hostedemail.com (Postfix) with ESMTP id 092D340005 for ; Mon, 25 Dec 2023 06:55:14 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vSfAHqP8; spf=pass (imf12.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703487315; a=rsa-sha256; cv=none; b=8D+Jrsh06kF1Vykg66fKwHdt0EOCJ7EG/e+WPVY8p9lvC7rLj04gxORgy9+MULbjGXHqog srIQllrS0rn5IMbrAiqyCOJ27/emcmrLD9DpD2Gczx/VFFW1RhSisTFQU13QEBePW7/PyN HztYt1e4oVUT8Vsza0BWg8Ep3V0mmOk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vSfAHqP8; spf=pass (imf12.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703487315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZyqJYcIcc+GjCQm5GmQ3IiA6wm6RwZv0sslOf4v+Z18=; b=AKaKIT70nAAv9rY8CnvIvsWs1yUPWyMtWSvwBbtvG+r1gJkpV8lT9Z21kdUjSZ9YrTYlQB mFxpXqxzg46KmXBrruNPqQPYaFJXojwAjOSpiy302OkYg0TY3Zeqm62fHofeyhxokPfgyI AE4eqQHokodiIN38IcqC8tWIaXOtj+c= Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-40d5097150fso53895e9.1 for ; Sun, 24 Dec 2023 22:55:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703487313; x=1704092113; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZyqJYcIcc+GjCQm5GmQ3IiA6wm6RwZv0sslOf4v+Z18=; b=vSfAHqP8laVkf6Z4V8+stMjpmnMgSeKGMRWExskC13rci+RWJZiCkACKZvYwvDL+WD w2ggnKWBfH/Ouj+maUpk8sIZX7+HYtQ0P12kStqnBVY9HA0AIhR08K/NGbpk/ghU3mSd xTTRTB8ljmmlCc7cplSnLAjPPTBZ9Loo6jEA2ufIQa8EoU0LS9vBnRstZSCxvaV82B/w UtN7ikRsu1HoJtg1ExcgOvqYOJphc3FnJt7zC6q6sdB0XleQ22minTrw9NvE5X5Zgmd2 Bw+oPvh1QOEI8/YHqiAbM1LeAvKA9ezwLU6gyhsUp2t+5G5qp+Lh+zxyEL/Wq5nifvHB L4AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703487313; x=1704092113; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZyqJYcIcc+GjCQm5GmQ3IiA6wm6RwZv0sslOf4v+Z18=; b=A6YfG7IJ7bW7FgDQVFuJEy6Ex/9emhooPPOEcYyKX2N5ei1lF5rL1gV5vbGxmXpYF1 zZQZQpMcN96IItBBgbiKW4th/Ou4kKToj9FvIMsQN8hfsQLamGjF2dDu5lT9qi9h5Reg vFBlkXpK3FAdVlynBbffDhx5rbODvbNBTQ5EyHl1w5ojd/I+fsyhTq0+KYzIw5SZ5a35 467hUSimW0QDmnhO6313Uw3FV905Mc0uXgC9CB5r3XRBTSF/Bke56e3yO6SJPCACWUH0 gLYiMEzvzPo3QRhV37wcbMUb1UAvmUyVpjgUlmer94xACho1f3ST3SCWYoEhWa4hSz8Z RNhg== X-Gm-Message-State: AOJu0Yw74Og5kQlpALfTQdih7pmLWgJUIfiwsBSyCBsE2uFrcHkjMrSd tzVup7wmIYwihnVaLxfwOvPTb4zJ0/ZQVEUvlWw4Wqr0FHt6vN+fa+VhUSbmAhYX X-Google-Smtp-Source: AGHT+IFzTQmYyCFiTaXLaXaZbcsvot1nofMeqvQ8VYH0owZFOuqx80JhTGXp41erVHLtzV7kZVmPne5htCQI/FCyKjQ= X-Received: by 2002:a05:600c:1c29:b0:40d:3bec:55a with SMTP id j41-20020a05600c1c2900b0040d3bec055amr333681wms.5.1703487313428; Sun, 24 Dec 2023 22:55:13 -0800 (PST) MIME-Version: 1.0 References: <20231222102255.56993-1-ryncsn@gmail.com> <20231222102255.56993-4-ryncsn@gmail.com> In-Reply-To: From: Yu Zhao Date: Sun, 24 Dec 2023 23:54:35 -0700 Message-ID: Subject: Re: [PATCH 3/3] mm, lru_gen: try to prefetch next page when canning LRU To: Kairui Song , Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 092D340005 X-Stat-Signature: duzaqr5ups9g861cbnwcmkji41f9cp9q X-Rspam-User: X-HE-Tag: 1703487314-490755 X-HE-Meta: U2FsdGVkX18YlwD6VyTTW1I1dizf80wPH2rJTvWY7GNKU8Z0hYio7ajEVRXTv/QfVnVntO2RTPCwxn9rztbCYt4wNMysITFQXueUeKvk/Q2+RV8LSxXUOsuBKfMOsnUZ4KUyPXNVj1mh2/aW8kEQu+kixZ2eFJKO1WkYGdBigkEWukBrNlYi+5VKkl5JYlth++BjpQts69JlIhXVUZJqFQhKJAnKhDMixpbijuQ4dLHDvQR9ipP+Ip2TU135Mz4oMR+WUh0LK4h3iekaM2oMbeHQ13oBa2UJJw05i7nv6OEXZk8elBjjUBCThokq09YKkTsgiiLeZ1B5a3qd2t/hde2WczWauaMVG9XFs7sB1+uGlyJEEReR7it/4oAqfwqtg+hMHefJ2cJyxELFlgmkM6vs2oJePK/spFWEQIwHDWAX+itXld13Em3bfnPnloSKugw8V/c+u1aKnS3Q1a5SfUlqBi9HfdPefOpJ1vGZrUl5+ePW3n9gIes4VNTU17txd2kEbqgevB5/rkp/n1j0zT47gQy2ur0PUrI8NfnLuPD/xK8oNHl1UhDdk9BrReLdV835mPWAwkmbwjDcR1VO7ogr3DSftxtaq4b8MNdWKlNrpFdzImENYqUVM4eQurjl7yJHJJpWiVZdBALM+xrIAc875zLvbsGg4XExY/D0Ue4RBdB8c3Lu0Sbwq7/eNj0+ZA4Ga4W+RoOHe1xIOPnF8uOMPeiUX8QiTjbHzrXbcINnLFEOWDfiAR9mdFW2RZf/hziw8rUbGLAPuZC4Kr++4tnqNmfhCKCo9f8IhTl8S1e4OI56n7VG8S05WMioXHS+BMiTQmn9xe6owWFggbNjWq2y9jzvmsguC8D8Stfm+ckgCVLrfcdw9rBHZ7elQ8y36t7f2C5wJV8+0d8bVxZXZPt7B7y8SeFXP63XKuCWrQmV9XxvZOEZStWWZre7NrhBgtlrRc2nms3D5yC7OEr UL7GCpk6 RDN0jVSo/W8Rr+l11T3Znhcplv9lhNbsN9jEDo8YE2V174VRew6ODmaZi88BCZ+9q9ODi9OFLPI1K8Y6WxMGP9npyOkap9eiUazM9hsiBjLug0dhr2B5hOwtvRc3QcF8Z3AKB6zfL7P2bFDr9+hFyqGl99efJxloGvCDnai4glbFMKk/r34IifHryxqGzRXUXLinj1owmmYrS/m3yJd3mPs3D3TslJmptriqZoeEBAChSTxDzQUw1QHVgi3Wl4ACs/JCyBDZtvG/j7tnw3BzDlrvXgAe/J9HBNZ62ohBUuVP9qbxSAf9xA9dysjMd8AcNAnH57yOS5xeXUfQ4GxeeAFSL9ClppCvATJv7ht/XAr3CI/jMU8eBR5CWWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.314353, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Dec 24, 2023 at 11:41=E2=80=AFPM Yu Zhao wrote: > > On Fri, Dec 22, 2023 at 3:24=E2=80=AFAM Kairui Song wr= ote: > > > > From: Kairui Song > > > > Prefetch for inactive/active LRU have been long exiting, apply the same > > optimization for MGLRU. > > I seriously doubt that prefetch helps in this case. > > Willy, any thoughts on this? Thanks. > > > Tested in a 4G memcg on a EPYC 7K62 with: > > > > memcached -u nobody -m 16384 -s /tmp/memcached.socket \ > > -a 0766 -t 16 -B binary & > > > > memtier_benchmark -S /tmp/memcached.socket \ > > -P memcache_binary -n allkeys \ > > --key-minimum=3D1 --key-maximum=3D16000000 -d 1024 \ > > --ratio=3D1:0 --key-pattern=3DP:P -c 2 -t 16 --pipeline 8 -x 6 > > > > Average result of 18 test runs: > > > > Before: 44017.78 Ops/sec > > After patch 1-3: 44890.50 Ops/sec (+1.8%) This patch itself only brought a 0.17% "improvement", which I'm 99.999% sure is just noise.