From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C8A6C3DA6E for ; Wed, 20 Dec 2023 17:55:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A278D6B007E; Wed, 20 Dec 2023 12:55:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D7FA6B0080; Wed, 20 Dec 2023 12:55:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A16E6B0081; Wed, 20 Dec 2023 12:55:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 76BAC6B007E for ; Wed, 20 Dec 2023 12:55:19 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 43A531C0D22 for ; Wed, 20 Dec 2023 17:55:19 +0000 (UTC) X-FDA: 81587948358.30.5FF7323 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf23.hostedemail.com (Postfix) with ESMTP id 7691E14001E for ; Wed, 20 Dec 2023 17:55:17 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=COxVvwLS; spf=pass (imf23.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703094917; a=rsa-sha256; cv=none; b=1xIo/fnbafFjlOamUA/tlhh0+zLlgFNu7s+6CcZDk/HKofdvvqBjkJVygxTqiRL58Mky8W IzuxlL8lF+nGF7GLjptKAyvLR6Wxaw4J+8XuBorUAob+4XI0xm4PXhlAYv2Tw4dnO2TVjl ug3YoJTL1XAtCWjyrFeS07hb+dkMxS4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=COxVvwLS; spf=pass (imf23.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703094917; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JXBfEAuqKBSMS1c3GRv3ur+swt6j3InHmy9rp0ZP3us=; b=ljC0mMTcMgqNXVtt2y02ibWUm7zmrq20Hyt9HFjYRNLJD2txs97wvlXsG+o9fF7V3S2t1W yOp5LjW7Wm4lHzpIc8ERegefEt4DPnTpl/kyUIITlbrG6S+oz5vgf/NhE6eQjxo46Q3DGf kTsNmWFCz2eBLLtYEENjzGzWqnOBqWo= Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-40c3963f9fcso295e9.1 for ; Wed, 20 Dec 2023 09:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703094916; x=1703699716; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JXBfEAuqKBSMS1c3GRv3ur+swt6j3InHmy9rp0ZP3us=; b=COxVvwLSEF+VpHvYNwwc/zMVx3DWHGy7H2GtX1mXkTwrL0L+zLT2X/1XmmBMb5nj2O HcM+1bHrP23WB/zuYppSrLmI2Aogp8aH/Ih5Hv6Nx5rpc2eFXg3fCtk+xOx/BUcRUhuj VYUnquszp2VJhLY1wgHg4ORp2d31vE2f7EkaIBYcWF5GM30rG4iQvG1Nh7gRIs//E2/f j0KlbI6Apw0xibQZd6JGtzXEmnaFM6o0sb7fj5d9d42w3jmdriwTxvrrYsixkgmZ9/WI I1UY/LDS/cZ5ia6OWOuuAWJLAbuMC4Or84CeZ5DTbmEV/mVX/jQY1fPzlqD8y8+2IFa5 mSDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703094916; x=1703699716; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JXBfEAuqKBSMS1c3GRv3ur+swt6j3InHmy9rp0ZP3us=; b=OeDBnGLOqAp07d66rz+e/3yEyXIk6+MKmVlZnjyuKA1xqpPHvvv/TuN76lIPSPPjjd Uf5nu/VsEIrTnDyMzrGjch8AUH9/i5+EL0goMcub+CJTtzHQzgJBMTfmay7X/ZYA/Pub KMURM7zXml4KFRVPThQFuGttn7NGP8Qx7+fm26LuY1aKTNh6+DeU8vq4CaLW/yfZRIMA SLur3vU3t3xQ26Umoz599UUra1tHgpHt21O1jHbAvmsIUkUV+X/N8njQyNAx2Y7auxc9 Edbpy2+RT9E7STN1R7IcLVzhi+XuY4WsHGJyF0QjONONFKuEscoGgtDl6d78k6icQIRI ac9Q== X-Gm-Message-State: AOJu0YzOClDcVL4/lrfe26TYRZhGAt8YCQK0+BzGtMjSFVmuw4pFvidq UFhiHx21SqeRtwFPWcy/9mZ5nx4sT66b3CXGDIdwiRnNNF3Y X-Google-Smtp-Source: AGHT+IHq8UHmJLiFOiMTsnij3nN2uawkD9E8P3p56H86OZir+aqGDEi/SFQXCqkznhc09wtdn2Bmjx7O0qVLrF3dxlU= X-Received: by 2002:a05:600c:3b9d:b0:40d:1bcf:1abf with SMTP id n29-20020a05600c3b9d00b0040d1bcf1abfmr207456wms.6.1703094915775; Wed, 20 Dec 2023 09:55:15 -0800 (PST) MIME-Version: 1.0 References: <20231220012123.2787-1-cuibixuan@vivo.com> <20231220012123.2787-3-cuibixuan@vivo.com> In-Reply-To: <20231220012123.2787-3-cuibixuan@vivo.com> From: Yu Zhao Date: Wed, 20 Dec 2023 10:54:37 -0700 Message-ID: Subject: Re: [PATCH -next v4 2/2] mm: vmscan: add new event to trace shrink lru To: Bixuan Cui Cc: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, opensource.kernel@vivo.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7691E14001E X-Stat-Signature: 87d8hh3wido3c1uhfjfern5tbq8rgj6n X-Rspam-User: X-HE-Tag: 1703094917-113628 X-HE-Meta: U2FsdGVkX1+gXhDh9Rjw0p0B/itZW41hegje4VaDWTxoSA2UwZYWfPToL3cBFyx8i9T70qtuipw0+QWeHGqBoRXqkzcwrWZNHsWEob5+nszFF5sUwmq3SylBZ7vydZ8Do1DKTzSkZ2KL8MexmX9dteJBxjDiv1WklHrO0kh+JT5fc+qQ/cEYNKix6YeAKTEfr3CURKjUwWzeDnElr33MuNVAvVJxGubaE29+/tgXhHzjAozf28Pj1G7pne7zwy/oF2rnDeEHcgxgD8ZU+YGiZK0SZs9tQkcvmIT99C+uazxceVt6wBcmUYJKuwEtj9s2alFQa16SwAc6BCRHGJZr4O3+ED55I+kOMvWVox8qnzm/WkmdMexGSx9kF7f6gEo+m+6PoP13QE33o1BxZDAD2jWgwhfVEoG/VjBTqpZpmbuJWdB0U+bbjCeiZB3GAvupJ6f+bTPkNUFqEDhBD78ADTkLKkl7wMhSxlZTbQECMOY38Mkv5bWOOkI4L8rrGp4Hrnhzwo1T1yR7wGgSq8vC/owfs6Du2czV79f0wDAQFVVaKG+4O4WJMrKJ8SmoY/GBacZaOgHOuTqVtRuyQ1xubFYb6Nzux2DoqMOfvX2EO9uIXqUuEn7EYeyqwbx5qx46HBDvg+GAoglS3H8y4kGD8+aWU/ptPd/1yIfVUi2Q3V8xjPFIrufPCMGQBeyoSfjmiLId/PYi362kgyO6zdT/Mg1Kp4mL1C2NRb9T7x5GwLKgjPnwvHPxu5kt407y1jCeD7nYzjsu4mqvJWsL0j+4pd0XFCihiLpIFH0ctVe9NJhtLwH9mhgKFTT49hsCGpHo4Mb1vsOZEDBSskj0i0r4aOoRtDLoT0gxX0lV5LgfHn/OJNL16OzMMsMfTi9C3g3Xl6g/43XNOhdnkTobRue2vlwS9iSB8uE3zlUEPcaURu8NqO11m9fX72+5KM/zBCQQlct4a8MHsVThiEoY6GO 32EFeqiI KQLs9ifmR3m1pWmGlsOk3tVwFJpWcvoBqEVd0NxbE+4XZbS57g3F3eBjuA+rp8JzxPqTQoLZ00zY8JkA0h+gWj3b7E5p34DRfqaBFpbdg+PFgHyjlM1HPAn5Vdkly2H/GqXoHElMwrXa5MLfbTttNzgGNpHjKXlpI5JPjwk7rdryN2wa2BZXGzLpSrQYxnEWfw3+eIWL1o2ODNzkK8aBgwKADqdNTcjxzecGGkjzXHe9ccV9uSyRhkcXFt0jxxv+TYdqCjzp1jie72BuSigjmrz5aSF4wQ8aAM0H+AaeNOxC4feSlpOEUSggok3mt8vEkyUNOmGU/EFAELnkhlVyRstP7xg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.133979, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 19, 2023 at 6:22=E2=80=AFPM Bixuan Cui wro= te: > > From: cuibixuan > > Add a new event to calculate the shrink_inactive_list()/shrink_active_lis= t() > execution time. > > Example of output: > kswapd0-103 [007] ..... 1098.353020: mm_vmscan_lru_shrink_a= ctive_start: nid=3D0 > kswapd0-103 [007] ..... 1098.353040: mm_vmscan_lru_shrink_a= ctive_end: nid=3D0 nr_taken=3D32 nr_active=3D0 nr_deactivated=3D32 nr_refer= enced=3D0 priority=3D6 flags=3DRECLAIM_WB_FILE|RECLAIM_WB_ASYNC > kswapd0-103 [007] ..... 1098.353040: mm_vmscan_lru_shrink_i= nactive_start: nid=3D0 > kswapd0-103 [007] ..... 1098.353094: mm_vmscan_lru_shrink_i= nactive_end: nid=3D0 nr_scanned=3D32 nr_reclaimed=3D0 nr_dirty=3D0 nr_write= back=3D0 nr_congested=3D0 nr_immediate=3D0 nr_activate_anon=3D0 nr_activate= _file=3D0 nr_ref_keep=3D32 nr_unmap_fail=3D0 priority=3D6 flags=3DRECLAIM_W= B_ANON|RECLAIM_WB_ASYNC > kswapd0-103 [007] ..... 1098.353094: mm_vmscan_lru_shrink_i= nactive_start: nid=3D0 > kswapd0-103 [007] ..... 1098.353162: mm_vmscan_lru_shrink_i= nactive_end: nid=3D0 nr_scanned=3D32 nr_reclaimed=3D21 nr_dirty=3D0 nr_writ= eback=3D0 nr_congested=3D0 nr_immediate=3D0 nr_activate_anon=3D0 nr_activat= e_file=3D0 nr_ref_keep=3D11 nr_unmap_fail=3D0 priority=3D6 flags=3DRECLAIM_= WB_FILE|RECLAIM_WB_ASYNC > > Signed-off-by: Bixuan Cui > Reviewed-by: Andrew Morton > --- > v4: Add Reviewed-by and Changlog to every patch. Where did Andrew provide his Reviewed-by? > v2: Modify trace_mm_vmscan_lru_shrink_inactive() in evict_folios() at the= same time to fix build error. The reason v3 was NAK'ed was not mentioned or fixed in v4. So NAK again.