From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4666C4332F for ; Thu, 22 Dec 2022 21:37:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39E78900003; Thu, 22 Dec 2022 16:37:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FFC1900002; Thu, 22 Dec 2022 16:37:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 179DD900003; Thu, 22 Dec 2022 16:37:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 001D8900002 for ; Thu, 22 Dec 2022 16:37:38 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C49CBA0EED for ; Thu, 22 Dec 2022 21:37:38 +0000 (UTC) X-FDA: 80271254196.17.2F778E9 Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by imf13.hostedemail.com (Postfix) with ESMTP id 4672F2000A for ; Thu, 22 Dec 2022 21:37:37 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mdwlbJDC; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671745057; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UY/dj03+2QLtFIGYOy0a9bWGSATbW0khYgL/ikJla8o=; b=uOeiEfG//jufykGneNkZpGI6v5CRupe8uI6FvafE5fL0qJ6Byobzo/WA4SlEYDJCBGbYbt ChqgDTxysl46x53X/Nzh7n7aHyRcRytauWpqORuNKDeSt75DkHNLgVVFooCpr3i2YY0lhu UyofZ/fE7v7BRxXYCjtjH4E/UH7kL1k= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mdwlbJDC; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671745057; a=rsa-sha256; cv=none; b=cjXpzQQ7iWiVM8pjgmuFRF2O/fGnhLtl7p+79ciRY0DE7ndalOJKzK68WP5jqLsEK/YuRA +jIh7a5FI6PajRe4lYDwgRAuY0SA5Fv3Q9Eak2Vi4G4I8WlDKAWwluiOYe5zoVAbFIuTsP 3vu7zk70a7oulERltB4O/5D0apBN6+M= Received: by mail-vs1-f53.google.com with SMTP id k11so2950709vsr.4 for ; Thu, 22 Dec 2022 13:37:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UY/dj03+2QLtFIGYOy0a9bWGSATbW0khYgL/ikJla8o=; b=mdwlbJDCdzR8VvaKfUlQyFB/XJl+Ydb99idTwOsiNjFveD3lm4SStfRmmwahUVwKP7 vA53fPLgfK/aqOcSWKhS1saWIEnqup4OB2SdWaamcmEn1t/DopUfE1gAc8aF0xz1w6hF YMrmAkmNR3/SH1Sb4SnVTQX3jKwtwBuLNeDOA6+pAFTApFAuZGP1/3WMbRVsoZ+tmMZD yBhEr8v6NvebAvviJwIDp/kyWt8XuAkcGpBI1ZT7DteWdkM4/kqYFUCcZlpUoJnc9c7m D3XbR8Hm4ZFyS5ox3VmXLlfqVhf9TA55VSbvz+4xQUYtwax6w0xRMZ3aE0dBndX6HdH6 H71w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UY/dj03+2QLtFIGYOy0a9bWGSATbW0khYgL/ikJla8o=; b=UjcFPu2CljmvqNl1Pit3LS9pnsgucfPTBKiLMF00vrFsgbBamepGx+qKI4ezW2Mqrc 9C+CZv44DZBadKcEYnrnJbzuMSO7p2keRhXusXPKDEHUQa1sRXLGV12Dm7n106odglVp on6uLZGLD7tzTAWmpvmh9pegvdTYZAzwYDfM1WXFu0vEaEqwWsWJjDAqhk2K1zrNUUSM 4JL/gBDdd8NYDmAkEh4ekQrLUPLT+9L/gS/x1oglUB9MVk/msP6EzugiHE6tDRs9a2Cy q1tmTHjLL62nNDVYvNN7JYHK5694bNBOdz+KtTmHU8bj+Xx74ttkPe21ZWXPfu4VakTL gMUA== X-Gm-Message-State: AFqh2krx+m4J0L6iTA5JRlGK8wcjQQrS0JFqqNv5tukQ94kTBDdbSVNq ssuRi+LRFOkbQtSA8hhSydBjPZ12sltlqafY04KvpQ== X-Google-Smtp-Source: AMrXdXu663kyFWtM+d50+anHGuSiOFw5R5pVVbRtV4SnkDdCD/UqxlbiHsAO6KucbzMaLBJ+rC+iD36qCZDstjNb9AI= X-Received: by 2002:a67:fb51:0:b0:3af:5ff9:ed51 with SMTP id e17-20020a67fb51000000b003af5ff9ed51mr900180vsr.46.1671745056292; Thu, 22 Dec 2022 13:37:36 -0800 (PST) MIME-Version: 1.0 References: <20221222061341.381903-1-yuanchu@google.com> <20221222061341.381903-2-yuanchu@google.com> In-Reply-To: <20221222061341.381903-2-yuanchu@google.com> From: Yu Zhao Date: Thu, 22 Dec 2022 14:37:00 -0700 Message-ID: Subject: Re: [PATCH 2/2] mm: support POSIX_FADV_NOREUSE for generic fadvise handler To: Yuanchu Xie Cc: Ivan Babrou , Johannes Weiner , Alexander Viro , Andrew Morton , Steven Barrett , Brian Geffon , Oleksandr Natalenko , Suren Baghdasaryan , Arnd Bergmann , Peter Xu , Hugh Dickins , Gaosheng Cui , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jens Axboe , Michael Larabel Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4672F2000A X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: qzyouxk78gtmbjnoxxfkx3kbm9firw4w X-HE-Tag: 1671745057-703378 X-HE-Meta: U2FsdGVkX1/6OYokB/L939GLyfMcGta7/8WJwc0QxJexzfF/AB54sVPUt8i9sk/KFnKJH4vKpcS0fkM1SO2RQWNrBXRSRORNRET3ziP0KFdvMz8g+sjxMPqyAeawXW5ZfkwcXUrHXjo51aU/ET3EC404EopkiI529pavI1p49SeKAjA8oQOcd4MucBiPxMfPhJN5Cd49DPuLT8eG9ppjVNOyt+N/E24QTZ4Cu2y2sYzlYgDaJ3v9pNcvcrtWrO99aKNtenqYV+XR1wjEtoOkZA+93xNNPlIOpo+XbUuTGJtxK4CeS6xBegnUxR88k4SLRJC0Lcc+cKlzjij7HFmv4v6T+rHejg/ZQbMbbK+uQ6ZfxRYc1f7ihsACUU4EhnkcPAZjfAbQKrZAg/ga91M8l4rPrL7GLsvQY/2R4NzpHEMewPIu/JLzwNTv6IYj+1sNdT9H5N30N1Y+ktNcIhE3JmczW224eHxqil2JasZuGlEAe3Kr2xwQ0/Sc3hwpBRepR2andcFGRVZnOr8Yp6zDdUi8MGY/F5ZI4WUJ2bP2ha1TBb73LFKkZ5LROCKMhL88gjjYWrubAOjGq2Cw93uyW64Nd1TnFfyZgIz1O3swFfZ8clVPbfCawXR4ekBwGEnSG4eDlMCoT6VvabgfHV27EyxRI/chztqmDqNdHGerSPQYsXZJD8WY8awEnQpL0+52zLd3qfztj4q/8XTuODwN7KmcYvXK7EvQs2Q5YbLTWRdYR2FF6ivh+o5+HGn2AzaDv+/8qT5QAn4EZVGRXUvhl3HCBWVQS84S33ronR/E2+zD5QNpV7FrtE2tXqVnEaC8NY8KBphOgaqXF9eN2+kAWw+dpWkA9FOcHlb0XXe/HYVJoXsLSAsfqQKRtfTwg1jGSk+TCE0l16BKtb0rTxT3SZyQKJuhRlBJzlqs6KdVpcdDy+Tb+tiCvFTy2S5cXp/CEqJ64T7xQrXbOEF0s0G igzKM2S9 W/87om2Z5mnGLv7JFy40yFfooJ5gxIIYBObjfj9/JKBVwXmNvvAGh1c30vg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 21, 2022 at 11:13 PM Yuanchu Xie wrote: Thanks for following up on this. > POSIX_FADV_NOREUSE allows an application to specify that accesses to > file data does not follow LRU and is used only once. Since 2.6.18 this > is a no-op. We add FMODE_NOREUSE, checked in vma_has_locality to prevent > LRU activation. This needs to include what you plan to write on the man page. A few questions to answer: 1. Does this flag work with accesses via FDs? 2. If there is a random or sequential file VMA, should the user choose this flag or the VMA flag or both? Consider a) how those flags affect readahead; b) their scopes, i.e., per VMA or per file. Please also follow up with Jens to add this flag to fio. Micheal reported that SVT-AV1 regressed with MGLRU, which is the only real one [1]. The following not only fixes the regression but also improves the baseline. Please follow up on that as well. --- a/Source/App/EncApp/EbAppMain.c +++ b/Source/App/EncApp/EbAppMain.c @@ -115,6 +115,7 @@ void init_memory_file_map(EbConfig* config) { fseeko(config->input_file, curr_loc, SEEK_SET); // seek back to that location #ifndef _WIN32 config->mmap.fd = fileno(config->input_file); + posix_fadvise(config->mmap.fd, 0, 0, POSIX_FADV_NOREUSE); #endif } config->mmap.file_frame_it = 0; [1] https://openbenchmarking.org/result/2209259-PTS-MGLRU8GB57