From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF49CD10BFC for ; Sat, 26 Oct 2024 15:26:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A81F6B0083; Sat, 26 Oct 2024 11:26:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9579B6B0085; Sat, 26 Oct 2024 11:26:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81FDA6B0088; Sat, 26 Oct 2024 11:26:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 633C16B0083 for ; Sat, 26 Oct 2024 11:26:46 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1E41AAD7F1 for ; Sat, 26 Oct 2024 15:26:05 +0000 (UTC) X-FDA: 82716130308.15.848AAC2 Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by imf17.hostedemail.com (Postfix) with ESMTP id 21E1540018 for ; Sat, 26 Oct 2024 15:26:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tpJIPI2h; spf=pass (imf17.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729956325; a=rsa-sha256; cv=none; b=ecgI2O/5REaQgcWOZFpPPtpaLVEzJgKTMzeGJu4F0qOiRyzVV5QOkRiwAnSK89UqTXp9er dXh5vKG5FXOAWZwwAsl9iPY3AXmtFwUbsxbYDGuGqfhYbfYd0RB2v+ESYQjb4hGr+G4+lq 3yeqMDFa73JlKvYRTbzUizuf5M8POcc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tpJIPI2h; spf=pass (imf17.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729956325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/xurp/dzSZiTxc3Q4P+xg6SJq6yioLcLs/RNUwkLIb8=; b=RdRzmk2dXuG+m+sDnordQcUIa/sQDmdn4N96wG00bGUkALeEDzhv3mD7JuyOnJ4ESo0DEV iEgfY9WhiFo/s/Dh6+ikiuSpC3EeTZkp2bV8cv12+oZQfrYCfu4SiruMp56AVsw/JsUBcR wh5yBq/oEqrKkkEjPfaLuZD/SxSTfrc= Received: by mail-vs1-f44.google.com with SMTP id ada2fe7eead31-4a74a77878dso902477137.0 for ; Sat, 26 Oct 2024 08:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729956401; x=1730561201; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/xurp/dzSZiTxc3Q4P+xg6SJq6yioLcLs/RNUwkLIb8=; b=tpJIPI2h1SpxZU3PM0tbgc139OPAr/1N1QuRAPoCC3NSnfMyEGKIdK5YQgmA7rmHLB sVkHWvfUUGcoLk9yENz0YLnOJ90iAhOgRIcmf/AHwRE5wKCbE/8txLTJWpCWNMFi5hNk Ijnha5tm9YUwcaE+BAfCG9DKPfq/WvdATA5gtXZ5XeI6yycYVkOaIZH3Bi6RQXuBHoQ8 R2za2yOUoh4wDA724SF7FXAKYVRNnfBK9CE+lbHS8dobJ66eFgAMY3TAbrEllVEJheZM C5ubwex7aZ3tvvtLllh3XYGeG3fshvLfcBrnPcKqb2bXRVuKkx2KBudWyHHSsZ9PI/pE sHYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729956401; x=1730561201; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/xurp/dzSZiTxc3Q4P+xg6SJq6yioLcLs/RNUwkLIb8=; b=asFcyny9gscd0Zl/JXGXgW0M9m+c9FUvWjYSD8cAsMdxhDPgrepQXPrhkXchW6Od7X dT+pnqmFDSazm7zDzrVb0+bMD72NgDFqR/73gJegNoJE7ZfJbByMA+dTcXomxyapcBtQ ioH8NKjyDKa9aGXjzrEX8zfcnC3qOxewP8SK0xDpy5gaBPPPosM64n+epYZqs0+4B0P0 AWxoW843SZfXu5T3tmf2vce6zSJQYjc11Rm0KdagGXYDwIVPNoO9EVKB81y4ViD/3/T8 6rx/Ui164uNfa8JluFLti/xnMB/o6aTKgAkFT+40RdlhpMEhenLX6r9RGKH8afwCDzYP ugcg== X-Forwarded-Encrypted: i=1; AJvYcCXuPWnJ3rjgb9tUkC7kDk/fnGGvh5dNc3X73O+cWciRq7jMEHcKkfLWKcsjVqT0vhmG1180cOGP3w==@kvack.org X-Gm-Message-State: AOJu0Yy3hirmkHQ+f2/VzZ/Z3bZljLFlE7B2y//cYr7LnD+GYgKlPOEg SuDWsS2/16hWcJMTfoDZvD06DXc55CSsOwNTCEz/jxCm1bCQk1Es+Lvb2PtIdhR4at7pIE3ew/y W5VYFdbdIQgB0GmEu1nFfph0guxzdzAoqpI4a X-Google-Smtp-Source: AGHT+IErUT0EIQ3izExbmaeiykyMEE+HsZfO112pFWJqZp8vISP3bZ5byVVQr2RWeeWRFFt6XPR1QkksNOhNbda7Msk= X-Received: by 2002:a05:6102:5112:b0:4a5:b0d3:cbbe with SMTP id ada2fe7eead31-4a8cfb27a5fmr2090677137.1.1729956401467; Sat, 26 Oct 2024 08:26:41 -0700 (PDT) MIME-Version: 1.0 References: <20241025012304.2473312-1-shakeel.butt@linux.dev> <20241025012304.2473312-6-shakeel.butt@linux.dev> In-Reply-To: From: Yu Zhao Date: Sat, 26 Oct 2024 09:26:04 -0600 Message-ID: Subject: Re: [PATCH v1 5/6] memcg-v1: no need for memcg locking for MGLRU To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Hugh Dickins , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Meta kernel team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 865johs8xeztmsfbae5p5fg6j56dpqh3 X-Rspamd-Queue-Id: 21E1540018 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729956387-674349 X-HE-Meta: U2FsdGVkX1+pPY5AapmO2mJzVJ17/MZs4a8dedV9ZfSBtXAZtyKX6kdKHbEuvuQOB7LVj8oK/Y0K1LTfXltijJv02ksurCuNpsUKRDhzjcfO0MxDQpzqinVcVmxClHupbuE2vMlA5V9fD3Hds5YEPlDwunj0jKRvTw971EPTl54E2vjZGyeRmUjUtu3wVdwQLqUIWdwL3gTpwJizMiwsGicrNONY6ich8gpZLyPx2GFXeLHuBb9qJzNUq14MKbOUEBF3r1a9shFQW56ad7GTUfbSBzqUAFfds54F6aJg466ujU27FBIGebN5hjRM7lJQGR+QdCemL0hgyxE5VUrxqUrDdSY4HawtCjJ5oG8AsVuVqJu9RDdnCOfiVsyJhbwezcwQl8XoZEZYIMx47NyF2WDN74AGNzcpOAnaQxj9SreM6l7Glvemdyp4XgTbDk5Ip35xP8BL+wxtSDvHRC1sZ6ccU5eoMMx3kZIsHLchlTsIswmuoRoWMDNT5VDCTwauhLz50zLB8ayJwF2YaeDjCLXGAn/yUigKu6gX+/MOiplciM/j2G2JjHzi+KAMRVPSuFa7N1Td/0KU4IuoHDVrgu9npOBqV5qw43JLW/vzz9jQkmHLccQaP0u3M6oRVEPsR5OwhTR+VmvgMlkEGMKENken7XMI+LNVptxyd/hf4ba30xcZHn+d3KxbW7yDTcfEMwQruLzCaBmxbijUmaLvBhU0JOHy3FJ/wWijM22lbQfSqh+CJrKDr+th2CLCRy/v3rz3c9oq+UMtZjKkF1X4NPXIFm1rux6ngJwN36Gis2gFo6XfzKZPtNcnOYMJmM/1fm8NmKPKQlsLmiF9tXmXi0vPrWXq7Pen1/n9eo0cDzCn22ccBEBz7Wd4/bL/IRcJ9N8KHV0IDEdovozHkIb84F6dLklt84oo4ZRhAxTjEfd7KxVFPPG+P4lKpLVK64lt0XWpkPJp0lhzP9/pEqf HydttwCW dWx1wKEfINgdThDRAV2+k+27CsT8OKXszce0v6XOU9TkljrI/2apZTjZ8H7ZVJRq/B9BJ1GQFz4QW60CTazvhcStKOqStuf1EAZJtqVnr0TwwfRcxyXR+h6SV7pDyRSmIIg/BAWEOGJhI2hU5rJ41C4JDcPLAxNC6s1XPIetNMI+EE6/nIZCoqoCaUN4QdVQRkIyM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Oct 26, 2024 at 12:34=E2=80=AFAM Shakeel Butt wrote: > > On Thu, Oct 24, 2024 at 06:23:02PM GMT, Shakeel Butt wrote: > > While updating the generation of the folios, MGLRU requires that the > > folio's memcg association remains stable. With the charge migration > > deprecated, there is no need for MGLRU to acquire locks to keep the > > folio and memcg association stable. > > > > Signed-off-by: Shakeel Butt > > Andrew, can you please apply the following fix to this patch after your > unused fixup? Thanks! > index fd7171658b63..b8b0e8fa1332 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -3353,7 +3353,7 @@ static struct folio *get_pfn_folio(unsigned long pf= n, struct mem_cgroup *memcg, > if (folio_nid(folio) !=3D pgdat->node_id) > return NULL; > > - if (folio_memcg_rcu(folio) !=3D memcg) > + if (folio_memcg(folio) !=3D memcg) > return NULL; > > /* file VMAs can contain anon pages from COW */ > >