From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4C50E69E99 for ; Mon, 2 Dec 2024 22:19:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33EE66B0082; Mon, 2 Dec 2024 17:19:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C7216B0083; Mon, 2 Dec 2024 17:19:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 140806B0085; Mon, 2 Dec 2024 17:19:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E44306B0082 for ; Mon, 2 Dec 2024 17:19:15 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8D52C406A5 for ; Mon, 2 Dec 2024 22:19:15 +0000 (UTC) X-FDA: 82851435492.23.82A5DC2 Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) by imf16.hostedemail.com (Postfix) with ESMTP id 3397C180015 for ; Mon, 2 Dec 2024 22:19:00 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1MNtX2gD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of yuzhao@google.com designates 209.85.161.53 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733177948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z+QVSMEEjK0LS8J5R+iauWqCDh5TBeNBLgUPvSj2HjI=; b=A3YWE1igDt/vZTOBV409IVGw8WrFh6riz9q256yV5NoeNofr2lOlU8TmL9wE1qZLQtHWVC a0wdnU95qSy4YpcHL37ub/kbgy+C1Qjd26NdE7Vc/SiUWV+XGhGHDvwHU2VL4cvVELlkoc KTjUj7E5sUeipZmOUG/hsFJuI1Sybk4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733177948; a=rsa-sha256; cv=none; b=TKnEBDnG+g3yanyOVVAYzllsmhnkbjF+zS7c5Cv9OyLpOh0mMbIM7oOXkXjbDQTXjk2VN4 Tx3taXFViG2zhLdx3SxujagoyDq+GPf+M9QOF2exNOFTCSBGsBBXyVE88lmP4dIal3+Qe4 IzlC/ilpOqZhxgSd45f2b3y2H/GxqF4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1MNtX2gD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of yuzhao@google.com designates 209.85.161.53 as permitted sender) smtp.mailfrom=yuzhao@google.com Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-5f1cec20a77so1520083eaf.1 for ; Mon, 02 Dec 2024 14:19:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1733177952; x=1733782752; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Z+QVSMEEjK0LS8J5R+iauWqCDh5TBeNBLgUPvSj2HjI=; b=1MNtX2gDUHpLitgO8LLRCaHDrwwB428kSFvcfTuYitaQW4buWrKKGYsiUJdFyNfg36 cjwteSNMMYlxkdDC+nlZspBwfLLjuJlF1rclR8b0zAwvkMuyi4NQ3A00ROFZWT2B9yaH RM3OsTIAyri67AhibvpKMx0Eggi2id+SL+MOrJfjpDD1s6aqMrcHfbeR3pjLN6g74ngI Wc2dJdC3OaA2OkX0DhXH8MjG0oWz8IV3QEDi4Chqqq9P2NBl510Or0Udr3NJTLizQsmR v2CBY71xF97Vxr2f8rlUPsy66WNBP0IrO1U30Z6d/t/5zo7AdlA8Q/me423Tmq3PJvOT DeAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733177952; x=1733782752; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z+QVSMEEjK0LS8J5R+iauWqCDh5TBeNBLgUPvSj2HjI=; b=oBeZ2Zbh5mt3n7Gj3XZk5LbYmHD6T+5ByAn8fziRegASsy5t6fDg+breJ3uUVpz2jn CTM9vDbGL6YcYV67K1gWYq1DXs1oHLMtHXrEr1synEfXfgauyBxHyUiT0LQWnBUwtDkK kKzpx76ktjRn5yRkB/B88eUijOdTNm3YzxosT7b6mP1DecYY4zCmaE/oAxdWOhb2SIkG PA9UZxtZKRB34xl9XSPs/4MNIojMP+/2SYZBYPHi2Pss8/6vpOyvst2PQkqClCluEwAC 2oCGRpEQuzRyC2c6wlYV/2M7EHnE0XCildBWCPasEnN3+cqkRT944D3BTHPwczMj4O0X ayFg== X-Forwarded-Encrypted: i=1; AJvYcCUETF5uMGchYreYXDOiQn/SFnOUuT37mLKmdvVENWKTyuR6gu9EnYArTSHGyjoTCdccvbZvbR840Q==@kvack.org X-Gm-Message-State: AOJu0YxjMfL0X1Ql0LtPUgPo1q3y4RJceGqX4r4aLmXsb+dRuYH2fYlF x1lWzibvmdjDiwX5zkO9EbM0CzHLsdUln3SJzBe7UEm/yRWEjpQ1uJQAizeGUpV9RfJSwBhFXoU ThmOSJ7l9pYE4N0zFFcTZNNZVahUUBijCsOvy X-Gm-Gg: ASbGncu7S27rAg3rwMnEzzjm8D+D0iK7L0ch3oIzdZDIvmzIcnzQVfdYO4B2jRkoTjB RsLhOs4xJGEzSlounRToc+UPzHk6TA1wYUm0P62yJ7E2HXBoghKh3fSZjXHtS56Q= X-Google-Smtp-Source: AGHT+IHUkaZPBeQviSYOsKB5i76bMkpozzTjH1NAPFuZVu+s8XxFCSKVHa/VsFE7PH6FEgTXJq6cL6qNXKZrXsbZuhk= X-Received: by 2002:a05:6358:d5a2:b0:1c6:7d9d:16c4 with SMTP id e5c5f4694b2df-1caeab9addcmr56797255d.19.1733177952383; Mon, 02 Dec 2024 14:19:12 -0800 (PST) MIME-Version: 1.0 References: <20241130001423.1114965-1-surenb@google.com> In-Reply-To: <20241130001423.1114965-1-surenb@google.com> From: Yu Zhao Date: Mon, 2 Dec 2024 15:18:35 -0700 Message-ID: Subject: Re: [PATCH 1/2] alloc_tag: fix module allocation tags populated area calculation To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, pasha.tatashin@soleen.com, rppt@kernel.org, souravpanda@google.com, 00107082@163.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ahb88au1yi7ttercsaukw7pnhbw9856c X-Rspamd-Queue-Id: 3397C180015 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1733177940-480839 X-HE-Meta: U2FsdGVkX1/xkmwV9ZbkWPiYEKUBrFgcLGMzkEhEgkKlXEX+jmB+0dkFxVwJRkmX7RJGOlWtvAHo0ZQyUkyJAbeXFRULRSymYP4A/GKJvLkBf2gRs/2i/rmjliEqbY23W1YFhriP1RuL8oqCP7YeOaCik9UT3zTW02BbALRORLWVjiqRCNcahX5lWb7Wtjm7Nv8eY6nYl8IOoxg0fP7vUu11ILNyD8UyvFr5Fs9iWymuZDBwC8HF4XxI8Tkpw6saYaO4X8CjT874RAOIZpJijfM0JzFf9AwaSdpH8bLM9YO22XZiAONV7vI53aMrqZfUgBlHEKzSctgo8dZY4DQim2sGjlsYbK7N0+RKvTIOmIGgvC3xNmQk9uQmcUvuZpzJ1BzbtOTF+zbmPJAa+VPYK2y9JYEitBs5yTGZow+cQ044xh/I9MMXNvnH0N9Y5GFtNCN+Wh9kHWOi4n3TakC+pDZA3kt0NVRJf5AK5Z+2dO3ooFlAJpd+8x3hUx0ILlkL7Msb5zrv0BDO2PyrjE7ommXaXru1+sLBQtOGI1x872JPrlNgioXQlHajOFsurZzHsdZeCiSkjDoTCOjnT7u8fbKTtcflbLvj9Pb2ikT3yF+76iarqGcqfR7EEVcf7p10z12n+H7bRU0UZsKmHkEGxQOagPEDMhk1MkU9SRmPviY/NkZoZxxLo+KlxDtuqHgS5a45++lbGRmLhAgjJ+BZB1xfUZYm7e8N0vUOSW+Ku5Ls3/5hbumZIyJLjydi4JdNY9falaU2CN/a8KuNEOJu27Asa1bFlz8+r5crwABXZwVEFMJcSv6VY56br2VlsDLN+L/g+QkixBwgE0wvEBWbspkHc9oKRG8VqNuMZi2//kuOVoocdOQW4G33yeEUK58HUBQTLZ1acglMZjWkxXIOMXAIntW6WToylWGsh3vdn+kymhE2I6GBaA0xEq2BrI/zb+ore9SOoHBmVi/hDwN lQo5TVnD S3YoCDt1rxjYxaebcsmgpmJPdSKVrwTMZ10gNZ9Ai2A8FrHd9bAHZVCQzJ6UJcObJwqpwbWO0OcBWt6TtsWMHz/+hlM1huyDRatkhSiorv1xJ24O8wvh9TCLLHHGGRwBjzSFNBvQhlMkqnJOK3IXbJp5K5y9S+PVzqjDroTxAA4/lEakO50G5iO0JMGj8DLWmBFULeZtkEzL3KLhTT905PEKyOIx6EXVPw2oJ2hA2OHAu0oGWFsD9CVUdJqSKTY4IR+SEf/tXC0uIEqw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.004668, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 29, 2024 at 5:14=E2=80=AFPM Suren Baghdasaryan wrote: > > vm_module_tags_populate() calculation of the populated area assumes that > area starts at a page boundary and therefore when new pages are allocatio= n, > the end of the area is page-aligned as well. If the start of the area is > not page-aligned then allocating a page and incrementing the end of the > area by PAGE_SIZE leads to an area at the end but within the area boundar= y > which is not populated. Accessing this are will lead to a kernel panic. > Fix the calculation by down-aligning the start of the area and using that > as the location allocated pages are mapped to. > > Fixes: 0f9b685626da ("alloc_tag: populate memory for module tags as neede= d") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202411132111.6a221562-lkp@intel.co= m > Signed-off-by: Suren Baghdasaryan Acked-by: Yu Zhao