From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A96C4D2069A for ; Wed, 16 Oct 2024 04:57:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4630E6B0083; Wed, 16 Oct 2024 00:57:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4135C6B0088; Wed, 16 Oct 2024 00:57:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DAAF6B0089; Wed, 16 Oct 2024 00:57:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 103876B0083 for ; Wed, 16 Oct 2024 00:57:36 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5A4A1C19EF for ; Wed, 16 Oct 2024 04:57:25 +0000 (UTC) X-FDA: 82678257060.10.D398ADF Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by imf07.hostedemail.com (Postfix) with ESMTP id 36D3940006 for ; Wed, 16 Oct 2024 04:57:22 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1ATJXc1G; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729054606; a=rsa-sha256; cv=none; b=bB3I4dw0k8GUfAeTL7zcXq5Ew5PbLh97CbXSqykdImRq/XzdlzMKBnFSieY8eB87K7zJ8V davjoYtLYYVE6IjJgcR4ps7ceTiVOFZKzh6Uxdj0WqwsVjH43blw2plLvXMFqjlUuv36Nf r5IpfzZvK5DfGDAFlweEdWBsHrPtvPg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1ATJXc1G; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729054606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vU4qjeo8nOa6YMk+qiXCTLI5pZ4+2YEJYeF56gJAK9c=; b=jzjFqEHokKkZd6x8O6m55NqfM7rcyuTLnckIZsxqI3V5LfPksU2prKcEFwlDAlfQR1biPs c+LwE2wFHlSir9NFpK5l+c7dsDD4xlsoMsQzkBYlQSKGGP4tluANWqarorloLm/A/OQrGU rTphot1EuttZ0r4noqzPduoF9WY2PHk= Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-84fc7b58d4dso1698395241.0 for ; Tue, 15 Oct 2024 21:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729054653; x=1729659453; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vU4qjeo8nOa6YMk+qiXCTLI5pZ4+2YEJYeF56gJAK9c=; b=1ATJXc1Gd1hD23/E9VDTv+C4xp3a6hV5TIlFLrCHgC8Mr7T78X3WYlUBNlbPPWWfcx qm9cG6dVp0jMIqbMf6+l0/xC/4v6tT9/X32eOoT73Y3wctntZagruHZGKmhZ7r/A712i PvNppxyCxyIe9WnaO+kr2nLnNS92a+3lwkELFNRefNbperVc7S64nK2gw8Z54LcgcOUo 5SLYDDe2cqfnx2jcAhb/y7/DJi2Mco1uJLR3DoiCCkdLkCyKuuOZ0U5tUnTbffL3yeeS XzqeWYGOcj2HsFLBGnty9LOPHgaBJv7DdbNFdKnaor3m4reshMtrBQZ6g7cHevnC0nsS LD5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729054653; x=1729659453; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vU4qjeo8nOa6YMk+qiXCTLI5pZ4+2YEJYeF56gJAK9c=; b=ajIjDbqKdswNSGyGFxxe+trEJB+0dKvxrWFCv28bRZa6q7k03AW22ieY3XQIOtN2Ld G6NZD96OgWi4wCpokoEp/zYXK7Qm0l0VRzqBkUvzsUmnvxJGsEDpWUcRQyHJCPeXaSy7 yWni/kJiwDExVYcDdF0h39PlCd2WArE55LrCL7MxmyiegRvkca3nQO4glOe6dZuhEKRW wlPh22qIwpL52KwslD/NuAH3Ib+3VPJpt/ltDIKd7rev3HVgpkcsENzGP6bZvIjFThN2 x2JB+A5fKCAPMmpZQeZ2KE2YmBz1WwJPWTpGO0j3fMHvc15elADg3vNRQOxAgp2ms3SX 28BA== X-Forwarded-Encrypted: i=1; AJvYcCWFbV1a1GShjG6rse+wvfw9jg9JpD4DEC/EKwvZRLXLw0zF249gfYQiE15n7Bnke2wRQubScRO2Sg==@kvack.org X-Gm-Message-State: AOJu0Yyq7W5pfFvwvkF1DG78jA9mlIJKW45aWX3BEn2EXFrs/yNxKO0F I1jGDbdjYxxUJcgQMX9k1QOBC1OXlJTJtRRKUqk0YV8+4Vkwyx3b5z9WhAK9fnzIuQbnzIqyco4 pBgfl/mRt3gTVuTEyEEwO+A6rSSG8pamujvSj X-Google-Smtp-Source: AGHT+IHMy8fRwC65EG2pqht5x6EMu4hfjHzbFfFB6UJ9MtCEo/SHqcxsyUXhSzYDiQ5LzZxMT6VNeDeWsGcu3Z8UDjA= X-Received: by 2002:a05:6102:950:b0:4a4:9363:b84c with SMTP id ada2fe7eead31-4a49363da7emr8108794137.6.1729054652793; Tue, 15 Oct 2024 21:57:32 -0700 (PDT) MIME-Version: 1.0 References: <20241014221211.832591-1-weixugc@google.com> In-Reply-To: <20241014221211.832591-1-weixugc@google.com> From: Yu Zhao Date: Tue, 15 Oct 2024 22:56:56 -0600 Message-ID: Subject: Re: [PATCH 1/2] mm/mglru: only clear kswapd_failures if reclaimable To: Wei Xu Cc: Andrew Morton , Axel Rasmussen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 36D3940006 X-Rspamd-Server: rspam01 X-Stat-Signature: woo5mg76646f5w86zd5bh4xyrhyd4xmr X-HE-Tag: 1729054642-887149 X-HE-Meta: U2FsdGVkX19K8LrViztRpLKUYZAKtztf/dc5CyaGqmLDf8GhGICvrkzTgImFAWZnE38igPX2+d2tOHzhwrjMrfTbIhY36Cu64ViXjlOyzIKaSUEilWvUcXb2gqR9uGfuixmnw5zSdRxRHjAGQASQCCYjHCaiiPOcd3Z+u6Qvy8aKXnAJrZVQXp4l+o9QBrT2YghYfgVHjRc1HJa4O1PJFPliTgO4mkG7lg024uEV3EixZ6dEuE5RBrca/4CoyWrlPrFsLHuSGTpT+X7cEpM34wEuVMJFE4TrwxwIcx+Nr6/2eIGsHLWJMr2to+6n4G101HrqHQy9IqPVVQG/7e5usK5w+J6v2qZRuhtonbBNKe+3r37PwpbL7Q8DFsqE3derpj2R2OB65hbOLcKaNe02cOlnk/r/38lks9Ln5t8Nd+h9i5N7d1STZaBmxXH6VBNspIPTeePmXb8NbRWgAM1prZOxw/I9dLG37p8cAIB/fA9nYsRS04JfpHPteK0W+2DnfV1QdBIzKo6/IuykqbYOCihTUz8E+nQ6drw2qEA4H2ofCDqo6R0ThzhulXnsKhRd1FnjGc8WqlWWY9H6Eoilxqz8zLXDePep6E+e+WQY2MOVue45vrDY7npwiyoKvN9cNOQasyghN9Gp79W/Knb8zrzzQmBBLdSLwlBxzHFhgs+ypLZYcrULot8GdxLGFE2TSOzsVlM0cqpu2fpva7UNHw96CzSrotueCTvbVoAeOoBzQE/ZPZZ0CPYae74Jj00yjRjmkQga7eRwR0f9W1Ze4qJBsMDdpyMlco1xN1ReW/Vf3qyyJJosyW0T7njkaXUSIqGx9NqQS/WxxtNSUmd4CI/6Ii+WfTZM8kkztYU1scgFV9l32fgsu3EoCNN1Cmcxuh2T0ioPISFrx13i6r5HyzHp2sz1OrPCefoQnbq5VHb0/MYb4YuEAQuXV2W/u+73QzYcQ9CKQ0xjYDuSCJV oBIcCTyi zo8TViTSA8+WtMHjZ3LnSerFbYFG5C/FtD+hc9IHzdAJlFF6EGFvE+f7OyLw7bxRd8pLaGUwkqqZ3RRohgW2HZ9+tMuvQSP+ZxF/a0m9A4k3AeEtnewgv1IhR9y8mgvYen9PIavgGfVvaydqD7IGWCLaoatjxAv82TcYv+edGOUpk8OP95ScYYoZZFOvRM2eDBV2iPlu2mkufJaKIhX5QzMBDNDiFJvIWeDn4uNAnmVbqqYn/5PPrd/V1pDNqXuXG+LdY3xYfgU6bWjw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000781, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 4:12=E2=80=AFPM Wei Xu wrote: > > lru_gen_shrink_node() unconditionally clears kswapd_failures, which > can prevent kswapd from sleeping and cause 100% kswapd cpu usage even > when kswapd repeatedly fails to make progress in reclaim. > > Only clear kswap_failures in lru_gen_shrink_node() if reclaim makes > some progress, similar to shrink_node(). > > Fixes: e4dde56cd208 ("mm: multi-gen LRU: per-node lru_gen_folio lists") > Signed-off-by: Wei Xu > --- > mm/vmscan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 50dc06d55b1d..9d1e1c4e383d 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -4970,8 +4970,8 @@ static void lru_gen_shrink_node(struct pglist_data = *pgdat, struct scan_control * > > blk_finish_plug(&plug); > done: Nit: the "done:" isn't used anymore, so better just remove it. > - /* kswapd should never fail */ > - pgdat->kswapd_failures =3D 0; > + if (sc->nr_reclaimed > reclaimed) > + pgdat->kswapd_failures =3D 0; > } > > /***********************************************************************= ******* > -- > 2.47.0.rc1.288.g06298d1525-goog > >