From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F8C6C4332F for ; Sun, 4 Dec 2022 22:59:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E05FB8E0002; Sun, 4 Dec 2022 17:59:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB5168E0001; Sun, 4 Dec 2022 17:59:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7C448E0002; Sun, 4 Dec 2022 17:59:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BA5BC8E0001 for ; Sun, 4 Dec 2022 17:59:23 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 83DE9AA507 for ; Sun, 4 Dec 2022 22:59:23 +0000 (UTC) X-FDA: 80206141806.03.9D1E431 Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) by imf30.hostedemail.com (Postfix) with ESMTP id 3A9DA80005 for ; Sun, 4 Dec 2022 22:59:23 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="MeZNB9/Y"; spf=pass (imf30.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670194763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U1YCWugnt7NNcwN1mLvIio05PcYTCT5nH/7JzPuEAF4=; b=yHKKiJY8ne6OongGAP8yu13eMzX4XIiF05i/IQYZHbzi0GxBcGjLuPQkwW+F6txPQUz2+7 8nQ1J8jwrpQ9vvznnlJWspqwPPV2RcgSSmHwEGEM2SF9vd3W6iVhcDpXqqDt1ywDrOXApt gVMQnBKcrNrffi1xGYweIjNwCkw9oAE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="MeZNB9/Y"; spf=pass (imf30.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670194763; a=rsa-sha256; cv=none; b=vBL6gk8Niy037Dha72liskT8T4ELS3u4qBcxV8AQfxURees4jLzoJct6fkuMORDkZcoKg6 VS40gjHU+76/FzViPnJD56oc07LE967suxbmJqLCT+nHDOmZ2qDcNN2OE1HmzBHzw/X5uW KVnbSJwdEQKd8RXan7gWLzKItkyuyFQ= Received: by mail-vk1-f179.google.com with SMTP id b81so4584209vkf.1 for ; Sun, 04 Dec 2022 14:59:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=U1YCWugnt7NNcwN1mLvIio05PcYTCT5nH/7JzPuEAF4=; b=MeZNB9/YoNEJG11VARRGWae/1ItbIoyRu5aQ36YsOEIFBl+tv4RFRIPPcSVlt4uXg+ rBrzktWDyGBkjcPeDJ64CNwJLYUUJAPYYhQ+0+hNxEodZIcyakPwB+BPPUtg6a+6G1+g X/pFg3jK9Cz1QBxXG1EQ65sMn80ePUeIXRqRGnuD/MUZBu/Fb+X8MqICRHfKLCcfPlMx f7Xdk9fvcyi73Bc6oycAEBanlqELODr6wnMTmzr3+jxo96XQuFg2ns+XsOG2Vtd+d46r 34TyTzhfzWAPa3QPp5oRqSxIlKxM3VxCKph8Nwm64PySn+1p9w8HApHiwNEbuUNoSaVB tGIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U1YCWugnt7NNcwN1mLvIio05PcYTCT5nH/7JzPuEAF4=; b=jl5Q3cx6nl904Vnwfr1UsGss1y8r2TugAmyB1c7rLc6HN1QGe4Re8uUpmk1rCLn0N4 9mJNy1eO/P1QnEyWFiqbmWh29XNv16U0cJjQnZH5iMsUqzN36f8ujhe/oIf2aK9DcpHw ZA9Qg7uANhdMT0GAC1wcI9CcjXatq9mTeuElfGZpm4t/gff6D1V2rV6lSSsCXw75Pa6k rqeKw/6kbf3vjHWTUuFVnSE2pTx+iT4KO11IhplRu7jXS7qlt2jiTr6ZGAEwAd9x4ctw 21eLKaB107qwyM4lqq318L3W5ck16fe0Orw2g+zeS2uAvolreFoZrTUrKhSpXF24xmyh 0VwQ== X-Gm-Message-State: ANoB5pnkghfJOCmmFWzEkDuL4rPzzDMB17iY40qnN6AnqvohDDKc3/fF M6ttb5J/CRDv2Rsd2RvxLqwU3l3BXN4anGtjUtYljw== X-Google-Smtp-Source: AA0mqf5x2PSpwgMuZHGI0b78Lrjpb6NlNe7Isuc6zHyZXrqZoLLufMiKNgYIEa8SLzR7fGAdy8XyYE8dK+xh80zTF9s= X-Received: by 2002:a05:6122:1243:b0:3bd:730b:ef5a with SMTP id b3-20020a056122124300b003bd730bef5amr4334490vkp.29.1670194762270; Sun, 04 Dec 2022 14:59:22 -0800 (PST) MIME-Version: 1.0 References: <20221202141630.41220-1-tcm1030@163.com> <20221202115954.a226f8ef3051266d04caff54@linux-foundation.org> In-Reply-To: <20221202115954.a226f8ef3051266d04caff54@linux-foundation.org> From: Yu Zhao Date: Sun, 4 Dec 2022 15:58:46 -0700 Message-ID: Subject: Re: [PATCH] mm/mempolicy: failed to disable numa balancing To: Andrew Morton Cc: tzm , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mel Gorman Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3A9DA80005 X-Rspam-User: X-Stat-Signature: d3gek9zdfphud6iryw66rio7ih1bxaqq X-Spamd-Result: default: False [8.03 / 9.00]; TC_DBL_BL_100(5.00)[163.com:email]; SORBS_IRL_BL(3.00)[209.85.221.179:from]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; BAYES_HAM(-0.07)[57.03%]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[google.com:+]; DMARC_POLICY_ALLOW(0.00)[google.com,reject]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_DKIM_ALLOW(0.00)[google.com:s=20210112]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[] X-HE-Tag: 1670194762-402824 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 2, 2022 at 1:00 PM Andrew Morton wrote: > > On Fri, 2 Dec 2022 22:16:30 +0800 tzm wrote: > > > It will be failed to disable numa balancing policy permanently by passing > > to boot cmdline parameters. > > The numabalancing_override variable is int and 1 for enable -1 for disable. > > So, !enumabalancing_override will always be true, which cause this bug. !enumabalancing_override is false when enumabalancing_override = -1 (numa_balancing=disable). > That's really old code! > > > --- a/mm/mempolicy.c > > +++ b/mm/mempolicy.c > > @@ -2865,7 +2865,7 @@ static void __init check_numabalancing_enable(void) > > if (numabalancing_override) > > set_numabalancing_state(numabalancing_override == 1); > > > > - if (num_online_nodes() > 1 && !numabalancing_override) { > > + if (num_online_nodes() > 1 && (numabalancing_override == 1)) { > > pr_info("%s automatic NUMA balancing. Configure with numa_balancing= or the kernel.numa_balancing sysctl\n", > > numabalancing_default ? "Enabling" : "Disabling"); > > set_numabalancing_state(numabalancing_default); > > Looks right to me. Mel? > > After eight years, I wonder if we actually need this. NAK. The original code works as intended. This patch breaks my test with CONFIG_NUMA_BALANCING_DEFAULT_ENABLED=n and numa_balancing=enable.