From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D8DC4332F for ; Thu, 14 Dec 2023 04:00:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7F158D008D; Wed, 13 Dec 2023 22:59:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2E538D0083; Wed, 13 Dec 2023 22:59:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F5A18D008D; Wed, 13 Dec 2023 22:59:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1E6678D0083 for ; Wed, 13 Dec 2023 22:59:58 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E5E064033B for ; Thu, 14 Dec 2023 03:59:57 +0000 (UTC) X-FDA: 81564070434.09.E52D71F Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf12.hostedemail.com (Postfix) with ESMTP id 34FFD40008 for ; Thu, 14 Dec 2023 03:59:56 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NaTsOruh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702526396; a=rsa-sha256; cv=none; b=zlx833KEHefhDnICyuxlAFamuvdT+7cdlbHnzxV0XWSals3tM+w9FePCAl4VuW67ohlnhz Nzq9LeqCRwLjyRQeQOlyxAY25LFLkbi1TGP1ngS/9+lIdwrK7qwAlbohs+rJgEIs40AuT/ IZPhRFcw+nIJhTMXLws65hvTG/wl2qo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NaTsOruh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702526396; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k9SXl2tgU3L2tlbd5i1MJ4Mhz783przOxvBKI9pySS8=; b=RQtoKB8tb2rGGH4sdUMiJtew+ZJDHk6l7I3g8T27BB5KhOOIEpOmSSdFsftUvebThFZnDj vZ+GH40gkcyOwIhP8VgSlyG6y2R+ys6D82Z/nTgzVS/MBuXAsTtU0tSxSB5S6w4CJIKM1m AVN+ubRgbqWRAeAAxvWqW/Xu7esqPuc= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-42598c2b0b7so99201cf.1 for ; Wed, 13 Dec 2023 19:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702526395; x=1703131195; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k9SXl2tgU3L2tlbd5i1MJ4Mhz783przOxvBKI9pySS8=; b=NaTsOruhlue+x6TrlaY+nUxvRyMWkBCp1UM1thDn43UubHZ0qZTpeTK52bWqt2vRjr +ZIcd2amtIVRNG9YEC2U5Ez9u399bbFVY83YrgD6AXKfb86ISdhwu4Hg76JMTG+5xWfi m1DA+kNWalXlYKWddhm9+5meIcD6GscA9R+JatXc1+PD3I0FeKqRyH0Ex6rPHDac2AE9 Oo20FGraXT49E0ggy6Ujm6vmL0CNj9O6041eE+uiIIlNrYBOZMUYbQV2yKwCo7TY4kQC fKhfQ8x5JbZQvYVDnaTZK1PtBW7lHlQqo9AtepKdw0TDSzYc0/l2DTwesnOGqZtP/yil GOgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702526395; x=1703131195; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k9SXl2tgU3L2tlbd5i1MJ4Mhz783przOxvBKI9pySS8=; b=KPD0olvNCgOuPCjJN0aMhSLY0Gd2/ZX7vqqD59zkxHD27P78Lsdd0JnvBO0qCDj3Cd R+1ojHgEmA+tv7WPm9/EB8OVqYK36xuyZ1vvzI8gRdO40kUsFsZZbxuYNhESWoHXxmGU cY2N1Skx9q42W8y+nCQE3qqVa2KJTt/f4t6ONe1zEmycxKEw6fZhc5y5PRQ0gEgoP+zC /2b1CAYyR3vyllgkk3c4/OInXq9+y7iJdNfbTro+5Qoxgplpx4J4/LGEI8uA0/eXA0SL kqqKJ0zbmd4SPri9hfpF09peXNAdNWD9Zhfy9lkeoxJc+caGhmHe0hS27l2SdQ7jIPSP PB+g== X-Gm-Message-State: AOJu0Yw07IdJUorsh5b5f/JmGdTtkp0u07G2wDqK/ZRHdEtSAVvQgSXR 3BnMuEKK3SJvpIUx/IZOKG6L44O+YMF2t5dv3J1ulw== X-Google-Smtp-Source: AGHT+IESwgZP1TXh1NT4O/RQwoZiqy2YV0XyAtyNBGRcT7/vSnMoL3kzLw4XBlh0PCwwtguE1YvhUUb4Oip8pcjOAUY= X-Received: by 2002:a05:622a:248:b0:425:962a:1972 with SMTP id c8-20020a05622a024800b00425962a1972mr1579258qtx.20.1702526395107; Wed, 13 Dec 2023 19:59:55 -0800 (PST) MIME-Version: 1.0 References: <20231214013450.5734-1-cuibixuan@vivo.com> <20231214013450.5734-3-cuibixuan@vivo.com> In-Reply-To: <20231214013450.5734-3-cuibixuan@vivo.com> From: Yu Zhao Date: Wed, 13 Dec 2023 20:59:18 -0700 Message-ID: Subject: Re: [PATCH -next v3 2/2] mm: vmscan: add new event to trace shrink lru To: cuibixuan@vivo.com Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, opensource.kernel@vivo.com, Linux-MM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 34FFD40008 X-Stat-Signature: c31fbmejhkno8qofr8w96bhwunmwkp69 X-HE-Tag: 1702526396-144360 X-HE-Meta: U2FsdGVkX19eTBHxRiHBmVnaA2opyCrnwLWIrMZZpEZp9N29QnewNgzFQdF7phdHNQCth8c5z7FXez/uvhvfWIDyP73prp0GWEr2XZikeoe8Br3cU4YFmZl/7G4U3NjVE2DfO4hskH4FmbaDpCmjaItBD14NaLC/PV6nW2TG6vZWPVCIss0oOHcHUOG+6XUd7U4cG0LUNvlAx2qCRMARIhRtbU31YsOz2naAa397BPS+pkXPQCnqnfPHvj1LLW3AZFHydG99HSQ0f34Go2hM+jYZQhyuuJiuH1OmBYpzQ3FtEWuGR+UhKGtUf02BtjAqoloGmixHCFbaulZmZt83xHRjwDLpLIpPV6VDyt24Vheea4t4b/Tc0lwKWuDJqi/c5cdP906JSiJ9mrcfhq+8/LfTtyA7eriR136+FbpJr/ZkLZtrRIJp5dKLZle6iZKKt9AWXknUF94NzNyYu4gzCPzCzNEqbvX2ijScyggi0QYDF8Tx297sHeK0+4mGnDX4H6frwu77igMQE8MlRQu0ip5iUPMd2YKuovo6pdp6iAFSyUoitKKI17YzI6oPRNLQAocKIIqoi+ZyF95HtHkm4n5L6y9Jmepp4kIzrhq6s339fWmUSli4XxEOLEJGVDmqpB3EJYDmPEhjuu8njg1mVYQjg9xc7i0HcFFq6klGRa6oagTofYdpyVQXcAaNCosVLPcM0yqZ+cIMUQwyHFLQoBY0fGY1A993ywicZDZohtnO5qevhh1XNdcPC3C2bcfBv1aEhZ5mSW6K0FPQAJYUzq7403DF3r2LXYZv+B8pAWFcdxIYJnmxq4kN+egpI3+yCtFFrtvIPYZzP5VAU7fREGu3O/YNJ9enimnJhQM5VwI6hnLbrvixBIQw8QqxUjaAh/DbsWAO/P9ArSJeZcU/i9nylGKGSDDJ+MuuVD5Yf8GCPyNu04d6ErC/OwOK6onmTQN0yg0lEkQ2D3kDH2t Kg82FGH2 Q/Hb6DaIqyo8cIDMdpuaG4PyBDTe8qvmPngQMIKSWknSSLLWhUNRpJYJeRaPyA0bnyy1FfS0H83249/z0k4WWHW6aatsvRgOlqgccBsoToubj+AqDt9rLXyhKkaWUQS+LUfE18ZTegy5mNv6ssrJIQ5mqP4+9LW9Y6FsJq98m7hkgXLH+I2pPkuISOyYnLN7uC9OIcKKXMRM8PYtr0SUXZfvjYLEwfXYA5fGxRtup/IhKbm/GHFKtHhJWgTPNb4ielcYIreSJsGoYuOlueS0oxIctfWngoqW72p/1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.077342, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 13, 2023 at 6:35=E2=80=AFPM Bixuan Cui wro= te: > > From: cuibixuan > > Add a new event to calculate the shrink_inactive_list()/shrink_active_lis= t() > execution time. > > Example of output: > kswapd0-103 [007] ..... 1098.353020: mm_vmscan_lru_shrink_a= ctive_start: nid=3D0 > kswapd0-103 [007] ..... 1098.353040: mm_vmscan_lru_shrink_a= ctive_end: nid=3D0 nr_taken=3D32 nr_active=3D0 nr_deactivated=3D32 nr_refer= enced=3D0 priority=3D6 flags=3DRECLAIM_WB_FILE|RECLAIM_WB_ASYNC > kswapd0-103 [007] ..... 1098.353040: mm_vmscan_lru_shrink_i= nactive_start: nid=3D0 > kswapd0-103 [007] ..... 1098.353094: mm_vmscan_lru_shrink_i= nactive_end: nid=3D0 nr_scanned=3D32 nr_reclaimed=3D0 nr_dirty=3D0 nr_write= back=3D0 nr_congested=3D0 nr_immediate=3D0 nr_activate_anon=3D0 nr_activate= _file=3D0 nr_ref_keep=3D32 nr_unmap_fail=3D0 priority=3D6 flags=3DRECLAIM_W= B_ANON|RECLAIM_WB_ASYNC > kswapd0-103 [007] ..... 1098.353094: mm_vmscan_lru_shrink_i= nactive_start: nid=3D0 > kswapd0-103 [007] ..... 1098.353162: mm_vmscan_lru_shrink_i= nactive_end: nid=3D0 nr_scanned=3D32 nr_reclaimed=3D21 nr_dirty=3D0 nr_writ= eback=3D0 nr_congested=3D0 nr_immediate=3D0 nr_activate_anon=3D0 nr_activat= e_file=3D0 nr_ref_keep=3D11 nr_unmap_fail=3D0 priority=3D6 flags=3DRECLAIM_= WB_FILE|RECLAIM_WB_ASYNC > > Signed-off-by: Bixuan Cui NAK. A _start should always be paired with an _end unless there is a good reason not to. mm-commits@ is the wrong mailing list to submit MM patches. Is the build error Andrew pointed out earlier fixed? If so, where is it credited to him?